Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

> On Nov. 16, 2015, 1:38 p.m., Andreas Hansson wrote: > > It is not clear to me why this is not just calling the "normal" stats dump. > > It seems like an unfortunate amount of code duplication. > > Abdul Mutaal Ahmad wrote: > It is using the same API as used in util/cxx_config. Even the

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review8384 --- Ship it! Ship It! - Matthias Jung On Mai 30, 2016, 9:37 vorm., Abdul

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review8323 --- Ship it! Caveat: make the filename/configuration for stats output

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

> On Oct. 16, 2015, 3:15 p.m., Nilay Vaish wrote: > > util/systemc/stats.cc, line 79 > > > > > > The file name can be kept as constant, but at least pass an argument to > > this function that specifies the file path. > >

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

> On Oct. 16, 2015, 3:15 p.m., Nilay Vaish wrote: > > util/systemc/stats.cc, line 79 > > > > > > The file name can be kept as constant, but at least pass an argument to > > this function that specifies the file path. > >

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review7598 --- It is not clear to me why this is not just calling the "normal" stats

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

> On Oct. 14, 2015, 2:02 a.m., Nilay Vaish wrote: > > Format this patch again. Read the following page: > > http://gem5.org/Submitting_Contributions Several lines are more than 80 characters. Also make sure that the identation is correct. - Nilay

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review7369 --- Format this patch again. Read the following page:

Re: [gem5-dev] Review Request 3132: misc: Separate stats file is generated for SystemC-gem5 co-simulation

--- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3132/#review7334 --- Ship it! Ship It! - Matthias Jung On Sept. 25, 2015, 3:16 nachm.,