Re: [gem5-dev] nightly regressions

orgot to turn on >> copyAllScoresOnTrivialRebase for the maintainer label. >> >> >> //Andreas >> >> >> From: gem5-dev <gem5-dev-boun...@gem5.org> on behalf of Gabe Black < >> gabebl...@google.com> >> Sent: Wednesd

Re: [gem5-dev] nightly regressions

dev <gem5-dev-boun...@gem5.org> on behalf of Gabe Black < > gabebl...@google.com> > Sent: Wednesday, April 5, 2017 7:25:36 PM > To: gem5 Developer List > Subject: Re: [gem5-dev] nightly regressions > > I had to rebase my CLs, and that seems to have dropped the maintainer +1

Re: [gem5-dev] nightly regressions

No, I think you reviewed the only one which doesn't just update the stats. It would be fine to just mark the other ones as good to go. Gabe On Wed, Apr 5, 2017 at 10:50 AM, Jason Lowe-Power wrote: > Hi Gabe, > > Thanks for going through and updating the stat files for all

Re: [gem5-dev] nightly regressions

Hi Gabe, Thanks for going through and updating the stat files for all of the recent changes. The people who used to volunteer to do that haven't had time lately. Is there any reason I shouldn't just check off on all of the stats changes? Is there anything in the changesets to review? Cheers,

Re: [gem5-dev] nightly regressions

Here's the changeset Andreas was referring to: http://repo.gem5.org/gem5?cmd=changeset;node=b2720503a978 On Tue, Apr 4, 2017 at 9:20 AM, Gabe Black wrote: > I can't add reviewers due to a known issue, but here is the stack of CLs > which fix the regressions: > >

Re: [gem5-dev] nightly regressions

I can't add reviewers due to a known issue, but here is the stack of CLs which fix the regressions: https://gem5-review.googlesource.com/#/c/2641/ Gabe On Tue, Apr 4, 2017 at 3:35 AM, Gabe Black wrote: > Oh, also, the problem with EIO I think is not because there are EIO

Re: [gem5-dev] nightly regressions

Oh, also, the problem with EIO I think is not because there are EIO regressions, it's that the EIO code is being added in with EXTRAS and breaking the build for certain targets. Excluding it would be fairly trivial if I had write permission for the regression script on zizzer. Gabe On Tue, Apr

Re: [gem5-dev] nightly regressions

Yeah, there are a lot of problems with the current system. It has three real functions: 1. Making sure things run from end to end without crashing. 2. Checking for inadvertent changes to the stats. 3. Checking for non-determinstic behavior. Unfortunately it takes a really long time to run,

Re: [gem5-dev] nightly regressions

On 01/04/2017 12:27, Gabe Black wrote: Hi folks. I'm working through the nightly regressions to get them to a good point for a rebase of our internal branch of gem5, and I've noticed a few things: 1. The stats have been changed but not updated a bunch of times. I've identified almost all the

Re: [gem5-dev] nightly regressions

Hmm, I think maybe there wasn't another CL which broke the stats, just that there was a change which had a wider impact than I caught with my initial sweep. Gabe On Mon, Apr 3, 2017 at 5:20 PM, Gabe Black wrote: > I almost have a set of CLs which fix the stats, but it

Re: [gem5-dev] nightly regressions

I almost have a set of CLs which fix the stats, but it looks like since I started working on this somebody broke them again. I'll now need to figure out where (fortunately a small window) and add a CL for that too. I'd like to fix the regression script on zizzer, but I don't have permissions to

Re: [gem5-dev] nightly regressions

Hi Gabe, I think you've interpreted everything correctly. I think the only context you're missing is that we're planning to change the regressions such that there is no dependence on proprietary binaries. This will allow all users/developers to run the regressions before committing code. We

[gem5-dev] nightly regressions

Hi folks. I'm working through the nightly regressions to get them to a good point for a rebase of our internal branch of gem5, and I've noticed a few things: 1. The stats have been changed but not updated a bunch of times. I've identified almost all the points this has happened since the