---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/#review782
---
Ship it!
Looks great!
- Steve
On 2011-01-18 23:21:55, Gabe Black
Yeah, I tried to stay away from using double since it can be imprecise.
To me it makes more sense to put a conversion function in base/time.hh
since Ticks seem like the more fundamental thing. Maybe it's as simple
as adding a setTick?
I'd say go for it.
Nate
I'd say go for it.
Though with one caveat. I think the definition should go in the .cc
file since you have to #include a file in sim/ to do it.
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/
---
(Updated 2011-01-18 04:25:09.655881)
Review request for Default, Ali Saidi, Gabe
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/#review764
---
src/sim/root.hh
http://reviews.m5sim.org/r/419/#comment1025
@file
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/
---
(Updated 2011-01-18 16:49:14.839440)
Review request for Default, Ali Saidi, Gabe
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/#review774
---
Ship it!
Looks good to me.
src/sim/root.hh
On 2011-01-18 07:03:49, Ali Saidi wrote:
src/sim/root.hh, line 93
http://reviews.m5sim.org/r/419/diff/2/?file=9736#file9736line93
This seems large enough that it should just go in the cc file
Done
On 2011-01-18 07:03:49, Ali Saidi wrote:
src/sim/root.cc, line 52
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/#review776
---
src/sim/root.hh
http://reviews.m5sim.org/r/419/#comment1056
Now
On 2011-01-18 17:07:45, Nathan Binkert wrote:
src/sim/root.hh, line 117
http://reviews.m5sim.org/r/419/diff/3/?file=9767#file9767line117
No big deal, but we usually have a comment here
Done
On 2011-01-18 17:07:45, Nathan Binkert wrote:
src/sim/root.cc, line 87
On 2011-01-18 17:57:05, Steve Reinhardt wrote:
src/sim/root.hh, line 85
http://reviews.m5sim.org/r/419/diff/3/?file=9767#file9767line85
Now that these methods are part of Root, I think they need a little
more context in their names, e.g.:
timeSyncEnabled()
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/
---
(Updated 2011-01-18 23:21:55.573947)
Review request for Default, Ali Saidi, Gabe
If you add a function for it I'll use it. We should be careful, though, since
when nanoseconds (or microseconds or milliseconds) spill into seconds might
get a little tricky. Actually, right now nanoseconds, microseconds, and
milliseconds all change the same data, but seconds are separate.
nathan binkert wrote:
If you add a function for it I'll use it. We should be careful, though,
since when nanoseconds (or microseconds or milliseconds) spill into seconds
might get a little tricky. Actually, right now nanoseconds, microseconds, and
milliseconds all change the same data,
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/419/#review703
---
SConstruct
http://reviews.m5sim.org/r/419/#comment948
What happens
On 2011-01-10 12:24:35, Nathan Binkert wrote:
SConstruct, line 707
http://reviews.m5sim.org/r/419/diff/1/?file=9416#file9416line707
What happens if this fails?
I'm fine with just not having the sync functionality if librt is unavailable,
if there are platforms that don't support
On 2011-01-10 15:41:41, Ali Saidi wrote:
src/sim/root.cc, line 200
http://reviews.m5sim.org/r/419/diff/1/?file=9421#file9421line200
Thanks for taking the time to do this!
Ditto... I meant to say something in my review but forgot... despite the
nitpicking, thanks for whipping up a
No problem, I'd been meaning to do it for a while anyway.
As far as librt, I agree it has its drawbacks and I have no problem
with alternatives. An alternative for clock_nanosleep is nanosleep,
the big difference I think being that you can't tell it to wait until
an absolute time, and you
19 matches
Mail list logo
