* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic
passed.
* build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-timing passed.
* build/ALPHA_SE/tests/fast/quick/30.eio-mp/alpha/eio/simple-atomic-mp
passed.
*
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/361/#review584
---
Hi Nilay,
This feature is long overdue, but I believe it is best if we
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/361/
---
(Updated 2011-01-03 09:54:30.940063)
Review request for Default.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/358/#review585
---
src/mem/ruby/slicc_interface/AbstractCacheEntry.hh
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/326/#review588
---
src/mem/protocol/MOESI_CMP_token-L1cache.sm
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/359/#review586
---
src/mem/protocol/MOESI_CMP_directory-L2cache.sm
On 2011-01-03 10:14:44, Steve Reinhardt wrote:
src/mem/protocol/MOESI_CMP_token-L1cache.sm, line 972
http://reviews.m5sim.org/r/326/diff/2/?file=8135#file8135line972
These functions that take multiple pointers just so the called function
can test which one is valid are pretty
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/280/#review590
---
src/mem/protocol/MOESI_hammer-cache.sm
changeset 9d94b886c61b in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=9d94b886c61b
description:
Ruby: Add option for random seed to Ruby.py
This patch adds an option to the script Ruby.py for setting the
parameter
m_random_seed used for randomizing
changeset 3a790012d6ed in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=3a790012d6ed
description:
RefCount: Fix reference counting pointer == and != with a T* on the
left.
These operators were expecting a const T instead of a const T*, and
were not
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/365/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/365/
---
(Updated 2011-01-03 12:56:11.143277)
Review request for Default, Ali Saidi, Gabe
On 2011-01-03 10:16:00, Steve Reinhardt wrote:
Though it was nice to split out the SLICC and protocol patches for
reviewing, I think these should be combined into a single changeset for
final commit.
I will commit all of these together.
- Nilay
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/358/
---
(Updated 2011-01-03 14:18:13.801375)
Review request for Default.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/359/
---
(Updated 2011-01-03 14:20:22.706038)
Review request for Default.
Changes
---
changeset a8fc35183c10 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=a8fc35183c10
description:
Make commenting on close namespace brackets consistent.
Ran all the source files through 'perl -pi' with this script:
changeset 850d71d21135 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=850d71d21135
description:
Delete unused files from src/base directory.
diffstat:
src/base/SConscript |6 -
src/base/compression/base.hh | 71 --
changeset 7338bc628489 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=7338bc628489
description:
Move sched_list.hh and timebuf.hh from src/base to src/cpu.
These files really aren't general enough to belong in src/base.
This patch doesn't reorder include
On 2011-01-03 10:14:44, Steve Reinhardt wrote:
src/mem/protocol/MOESI_CMP_token-L1cache.sm, line 972
http://reviews.m5sim.org/r/326/diff/2/?file=8135#file8135line972
These functions that take multiple pointers just so the called function
can test which one is valid are pretty
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/366/
---
Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/358/#review596
---
Hi Nilay,
First, I must say this is an impressive amount of work. You
I like the original (Ali's version) better. When was it confusing?
Perhaps there's a particular action that would be better the other way
around. Maybe we should have graduated levels of verbosity for this
stuff where, for example, 0 is Ali's version, 1 is this version, and 2
is the full command.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/366/
---
(Updated 2011-01-03 16:10:27.987336)
Review request for Default, Ali Saidi, Gabe
I think this is the first time I've updated an existing diff via
reviewboard, and I thought it would give me a chance to enter some comments
on the website before publishing it like a new diff, but it didn't. so here
are the comments that go with this diff:
I had originally been more aggressive
I don't recall all the details about what got me going on this, but I think
a couple of the specific things I didn't like were (1) if you compile
multiple binaries at the same time (e.g., m5.debug and m5.opt) the CXX lines
print the source file which doesn't give you enough information to know
Yeah, primarily. In this new version there's enough text that it gets
hard to pick out the nugget that lets you know what it's doing. We have
some way to turn on the command lines again, don't we? I don't really
remember off hand. Granted when things are compiling I usually just
ignore it and
I had originally been more aggressive about common prefix extraction, but
there were some glitches that made me go with the path-based approach...
however, in the process of uploading this diff I thought of some fixes. So
consider this second diff as an alternative and not necessarily a
On Jan 3, 2011, at 10:21 PM, nathan binkert wrote:
I had originally been more aggressive about common prefix extraction, but
there were some glitches that made me go with the path-based approach...
however, in the process of uploading this diff I thought of some fixes. So
consider this
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/365/#review597
---
Ship it!
I have some suggestions, but overall, it looks good. It would
I love this and I've been wanting it for a while for your reason #1,
also, there are some ambiguous things where the same file is printed
because one is a TARGET and another thing uses a SOURCE (that always
bothered me.)
[ CXX] ALPHA_SE/sim/main: .cc - .do
My only change would be to
On Mon, Jan 3, 2011 at 8:38 PM, nathan binkert n...@binkert.org wrote:
I love this and I've been wanting it for a while for your reason #1,
also, there are some ambiguous things where the same file is printed
because one is a TARGET and another thing uses a SOURCE (that always
bothered
On Jan 3, 2011, at 10:57 PM, Steve Reinhardt wrote:
With Nate's suggested change, for CXX lines we're really just tacking on the
' - .o' at the end... the initial part of the line is unchanged, and the
number of extra chars per line is 6 or 7. If you guys really insist, it
probably
On Mon, Jan 3, 2011 at 8:57 PM, Steve Reinhardt ste...@gmail.com wrote:
[ CXX] ALPHA_SE/sim/main: .cc - .do
My only change would be to remove the colon space. It serves little
purpose and makes cut-and-paste less useful.
[ CXX] ALPHA_SE/sim/main.cc - .do
That's a decent
Ali Saidi wrote:
On Jan 3, 2011, at 10:57 PM, Steve Reinhardt wrote:
With Nate's suggested change, for CXX lines we're really just tacking
on the ' - .o' at the end... the initial part of the line is
unchanged, and the number of extra chars per line is 6 or 7. If you
guys really insist,
So far I've found two oddities with a straightforward implementation of this
approach:
(1) It breaks down when the target is a prefix of the source:
[ STRIP] ALPHA_SE/m5.fast.unstripped -
instead of
[ STRIP] ALPHA_SE/m5.fast: .unstripped -
(2) It gives the wrong impression when
35 matches
Mail list logo
