---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/#review1009
---
Hi Somayeh,
I was hoping this would be the final review, but I'm
On 2011-03-24 08:58:15, Brad Beckmann wrote:
src/mem/ruby/system/Sequencer.cc, line 396
http://reviews.m5sim.org/r/552/diff/6/?file=11209#file11209line396
I don't think you need to separately handle Flush request. I believe
the current implmementation of handleLlsc should always
On 2011-03-24 08:58:15, Brad Beckmann wrote:
src/mem/ruby/system/Sequencer.cc, line 541
http://reviews.m5sim.org/r/552/diff/6/?file=11209#file11209line541
I thought we concluded that Flush requests can callback the RubyPort?
As long as needsResponse is set to false, the cpu
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/
---
(Updated 2011-03-24 17:17:59.835934)
Review request for Default and Brad Beckmann.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/#review1013
---
Ship it!
Hi Somayeh,
Other than a couple minor comment updates (see
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/
---
(Updated 2011-03-23 22:28:01.608904)
Review request for Default and Brad Beckmann.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/
---
(Updated 2011-03-22 19:33:58.68)
Review request for Default and Brad Beckmann.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/#review1005
---
Hi Somayeh,
This looks great. I just have a couple comments below.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/#review958
---
Hi Somayeh,
I just have one larger issue to mention, then a few minor
On 2011-03-14 15:54:41, Brad Beckmann wrote:
Hi Somayeh,
I just have one larger issue to mention, then a few minor comments. See below
for details. The larger issue is that I believe one of the transitions you
specify is unecessary (see specific comments below). In general, be very
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/
---
(Updated 2011-03-13 19:34:43.699185)
Review request for Default and Brad Beckmann.
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/552/
---
(Updated 2011-03-13 19:50:32.384965)
Review request for Default and Brad Beckmann.
Hi Brad,
I have applied the previous comments. This version also passes
10,000,000 ruby tests and the MOESI_hammer regression test (quick).
I have a question about Flush requests. In the current version, flush
requests return data (similar to loads) for testing purposes. I think it
should
13 matches
Mail list logo
