---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/21/#review44
---
Ship it!
- Nilay
On 2010-06-02 15:56:26, Nathan Binkert wrote:
On 2010-06-06 12:34:28, Nilay Vaish wrote:
The changes seem
I have two observations
1. In several places we are using dynamic_cast. The patch under
consideration moves some of these to safe_cast and retains dynamic_cast at
other places. Should we not use safe_cast in all
1. In several places we are using dynamic_cast. The patch under consideration
moves some of these to safe_cast and retains dynamic_cast at other places.
Should we not use safe_cast in all places? This would avoid the checks that
dynamic_cast carries out when not running the debug version.
I haven't looked at this in great detail (and don't plan to), but I'm
wondering: I don't know what the purpose of Allocator() was, but does it make
sense to replace it with FastAlloc rather than just leaving it to the default
allocator? I see where this would be a little more complicated
---
This is an automatically generated e-mail. To reply, visit:
http://reviews.m5sim.org/r/21/
---
Review request for Ruby Reviewers.
Summary
---
ruby: get rid of RefCnt and
