changeset b83e07b4541d in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=b83e07b4541d
description:
style: remove extra debugging print
diffstat:
util/style.py | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diffs (11 lines):
diff -r a660cabc3ea6 -r
changeset d8ec0a7b3f0c in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=d8ec0a7b3f0c
description:
style: fix all_regions code and remove bogus region type
diffstat:
util/style.py | 6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diffs (23 lines):
diff -r
changeset bca419132437 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=bca419132437
description:
style: add a user interface wrapper class
makes things work both with mercurial and stand alone with stdio
diffstat:
util/style.py | 60
changeset f3aaa2470b5a in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=f3aaa2470b5a
description:
style: move style verifiers into classes
diffstat:
util/style.py | 250 -
1 files changed, 139 insertions(+), 111
changeset 59d3bfa85f16 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=59d3bfa85f16
description:
style: add sort_includes to the style hook
diffstat:
util/style.py | 83 +++---
1 files changed, 72 insertions(+), 11
changeset 7107a2f3e53a in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=7107a2f3e53a
description:
Style checker: Fix a couple bugs in style.py.
diffstat:
util/style.py | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diffs (21 lines):
diff -r c6bc8fe81e79
changeset 49b7d40ee88a in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=49b7d40ee88a
description:
style: clean up style hook code a bit
I've renamed the check_whitespace operation to check_style. You're
going to
need to change your .hg/hgrc file. While
changeset 817c662677d1 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=817c662677d1
description:
style: prevent the style hook from aborting uncleanly because of an
exception
diffstat:
util/style.py | 16 ++--
1 files changed, 14 insertions(+), 2
changeset 15553b536bd6 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=15553b536bd6
description:
style: make style hook work with pre-qrefresh and update to use new code
clean up the code a little bit while we're at it.
I recommend that everyone adds the
changeset 9ea24d102d66 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=9ea24d102d66
description:
style: clean up ruby's Set class
Further cleanup should probably be done to make this class be non-Ruby
specific and put it in src/base.
There are
changeset 7d6862b80049 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=7d6862b80049
description:
style: another ruby style pass
diffstat:
46 files changed, 2195 insertions(+), 2958 deletions(-)
src/mem/ruby/SConsopts|4
changeset ec76e5c7cdd3 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=ec76e5c7cdd3
description:
style: cleanup style
diffstat:
1 file changed, 39 insertions(+), 49 deletions(-)
src/sim/serialize.cc | 88 ++
diffs (248
changeset 6df0633d883b in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=6df0633d883b
description:
style: fix style hook for some newer versions of mercurial.
diffstat:
1 file changed, 2 insertions(+), 2 deletions(-)
util/style.py |4 ++--
diffs (21 lines):
diff -r
changeset 5645632d594c in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=5645632d594c
description:
style
diffstat:
2 files changed, 63 insertions(+), 47 deletions(-)
src/cpu/static_inst.cc | 43 --
src/cpu/static_inst.hh | 67
binkert
Sent: Wednesday, November 12, 2008 4:42 PM
To: Beckmann, Brad
Cc: M5 Developer List
Subject: Re: [m5-dev] changeset in m5: style: clean up the Packet
stuff
The VALID_DST change is correct, but I don't quite understand the
allocate() change. You got rid of the assertion that there is valid
: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of
nathan
binkert
Sent: Wednesday, November 12, 2008 4:42 PM
To: Beckmann, Brad
Cc: M5 Developer List
Subject: Re: [m5-dev] changeset in m5: style: clean up the Packet
stuff
The VALID_DST change is correct, but I don't quite
Isn't the assertion backwards? Looks to me that if data is nonzero
you're asserting that neither STATIC_DATA nor DYNAMIC_DATA is set.
Don't you need a '!' in that assertion? Or change it to flags.any()
or whatever the right operator is?
You're right of course. It should be flags.any().
changeset a88e8e7dec75 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=a88e8e7dec75
description:
style: clean up the Packet stuff
diffstat:
3 files changed, 24 insertions(+), 32 deletions(-)
src/mem/packet.cc |1
src/mem/packet.hh |1
src/mem/request.hh |
This diff went way beyond style cleanup. Unfortunately, I didn't
remember to update the commit message. One of the big things I did
was get rid of all of the individual boolean variable flags and create
a single flags variable. I also made all of the flag values static
members of their classes
changeset 345ef3bda3d2 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=345ef3bda3d2
description:
style: Bring statistics code in line with the proper style.
diffstat:
3 files changed, 3 insertions(+), 3 deletions(-)
src/base/statistics.hh |2 +-
changeset baeee670d4ce in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=baeee670d4ce
description:
style: Make a style pass over the whole arch/alpha directory.
diffstat:
46 files changed, 776 insertions(+), 509 deletions(-)
src/arch/alpha/ev5.cc|1
I thought that we had agreed to always use braces for control structures
(for, if, while, etc.) since that makes it easier to add/remove lines
without worrying about adding/removing braces too. I don't see it mentioned
either way on the coding style page, but I know I've developed the habit of
Also, please make these sorts of large scale formatting changes
judiciously. There's a large collection of patches out there and it can
be non-trivial to keep them applying correctly.
Gabe
Steve Reinhardt wrote:
I thought that we had agreed to always use braces for control
structures (for,
I thought that we had agreed to always use braces for control structures
(for, if, while, etc.) since that makes it easier to add/remove lines
without worrying about adding/removing braces too. I don't see it mentioned
either way on the coding style page, but I know I've developed the habit
I don't really have a strong opinion either way; the #1 thing is that we
should agree and get it down on the wiki page so that these style updates
converge rather than oscillating.
Agreed. What do you think about my above statement? If the whole
expression fits in two lines, no
I think that sounds fine. Does no braces required also mean no braces
allowed, or is that something left up to the implementers discretion? I
think it should be optional rather than forbidden.
I'd agree with optional.
___
m5-dev mailing list
On Sat, Sep 27, 2008 at 9:35 PM, nathan binkert [EMAIL PROTECTED] wrote:
I think that sounds fine. Does no braces required also mean no braces
allowed, or is that something left up to the implementers discretion? I
think it should be optional rather than forbidden.
I'd agree with
Optional is OK with me, but in that case it's not something that should be
fixed in a style update.
True, my bad. I was just going really fast.
Nate
___
m5-dev mailing list
m5-dev@m5sim.org
http://m5sim.org/mailman/listinfo/m5-dev
changeset cb98f0fcc6c6 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=cb98f0fcc6c6
description:
style: These files didn't even come close to following the M5 style
guide.
diffstat:
2 files changed, 27 insertions(+), 145 deletions(-)
src/arch/mips/dsp.cc | 32
changeset c2db27fc4f27 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=c2db27fc4f27
description:
style: bring this file into M5 style, use the new pte translate
function.
diffstat:
1 file changed, 54 insertions(+), 10 deletions(-)
src/arch/sparc/vtophys.cc | 64
changeset 4c4b5dfc9944 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=4c4b5dfc9944
description:
style: missed space after switch
diffstat:
0 files changed
diffs (129 lines):
diff -r 875cb7d09831 -r 4c4b5dfc9944 src/arch/mips/dsp.cc
--- a/src/arch/mips/dsp.cc
yeah, I just did this quickly and I guess I missed switch in my
regexp. I just committed fix.
I've been toying around with an emacs script to go through and fix up
some of the basics.
It might be worth spending some effort to get a beautifier working.
There's one that seems to still be getting
I really hope this isn't going to make applying all my patches significantly
harder...
Gabe
Quoting Ali Saidi [EMAIL PROTECTED]:
changeset 3af77710f397 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=3af77710f397
description:
style: Remove non-leading tabs
run expand on the patch files before trying to apply them...
Everything should work fine.
Ali
On Sep 10, 2008, at 4:44 PM, [EMAIL PROTECTED] wrote:
I really hope this isn't going to make applying all my patches
significantly
harder...
Gabe
Quoting Ali Saidi [EMAIL PROTECTED]:
we've hacked on remote_gdb so much that preserving the tabs wouldn't
really help.
Ali
On Sep 10, 2008, at 4:48 PM, [EMAIL PROTECTED] wrote:
Also I notice some of these are changes to the *bsd copyrights on
some files,
for instance the remote_gdbs. We probably shouldn't change those.
changeset bb31ea8583d8 in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=bb31ea8583d8
description:
style: This file hugely violated the M5 style.
Remove a bunch of unused cruft from the interface while we're at it
diffstat:
2 files changed, 20 insertions(+), 40
On the topic of style violations, I've seen an increasing number of 'if('
and 'for(' (with no space) creeping in (see below). Another thing I've seen
that irritates me (but isn't officially banned by the style code ... yet
...) is C++-style comments with no space between the // and the comment:
On the topic of style violations, I've seen an increasing number of 'if('
and 'for(' (with no space) creeping in (see below). Another thing I've seen
that irritates me (but isn't officially banned by the style code ... yet
...) is C++-style comments with no space between the // and the
changeset a5ff5e57fafd in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=a5ff5e57fafd
description:
style
diffstat:
4 files changed, 11 insertions(+), 39 deletions(-)
src/arch/mips/regfile/misc_regfile.cc | 38 -
changeset 288b54c2fd8d in /z/repo/m5
details: http://repo.m5sim.org/m5?cmd=changeset;node=288b54c2fd8d
description:
style: fix indentation and formatting of the pseudo insts.
diffstat:
2 files changed, 209 insertions(+), 37 deletions(-)
src/sim/pseudo_inst.cc | 223
40 matches
Mail list logo
