[m5-dev] Review Request: NetworkMessage copy constructor fix

2010-07-06 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/30/ --- Review request for Default. Summary --- NetworkMessage copy constructor fix

[m5-dev] Review Request: garnet: Added topology print function to Garnet printStats

2010-07-06 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/33/ --- Review request for Default. Summary --- garnet: Added topology print function

Re: [m5-dev] Review Request: garnet: Added topology print function to Garnet printStats. Unless I hear otherwise, I will check it in, in a couple of days.

2010-07-06 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/33/ --- (Updated 2010-07-06 15:17:25.503373) Review request for Default. Summary

Re: [m5-dev] Review Request: NetworkMessage copy constructor fix. Unless I hear otherwise, I will check it in, in a couple of days.

2010-07-06 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/30/ --- (Updated 2010-07-06 15:19:27.721787) Review request for Default. Summary

[m5-dev] Review Request: Fix x86 XCHG macro-op to use locked micro-ops for all memory accesses

2010-07-20 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/59/ --- Review request for Default. Summary --- Fix x86 XCHG macro-op to use locked

[m5-dev] changeset in m5: Fix x86 XCHG macro-op to use locked micro-ops f...

2010-07-21 Thread Tushar Krishna
changeset a75564db03c3 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=a75564db03c3 description: Fix x86 XCHG macro-op to use locked micro-ops for all memory accesses diffstat: src/arch/x86/isa/insts/general_purpose/data_transfer/xchg.py | 16 ++-- 1 files

[m5-dev] changeset in m5: garnet: separate data and ctrl VCs

2011-02-06 Thread Tushar Krishna
changeset 8439266ec9e5 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=8439266ec9e5 description: garnet: separate data and ctrl VCs Separate data VCs and ctrl VCs in garnet, as ctrl VCs have 1 buffer per VC, while data VCs have 1 buffers per VC. This

[m5-dev] changeset in m5: MOESI_CMP_token: removed unused message fields

2011-02-06 Thread Tushar Krishna
changeset b3d642f01495 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=b3d642f01495 description: MOESI_CMP_token: removed unused message fields diffstat: src/mem/protocol/MOESI_CMP_token-msg.sm | 6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diffs (32

[m5-dev] Review Request: Network Tester Patch

2011-03-11 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/561/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan

[m5-dev] Review Request: minor fixes to garnet flexible pipeline code

2011-03-11 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/562/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

Re: [m5-dev] Review Request: Network Tester Patch

2011-03-11 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/561/ --- (Updated 2011-03-11 09:33:50.616494) Review request for Default, Ali Saidi, Gabe

[m5-dev] Review Request: fix garnet flexible pipeline

2011-03-15 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/584/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

[m5-dev] Review Request: This patch makes garnet use the info about active and inactive vnets during allocation and power estimations etc

2011-03-15 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/585/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

Re: [m5-dev] Review Request: Network Tester Patch

2011-03-20 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/561/ --- (Updated 2011-03-20 05:11:37.330118) Review request for Default, Ali Saidi, Gabe

Re: [m5-dev] Review Request: Network Tester Patch

2011-03-20 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/561/ --- (Updated 2011-03-20 05:23:02.880797) Review request for Default, Ali Saidi, Gabe

[m5-dev] changeset in m5: This patch adds the network tester for simple a...

2011-03-21 Thread Tushar Krishna
. +# +# Authors: Ron Dreslinski +# Tushar Krishna + +import m5 +from m5.objects import * +from m5.defines import buildEnv +from m5.util import addToPath +import os, optparse, sys +addToPath('../common') +addToPath('../ruby') +import Ruby + +if buildEnv['FULL_SYSTEM']: +panic(This script

[m5-dev] changeset in m5: fix garnet fleible pipeline

2011-03-21 Thread Tushar Krishna
changeset bdb039c42553 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=bdb039c42553 description: fix garnet fleible pipeline diffstat: src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc| 18 -

[m5-dev] changeset in m5: This patch makes garnet use the info about acti...

2011-03-21 Thread Tushar Krishna
changeset 2c47dc111abd in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=2c47dc111abd description: This patch makes garnet use the info about active and inactive vnets during allocation and power estimations etc diffstat:

[m5-dev] networktest.cc error

2011-03-22 Thread Tushar Krishna
Hi all, I didn't (and still don't) see any errors in networktest.cc when I built m5 on my own computer for both SE and FS modes before checking in the patch. Could it be a gcc version issue? The error which the regression tester points to is

[m5-dev] changeset in m5: This patch fixes a build error in networktest.c...

2011-03-22 Thread Tushar Krishna
changeset ec1eecca2f8f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=ec1eecca2f8f description: This patch fixes a build error in networktest.cc that occurs with gcc4.2 diffstat: src/cpu/testers/networktest/networktest.cc | 6 +++--- 1 files changed, 3

Re: [m5-dev] networktest.cc error

2011-03-22 Thread Tushar Krishna
Thanks guys. Yeah I was using gcc4.3 which does not give this error, while gcc4.2 does. I just checked in a patch to solve this. Thanks, Tushar On 3/23/2011 10:56 AM, Nilay wrote: On Tue, March 22, 2011 9:45 pm, Tushar Krishna wrote: Hi all, I didn't (and still don't) see any errors

Re: [m5-dev] changeset in m5: This patch fixes a build error in networktest.c...

2011-03-22 Thread Tushar Krishna
Ah sorry Nate didn't know the commit convention. Will follow it in future checkins. Is this link available from the m5sim wiki somewhere? I tried searching in http://www.m5sim.org/wiki/index.php/Development and in http://www.m5sim.org/wiki/index.php/NewDoc#Development for the checkin

Re: [m5-dev] Review Request: network: generalized bw for basic links

2011-04-27 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/661/#review1161 --- src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py

Re: [m5-dev] Review Request: network: moved network config params

2011-04-27 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/662/#review1164 --- Ship it! Yeah this will make things clearer between simple and garnet

Re: [m5-dev] Review Request: network: generalized bw for basic links

2011-04-27 Thread Tushar Krishna
On 2011-04-27 16:03:25, Tushar Krishna wrote: src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py, line 44 http://reviews.m5sim.org/r/661/diff/1/?file=12097#file12097line44 In garnet, the link width is actually equal to flit size (i.e. the entire flit is injected

Re: [m5-dev] Review Request: network: generalized bw for basic links

2011-04-27 Thread Tushar Krishna
On 2011-04-27 16:03:25, Tushar Krishna wrote: src/mem/ruby/network/garnet/fixed-pipeline/GarnetLink_d.py, line 44 http://reviews.m5sim.org/r/661/diff/1/?file=12097#file12097line44 In garnet, the link width is actually equal to flit size (i.e. the entire flit is injected

[m5-dev] Review Request: network: added Torus and Pt2Pt topologies

2011-04-29 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/667/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

[m5-dev] changeset in m5: network: added Torus and Pt2Pt topologies

2011-05-07 Thread Tushar Krishna
, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. +# +# Authors: Brad Beckmann +# Tushar Krishna + +from m5.params import * +from m5.objects import

[m5-dev] changeset in m5: NetworkTest: added sim_cycles parameter to the ...

2011-05-07 Thread Tushar Krishna
changeset db269e704d07 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=db269e704d07 description: NetworkTest: added sim_cycles parameter to the network tester. The network tester terminates after injecting for sim_cycles (default=1000), instead of having

[m5-dev] Review Request: slicc: added vnet_type field to identify response vnets from others

2011-05-08 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/686/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

[m5-dev] Review Request: garnet: rename and rearrange config parameters

2011-05-09 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/688/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

Re: [m5-dev] Review Request: slicc: added vnet_type field to identify response vnets from others

2011-05-09 Thread Tushar Krishna
to let you know while you review this patch since the change for that might be related ... Thanks - Tushar On 2011-05-08 21:09:50, Tushar Krishna wrote: --- This is an automatically generated e-mail. To reply, visit: http

[gem5-dev] changeset in m5: garnet: rename and rearrange config parameters.

2011-05-18 Thread Tushar Krishna
changeset 76f7c2858c5c in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=76f7c2858c5c description: garnet: rename and rearrange config parameters. Renamed (message) class to vnet for consistency with rest of ruby. Moved some parameters specific to

[gem5-dev] changeset in m5: slicc: added vnet_type field to identify respon...

2011-05-18 Thread Tushar Krishna
changeset 79cf09f5a234 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=79cf09f5a234 description: slicc: added vnet_type field to identify response vnets from others Identifying response vnets versus other vnets will allow garnet to determine which vnets

[gem5-dev] changeset in m5: slicc: added vnet_type to MI_example

2011-05-20 Thread Tushar Krishna
changeset adb2d5f7407d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=adb2d5f7407d description: slicc: added vnet_type to MI_example Forgot to add this to MI_example in my previous patch. diffstat: src/mem/protocol/MI_example-cache.sm | 8

Re: [gem5-dev] Cron m5test@zizzer /z/m5/regression/do-regression quick

2011-05-20 Thread Tushar Krishna
Sorry about that. Just checked in a patch which should fix it. Had added vnet_type to all protocols, but forgot to add it to MI_example. And its default build does not use RUBY so I missed catching it earlier. On 5/20/2011 4:35 AM, Gabe Black wrote: The regressions are failing with the error

[gem5-dev] changeset in m5: configs: remove -p from ruby_network_test.py

2011-05-20 Thread Tushar Krishna
changeset de2451e66935 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=de2451e66935 description: configs: remove -p from ruby_network_test.py A recent patch broke the ruby network tester by adding -p inside Options.py which conflicts with the -p inside

[gem5-dev] changeset in m5: garnet: use vnet_type from protocol to decide b...

2011-05-20 Thread Tushar Krishna
changeset 1eaa1fbd2212 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=1eaa1fbd2212 description: garnet: use vnet_type from protocol to decide buffer depths The virtual channels within response vnets are made buffers_per_data_vc deep (default=4), while

Re: [gem5-dev] Review Request: config: tweak ruby configs to clean up hierarchy

2011-05-23 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/709/#review1253 --- Hi Steve, I think you will also have to make similar changes in

[gem5-dev] Review Request: garnet: add network ptr to links

2011-05-23 Thread Tushar Krishna
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/711/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, Nathan Binkert,

[gem5-dev] possible bug in ruby/common/Set.hh

2011-05-28 Thread Tushar Krishna
Hi all, I think src/mem/ruby/common/Set.hh has a bug. It has the following lines: static const int LONG_BITS = std::numeric_limitslong::digits; static const int INDEX_SHIFT = LONG_BITS == 64 ? 6 : 5; Since long by default is signed, LONG_BITS will always be 31 or 63, depending on the

Re: [gem5-dev] possible bug in ruby/common/Set.hh

2011-05-28 Thread Tushar Krishna
Thanks Korey. Yeah inability to run 32 cores on 32-bit machines, and inability to run 64 cores on 64-bit machines is the same issue, so I guess the STL bitsets solution should fix this problem too. Thanks, Tushar On 5/28/2011 2:34 AM, Korey Sewell wrote: Tushar, There should be an earlier

[gem5-dev] changeset in m5: garnet: added network ptr to links to be used b...

2011-05-31 Thread Tushar Krishna
changeset 24a00a6d5992 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=24a00a6d5992 description: garnet: added network ptr to links to be used by orion diffstat: src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc | 7 +++

[gem5-dev] changeset in m5: orion: bug fix in link power, and some reorg

2011-05-31 Thread Tushar Krishna
changeset 681497e0356b in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=681497e0356b description: orion: bug fix in link power, and some reorg diffstat: src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc | 3 +

[gem5-dev] Unable to upload figures to wiki

2011-05-31 Thread Tushar Krishna
Hi Nate, I am unable to upload new figures to the wiki. I get this upload warning: The upload directory (public) is not writable by the webserver. Does this have something to do with permissions? Thanks, Tushar ___ gem5-dev mailing list

Re: [gem5-dev] Unable to upload figures to wiki

2011-05-31 Thread Tushar Krishna
, Tushar Krishna tus...@csail.mit.edu wrote: Hi Nate, I am unable to upload new figures to the wiki. I get this upload warning: The upload directory (public) is not writable by the webserver. Does this have something to do with permissions? Thanks, Tushar

[gem5-dev] changeset in web-graphics: network: updated topology figure

2011-05-31 Thread Tushar Krishna
changeset 8b47475cd2b3 in /z/repo/web-graphics details: web-graphics?cmd=changeset;node=8b47475cd2b3 description: network: updated topology figure diffstat: ruby/figures/Topology_overview.jpg |0 1 files changed, 0 insertions(+), 0 deletions(-) diffs (2 lines): diff -r

[gem5-dev] changeset in web-graphics: Resize topology figure

2011-05-31 Thread Tushar Krishna
changeset c1a85b596072 in /z/repo/web-graphics details: web-graphics?cmd=changeset;node=c1a85b596072 description: Resize topology figure diffstat: ruby/figures/Topology_overview.jpg |0 1 files changed, 0 insertions(+), 0 deletions(-) diffs (2 lines): diff -r 8b47475cd2b3 -r