Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-07 Thread Craig Russell
> On May 6, 2017, at 10:04 AM, Craig Russell wrote: > >>> 3. The java source files in android/commons/src are still in the >>> com.alibaba name space. Assuming that these are actually weex source files, >>> they must be repackaged to org.apache. >>> >> The ASF actually has no policy around this

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-06 Thread Craig Russell
Hi John, > On May 6, 2017, at 5:27 AM, John D. Ament wrote: > > Craig, > > To comment on a few of these notes. > > Many of these are valid issues with the release, but generally would not > block an initial release. I would recommend we follow our rule of "point > it out, pass it as it doesn'

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-06 Thread John D. Ament
Craig, To comment on a few of these notes. Many of these are valid issues with the release, but generally would not block an initial release. I would recommend we follow our rule of "point it out, pass it as it doesn't create a legal issue, and expect it to be fixed for next release." The only

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-05 Thread Niclas Hedhman
Thanks Anthony, so that's where the notion "gradlew doesn't work on Windows" comes from. Makes more sense now. But I don't think that is just as practical for Weex as it is for BigTop. On Sat, May 6, 2017 at 3:10 AM, Anthony Baker wrote: > > > On May 5, 2017, at 4:27 AM, sospartan wrote: > > >

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-05 Thread Anthony Baker
> On May 5, 2017, at 4:27 AM, sospartan wrote: > > I'll remove whole playground sample app from artifacts innext release. So > #7 would be a problem anymore. > As the gradle wrapper will be removed too. I'll suggest use installed > gradle to create that. These will be put in new "how to build fr

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-05 Thread sospartan
I'll remove whole playground sample app from artifacts innext release. So #7 would be a problem anymore. As the gradle wrapper will be removed too. I'll suggest use installed gradle to create that. These will be put in new "how to build from source" doc in root folder. Pierre Smits 于2017年5月5日 周五下午6

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-05 Thread Pierre Smits
I forgot to address in my conclusion aspect #7 (classes.jar). This seems to be quite the issue, as I could not find a license associated with it when I did the cursory review. Nor could I find in the proposal anything more than a single reference. My question(s): - where does this originate fr

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-05 Thread Pierre Smits
Hi All, To understand part of the problem correctly, in currently proposed release there are many compiled components (jar files)that aren't allowed to be included > clr% find . -name "*.jar" 1. > ./android/playground/gradle/wrapper/gradle-wrapper.jar 2. > ./android/sdk/gradle/wrapper/

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-04 Thread sospartan
Taylor, Can you point out which objections you are agreed exactly? On Fri, May 5, 2017 at 9:31 AM, P. Taylor Goetz wrote: > Apologies for the auto correct. > > Please sub "Niclas" for "Nicolas". > > -Taylor > > > On May 4, 2017, at 8:43 PM, P. Taylor Goetz wrote: > > > > Nicolas, > > > > I un

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-04 Thread P. Taylor Goetz
Apologies for the auto correct. Please sub "Niclas" for "Nicolas". -Taylor > On May 4, 2017, at 8:43 PM, P. Taylor Goetz wrote: > > Nicolas, > > I understand and appreciate your passion, but would respectfully ask that you > step down your tone a little bit. Craig and John have both taken ti

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-04 Thread P. Taylor Goetz
Nicolas, I understand and appreciate your passion, but would respectfully ask that you step down your tone a little bit. Craig and John have both taken time to review the release candidate (which you should be appreciative of -- getting IPMC members to review a release can be difficult). In my

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-04 Thread Craig Russell
If your objective is to get me to change my vote, I'd suggest this is not a good way forward. Craig > On May 4, 2017, at 12:02 AM, Niclas Hedhman wrote: > > Sorry, but if you don't know the background on that file, then perhaps you > think I am "not civil"... The fact is that NOTICE file doesn

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-04 Thread Niclas Hedhman
Sorry, but if you don't know the background on that file, then perhaps you think I am "not civil"... The fact is that NOTICE file doesn't require any inclusion of what the project depends on, since they are not bundled, but will be downloaded during build. In a previous round, we were told to take

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-03 Thread Craig Russell
I'm going to call foul on this one. If you cannot be civil, then leave the discussion to others. Craig > On May 3, 2017, at 7:24 PM, Niclas Hedhman wrote: > > BUT ALSO figuring out what to start looking for. For fak sake, > man Get a grip on reality! Craig L Russell Secretary, Apache Sof

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-03 Thread sospartan
> 4. The javascript source files in playground/app/src are missing the license header. They have a style that I do not recognize. Are these generated files? The first several lines of storage-demo.js: > > /**/ (function(modules) { // webpackBootstrap > /**/// The module cache > /**

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-03 Thread Niclas Hedhman
On Thu, May 4, 2017 at 9:22 AM, Craig Russell wrote: > clr% find . -name "*.jar" > ./android/playground/gradle/wrapper/gradle-wrapper.jar > ./android/sdk/gradle/wrapper/gradle-wrapper.jar > ./android/sdk/license/license-gradle-plugin-0.12.1.jar > ./android/sdk/license/maven-license-plugin-1.10.b1.

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-03 Thread Craig Russell
I also must vote -1 on this release. clr% find . -name "*.jar" ./android/playground/gradle/wrapper/gradle-wrapper.jar ./android/sdk/gradle/wrapper/gradle-wrapper.jar ./android/sdk/license/license-gradle-plugin-0.12.1.jar ./android/sdk/license/maven-license-plugin-1.10.b1.jar ./android/sdk/license/

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-02 Thread Niclas Hedhman
+1 On Tue, May 2, 2017 at 1:49 PM, sospartan wrote: > Hi all, > I'll calling a vote for Weex-incubating 0.12.0-RC3 release. > > The PPMC vote for this release has passed: > https://lists.apache.org/thread.html/c5514c86433e3551cae00b21a77a14 > 07ee20846f6565f9701d78c85b@%3Cdev.weex.apache.org%3E

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-02 Thread Niclas Hedhman
As for the Gradle Jar; I gave the go ahead for this release, as I am pursuing to make Gradle have a single Java file instead of a Jar file, as this will take some time. This is known and not of legal concern, and up for interpretation of policy, which we both agree is not definitive. Since there

Re: [VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-02 Thread John D. Ament
Sorry but -1 due to binaries in the source release. I'm not sure if I missed these the last go around or what, but they should not be included (gradle-wrapper I know was called out before): ./apache-weex-incubating-0.12.0-src/android/playground/gradle/wrapper/gradle-wrapper.jar ./apache-weex-incu

[VOTE]: Apache Weex-incubating Release 0.12.0-RC3

2017-05-01 Thread sospartan
Hi all, I'll calling a vote for Weex-incubating 0.12.0-RC3 release. The PPMC vote for this release has passed: https://lists.apache.org/thread.html/c5514c86433e3551cae00b21a77a1407ee20846f6565f9701d78c85b@%3Cdev.weex.apache.org%3E The tag to be voted upon: https://git-wip-us.apache.org/repos/asf?