Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-10 Thread Jun Liu
> Just a quick note for binary release, it only includes the dubbo > jars. It could be more convenience for the end user if we can include > the third party dependencies jars in the binary release. Yes, this is a point that I have seen some people have also put out in the community, but sadly,

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-09 Thread Willem Jiang
Sorry, I just got some time back to this thread. I just went through the dev discussion of the dubbo and found out dubbo community are planning the next release cut by discussion the bug fix list first. I'm sure we could do it better in the next release. Here are my +1 for this vote. I can build

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-07 Thread Huxing Zhang
Hi community, We have 2 binding votes, still need one vote to pass. Would you please kindly help to check and vote for it? On Mon, Sep 3, 2018 at 10:32 AM Jun Liu wrote: > > Hello All, > > This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3. > > The Apache Dubbo

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-06 Thread Jun Liu
> I just checked the commit, it relates to system property setting, the > fix is quite simple. > I also checked the CI build, it looks like the CI is green[1] > > But my question is this fix was merged into 2.6.x branch for three > weeks ago, why didn't we do the cherry pick it into 2.6.3

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-06 Thread jun liu
> Issues from previous RC still present in this RC: > = > > The sha512 hashes are missing the '*' marker that indicates they are > hashes for binary files rather than text files. Trivial issue. New RC > not required. I have filed an issue[1] to

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-05 Thread Willem Jiang
I just checked the commit, it relates to system property setting, the fix is quite simple. I also checked the CI build, it looks like the CI is green[1] But my question is this fix was merged into 2.6.x branch for three weeks ago, why didn't we do the cherry pick it into 2.6.3 release branch

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-05 Thread Jerrick Zhu
On Wed, Sep 5, 2018 at 6:10 PM Mark Thomas wrote: > On 03/09/18 03:32, Jun Liu wrote: > > > > > Please vote accordingly: > > [X] +1 approve > > [ ] +0 no opinion > > [ ] -1 disapprove with the reason > > Notes: > == > > Hash and signature match. > > Source zip matches Git tag (apart from

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-05 Thread Mark Thomas
On 03/09/18 03:32, Jun Liu wrote: > Please vote accordingly: > [X] +1 approve > [ ] +0 no opinion > [ ] -1 disapprove with the reason Notes: == Hash and signature match. Source zip matches Git tag (apart from expected differences of .gitignore and Maven wrapper) Builds and all tests

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-05 Thread Justin Mclean
Hi, > This product contains code derived from Google Guava project, which is > available under a "Apache License 2.0" license. > (https://github.com/google/guava ). > > This product contains code derived from the Netty Project, which is > available under a

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-04 Thread Huxing Zhang
Hi, On Tue, Sep 4, 2018 at 5:02 PM Justin Mclean wrote: > > Hi, > > +1 binding > > I checked: > - incubating in name > - signatures and hashes correct > - DISCLAIMER exits > - LICENSE is fine > - NOTICE may need a little more work (as it is bundling a couple of file from > ALv2 license software

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-04 Thread Justin Mclean
Hi, +1 binding I checked: - incubating in name - signatures and hashes correct - DISCLAIMER exits - LICENSE is fine - NOTICE may need a little more work (as it is bundling a couple of file from ALv2 license software with NOTICE files) [1] - No binary files in release - All source files have ASF

Re: [VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-03 Thread Huxing Zhang
+1 (non-binding) * Signatures ok for both source and binary. * DISCLAIMER, LICENSE and NOTICE ok for both source and binary. * No SNAPSHOT in source file name or content. * Unit test passed on Java 8, although still have some unstable UT. On Mon, Sep 3, 2018 at 10:32 AM Jun Liu wrote: > > Hello

[VOTE] Release Apache Dubbo (Incubating) 2.6.3 [RC5]

2018-09-02 Thread Jun Liu
Hello All, This is a call for vote to release Apache Dubbo (Incubating) version 2.6.3. The Apache Dubbo community has voted on and approved a proposal to release Apache Dubbo (Incubating) version 2.6.3. We now kindly request the Incubator PMC members review and vote on this incubator release.