Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Jean-Baptiste Onofré
Good catch, I missed the DISCLAIMER in my review. LICENSE should be improved too even if I don't think it's a blocker for this release. Regards JB On 07/15/2016 01:50 PM, John D. Ament wrote: Sorry but -1 due to missing DISCLAIMER in the release. See [1] for more details [1]:

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Kam Kasravi
Hi Justin Thanks for the detailed review! - especially in regards to the LICENSE file. We had originally included license references that were part of a binary release. I'll clean this up to remove these items and address the other issues you've noted. Your youtube video is really helpful with

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Kam Kasravi
Thanks John. We have already merged a PR that has a separate DISCLAIMER file.I agree - it's an easy thing to add at this time but we'll wait for the final tally. On Friday, July 15, 2016 3:43 PM, John D. Ament wrote: Hi Kam, Two things.. 1. I'm not asking for

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Justin Mclean
Hi, -1 binding, missing DISCLAIMER and LICENSE and header issues I checked: - artefact names contain incubating - hashes and signature good - DISCLAIMER file is missing - LICENSE contains things that are not bundled and missing things that are (see below). It also contains paths to files that

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread John D. Ament
Hi Kam, Two things.. 1. I'm not asking for the disclaimer in the README. You can choose to put it wherever you see appropriate, a dedicated DISCLAIMER file may make sense. It shouldn't be too hard to re-roll a release with that fix (I didn't see any other issues, but I can take a second closer

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Kam Kasravi
Thanks John. We will add this to the README as suggested. We will also update the web site (gearpump.apache.org) with the incubating logo, disclaimer - however we were going to do that once we release (as part of updating the website with the release information). Hopefully this is acceptable.

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Andrew Purtell
Thank you very much John. We will fix. On Fri, Jul 15, 2016 at 4:50 AM, John D. Ament wrote: > Sorry but -1 due to missing DISCLAIMER in the release. See [1] for more > details > > > [1]: > http://incubator.apache.org/guides/releasemanagement.html#notes-disclaimer > >

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread John D. Ament
Sorry but -1 due to missing DISCLAIMER in the release. See [1] for more details [1]: http://incubator.apache.org/guides/releasemanagement.html#notes-disclaimer On Thu, Jul 14, 2016 at 3:39 PM Kam Kasravi wrote: > Hi IPMC Community > > The PPMC vote to release Apache

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-15 Thread Jean-Baptiste Onofré
+1 (binding) Regards JB On 07/14/2016 09:39 PM, Kam Kasravi wrote: Hi IPMC Community The PPMC vote to release Apache Gearpump (incubating) 0.8.1-RC3 has passed. We would like to now submit this release candidate to the IPMC. The PPMC vote thread is here:

Re: [VOTE] Apache Gearpump (incubating) 0.8.1-RC3

2016-07-14 Thread Andrew Purtell
Carrying over my +1 from the PPMC vote. Please someone have a look at the release artifacts. I try, but don't have the encyclopedic knowledge of policy nor the eye for detail that some of you other IPMCers do. On Thu, Jul 14, 2016 at 12:39 PM, Kam Kasravi wrote: > Hi