[RESULT] [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-24 Thread Cédric Champeau 
Hi everyone!

Vote for the release of Groovy 2.4.5-incubating passed with 6 +1 votes (5
binding) and no 0/-1 votes.

Vote thread:
http://mail-archives.apache.org/mod_mbox/incubator-general/201509.mbox/%3CCADQzvm%3DRbC-1649Vt62e%3D%2BK35KRE4difPg0s7ryuQKoDSJc-QA%40mail.gmail.com%3E

Thank you all!

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-24 Thread Jim Jagielski 
+1

> [X] +1, release Apache Groovy 2.4.5-incubating
> [ ] 0, I don't care
> [ ] -1, because...


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-21 Thread Sergio Fernández 
+1 (binding)

On Sun, Sep 20, 2015 at 12:20 PM, Cédric Champeau 
wrote:

> Hi all!
>
> The Apache Groovy PPMC has successfully voted the release of Apache Groovy
> 2.4.5-incubating [1], with 4 "+1" binding votes, one "+1" non binding and
> no 0/-1 votes. We are now asking the IPMC to vote it too.
>
> This release was done in a particular context, at the SpringOne2GX
> conference. Following a very successful BOF session, we followed up with a
> release initiation party to share the knowledge about how to perform a
> release! We anticipate this will make it easier for more of us to be
> involved with releases in the future. It's worth noting that the release
> was performed with the presence of Baruch Sadogursky from JFrog
> (Artifactory/Bintray) that we use, and he could already suggest some nice
> improvements in our release process that we're going to improve for the
> upcoming releases.
>
> Vote on dev list:
>
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvmkCoEUFXfmSR%2B71K%2BEmSYHAjkFWa1HH76LEcPDLMNSYZQ%40mail.gmail.com%3E
> Result of vote on dev list:
>
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvm%3DDzF-6T46crzuOBizG2wq0xPArfuz%3DQio_OwgQxEHEcw%40mail.gmail.com%3E
>
> This release fixes documentation issues, a potential memory leak when
> loading the Groovy runtime from different classloaders, some JSON fixes and
> improvements and numerous small bug fixes.
>
> The changelog for this release can be found here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12332749
>
> Tag:
>
> https://git1-us-west.apache.org/repos/asf?p=incubator-groovy.git;a=commit;h=13934972b400d40600c994377308b26978fcc325
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/KEYS
> Vote is open for at least 72 hours. Artifacts will be moved to dist as soon
> as the vote passes.
>
> [ ] +1, release Apache Groovy 2.4.5-incubating
> [ ] 0, I don't care
> [ ] -1, because...
>



-- 
Sergio Fernández
Partner Technology Manager
Redlink GmbH
m: +43 6602747925
e: sergio.fernan...@redlink.co
w: http://redlink.co

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-21 Thread Bertrand Delacretaz 
Hi,

On Sun, Sep 20, 2015 at 12:20 PM, Cédric Champeau  wrote:
>.. The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/...

+1 for the release, checked signatures, digest, license, notice,
disclaimer and license headers of the groovy, java, html and adoc
source files from this source archive:

SHA1(apache-groovy-src-2.4.5-incubating.zip)=
ddceb6ea326e2137dec94161cd18d2862b4bfd5d

Two files do not have the standard Apache license header, changing
those would make future checks easier:

./config/codenarc/codenarc.groovy
./src/spec/test/PrimitiveTest.groovy

Including only an md5 digest is insufficient IMO as that's broken
today [1] (we should update our release docs about that), please also
include a stronger digest like sha1 for future releases.

-Bertrand (Groovy incubation mentor)

[1] 
http://natmchugh.blogspot.co.uk/2014/10/how-i-created-two-images-with-same-md5.html

-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-21 Thread Paul King 
On Mon, Sep 21, 2015 at 6:05 PM, Bertrand Delacretaz  wrote:
>
>
> Two files do not have the standard Apache license header, changing
> those would make future checks easier:
>
> ./config/codenarc/codenarc.groovy
> ./src/spec/test/PrimitiveTest.groovy
>
>
Fixed (for the next release).

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-21 Thread Paul King 
On Mon, Sep 21, 2015 at 3:37 PM, Jochen Theodorou  wrote:

> Am 21.09.2015 01:17, schrieb Justin Mclean:
> [...]
>
>> - The file LineColumnCheck.txt looks like it's source code and is missing
>> an header. Is it Apache licensed or generated?
>>
>
> The file provides test data. It contains sample scripts which are compiled
> and the line/column information that the test will check against. In the
> repository the file has a header, but using == as comment marker. I have no
> idea what in our build is removing the header. We have to investigate this
>
> bye Jochen


The  header is in master but not 2.4.5 though it looks like it is set
up for manual running - so we'll have to check it still works with such a
header in place and doesn't muck up the line/column information that the
test needs.
.

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-21 Thread Olivier Lamy 
+1 (ipmc binding)

On 20 September 2015 at 20:20, Cédric Champeau  wrote:

> Hi all!
>
> The Apache Groovy PPMC has successfully voted the release of Apache Groovy
> 2.4.5-incubating [1], with 4 "+1" binding votes, one "+1" non binding and
> no 0/-1 votes. We are now asking the IPMC to vote it too.
>
> This release was done in a particular context, at the SpringOne2GX
> conference. Following a very successful BOF session, we followed up with a
> release initiation party to share the knowledge about how to perform a
> release! We anticipate this will make it easier for more of us to be
> involved with releases in the future. It's worth noting that the release
> was performed with the presence of Baruch Sadogursky from JFrog
> (Artifactory/Bintray) that we use, and he could already suggest some nice
> improvements in our release process that we're going to improve for the
> upcoming releases.
>
> Vote on dev list:
>
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvmkCoEUFXfmSR%2B71K%2BEmSYHAjkFWa1HH76LEcPDLMNSYZQ%40mail.gmail.com%3E
> Result of vote on dev list:
>
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvm%3DDzF-6T46crzuOBizG2wq0xPArfuz%3DQio_OwgQxEHEcw%40mail.gmail.com%3E
>
> This release fixes documentation issues, a potential memory leak when
> loading the Groovy runtime from different classloaders, some JSON fixes and
> improvements and numerous small bug fixes.
>
> The changelog for this release can be found here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12332749
>
> Tag:
>
> https://git1-us-west.apache.org/repos/asf?p=incubator-groovy.git;a=commit;h=13934972b400d40600c994377308b26978fcc325
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/KEYS
> Vote is open for at least 72 hours. Artifacts will be moved to dist as soon
> as the vote passes.
>
> [ ] +1, release Apache Groovy 2.4.5-incubating
> [ ] 0, I don't care
> [ ] -1, because...
>



-- 
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-21 Thread Jochen Theodorou 

Am 21.09.2015 13:29, schrieb Paul King:

On Mon, Sep 21, 2015 at 3:37 PM, Jochen Theodorou  wrote:


Am 21.09.2015 01:17, schrieb Justin Mclean:
[...]


- The file LineColumnCheck.txt looks like it's source code and is missing
an header. Is it Apache licensed or generated?



The file provides test data. It contains sample scripts which are compiled
and the line/column information that the test will check against. In the
repository the file has a header, but using == as comment marker. I have no
idea what in our build is removing the header. We have to investigate this

[...]

The  header is in master but not 2.4.5 though it looks like it is set
up for manual running - so we'll have to check it still works with such a
header in place and doesn't muck up the line/column information that the
test needs.


I created https://issues.apache.org/jira/browse/GROOVY-7596 for tracking 
this. But yes, I made the mistake of looking at master not the branch... 
silly me


bye blackdrag


--
Jochen "blackdrag" Theodorou
blog: http://blackdragsview.blogspot.com/


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-20 Thread John D. Ament 
+1

On Sun, Sep 20, 2015 at 6:20 AM Cédric Champeau 
wrote:

> Hi all!
>
> The Apache Groovy PPMC has successfully voted the release of Apache Groovy
> 2.4.5-incubating [1], with 4 "+1" binding votes, one "+1" non binding and
> no 0/-1 votes. We are now asking the IPMC to vote it too.
>
> This release was done in a particular context, at the SpringOne2GX
> conference. Following a very successful BOF session, we followed up with a
> release initiation party to share the knowledge about how to perform a
> release! We anticipate this will make it easier for more of us to be
> involved with releases in the future. It's worth noting that the release
> was performed with the presence of Baruch Sadogursky from JFrog
> (Artifactory/Bintray) that we use, and he could already suggest some nice
> improvements in our release process that we're going to improve for the
> upcoming releases.
>
> Vote on dev list:
>
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvmkCoEUFXfmSR%2B71K%2BEmSYHAjkFWa1HH76LEcPDLMNSYZQ%40mail.gmail.com%3E
> Result of vote on dev list:
>
> http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvm%3DDzF-6T46crzuOBizG2wq0xPArfuz%3DQio_OwgQxEHEcw%40mail.gmail.com%3E
>
> This release fixes documentation issues, a potential memory leak when
> loading the Groovy runtime from different classloaders, some JSON fixes and
> improvements and numerous small bug fixes.
>
> The changelog for this release can be found here:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12332749
>
> Tag:
>
> https://git1-us-west.apache.org/repos/asf?p=incubator-groovy.git;a=commit;h=13934972b400d40600c994377308b26978fcc325
>
> The artifacts to be voted on are located here:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/
>
> Release artifacts are signed with the following key:
> https://dist.apache.org/repos/dist/dev/incubator/groovy/KEYS
> Vote is open for at least 72 hours. Artifacts will be moved to dist as soon
> as the vote passes.
>
> [ ] +1, release Apache Groovy 2.4.5-incubating
> [ ] 0, I don't care
> [ ] -1, because...
>

[VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-20 Thread Cédric Champeau 
Hi all!

The Apache Groovy PPMC has successfully voted the release of Apache Groovy
2.4.5-incubating [1], with 4 "+1" binding votes, one "+1" non binding and
no 0/-1 votes. We are now asking the IPMC to vote it too.

This release was done in a particular context, at the SpringOne2GX
conference. Following a very successful BOF session, we followed up with a
release initiation party to share the knowledge about how to perform a
release! We anticipate this will make it easier for more of us to be
involved with releases in the future. It's worth noting that the release
was performed with the presence of Baruch Sadogursky from JFrog
(Artifactory/Bintray) that we use, and he could already suggest some nice
improvements in our release process that we're going to improve for the
upcoming releases.

Vote on dev list:
http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvmkCoEUFXfmSR%2B71K%2BEmSYHAjkFWa1HH76LEcPDLMNSYZQ%40mail.gmail.com%3E
Result of vote on dev list:
http://mail-archives.apache.org/mod_mbox/incubator-groovy-dev/201509.mbox/%3CCADQzvm%3DDzF-6T46crzuOBizG2wq0xPArfuz%3DQio_OwgQxEHEcw%40mail.gmail.com%3E

This release fixes documentation issues, a potential memory leak when
loading the Groovy runtime from different classloaders, some JSON fixes and
improvements and numerous small bug fixes.

The changelog for this release can be found here:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12318123=12332749

Tag:
https://git1-us-west.apache.org/repos/asf?p=incubator-groovy.git;a=commit;h=13934972b400d40600c994377308b26978fcc325

The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/incubator/groovy/

Release artifacts are signed with the following key:
https://dist.apache.org/repos/dist/dev/incubator/groovy/KEYS
Vote is open for at least 72 hours. Artifacts will be moved to dist as soon
as the vote passes.

[ ] +1, release Apache Groovy 2.4.5-incubating
[ ] 0, I don't care
[ ] -1, because...

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-20 Thread Justin Mclean 
Hi,

+1 binding 

I checked:
- source release has incubating in it’s name
- signatures and hashes correct
- DISCLAIMER exists
- LICENSE and NOTICE are good
- All source code contains Apache headers
- No unexpected binaries in source release

I was unable to compile from source, may be this issue [1] but most likely 
something wrong with my setup.
Error when running gradle
Could not create task of type 'AsciidoctorTask'.

Some other things you may want to consider:
- The convenience binaries are missing incubating from their name.
- Would be better to sign the artefacts with an apache.org email address
- The file LineColumnCheck.txt looks like it's source code and is missing an 
header. Is it Apache licensed or generated?

Thanks,
Justin

1. https://github.com/asciidoctor/asciidoctor-gradle-plugin/issues/112
-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org

Re: [VOTE] Release Apache Groovy 2.4.5-incubating

2015-09-20 Thread Jochen Theodorou 

Am 21.09.2015 01:17, schrieb Justin Mclean:
[...]

Some other things you may want to consider:
- The convenience binaries are missing incubating from their name.


so far we have not done this, because our pre-apache binaries did not 
have the incubating. It produces a problem for things, that 
automatically download those... Needs a bit longer to be changed.


[...]

- The file LineColumnCheck.txt looks like it's source code and is missing an 
header. Is it Apache licensed or generated?


The file provides test data. It contains sample scripts which are 
compiled and the line/column information that the test will check 
against. In the repository the file has a header, but using == as 
comment marker. I have no idea what in our build is removing the header. 
We have to investigate this


bye Jochen

--
Jochen "blackdrag" Theodorou
blog: http://blackdragsview.blogspot.com/


-
To unsubscribe, e-mail: general-unsubscr...@incubator.apache.org
For additional commands, e-mail: general-h...@incubator.apache.org