Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-05-17 Thread Justin Mclean
HI, > I replaced the babytux image by one I got here > https://pixabay.com/vectors/toddlers-babies-children-303904/, now how do I > expose the license for the image? Assuming the license is compatible you would add the text of the license (or if it is long a pointer to a file containing the

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-05-17 Thread Maxime Beauchemin
I replaced the babytux image by one I got here https://pixabay.com/vectors/toddlers-babies-children-303904/, now how do I expose the license for the image? Max On Fri, May 17, 2019 at 4:36 PM Maxime Beauchemin < maximebeauche...@gmail.com> wrote: > Making progress here >

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-05-17 Thread Maxime Beauchemin
Making progress here https://github.com/apache/incubator-superset/pull/7539 Many of the issues have been addressed in `master` but can't easily be cherry-picked into 0.32, so I'm thinking about skipping to 0.33 instead that has been cut 1 month ago. So the next attempt will be `0.33.0rc1` Max

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-30 Thread Maxime Beauchemin
FYI I'm working integrating the feedback and working towards the next RC. I started working on build instructions and things were getting quite complex while building from source, and adding steps like the os-level deps, creating the `.po` files, building the JS, and these instructions tend to

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-27 Thread justin
Hi, > - they are not? I dont follow? How would you suggest making them binary then? Ask on legal discuss, I don’t think they will be allowed in a source release, but it may be possible given maps are not likely to change much. Worse case you may have to find some maps under a different license

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-27 Thread Bolke de Bruin
Hi, - okay :-) I'm a bit confused here but fine - they are not? I dont follow? How would you suggest making them binary then? And yes I agree there are more pressing issues. The roboto fonts are in fact ALv2 (https://github.com/apache/fineract-site/tree/master/font/roboto ), the glyphs fonts

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-27 Thread justin
Hi, > Can I assume that we are doing the right thing now for the CC-BY 4.0 in > NOTICE and LICENSE. You're not :-) but it not a major issue as as I said, it doesn’t need to be fixed in this release. If files were modified then you might need to list those changes in NOTICE but then AFAIK it’s

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-27 Thread Bolke de Bruin
Hi Justin, Can I assume that we are doing the right thing now for the CC-BY 4.0 in NOTICE and LICENSE. The license does ask for “something beyond” and referring to it in NOTICE seems to me a “reasonable manner”. On the GeoJSON, these are actually compiled from the shape files that Diva GIS makes

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Justin Mclean
Hi, > "Attribution — You must give appropriate credit, provide a link to the > license, and indicate if changes were made. You may do so in any reasonable > manner, but not in any way that suggests the licensor endorses you or your > use.” License stuff goes in LICENSE. If the license ask for

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Dave Fisher
Hi - From time to time podlings do not put incubating or incubator in the name. The clutch analysis does catch this in the daily scan of the release distribution areas. On https://incubator.apache.org/clutch/ look down towards the bottom for “Other Issues”. On a podling clutch analysis page

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Bolke de Bruin
Hi Justin The CC-BY 4.0 is included in both NOTICE and LICENSE due to " Attribution — You must give appropriate credit, provide a link to the license, and indicate if changes were made. You may do so in any reasonable manner, but not in any way that suggests the licensor endorses you or your

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Justin Mclean
Hi, > The GIS data is under CC BY 4.0 see here: > > Hence the reference to this license. Which should be in LICENSE not NOTICE but not a major issue. > According to https://apache.org/legal/resolved.html it is fine to include > this in binary form (whether it can be as part of a source

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Bolke de Bruin
Also on [5] and [6] the license location is here https://github.com/syntagmatic/parallel-coordinates which includes divgrid.js in examples/lib as part of the package and from the same author. Cheers Bolke Verstuurd vanaf mijn iPad > Op 26 apr. 2019 om 15:14 heeft Bolke de Bruin het >

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Bolke de Bruin
Additionally [3] Is CC-BY 4.0 as mentioned [4] is in licenses/ and states the correct license. [5] [6] ([6] is equal to [9]) are from the same author and the correct license (BSD-3) is included in licenses/ (see also: http://bl.ocks.org/syntagmatic/3150059 - scroll down please). All above

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-26 Thread Bolke de Bruin
Hi Justin, The GIS data is under CC BY 4.0 see here: https://journals.plos.org/plosone/article/file?type=supplementary=info:doi/10.1371/journal.pone.0151586.s002 Hence the reference to this license. According to https://apache.org/legal/resolved.html it is fine to include this in binary form

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-25 Thread Sheng Wu
Hi Justin I mean these two are very important and should be fixed. Sorry for not clear enough. Sheng Wu 吴晟 Apache SkyWalking, ShardingSphere, Zipkin Twitter, wusheng1108 Justin Mclean 于2019年4月26日周五 下午12:16写道: > Hi, > > It a little unclear to me if your are commenting on the release check

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-25 Thread Justin Mclean
Hi, It a little unclear to me if your are commenting on the release check list or the Superset release here. > 1. Missing licensing information Well IMO it depends on the serenity IMO missing one or two MIT or BSD licenses in a podling release is generally a fix next release type of issue

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-25 Thread Sheng Wu
Hi In Justin's checked list, you hope the community to confirm at least for this first release. 1. Missing licensing information 2. Source release may contained compiled code And add `incubating` in the name. Please make sure doesn't include the license against Apache 2.0, Sheng Wu 吴晟 Apache

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-25 Thread Justin Mclean
Hi, Normally I would be -1 binding as there’s a number of issues here, however the most serious one for a first release is that you are missing incubating from the artefact name. The artefacts can be renamed without changing the hash or anything else, if you rename I’ll change my vote to +1.

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-25 Thread Jakob Homan
+1 (binding) * Checked DISCLAIMER/ LICENSE/ NOTICE, * Checked headers * Verified sig (Only Max's key is in there, we should probably have others roll a release too in the future) * Spotchecked licenses * Verified md512 hash. -Jakob On Wed, Apr 24, 2019 at 4:14 PM Alan Gates wrote: > >

Re: [VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-24 Thread Alan Gates
Forwarding my +1 from the dev list. Checked the NOTICE, LICENSE, and DISCLAIMER files. Did a quick check that everything had appropriate Apache License headers, and I didn't find any binaries in the RC. Alan. On Wed, Apr 24, 2019 at 1:37 PM Maxime Beauchemin < maximebeauche...@gmail.com>

[VOTE] Release Superset 0.32.0 based on Superset 0.32.0 RC2

2019-04-24 Thread Maxime Beauchemin
Dear all, The source release 0.32.0 RC2 for Apache Superset is baked and available at: https://dist.apache.org/repos/dist/dev/incubator/superset/, public keys are available at https://dist.apache.org/repos/dist/release/incubator/superset/KEYS This is the second ASF release candidate of Superset