Hi,
I agree there does not appear to be consensus on when it's appropriate
to add Apache License Headers to Third Party code across projects. Here
is Justin's email that request the Apache Headers removed [1]
- file copyright NumPy Developers [6] this file look to incorrectly have an
ASF
Hi
+1 (binding)
I checked:
- incubating in name
- signatures and hashes are fine
- LICENSE and NOTICE are fine
- No unexpected binary files
- All source files have ASF headers
- Don't have a suitable environment setup to compile
Thanks,
Justin
Hi,
-1 (binding) due to licensing concerns. You might want to consider using the
WIP disclaimer
I checked:
- incubating in name
- signatures and hash correct
- DISCLAIMER exists
- LICENSE is missing a number of 3rd party licenses
- NOTICE mentions MIT licensed software there’s no need to do
+1 (binding) carrying my dev vote forward.
I'll note here for anyone running the test suite under Windows - there
seems to be some issues on some systems that are being looked at in
parallel and testing using WSL2 seems to avoid the problem.
Cheers, Paul.
On Sat, Jun 13, 2020 at 4:30 AM Aaron
@Justin
thank you for checking, we will cancel this vote, and check all the
licenses and notices seriously.
Justin Mclean 于2020年6月14日周日 上午10:10写道：
> Hi,
>
> -1 (binding) as LICENSE and NOTICE are missing information and this file
> [3] incorrectly has an ASF header (it’s MIT license). Similar
Thank you very much for your vote,
but there are still some license and notice issues.
So decide to cancel this vote and fix related issues.
1. some missing information in NOTICE.
2. incorrect license header in
./dolphinscheduler-ui/src/sass/common/_animation.scss
3. other LICENSE and NOTICE
Hi,
-1 (binding) as LICENSE and NOTICE are missing information and this file [3]
incorrectly has an ASF header (it’s MIT license). Similar issues were brought
up last release.
I checked:
- incubating in nam
- LICENSE is missing license for [3]
- NOTICE in missing information from [1] See [2]
Hi,
+1 (binding)
I checked:
- incubating in name
- signature and hashes are fine
- LICENSE is perhaps missing something e.g. license for [1]
- NOTICE is fine
- DISCLAIMER exists but please list why you are using the WIP disclaimer
- No unexpected binary files
- All source files have ASF headers
