>Given you have soured files from all those project the minimum would be
the project name and copyright line, I’m not seeing that. [1]
I've opened a PR to adjust NOTICE and NOTICE.BINARY files to include the
copyright notices which were previously removed,
+1
I checked:
- Can compile from source
- No unexpected binary files
- Source files have ASF headers
- incubating in name
- signatures and hashes fine
- LICENSE is fine
Thanks,
William
On Wed, Aug 14, 2019 at 6:59 AM Furkan KAMACI
wrote:
> Hi,
>
> +1 from me.
>
> I checked:
> - Incubating
Hi,
+1 from me.
I checked:
- Incubating in name
- Disclaimer exists
- LICENSE is fine
- No unexpected binary files
- Code compiles and tests successfully run
Kind Regards,
Furkan KAMACI
13 Ağu 2019 Sal, saat 13:04 tarihinde Justin Mclean <
jus...@classsoftware.com> şunu yazdı:
> Hi,
>
> > I
Hi,
> I was not directly involved in this, but it is my understanding that the
> modifications to our source NOTICE file between 0.15.0-incubating and this
> version are a result of this thread on the IPMC vote,
>
+1 (binding)
Checked hashes; in -src.tar.gz, checked license, notice, disclaimer, readme;
compiled from source (skipping tests) on Ubuntu/JDK 8; ran RAT; checked that
src tarball contents match git commit c698daa.
Did not examine -bin.tar.gz.
Julian
> On Aug 9, 2019, at 5:28 PM, Justin
Hi Justin,
Thank you so much for taking the time to have a look and for the +1 vote.
> NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache
Hadoop and Apache Calcite. Only Calcite is mentioned in your NOTICE file
and all of those projects have NOTICE files, Jets3t contains a
Hi,
+1 (binding)
I checked:
- incubating in name
- signatures and hashes fine
- LICENSE is fine
- NOTICE may need a little work
- No unexpected binary files
- Source files have ASF headers
- Can compile from source
NOTICE mentions using code From Apache Hive, Apache Lucerne, Apache Hadoop and
