[gentoo-dev] [PATCH 4/7] toolchain.eclass: prefixify helper scripts.

[Benda Xu]

  Directory prefixify part 2.
---
 eclass/toolchain.eclass | 10 +-
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 40759f5..17950c1 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -8,7 +8,7 @@ DESCRIPTION="The GNU Compiler Collection"
 HOMEPAGE="https://gcc.gnu.org/";
 RESTRICT="strip" # cross-compilers need controlled stripping
 
-inherit eutils fixheadtails flag-o-matic gnuconfig libtool multilib pax-utils 
toolchain-funcs versionator
+inherit eutils fixheadtails flag-o-matic gnuconfig libtool multilib pax-utils 
toolchain-funcs versionator prefix
 
 if [[ ${PV} == *_pre* ]] ; then
EGIT_REPO_URI="git://gcc.gnu.org/git/gcc.git"
@@ -1764,10 +1764,10 @@ toolchain_src_install() {
# Rather install the script, else portage with changing $FILESDIR
# between binary and source package borks things 
if ! is_crosscompile ; then
-   insinto "${DATAPATH}"
-   newins "${GCC_FILESDIR}"/awk/fixlafiles.awk-no_gcc_la 
fixlafiles.awk || die
-   exeinto "${DATAPATH}"
-   doexe "${GCC_FILESDIR}"/fix_libtool_files.sh || die
+   insinto "${DATAPATH#${EPREFIX}}"
+   newins "$(prefixify_ro 
"${GCC_FILESDIR}"/awk/fixlafiles.awk-no_gcc_la)" fixlafiles.awk || die
+   exeinto "${DATAPATH#${EPREFIX}}"
+   doexe "$(prefixify_ro "${GCC_FILESDIR}"/fix_libtool_files.sh)" 
|| die
doexe "${GCC_FILESDIR}"/c{89,99} || die
fi
 
-- 
2.8.3

[gentoo-dev] [PATCH 7/7] toolchain.eclass: remove trailing slash of D.

[Benda Xu]

---
 eclass/toolchain.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 941e37b..0d8148f 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -1727,7 +1727,7 @@ toolchain_src_install() {
# Now do the fun stripping stuff
env RESTRICT="" CHOST=${CHOST} prepstrip "${D}${BINPATH}"
is_crosscompile && \
-   env RESTRICT="" CHOST=${CHOST} prepstrip "${D}/${HOSTLIBPATH}"
+   env RESTRICT="" CHOST=${CHOST} prepstrip "${D}${HOSTLIBPATH}"
env RESTRICT="" CHOST=${CTARGET} prepstrip "${D}${LIBPATH}"
# gcc used to install helper binaries in lib/ but then moved to libexec/
[[ -d ${D}${PREFIX}/libexec/gcc ]] && \
-- 
2.8.3

[gentoo-dev] [PATCH 6/7] toolchain.eclass: Quote variables containing EPREFIX.

[Benda Xu]

  Directory prefixify part 4.

  LIBPATH, etc. now have EPREFIX prepended.  The latter need to be
  quoted.
---
 eclass/toolchain.eclass | 22 +++---
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index f54316c..941e37b 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -983,10 +983,10 @@ toolchain_src_configure() {
elif built_with_use --hidden --missing false 
${CATEGORY}/${needed_libc} crosscompile_opts_headers-only ; then
confgcc+=(
"${confgcc_no_libc[@]}"
-   --with-sysroot=${PREFIX}/${CTARGET}
+   --with-sysroot="${PREFIX}"/${CTARGET}
)
else
-   confgcc+=( --with-sysroot=${PREFIX}/${CTARGET} )
+   confgcc+=( 
--with-sysroot="${PREFIX}"/${CTARGET} )
fi
fi
 
@@ -1812,11 +1812,11 @@ toolchain_src_install() {
# Use gid of 0 because some stupid ports don't have
# the group 'root' set to gid 0.  Send to /dev/null
# for people who are testing as non-root.
-   chown -R root:0 "${D}"${LIBPATH} 2>/dev/null
+   chown -R root:0 "${D}${LIBPATH}" 2>/dev/null
 
# Move pretty-printers to gdb datadir to shut ldconfig up
local py 
gdbdir=/usr/share/gdb/auto-load${LIBPATH/\/lib\//\/$(get_libdir)\/}
-   pushd "${D}"${LIBPATH} >/dev/null
+   pushd "${D}${LIBPATH}" >/dev/null
for py in $(find . -name '*-gdb.py') ; do
local multidir=${py%/*}
insinto "${gdbdir}/${multidir}"
@@ -1862,16 +1862,16 @@ gcc_movelibs() {
 
local OS_MULTIDIR=$($(XGCC) ${multiarg} 
--print-multi-os-directory)
local MULTIDIR=$($(XGCC) ${multiarg} --print-multi-directory)
-   local TODIR=${D}${LIBPATH}/${MULTIDIR}
+   local TODIR="${D}${LIBPATH}"/${MULTIDIR}
local FROMDIR=
 
[[ -d ${TODIR} ]] || mkdir -p ${TODIR}
 
for FROMDIR in \
-   ${LIBPATH}/${OS_MULTIDIR} \
-   ${LIBPATH}/../${MULTIDIR} \
-   ${PREFIX}/lib/${OS_MULTIDIR} \
-   ${PREFIX}/${CTARGET}/lib/${OS_MULTIDIR}
+   "${LIBPATH}"/${OS_MULTIDIR} \
+   "${LIBPATH}"/../${MULTIDIR} \
+   "${PREFIX}"/lib/${OS_MULTIDIR} \
+   "${PREFIX}"/${CTARGET}/lib/${OS_MULTIDIR}
do
removedirs="${removedirs} ${FROMDIR}"
FROMDIR=${D}${FROMDIR}
@@ -2034,12 +2034,12 @@ gcc_slot_java() {
# Move random gcj files to compiler-specific directories
for x in libgcj.spec logging.properties ; do
x="${D}${PREFIX}/lib/${x}"
-   [[ -f ${x} ]] && mv -f "${x}" "${D}"${LIBPATH}/
+   [[ -f ${x} ]] && mv -f "${x}" "${D}${LIBPATH}"/
done
 
# Rename jar because it could clash with Kaffe's jar if this gcc is
# primary compiler (aka don't have the - extension)
-   cd "${D}"${BINPATH}
+   cd "${D}${BINPATH}"
[[ -f jar ]] && mv -f jar gcj-jar
 }
 
-- 
2.8.3

[gentoo-dev] [PATCH 1/7] toolchain.eclass: Call fix_libtool_files.sh by name

[Benda Xu]

  /usr/sbin is in PATH, avoid writing
  ${EPREFIX}/usr/sbin/fix_libtool_files.sh.
---
 eclass/toolchain.eclass | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 55249b0..ef932d2 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -2107,10 +2107,10 @@ toolchain_pkg_postrm() {
do_gcc_config
 
einfo "Running 'fix_libtool_files.sh ${GCC_RELEASE_VER}'"
-   /usr/sbin/fix_libtool_files.sh ${GCC_RELEASE_VER}
+   fix_libtool_files.sh ${GCC_RELEASE_VER}
if [[ -n ${BRANCH_UPDATE} ]] ; then
einfo "Running 'fix_libtool_files.sh 
${GCC_RELEASE_VER}-${BRANCH_UPDATE}'"
-   /usr/sbin/fix_libtool_files.sh 
${GCC_RELEASE_VER}-${BRANCH_UPDATE}
+   fix_libtool_files.sh ${GCC_RELEASE_VER}-${BRANCH_UPDATE}
fi
fi
 
-- 
2.8.3

[gentoo-dev] [PATCH 5/7] toolchain.eclass: Prepend/strip EPREFIX.

[Benda Xu]

  Directory prefixify part 3.

  Raw directories are prepended by EPREFIX. Directories passed to
  ebuild helpers are EPREFIX stripped.
---
 eclass/toolchain.eclass | 34 +-
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 17950c1..f54316c 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -93,7 +93,7 @@ fi
 
 export GCC_FILESDIR=${GCC_FILESDIR:-${FILESDIR}}
 
-PREFIX=${TOOLCHAIN_PREFIX:-/usr}
+PREFIX=${TOOLCHAIN_PREFIX:-${EPREFIX}/usr}
 
 if tc_version_is_at_least 3.4.0 ; then

LIBPATH=${TOOLCHAIN_LIBPATH:-${PREFIX}/lib/gcc/${CTARGET}/${GCC_CONFIG_VER}}
@@ -1267,7 +1267,7 @@ toolchain_src_configure() {
echo "${S}"/configure "${confgcc[@]}"
# Older gcc versions did not detect bash and re-exec itself, so force 
the
# use of bash.  Newer ones will auto-detect, but this is not harmeful.
-   CONFIG_SHELL="/bin/bash" \
+   CONFIG_SHELL="${EPREFIX}/bin/bash" \
bash "${S}"/configure "${confgcc[@]}" || die "failed to run configure"
 
# return to whatever directory we were in before
@@ -1703,11 +1703,11 @@ toolchain_src_install() {
if [[ -f ${CTARGET}-${x} ]] ; then
if ! is_crosscompile ; then
ln -sf ${CTARGET}-${x} ${x}
-   dosym ${BINPATH}/${CTARGET}-${x} \
+   dosym ${BINPATH#${EPREFIX}}/${CTARGET}-${x} \
/usr/bin/${x}-${GCC_CONFIG_VER}
fi
# Create versioned symlinks
-   dosym ${BINPATH}/${CTARGET}-${x} \
+   dosym ${BINPATH#${EPREFIX}}/${CTARGET}-${x} \
/usr/bin/${CTARGET}-${x}-${GCC_CONFIG_VER}
fi
 
@@ -1745,11 +1745,11 @@ toolchain_src_install() {
fi
fi
has noinfo ${FEATURES} \
-   && rm -r "${D}/${DATAPATH}"/info \
-   || prepinfo "${DATAPATH}"
+   && rm -r "${D}${DATAPATH}"/info \
+   || prepinfo "${DATAPATH#${EPREFIX}}"
has noman ${FEATURES} \
-   && rm -r "${D}/${DATAPATH}"/man \
-   || prepman "${DATAPATH}"
+   && rm -r "${D}${DATAPATH}"/man \
+   || prepman "${DATAPATH#${EPREFIX}}"
fi
# prune empty dirs left behind
find "${D}" -depth -type d -delete 2>/dev/null
@@ -1999,7 +1999,7 @@ copy_minispecs_gcc_specs() {
create_gcc_env_entry hardenednossp
fi
create_gcc_env_entry vanilla
-   insinto ${LIBPATH}
+   insinto ${LIBPATH#${EPREFIX}}
doins "${WORKDIR}"/specs/*.specs || die "failed to install specs"
# Build system specs file which, if it exists, must be a complete set of
# specs as it completely and unconditionally overrides the builtin 
specs.
@@ -2014,21 +2014,21 @@ gcc_slot_java() {
local x
 
# Move Java headers to compiler-specific dir
-   for x in "${D}"${PREFIX}/include/gc*.h "${D}"${PREFIX}/include/j*.h ; do
-   [[ -f ${x} ]] && mv -f "${x}" "${D}"${LIBPATH}/include/
+   for x in "${D}${PREFIX}"/include/gc*.h "${D}${PREFIX}"/include/j*.h ; do
+   [[ -f ${x} ]] && mv -f "${x}" "${D}${LIBPATH}"/include/
done
for x in gcj gnu java javax org ; do
if [[ -d ${D}${PREFIX}/include/${x} ]] ; then
-   dodir /${LIBPATH}/include/${x}
-   mv -f "${D}"${PREFIX}/include/${x}/* 
"${D}"${LIBPATH}/include/${x}/
-   rm -rf "${D}"${PREFIX}/include/${x}
+   dodir /${LIBPATH#${EPREFIX}}/include/${x}
+   mv -f "${D}${PREFIX}"/include/${x}/* 
"${D}${LIBPATH}"/include/${x}/
+   rm -rf "${D}${PREFIX}"/include/${x}
fi
done
 
if [[ -d ${D}${PREFIX}/lib/security ]] || [[ -d 
${D}${PREFIX}/$(get_libdir)/security ]] ; then
-   dodir /${LIBPATH}/security
-   mv -f "${D}"${PREFIX}/lib*/security/* "${D}"${LIBPATH}/security
-   rm -rf "${D}"${PREFIX}/lib*/security
+   dodir /${LIBPATH#${EPREFIX}}/security
+   mv -f "${D}${PREFIX}"/lib*/security/* "${D}${LIBPATH}"/security
+   rm -rf "${D}${PREFIX}"/lib*/security
fi
 
# Move random gcj files to compiler-specific directories
-- 
2.8.3

[gentoo-dev] [PATCH 3/7] toolchain.eclass: D->ED ROOT->EROOT replacements.

[Benda Xu]

  Directory prefixify part 1.

  In addition, E/D and E/ROOT has trailing slashes. No need to write
  an additional slash.
---
 eclass/toolchain.eclass | 29 +++--
 1 file changed, 15 insertions(+), 14 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 8e04864..40759f5 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -1735,7 +1735,7 @@ toolchain_src_install() {
 
cd "${S}"
if is_crosscompile; then
-   rm -rf "${D}"/usr/share/{man,info}
+   rm -rf "${ED}"usr/share/{man,info}
rm -rf "${D}"${DATAPATH}/{man,info}
else
if tc_version_is_at_least 3.0 ; then
@@ -1849,8 +1849,8 @@ gcc_movelibs() {
# that you want to link against when building tools rather than building
# code to run on the target.
if tc_version_is_at_least 5 && is_crosscompile ; then
-   dodir "${HOSTLIBPATH}"
-   mv "${D}"/usr/$(get_libdir)/libcc1* "${D}${HOSTLIBPATH}" || die
+   dodir "${HOSTLIBPATH#${EPREFIX}}"
+   mv "${ED}"usr/$(get_libdir)/libcc1* "${D}${HOSTLIBPATH}" || die
fi
 
# For all the libs that are built for CTARGET, move them into the
@@ -1935,7 +1935,7 @@ create_gcc_env_entry() {
local gcc_envd_base="/etc/env.d/gcc/${CTARGET}-${GCC_CONFIG_VER}"
 
local gcc_specs_file
-   local gcc_envd_file="${D}${gcc_envd_base}"
+   local gcc_envd_file="${ED}${gcc_envd_base}"
if [[ -z $1 ]] ; then
# I'm leaving the following commented out to remind me that it
# was an insanely -bad- idea. Stuff broke. GCC_SPECS isnt unset
@@ -2059,16 +2059,17 @@ toolchain_pkg_postinst() {
echo
 
# Clean up old paths
-   rm -f "${ROOT}"/*/rcscripts/awk/fixlafiles.awk 
"${ROOT}"/sbin/fix_libtool_files.sh
-   rmdir "${ROOT}"/*/rcscripts{/awk,} 2>/dev/null
+   rm -f "${EROOT}"*/rcscripts/awk/fixlafiles.awk 
"${EROOT}"sbin/fix_libtool_files.sh
+   rmdir "${EROOT}"*/rcscripts{/awk,} 2>/dev/null
 
-   mkdir -p "${ROOT}"/usr/{share/gcc-data,sbin,bin}
-   cp "${ROOT}/${DATAPATH}"/fixlafiles.awk 
"${ROOT}"/usr/share/gcc-data/ || die
-   cp "${ROOT}/${DATAPATH}"/fix_libtool_files.sh 
"${ROOT}"/usr/sbin/ || die
+   mkdir -p "${EROOT}"usr/{share/gcc-data,sbin,bin}
+   # DATAPATH has EPREFIX already, use ROOT with it
+   cp "${ROOT}${DATAPATH}"/fixlafiles.awk 
"${EROOT}"usr/share/gcc-data/ || die
+   cp "${ROOT}${DATAPATH}"/fix_libtool_files.sh 
"${EROOT}"usr/sbin/ || die
 
# Since these aren't critical files and portage sucks with
# handling of binpkgs, don't require these to be found
-   cp "${ROOT}/${DATAPATH}"/c{89,99} "${ROOT}"/usr/bin/ 2>/dev/null
+   cp "${ROOT}${DATAPATH}"/c{89,99} "${EROOT}"usr/bin/ 2>/dev/null
fi
 
if use regression-test ; then
@@ -2091,10 +2092,10 @@ toolchain_pkg_postrm() {
 
# clean up the cruft left behind by cross-compilers
if is_crosscompile ; then
-   if [[ -z $(ls "${ROOT}"/etc/env.d/gcc/${CTARGET}* 2>/dev/null) 
]] ; then
-   rm -f "${ROOT}"/etc/env.d/gcc/config-${CTARGET}
-   rm -f "${ROOT}"/etc/env.d/??gcc-${CTARGET}
-   rm -f "${ROOT}"/usr/bin/${CTARGET}-{gcc,{g,c}++}{,32,64}
+   if [[ -z $(ls "${EROOT}"etc/env.d/gcc/${CTARGET}* 2>/dev/null) 
]] ; then
+   rm -f "${EROOT}"etc/env.d/gcc/config-${CTARGET}
+   rm -f "${EROOT}"etc/env.d/??gcc-${CTARGET}
+   rm -f "${EROOT}"usr/bin/${CTARGET}-{gcc,{g,c}++}{,32,64}
fi
return 0
fi
-- 
2.8.3

[gentoo-dev] [PATCH 2/7] toolchain.eclass: drop env -i from gcc-config calls.

[Benda Xu]

  In Prefix, PATH should also be preserved, resulting in a mouthful of
  `env -i PATH=${PATH} ROOT=${ROOT}`.  The origin commit introducing
  env -i was for "cleanup".  Dropping env -i is cleaner.

Reference: 
https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=a8a64d1886cc5c9f975353b97237f2900a3ee88c
Reference: 
https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=7d9f89700a2ee50674c0d871ec6d21b468ac6206
---
 eclass/toolchain.eclass | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index ef932d2..8e04864 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -2119,13 +2119,13 @@ toolchain_pkg_postrm() {
 
 do_gcc_config() {
if ! should_we_gcc_config ; then
-   env -i ROOT="${ROOT}" gcc-config --use-old --force
+   gcc-config --use-old --force
return 0
fi
 
local current_gcc_config target
 
-   current_gcc_config=$(env -i ROOT="${ROOT}" gcc-config -c ${CTARGET} 
2>/dev/null)
+   current_gcc_config=$(gcc-config -c ${CTARGET} 2>/dev/null)
if [[ -n ${current_gcc_config} ]] ; then
local current_specs use_specs
# figure out which specs-specific config is active
@@ -2159,12 +2159,12 @@ should_we_gcc_config() {
# if the current config is invalid, we definitely want a new one
# Note: due to bash quirkiness, the following must not be 1 line
local curr_config
-   curr_config=$(env -i ROOT="${ROOT}" gcc-config -c ${CTARGET} 2>&1) || 
return 0
+   curr_config=$(gcc-config -c ${CTARGET} 2>&1) || return 0
 
# if the previously selected config has the same major.minor (branch) as
# the version we are installing, then it will probably be uninstalled
# for being in the same SLOT, make sure we run gcc-config.
-   local curr_config_ver=$(env -i ROOT="${ROOT}" gcc-config -S 
${curr_config} | awk '{print $2}')
+   local curr_config_ver=$(gcc-config -S ${curr_config} | awk '{print $2}')
 
local curr_branch_ver=$(get_version_component_range 1-2 
${curr_config_ver})
 
-- 
2.8.3

[gentoo-dev] [PATCH 0/7] RFC1: toolchain.eclass prefix support

[Benda Xu]

Hi,

This patch series is splitted from the previous one

  
https://archives.gentoo.org/gentoo-dev/message/8a7ac352cb047567309c70aaf7105305

Note that the splitting is not perfect when different kinds
of updates happen in adjacent lines.

Please review.

Benda

Benda Xu (7):
  toolchain.eclass: Call fix_libtool_files.sh by name
  toolchain.eclass: drop env -i from gcc-config calls.
  toolchain.eclass: D->ED ROOT->EROOT replacements.
  toolchain.eclass: prefixify helper scripts.
  toolchain.eclass: Prepend/strip EPREFIX.
  toolchain.eclass: Quote variables containing EPREFIX.
  toolchain.eclass: remove trailing slash of D.

 eclass/toolchain.eclass | 109 
 1 file changed, 55 insertions(+), 54 deletions(-)

-- 
2.8.3

[gentoo-dev] Re: RFC: toolchain.eclass prefix support

[Benda Xu]

Mike Gilbert  writes:

> Regarding the PATH/gcc-config change, I'm thinking it would make more
> sense to drop the env -i command than to add to he list of special
> variables we pass through to it.

All the env -i has been introduced in this commit by vapier in 2005:

  
https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=a8a64d1886cc5c9f975353b97237f2900a3ee88c

"clean up/simplify the gcc-config and fix_libtool_files logic". The
reasonale was "clean-up".


"ROOT=${ROOT}" was added in 2007 by vapier,

  
https://gitweb.gentoo.org/repo/gentoo/historical.git/commit/?id=7d9f89700a2ee50674c0d871ec6d21b468ac6206

"cleanup gcc-config logic so that it doesnt matter what the ROOT value
is". The reasonale was "cleanup gcc-config logic"


So, from the two historical commits, it is safe to drop env -i without
breaking anything sacred.

Benda

[gentoo-dev] Commit signing for metadata/* repos

[Luis Ressel]

Hello,

there are some additional git repositories which need to be added to
metadata/ subdirectories to make the 'gentoo' git repository usable
for /usr/portage. Specifically, those are dtd, glsa, news and
xml-schema.

It'd be great if developers could sign their commits in these repos,
too. (I don't really care about dtd and xml-schema, but for the other
two, I think this would make much sense.)

Currently, it looks like commits to xml-schema aren't signed at all,
all commits to glsa are signed, and commits to the other two repos are
partly signed.

Regards,
Luis Ressel

Re: [gentoo-dev] Announce e-mail sending nonsense (Was: Last rites: x11-libs/gtk+:1)

[Rich Freeman]

On Sat, Jan 7, 2017 at 2:41 PM, Mart Raudsepp  wrote:
> Ühel kenal päeval, L, 07.01.2017 kell 14:18, kirjutas Rich Freeman:
>>
>> Not all replies to gentoo-dev-announce should go to gentoo-dev.  Some
>> belong on gentoo-project, or maybe even gentoo-nfp or some other less
>> common list.  Hence the need to set a reply-to.
>
> 1) It is called gentoo-DEV-announce; there is gentoo-announce for the
> other stuff already.

Actually, gentoo-dev-announce is completely appropriate for things
like Council meeting agenda notices (where discussion goes on
-project), or elections, and so on.  Not all of it is purely
development-related.

>
> Thanks for the history lesson. It is interesting you know that stuff
> about that this was on -core prior to -dev-announce, considering you
> became a developer in December 2007, while gentoo-dev-announce was
> created in July 2007 and the last rites have went there since then.
> (And I have sent last rites since early 2007 at least). Though I'm
> pretty sure this information about last rites to -core is wrong, but my
> memory fades and my old -core is archived up somewhere offline :D
>

Lastrites were on -dev previously I believe.

Many years ago over-use of -core was one of our larger hot-button
topics, and a lot of effort was made to move this sort of traffic
elsewhere.  A lot of it pre-dates my time on the Council.  I don't
personally have archives of what was on -core prior to becoming a dev,
but there had been plenty of discussion around it in general and of
course correct mailing list topics was a subject for new dev quizzes
and such way back then as well.  Gentoo tends to have flares of drama
every couple of years and there had been a bit of a changing of the
guard right before I became a dev, though I was fairly involved well
before then as an AT and general user (think Duncan, who goes back
probably about as far, perhaps further).

As with today a lot gets said in private that doesn't make it onto the
lists, so list archives only really tell part of the story, though
again as with today you can read a lot of it between the lines.

-- 
Rich

Re: [gentoo-dev] Announce e-mail sending nonsense (Was: Last rites: x11-libs/gtk+:1)

[Mart Raudsepp]

Ühel kenal päeval, L, 07.01.2017 kell 14:18, kirjutas Rich Freeman:
> On Sat, Jan 7, 2017 at 2:05 PM, Mart Raudsepp 
> wrote:
> > 
> > 
> > If gentoo-dev feel the need to set Reply-To in my place, then
> > gentoo-
> > dev-announce should do the same and not throw my mail into
> > /dev/null,
> > but into some regular moderation rules after setting the Reply-To
> > itself then.
> > 
> 
> Not all replies to gentoo-dev-announce should go to gentoo-dev.  Some
> belong on gentoo-project, or maybe even gentoo-nfp or some other less
> common list.  Hence the need to set a reply-to.

1) It is called gentoo-DEV-announce; there is gentoo-announce for the
other stuff already.
2) It could keep an existing reply-to and set the default if none is
set, instead of just making the mail disappear with no notice of any
kind for spam reasons
3) I still haven't seen my announce mails after setting a Reply-To, so
I assume there's manual moderation anyways.

> Perhaps it should just be called gentoo-announce, though it is mostly
> aimed at developers.

Such a gentoo-announce list exists. Mostly has the GLSAs.

> In the past people used to send stuff like this
> to -core, but that led to a lot of over-use of -core which is private
> to devs only.  Now -core is only used very rarely and for the sorts
> of
> things it was intended for (exchanging phone numbers at conferences,
> etc), so in that it was a pretty big success and it makes us more
> open.

Thanks for the history lesson. It is interesting you know that stuff
about that this was on -core prior to -dev-announce, considering you
became a developer in December 2007, while gentoo-dev-announce was
created in July 2007 and the last rites have went there since then.
(And I have sent last rites since early 2007 at least). Though I'm
pretty sure this information about last rites to -core is wrong, but my
memory fades and my old -core is archived up somewhere offline :D

Re: [gentoo-dev] Announce e-mail sending nonsense (Was: Last rites: x11-libs/gtk+:1)

[Rich Freeman]

On Sat, Jan 7, 2017 at 2:05 PM, Mart Raudsepp  wrote:
>
> If gentoo-dev feel the need to set Reply-To in my place, then gentoo-
> dev-announce should do the same and not throw my mail into /dev/null,
> but into some regular moderation rules after setting the Reply-To
> itself then.
>

Not all replies to gentoo-dev-announce should go to gentoo-dev.  Some
belong on gentoo-project, or maybe even gentoo-nfp or some other less
common list.  Hence the need to set a reply-to.

Perhaps it should just be called gentoo-announce, though it is mostly
aimed at developers.  In the past people used to send stuff like this
to -core, but that led to a lot of over-use of -core which is private
to devs only.  Now -core is only used very rarely and for the sorts of
things it was intended for (exchanging phone numbers at conferences,
etc), so in that it was a pretty big success and it makes us more
open.

-- 
Rich

[gentoo-dev] Announce e-mail sending nonsense (Was: Last rites: x11-libs/gtk+:1)

[Mart Raudsepp]

Ühel kenal päeval, L, 07.01.2017 kell 20:59, kirjutas Mart Raudsepp:
> # Mart Raudsepp  (06 Jan 2017)
> # No releases of this API version since April 2001, abandoned
> # in favour of gtk+:2 for 14 years.
> # Masked for removal in 30 days. Bug 604862.
> x11-libs/gtk+:1

This was a failed try to get this to show up on -dev-announce, but of
course I don't have such fancy Reply-To munging fields by default and
with localized stuff I didn't pay attention I was using CC.
Previous tries just went to /dev/null, because apparently I need to set
a Reply-To field myself per some hidden documentation at comrel
wiki[1], while both devmanual pages that talk of sending last rites e-
mails[2][3] don't have a mention of it.
Additionally gentoo-dev that accepted this already sets the Reply-To as
needed, so anyone looking from the side, it's already all fine, only
infra and my Sent folder would know I "failed" to put the Reply-To.

If gentoo-dev feel the need to set Reply-To in my place, then gentoo-
dev-announce should do the same and not throw my mail into /dev/null,
but into some regular moderation rules after setting the Reply-To
itself then.


1. https://wiki.gentoo.org/wiki/Project:ComRel/Developer_Handbook/What_you_get
2. https://devmanual.gentoo.org/eclass-writing/
2. https://devmanual.gentoo.org/ebuild-maintenance/index.html

[gentoo-dev] Last rites: x11-libs/gtk+:1

[Mart Raudsepp]

# Mart Raudsepp  (06 Jan 2017)
# No releases of this API version since April 2001, abandoned
# in favour of gtk+:2 for 14 years.
# Masked for removal in 30 days. Bug 604862.
x11-libs/gtk+:1

[gentoo-dev] Last rites: dev-libs/glib:1

[Mart Raudsepp]

# Mart Raudsepp  (07 Jan 2017)
# No releases of this API version since March 2001, abandoned
# in favour of glib:2 for 14 years.
# Marked for removal in 30 days. Bug 604966.
dev-libs/glib:1

Re: [gentoo-dev] [PATCH] eutils.eclass: add 512 icon size to doicon documentation

[Mike Gilbert]

On Sat, Jan 7, 2017 at 11:53 AM, Chris Mayo  wrote:
> Signed-off-by: Chris Mayo 
> ---
> Sent as requested on
> https://github.com/gentoo/gentoo/pull/3298
>
>  eclass/eutils.eclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks good to me. Merged.

[gentoo-dev] [PATCH] eutils.eclass: add 512 icon size to doicon documentation

[Chris Mayo]

Signed-off-by: Chris Mayo 
---
Sent as requested on 
https://github.com/gentoo/gentoo/pull/3298

 eclass/eutils.eclass | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/eclass/eutils.eclass b/eclass/eutils.eclass
index aaf195b..d868467 100644
--- a/eclass/eutils.eclass
+++ b/eclass/eutils.eclass
@@ -1062,7 +1062,7 @@ _iconins() {
 #!!! must specify to install into /usr/share/icons/... !!!
 #size of the icon, like 48 or 48x48
 #supported icon sizes are:
-#16 22 24 32 36 48 64 72 96 128 192 256 scalable
+#16 22 24 32 36 48 64 72 96 128 192 256 512 scalable
 #  -c, --context
 #defaults to "apps"
 #  -t, --theme
-- 
2.10.2

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

[Mike Gilbert]

On Sat, Jan 7, 2017 at 10:07 AM, Benda Xu  wrote:
> Hi,
>
> Please help me review the patch attached.

Please send patches for review with the content as the email body. See
git format-patch and git send-email.

> This patch has 5 main kinds of modifications to the eclass,
>
>   * Define ED and EROOT for EAPI 0, 1 and 2.
>   * Add ${EPREFIX} to ${PREFIX} and quote the variables.
>   * Strip ${EPREFIX} if used with a ebuild helper.
>   * call fix_libtool_files.sh by name, because /usr/sbin is in PATH,
> and no need to write as ${EPREFIX}/usr/sbin/fix_libtool_files.sh
>   * Preserve PATH when calling gcc-config.

You should split these changes into separate patches, each with it's
own meaningful commit message.

Regarding the PATH/gcc-config change, I'm thinking it would make more
sense to drop the env -i command than to add to he list of special
variables we pass through to it.

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

[David Seifert]

On Sun, 2017-01-08 at 00:25 +0900, Benda Xu wrote:
> James Le Cuirot  writes:
> 
> > Why? All the ebuilds using this eclass that I can find are at least
> > EAPI 4.
> 
> Okay!  I will remove this.
> 
> Benda

https://qa-reports.gentoo.org/output/eapi-per-eclass/toolchain.eclass/S
TATS.txt

Chewi seems right, no use in defining them.

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

[Benda Xu]

James Le Cuirot  writes:

> Why? All the ebuilds using this eclass that I can find are at least
> EAPI 4.

Okay!  I will remove this.

Benda


signature.asc
Description: PGP signature

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

[James Le Cuirot]

On Sun, 08 Jan 2017 00:07:05 +0900
Benda Xu  wrote:

>   * Define ED and EROOT for EAPI 0, 1 and 2.

Why? All the ebuilds using this eclass that I can find are at least
EAPI 4.

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer


pgpalLkoo9wHk.pgp
Description: OpenPGP digital signature

[gentoo-dev] RFC: toolchain.eclass prefix support

[Benda Xu]

Hi,

Please help me review the patch attached.

This patch has 5 main kinds of modifications to the eclass,

  * Define ED and EROOT for EAPI 0, 1 and 2.
  * Add ${EPREFIX} to ${PREFIX} and quote the variables.
  * Strip ${EPREFIX} if used with a ebuild helper.
  * call fix_libtool_files.sh by name, because /usr/sbin is in PATH,
and no need to write as ${EPREFIX}/usr/sbin/fix_libtool_files.sh
  * Preserve PATH when calling gcc-config.

Benda

diff --git a/eclass/toolchain.eclass b/eclass/toolchain.eclass
index 55249b0..ca64091 100644
--- a/eclass/toolchain.eclass
+++ b/eclass/toolchain.eclass
@@ -8,7 +8,7 @@ DESCRIPTION="The GNU Compiler Collection"
 HOMEPAGE="https://gcc.gnu.org/";
 RESTRICT="strip" # cross-compilers need controlled stripping
 
-inherit eutils fixheadtails flag-o-matic gnuconfig libtool multilib pax-utils toolchain-funcs versionator
+inherit eutils fixheadtails flag-o-matic gnuconfig libtool multilib pax-utils toolchain-funcs versionator prefix
 
 if [[ ${PV} == *_pre* ]] ; then
 	EGIT_REPO_URI="git://gcc.gnu.org/git/gcc.git"
@@ -49,6 +49,11 @@ is_crosscompile() {
 	[[ ${CHOST} != ${CTARGET} ]]
 }
 
+if [[ ${EAPI:-0} == [012] ]] ; then
+		: ${ED:=${D}}
+		: ${EROOT:=${ROOT}}
+fi
+
 # General purpose version check.  Without a second arg matches up to minor version (x.x.x)
 tc_version_is_at_least() {
 	version_is_at_least "$1" "${2:-${GCC_RELEASE_VER}}"
@@ -93,7 +98,7 @@ fi
 
 export GCC_FILESDIR=${GCC_FILESDIR:-${FILESDIR}}
 
-PREFIX=${TOOLCHAIN_PREFIX:-/usr}
+PREFIX=${TOOLCHAIN_PREFIX:-${EPREFIX}/usr}
 
 if tc_version_is_at_least 3.4.0 ; then
 	LIBPATH=${TOOLCHAIN_LIBPATH:-${PREFIX}/lib/gcc/${CTARGET}/${GCC_CONFIG_VER}}
@@ -983,10 +988,10 @@ toolchain_src_configure() {
 			elif built_with_use --hidden --missing false ${CATEGORY}/${needed_libc} crosscompile_opts_headers-only ; then
 confgcc+=(
 	"${confgcc_no_libc[@]}"
-	--with-sysroot=${PREFIX}/${CTARGET}
+	--with-sysroot="${PREFIX}"/${CTARGET}
 )
 			else
-confgcc+=( --with-sysroot=${PREFIX}/${CTARGET} )
+confgcc+=( --with-sysroot="${PREFIX}"/${CTARGET} )
 			fi
 		fi
 
@@ -1073,7 +1078,7 @@ toolchain_src_configure() {
 		[[ ${arm_arch} == armv7? ]] && arm_arch=${arm_arch/7/7-}
 		# See if this is a valid --with-arch flag
 		if (srcdir=${S}/gcc target=${CTARGET} with_arch=${arm_arch};
-		. "${srcdir}"/config.gcc) &>/dev/null
+			. "${srcdir}"/config.gcc) &>/dev/null
 		then
 			confgcc+=( --with-arch=${arm_arch} )
 		fi
@@ -1267,7 +1272,7 @@ toolchain_src_configure() {
 	echo "${S}"/configure "${confgcc[@]}"
 	# Older gcc versions did not detect bash and re-exec itself, so force the
 	# use of bash.  Newer ones will auto-detect, but this is not harmeful.
-	CONFIG_SHELL="/bin/bash" \
+	CONFIG_SHELL="${EPREFIX}/bin/bash" \
 	bash "${S}"/configure "${confgcc[@]}" || die "failed to run configure"
 
 	# return to whatever directory we were in before
@@ -1703,11 +1708,11 @@ toolchain_src_install() {
 		if [[ -f ${CTARGET}-${x} ]] ; then
 			if ! is_crosscompile ; then
 ln -sf ${CTARGET}-${x} ${x}
-dosym ${BINPATH}/${CTARGET}-${x} \
+dosym ${BINPATH#${EPREFIX}}/${CTARGET}-${x} \
 	/usr/bin/${x}-${GCC_CONFIG_VER}
 			fi
 			# Create versioned symlinks
-			dosym ${BINPATH}/${CTARGET}-${x} \
+			dosym ${BINPATH#${EPREFIX}}/${CTARGET}-${x} \
 /usr/bin/${CTARGET}-${x}-${GCC_CONFIG_VER}
 		fi
 
@@ -1727,7 +1732,7 @@ toolchain_src_install() {
 	# Now do the fun stripping stuff
 	env RESTRICT="" CHOST=${CHOST} prepstrip "${D}${BINPATH}"
 	is_crosscompile && \
-		env RESTRICT="" CHOST=${CHOST} prepstrip "${D}/${HOSTLIBPATH}"
+		env RESTRICT="" CHOST=${CHOST} prepstrip "${D}${HOSTLIBPATH}"
 	env RESTRICT="" CHOST=${CTARGET} prepstrip "${D}${LIBPATH}"
 	# gcc used to install helper binaries in lib/ but then moved to libexec/
 	[[ -d ${D}${PREFIX}/libexec/gcc ]] && \
@@ -1735,7 +1740,7 @@ toolchain_src_install() {
 
 	cd "${S}"
 	if is_crosscompile; then
-		rm -rf "${D}"/usr/share/{man,info}
+		rm -rf "${ED}"usr/share/{man,info}
 		rm -rf "${D}"${DATAPATH}/{man,info}
 	else
 		if tc_version_is_at_least 3.0 ; then
@@ -1745,11 +1750,11 @@ toolchain_src_install() {
 			fi
 		fi
 		has noinfo ${FEATURES} \
-			&& rm -r "${D}/${DATAPATH}"/info \
-			|| prepinfo "${DATAPATH}"
+			&& rm -r "${D}${DATAPATH}"/info \
+			|| prepinfo "${DATAPATH#${EPREFIX}}"
 		has noman ${FEATURES} \
-			&& rm -r "${D}/${DATAPATH}"/man \
-			|| prepman "${DATAPATH}"
+			&& rm -r "${D}${DATAPATH}"/man \
+			|| prepman "${DATAPATH#${EPREFIX}}"
 	fi
 	# prune empty dirs left behind
 	find "${D}" -depth -type d -delete 2>/dev/null
@@ -1764,10 +1769,10 @@ toolchain_src_install() {
 	# Rather install the script, else portage with changing $FILESDIR
 	# between binary and source package borks things 
 	if ! is_crosscompile ; then
-		insinto "${DATAPATH}"
-		newins "${GCC_FILESDIR}"/awk/fixlafiles.awk-no_gcc_la fixlafiles.awk || die
-		exeinto "${DATAPATH}"
-		doexe "${GCC_FILESDIR}"/fix_libtool_files.sh || die
+		insinto "${DA

Re: [gentoo-dev] Last rites: x11-libs/gtk+:1

[James Le Cuirot]

On Sat, 7 Jan 2017 15:04:34 +0100
Alexis Ballier  wrote:

> On Fri, 06 Jan 2017 21:22:12 +0200
> Mart Raudsepp  wrote:
> 
> > # Mart Raudsepp  (06 Jan 2017)
> > # No releases of this API version since April 2001, abandoned
> > # in favour of gtk+:2 for 14 years.
> > # Masked for removal in 30 days. Bug 604862.
> > x11-libs/gtk+:1
> >   
> 
> Oh no!
> 
> http://www.xmms.org/graphics/Gaylord.Nelson.waves.byebye.jpg

Haha, I remember that.

http://web.archive.org/web/20061107142506/http://www.xmms.org/

-- 
James Le Cuirot (chewi)
Gentoo Linux Developer


pgpihHo2A7RWp.pgp
Description: OpenPGP digital signature

Re: [gentoo-dev] Last rites: x11-libs/gtk+:1

[Alexis Ballier]

On Fri, 06 Jan 2017 21:22:12 +0200
Mart Raudsepp  wrote:

> # Mart Raudsepp  (06 Jan 2017)
> # No releases of this API version since April 2001, abandoned
> # in favour of gtk+:2 for 14 years.
> # Masked for removal in 30 days. Bug 604862.
> x11-libs/gtk+:1
> 

Oh no!

http://www.xmms.org/graphics/Gaylord.Nelson.waves.byebye.jpg

[gentoo-dev] Last rites: games-emulation/visualboyadvance

[David Seifert]

# David Seifert  (29 Dec 2016)
# Ancient codebase, maintenance nightmare, dead
# upstream, games-emulation/vbam is spiritual successor
# Removal in 30 days, #598607
games-emulation/visualboyadvance

Re: [gentoo-dev] [PATCH] cmake-utils.eclass: Support running ctest in parallel

[Michał Górny]

On Mon, 19 Dec 2016 16:48:45 +0100
Michał Górny  wrote:

> Pass -j and --test-load options (with values based on MAKEOPTS) to CTest
> by default, in order to enable parallel test runs.
> ---
>  eclass/cmake-utils.eclass | 7 ---
>  1 file changed, 4 insertions(+), 3 deletions(-)

Pushed now.

-- 
Best regards,
Michał Górny



pgptJqSvTV1m3.pgp
Description: OpenPGP digital signature