Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-06-02 Thread Mathy Vanvoorden
Op di 2 jun. 2020 om 19:51 schreef Alec Warner : > > The conclusion was that the software needed to be released under an open > license (preferably FSF / OSI approved.) So for example, Gitlab CE is OK > (its an OSI approved licensed) but Gitlab EE is not. The source for Gitlab > EE is open (I can

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-06-02 Thread Alec Warner
On Tue, Jun 2, 2020 at 1:44 AM Mathy Vanvoorden wrote: > Hi, > > Sorry I'm a bit late to the party here but was behind on my emails. > > Op wo 27 mei 2020 om 05:25 schreef Alec Warner : > >> The TL;DR is that a crack team of infra-folks[0] have been putting >> together demos of CI services and th

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-06-02 Thread Mathy Vanvoorden
Op di 2 jun. 2020 om 10:47 schreef Michał Górny : > 1. This is not free software. > It was not clear for me if this was a requirement or not. The license is free for open source projects. I don't see the difference between companies offering CE versions of their commercial products, they also "ta

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-06-02 Thread Michał Górny
On Tue, 2020-06-02 at 10:44 +0200, Mathy Vanvoorden wrote: > Hi, > > Sorry I'm a bit late to the party here but was behind on my emails. > > Op wo 27 mei 2020 om 05:25 schreef Alec Warner : > > > The TL;DR is that a crack team of infra-folks[0] have been putting > > together demos of CI services

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-06-02 Thread Mathy Vanvoorden
Hi, Sorry I'm a bit late to the party here but was behind on my emails. Op wo 27 mei 2020 om 05:25 schreef Alec Warner : > The TL;DR is that a crack team of infra-folks[0] have been putting > together demos of CI services and things like gitlab / gitea / gerrit and > so on. > > I didn't see in t

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-31 Thread Michał Górny
On Sun, 2020-05-31 at 18:42 -0700, Alec Warner wrote: > On Fri, May 29, 2020 at 11:17 PM Michał Górny wrote: > > > On Fri, 2020-05-29 at 16:34 -0700, Alec Warner wrote: > > > The pull-based mirroring is a bit sad, as it would be nice to auto-update > > > some forks, but it's not a killer feature.

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-31 Thread Alec Warner
On Fri, May 29, 2020 at 11:17 PM Michał Górny wrote: > On Fri, 2020-05-29 at 16:34 -0700, Alec Warner wrote: > > The pull-based mirroring is a bit sad, as it would be nice to auto-update > > some forks, but it's not a killer feature. > > Exactly. Especially that our push-based mirroring is bette

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-31 Thread William Hubbs
On Fri, May 29, 2020 at 04:34:24PM -0700, Alec Warner wrote: > Another major issue is operating the software. I haven't found anyone to > *run* gitlab; I'm not eager to do it. Today Gentoo is mostly distributed, > bugs are in bugzilla, wiki is on mediawiki, code is on gitolite with N > mirrors, ema

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-31 Thread Brian Dolbec
On Wed, 27 May 2020 01:28:02 -0700 Alec Warner wrote: > On Wed, May 27, 2020 at 1:09 AM Brian Dolbec > wrote: > > > On Tue, 26 May 2020 20:24:56 -0700 > > Alec Warner wrote: > > > > > The TL;DR is that a crack team of infra-folks[0] have been putting > > > together demos of CI services and t

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-29 Thread Michał Górny
On Fri, 2020-05-29 at 16:34 -0700, Alec Warner wrote: > The pull-based mirroring is a bit sad, as it would be nice to auto-update > some forks, but it's not a killer feature. Exactly. Especially that our push-based mirroring is better, and I think that's how we want to populate it. > I think ou

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-29 Thread Alec Warner
On Wed, May 27, 2020 at 2:31 PM Matt Turner wrote: > On Wed, May 27, 2020 at 1:14 AM Alec Warner wrote: > > On Tue, May 26, 2020, 23:08 Michał Górny wrote: > >> > >> On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote: > >> > The TL;DR is that a crack team of infra-folks[0] have been putting >

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Matt Turner
On Wed, May 27, 2020 at 1:14 AM Alec Warner wrote: > On Tue, May 26, 2020, 23:08 Michał Górny wrote: >> >> On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote: >> > The TL;DR is that a crack team of infra-folks[0] have been putting together >> > demos of CI services and things like gitlab / gite

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Alec Warner
On Wed, May 27, 2020 at 5:16 AM Thomas Deutschmann wrote: > Hi, > > is this really CI _vs_ Code Review? I.e. we can only have one? > I'll try to come back to this. We can make computers do anything, but it's a question of limited time for me and for Gentoo as a whole. > > CI is nice and helpfu

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Louis Sautier
On 27/05/2020 15:22, Guilherme Amadio wrote: > Hi, > > On Wed, May 27, 2020 at 02:45:29PM +0200, Toralf Förster wrote: >> On 5/27/20 2:16 PM, Thomas Deutschmann wrote: >>> The problem when doing review on Github >>> for me is, that we usually create new revisions. Therefore we don't see >>> what's

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Guilherme Amadio
Hi, On Wed, May 27, 2020 at 02:45:29PM +0200, Toralf Förster wrote: > On 5/27/20 2:16 PM, Thomas Deutschmann wrote: > > The problem when doing review on Github > > for me is, that we usually create new revisions. Therefore we don't see > > what's changed in new revision versus previous revision.

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Toralf Förster
On 5/27/20 2:16 PM, Thomas Deutschmann wrote: > The problem when doing review on Github > for me is, that we usually create new revisions. Therefore we don't see > what's changed in new revision versus previous revision. That's my main concern with the current behaviour: a "git diff" often doesn't

RE: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Thomas Deutschmann
Hi, is this really CI _vs_ Code Review? I.e. we can only have one? CI is nice and helpful. For example I usually don't start review until CI sets green light but CI alone wouldn't be enough. Thought that Gitlab will support same kind of hooks similar to how current CI is integrated into Github, n

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Andreas K . Hüttel
> Works great for whom? How many deployments are we talking about? To be > honest, I don't think I've stumbled upon a single instance. > On the other hand, GitLab deployments are pretty common -- GNOME, Xfce, > Debian come instantly to my mind. Then, there's Heptapod -- the GitLab > fork for Mer

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Alec Warner
On Wed, May 27, 2020 at 1:09 AM Brian Dolbec wrote: > On Tue, 26 May 2020 20:24:56 -0700 > Alec Warner wrote: > > > The TL;DR is that a crack team of infra-folks[0] have been putting > > together demos of CI services and things like gitlab / gitea / gerrit > > and so on. > > > > Some of these co

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Michał Górny
On Wed, 2020-05-27 at 01:14 -0700, Alec Warner wrote: > On Tue, May 26, 2020, 23:08 Michał Górny wrote: > > > On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote: > > > The TL;DR is that a crack team of infra-folks[0] have been putting > > together > > > demos of CI services and things like gitl

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Alec Warner
On Tue, May 26, 2020, 23:08 Michał Górny wrote: > On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote: > > The TL;DR is that a crack team of infra-folks[0] have been putting > together > > demos of CI services and things like gitlab / gitea / gerrit and so on. > > > > Some of these come in combi

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-27 Thread Brian Dolbec
On Tue, 26 May 2020 20:24:56 -0700 Alec Warner wrote: > The TL;DR is that a crack team of infra-folks[0] have been putting > together demos of CI services and things like gitlab / gitea / gerrit > and so on. > > Some of these come in combined (e.g. gitlab offers repo hosting, code > review / pul

Re: [gentoo-dev] Value of Continuous integration vs Code Review / Pull Requests

2020-05-26 Thread Michał Górny
On Tue, 2020-05-26 at 20:24 -0700, Alec Warner wrote: > The TL;DR is that a crack team of infra-folks[0] have been putting together > demos of CI services and things like gitlab / gitea / gerrit and so on. > > Some of these come in combined (e.g. gitlab offers repo hosting, code > review / pull re