-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
(This holds for all patches)
Please surround '+' with spaces[0].
Please ensure 79 width[1].
Please indent continuation lines properly[2].
[0] http://www.python.org/dev/peps/pep-0008/#id19
[1] http://www.python.org/dev/peps/pep-0008/#id13
[2]
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Great idea! ANd, wow, unit tests, weee. :-) Here are a few comments,
mostly on style:
(I'm not sure how you usually do code reviews/comments here, so please
pardon my ignorance on the matter.)
pym/portage/bin/prepstrip.py:
-You import sys,
+r9uCvu+YBAJauUd/7KkiVyn6ozKfGKxJaRdqETGPbYaJc9rcXQc1b
=ZX2u
-END PGP SIGNATURE-
From 887d7c8e179f4f011047e42b547cf46261fb10c0 Mon Sep 17 00:00:00 2001
From: Alexander Berntsen alexan...@plaimi.net
Date: Tue, 1 Oct 2013 11:40:55 +0200
Subject: [PATCH 1/3] emerge: Deprecate --autounmask
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 21/11/13 12:19, Duncan wrote:
I'm with zmedico in comment #11, and *STRONGLY* oppose this change
as you're proposing. Current autounmask is **NOT** useless.
How is it not? Consider comment 6[0] and 10[1].
FWIW, I have a very specific
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 21/11/13 14:34, Duncan wrote:
I read comment 10, and am objecting based on it
You have fundamentally misunderstood everything in it. Please reread it.
1) Because the dependency calculations take time, I normally use
--ask so I don't have to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 22/11/13 06:37, Duncan wrote:
emerge --ask foo would also do what is currently done by: emerge
--ask --autounmask-write foo
Which is exactly what I said, and what you're now saying it won't
do, while pointing at comment 10 which says
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 21/11/13 21:06, Pacho Ramos wrote:
Does anyone know what did occur to Zac? I expect it's not a major
problem or similar :'(
Someone posted in #gentoo-portage that they had spoken to him, and that
he was just taking a break. (I don't remember
-END PGP SIGNATURE-
From a8e3955829cad53dbfc346a3d5b8b613f4097ff0 Mon Sep 17 00:00:00 2001
From: Alexander Berntsen alexan...@plaimi.net
Date: Mon, 2 Dec 2013 00:53:25 +0100
Subject: [PATCH] man/make.conf.5: Mention sourced files syntax
---
man/make.conf.5 | 3 ++-
1 file changed, 2
/
iF4EAREIAAYFAlKb1D0ACgkQRtClrXBQc7U9EgD/X4JyNJ82J8Rihu4zf6EOEm8r
kJrRlxXaCRPK0+qSwEcA/RHIM+LhfkLT0MuX2zIcot4j+hwJ/vAUU3hVDR0n5wPU
=aFPn
-END PGP SIGNATURE-
From 9f6c0ebdb6abe3b7cdac8a59899b4571bd6e119a Mon Sep 17 00:00:00 2001
From: Alexander Berntsen alexan...@plaimi.net
Date: Mon, 2 Dec 2013 01:25:21
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
For future reference: please stop CCing me.
- --
Alexander
alexan...@plaimi.net
http://plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Apparently I forgot to turn off the option that CCs the author, and
consequently managed to do what I have been telling you to not do.
Don't take this as an invitation to CC me after all. ;-)
- --
Alexander
alexan...@plaimi.net
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/12/13 10:46, Sebastian Luther wrote:
Should we really document specific USE_EXPAND variables? What
about all the others?
I think so, yes.
USE_EXPAND=ABI_MIPS ABI_X86 ALSA_CARDS APACHE2_MODULES
APACHE2_MPMS CALLIGRA_FEATURES CAMERAS
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 03/12/13 11:21, Sebastian Luther wrote:
The problem with all these variables is that we don't maintain
them. If they disappear, change meaning or new ones are added we
constantly have to fix our documentation.
I don't think this is a problem.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 05/01/14 23:05, Sebastian Luther wrote:
I like this workflow because it makes it easy to see what has been
fixed since the last release. The only thing I have no use for, is
this InVCS keyword. I do not know what Zac used it for. Does
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 05/01/14 23:30, Brian Dolbec wrote:
If you open the tracker bug. The bug numbers listed as blockers.
Hover your mouse over the bug number. A small popup window
appears and shows the bug summary and status. The keywords are not
listed. So,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Sounds good. A couple of comments,
On 10/01/14 11:35, Brian Dolbec wrote:
General rule is to submit all patches to this list for review and
approval before committing.
s/committ/push
1) run pyflakes on your changes to check for faults,
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
We have quite a few dedicated developers now. To ensure that good
taste is exercised, and that best practices are followed, patches
should be signed.
My proposals:
Signed-off-by: Wrote (a substantial portion of) the patch
Reviewed-by: Reviewed the
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 16/01/14 17:45, W. Trevor King wrote:
I love Signed-off-by, but in all projects where I've seen it used
it means the signer is agreeing to some form of a Developer's
Certificate of Origin [1]. Without such a DCO, I think the usual
commit
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 16/01/14 17:41, Alec Warner wrote:
I'm confused, are you proposing all patches have all of these
fields? Or we should simply cherry-pick the fields we think are
useful?
Nearly all patches should have Signed-off-by. The others are situational.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 16/01/14 18:24, Jesus Rivero (Neurogeek) wrote:
So, how would this work with emails to this list, exactly? An
email should be sent any time one of those fields is changed?
That's not necessary, in my opinion. We already send emails, looks OK
to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 16/01/14 22:18, Tom Wijsman wrote:
My plan is to first work a bit on repoman to get to know it, then
when knowing better where everything is work on refactoring it.
That, along with I'll use this ugly short cut, but only this one
time!, is
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Your ill-placed attempts at being clever are missing the point.
Portage is a mess. We don't need it to become more messy to the point
of maintainability.
Yes, no one fixing bugs (because they are all designing a grand
redesign of Portage) would be
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 18/01/14 22:52, Robin H. Johnson wrote:
You mean like... https://github.com/gentoo/portage
This didn't exist back when. I should have done more research though.
Thanks.
- --
Alexander
alexan...@plaimi.net
http://plaimi.net/~alexander
---
man/emerge.1| 9 +
pym/_emerge/depgraph.py | 5 +++--
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/man/emerge.1 b/man/emerge.1
index e23d1b4..52f8ed7 100644
--- a/man/emerge.1
+++ b/man/emerge.1
@@ -331,10 +331,11 @@ Write required unmask changes to the
Rename --autounmask-write to --autounmask. Please note that removing the
option does not mean that the variable used for keeping track of
autounmask writing is not removed from depgraph.py.
---
man/emerge.1| 19 +++
pym/_emerge/depgraph.py | 4 ++--
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 11:23, Alexander Berntsen wrote:
emerge --ask foo # This won't -write emerge --autounmask --pretend
foo # Same as the above
Sorry, the comments here are imprecise. The first-mentioned will
*prompt* the user for writing the changes
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 10:17, Mike Frysinger wrote:
prefer OSes - OS's
That's just not proper English. It makes no sense. Please don't prefer
that. If for nothing else, then to prevent me from sighing whenever I
have to read it.
not a new issue, but we
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 10:20, Mike Frysinger wrote:
typically when we delete/rename an option, we give users a heads
up. that means a cycle where the old option exists but emits a
warning before switching to the new one. then we can delete it.
We should
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 17:49, Mike Gilbert wrote:
Please give me a way to shut off autounmask entirely no mater what
other options I pass to emerge. Tying it to --ask with no way to
disable it is not acceptable.
- --autounmask=n should do this. I messed
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 22:22, Sebastian Luther wrote:
The usual doc string style used in portage is:
text
Please use that for new functions. Also make sure you don't use
spaces to indent the last .
As mentioned by Mike in another thread, we should
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 23:46, Alec Warner wrote:
Does pylint or pyflakes point out if you mess it up?
Not very successfully in my experience.
- --
Alexander
alexan...@plaimi.net
http://plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 19/01/14 23:54, Alec Warner wrote:
I'm very against add a bunch of extra rules that have to be
enforced by hand. I want to make it easy to contribute, not more
difficult. If bob can run a tool that tells him all the things
that are wrong
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 20/01/14 12:05, Sebastian Luther wrote:
Basically it's either
1) We add things as we see fit. or
2) We should only add things if absolutely necessary..
So what's your opinion? Should we go for 1) or 2) or something else?
2.
- --
Alexander
/
iF4EAREIAAYFAlLkC3UACgkQRtClrXBQc7Un7gD8DFjXDZzWypJiCD7GFdXIiGEg
Gbzl2rZb3b9JOssNC8sA/3JdcsQI315GJ8szKYBsadmcZVC/k2/gZE8ZnW2qXtK+
=SJ9h
-END PGP SIGNATURE-
From 3a4cd65e97d7323562fba9669a14f5caa5523eeb Mon Sep 17 00:00:00 2001
From: Alexander Berntsen alexan...@plaimi.net
Date: Sat, 25 Jan
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 27/01/14 23:00, Tom Wijsman wrote:
A first idea from looking at search engine results is through the
menu View and then click Message Source; maybe there's some
faster way around, changing the options of what header fields to
show perhaps?
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 27/01/14 23:26, Tom Wijsman wrote:
It's somewhere near the end of the header:
Message-ID:
CAJ0EP408ncVB5zMF92upG+eQ0K2JT8WJbchm3XJFzrWj=c2...@mail.gmail.com
Oh,
right. I was being stupid. Case matching was enabled, so /message
didn't
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
- --
Alexander
alexan...@plaimi.net
http://plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Ooops. Disregard. Am resubscribing with my go account.
- --
Alexander
alexan...@plaimi.net
http://plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 20/02/14 01:08, Pavel Kazakov wrote:
Scan for failed merges fix them.
All the other modules put the second on a newline, so I wanted
to be consistent. Should I still make the change?
What the other modules are doing is not necessarily an
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 20/02/14 14:58, Brian Dolbec wrote:
Alexander, did you NOT read my other reply about 'module1'?
Obviously not closely enough. A bit tired today. :-)
Pavel is trying to learn the plug-in system, so that he can better
help with the new plug-in
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Alignment is a PITA with hard tabs, so can we at least agree on what
tab stop to use? I naïvely mentioned in DEVELOPING that it should be
set to 4, because that's what every Python standard uses. But
throughout the code it varies.
There are plenty
Don't try to display atoms that are None when in debug mode.
---
Can I get an ACK on this please? Do share your ideas for refactoring,
if any. But even if this is not how we want it to work in the end, I
still think we should commit it to fix the bug.
pym/_emerge/depgraph.py | 13 +++--
the relevant bug, and b) because '#' is a
very grepable char for looking up recently fixed bugs with head or
whatever.
No bikeshedding, please. These are not very interesting things to talk
about. Let's just form a decision. Object if you have an objection. If
not, give me an ACK.
Alexander Berntsen
---
Nothing to see here, move along.
DEVELOPING | 71 +-
1 file changed, 38 insertions(+), 33 deletions(-)
diff --git a/DEVELOPING b/DEVELOPING
index 40b4ca2..1f5087a 100644
--- a/DEVELOPING
+++ b/DEVELOPING
@@ -1,37 +1,39 @@
Code
---
DEVELOPING | 20
1 file changed, 20 insertions(+)
diff --git a/DEVELOPING b/DEVELOPING
index c6004ec..a34dda5 100644
--- a/DEVELOPING
+++ b/DEVELOPING
@@ -175,6 +175,26 @@ change a lot of unrelated things. This makes it easier to
see what
parts of the system have
---
Following a chat with Brian, here's my suggestion. ACK or object.
DEVELOPING | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/DEVELOPING b/DEVELOPING
index b2b0a19..f8ccc20 100644
--- a/DEVELOPING
+++ b/DEVELOPING
@@ -23,10 +23,9 @@ with Python itself, must be
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 27/03/14 17:16, Brian Dolbec wrote:
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index 83035c2..61ef31d 100644 --- a/pym/_emerge/depgraph.py +++
b/pym/_emerge/depgraph.py @@ -1942,8 +1942,9 @@ class
depgraph(object): #
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Please use a max 50 char commit message headline, without the period.
On 29/03/14 19:45, Michał Górny wrote:
+import locale +import math
Why not explicitly import what you are going to use? (On the form of
from foo import bar, baz.)
- --
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Please remove the period from the commit message. I would prefer if
you used an explicit import here as well.
Other than those minor complaints, these patches look good to me.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Prefer repoman: Sort check results in output as a message, as per
the new guidelines in DEVELOPING.
The patch is simple enough. ACK.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 31/03/14 04:06, Brian Dolbec wrote:
It all looked really good to me.
{:-D
Yep.
Please update the commit messages to follow DEVELOPING though.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 04/04/14 21:36, Brian Dolbec wrote:
Is there any other bugfixes to go in? I am merging some other
patches submitted to the list as well.
There's my/your/our patch(es) for bug 505944. Any idea on what to do
about that? No one has offered a
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 04/04/14 21:36, Brian Dolbec wrote:
- Use /proc/mounts to check that no directories installed by the ebuild
are set
- to be installed to a read-only filesystem.
+ Use /proc/self/mountinfo to check that no directories installed by
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 04/04/14 21:36, Brian Dolbec wrote:
--- pym/_emerge/TaskSequence.py | 5 +++-- 1 file changed, 3
insertions(+), 2 deletions(-)
diff --git a/pym/_emerge/TaskSequence.py
b/pym/_emerge/TaskSequence.py index 1fecf63..b4bfefe 100644 ---
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 06/04/14 11:09, Douglas Freed wrote:
Adds the currently running python version to the portage version
line, so that it's immediately obvious what version of python is
being used to run portage.
Is this useful?
The patch itself looks OK
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 07/04/14 04:29, Brian Dolbec wrote:
YES, there can be problems associated with certain python
versions, like the recent bug 506870. It turned out to be a pypy
compatibility bug.
OK. ACK from me then.
- --
Alexander
berna...@gentoo.org
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Thanks! Committed as b4d8e300c04b768be7cd5c64116d6cc0453219b4.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 12/05/14 20:45, Brian Dolbec wrote:
Did you look at the bug mentioned? It is an EAPI-6 proposal,
which when you look at the PMS patch... it also mentions that
catalyst is not capable of packages.build as a directory. So it
needs to be
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Apparently the list is back up.
This patch makes it easier to e.g. copypaste atoms into
/var/lib/portage/world or whatever.
I might, following a suggestion from Seb, restrict the atom parser so
that unmerge does not accept atoms
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Friends,
we should have a new meeting to discuss the autounmask patches and
dynamic dependencies[0]. Please add your own items to the agenda,
should you have any.
I will set up the meeting scheduler later. Suggest a time that you
think could work
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Hi,
I'm organizing this event : Portage meeting
I'd like to find out your availability. This link will show you my
proposed times. All you need to do is click on when is good for you ...
http://whenisgood.net/portage
Thanks!
- --
Alexander
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
The Portage team meeting will be Thursday 24th at 6pm. If you have
some really good reason for it not be, let me know and I will at least
consider rearranging it.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Sorry, I got timezone confused! That's 7pm UTC 0.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
MEETING SUMMARY
===
Assorted Bugs
- --
Andreas Hüttel has patch for repoman. It checks that a package does
not depend on anything in perl-core if it is not a virtual package.
This patch will be tested and merged by myself.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 25/07/14 11:54, Alexander Berntsen wrote:
MEETING SUMMARY ===
Assorted Bugs -- Andreas Hüttel has patch for repoman.
It checks that a package does not depend on anything in perl-core
if it is not a virtual package
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 25/07/14 12:42, Alexander Berntsen wrote:
On 25/07/14 11:54, Alexander Berntsen wrote:
MEETING SUMMARY ===
Assorted Bugs -- Andreas Hüttel has patch for
repoman. It checks that a package does not depend on anything
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
I don't have time for any more playing with this. Please test it, and
ACK it if it is OK. I will merge it when I get back if it's OK. :-]
pym/_emerge/actions.py | 10 --
pym/_emerge/post_emerge.py | 5 -
2 files changed
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Friends,
Portage 2.2.11 is now out. Brian is uploading the tarball and bumping
the ebuild right now.
Release notes:
- Remove some broken old style virtual code
- Bug # 505428 RO only filesystem check
- Bug # 506186 TaskSequence
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
pym/_emerge/depgraph.py | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/pym/_emerge/depgraph.py b/pym/_emerge/depgraph.py
index bfa63fa..37b3a54 100644
--- a/pym
::gentoo (masked by: ~amd64 keyword)
Please review test.
For more information, see the MASKED PACKAGES section in the emerge
man page or refer to the Gentoo Handbook.
Alexander Berntsen (4):
emerge: Deprecate --autounmask
emerge: Rename --autounmask-write to --autounmask
emerge: Make
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
man/emerge.1| 9 +
pym/_emerge/depgraph.py | 5 +++--
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/man/emerge.1 b/man/emerge.1
index be52f25..c52cd0a
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Options are a bit... odd in Portage source, so please *test* this before
ACKing!
man/emerge.1| 3 ++-
pym/_emerge/depgraph.py | 5 +++--
2 files changed, 5 insertions(+), 3
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 13/08/14 18:45, Brian Dolbec wrote:
Actually, re-reading your patches again, your patches actually made
more sense to me finally. You were fixing it to make implied
behavior the actual behavior. So while I was originally objecting
to
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 13/08/14 19:59, Duncan wrote:
* I don't want portage writing mask/use changes on its own under
any circumstances, as I use directories and have my own idea of
what files I want stuff in.
It never has, and these patches never have implemented
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 13/08/14 21:24, Wyatt Epp wrote:
Is there really any situation where the user would benefit from
not having the suggestions?
floppym complained about how he needed the ability to turn them
completely off like this -- hence patch 4.
Regardless
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
These look good. ACK on 1 and 2 from me, but I would like Sebastian,
Arfrever, Brian, or someone else at least to look over them. These
patches are too interesting to be pushed after a single ACK.
For 3, I think it looks nice but you should check
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
It doesn't look like anyone else is going to sign up. So lets do it at
7AM UTC on Wednesday 3rd. And lets hope that's not until 9am local
time me, because that's already about 6h too early. ;-)
- --
Alexander
berna...@gentoo.org
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Friends, here is the meeting summary:
- -We'll merge the fakeroot patches[0].
- -Trofi's repoman patch is mostly OK as far as Michał and I are
concerned. I will respond to his thread on the ML. Tom or whoever's
doing repoman now needs to ACK it.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 25/07/14 00:11, Sergei Trofimovich wrote:
- assert(h.known_maintainer('sping'))
- assert(h.known_maintainer('sp...@gentoo.org'))
+ assert(h.known_maintainer('slyfox'))
+ assert(h.known_maintainer('sly...@gentoo.org'))
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
LGTM.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
I'm not familiar with the formalities surrounding ebuild commit
messages -- is this something that's actually mandatory? If not, is
this change at least mandated? If not, this should probably go to QA
before Portage.
- --
Alexander
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 09/09/14 05:22, Brian Dolbec wrote:
LGTM
+1
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
For Brian to review, and anyone else who feels like it.
man/emerge.1| 3 ++-
pym/_emerge/depgraph.py | 7 +--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 17/09/14 00:13, Zac Medico wrote:
I all looks very well done to me now. I'd encourage others on the
list to review it now, in case there's anything that I missed.
At a glance, it looks OK to me. You can commit it if you vouch for it,
Zac.
- --
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
For future reference, please use git's send-email option with
- --in-reply-to, to send the patches inline. The way they are sent now,
(I assume) most of us have to download your patches and open them in a
text viewer to review it. If the patches
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Use 'is' instead of '==', as recommended by Zac.
man/emerge.1| 3 ++-
pym/_emerge/depgraph.py | 7 +--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/man
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Tested Zac's version. Seems to work fine.
man/emerge.1| 3 ++-
pym/_emerge/depgraph.py | 6 --
2 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/man/emerge.1 b
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Add exception in case eselect is not found. Fix output a tiny bit.
pym/_emerge/actions.py | 17 +++--
pym/_emerge/post_emerge.py | 5 -
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/pym/_emerge
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Fix some comment snafus that Arfrever spotted.
pym/_emerge/actions.py | 17 +++--
pym/_emerge/post_emerge.py | 5 -
2 files changed, 19 insertions(+), 3 deletions(-)
diff --git a/pym/_emerge/actions.py b/pym/_emerge
From: Alexander Berntsen alexan...@plaimi.net
Signed-off-by: Alexander Berntsen berna...@gentoo.org
---
Update manpage header, as pointed out by Arfrever.
man/emerge.1| 5 +++--
pym/_emerge/depgraph.py | 6 --
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/man
Turn off news-reading by default when --ask, and instead make it an
option --read-news.
Apparently making --ask a bit more interactive was goddamn stupid and
ruined the lives of several Gentoo developers. Props to Michał who
predicted this all along.
Signed-off-by: Alexander Berntsen berna
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
As mentioned on bugzie, LGTM. Feel free to add me as Reviewed-By push.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird -
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 24/10/14 04:00, Zac Medico wrote:
Should we go ahead and merge this now that 2.2.14 is released?
ACK from me.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment:
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Friends,
I accidentally pushed a GPG signed commit. This isn't a problem;
merely pointless at this stage, as it won't be used.
But following this accident I thought I should ask, is it OK to just
start GPG signing commits now? It's default in my
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 24/10/14 22:57, Zac Medico wrote:
1) Replace self.configdict[BASHRC_FILES] with self._pbashrc,
since configdict is used for other unrelated things. Also make it
an immutable tuple instead of a list. 2) Test if profile.bashrc
exists before
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Reviewed-by: me. :-] Go ahead push!
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
LGTM, Zac. Go ahead and push.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
Sure. Go ahead and push, Zac.
- --
Alexander
berna...@gentoo.org
https://secure.plaimi.net/~alexander
-BEGIN PGP SIGNATURE-
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 27/10/14 08:33, Zac Medico wrote:
+ if not
self._depgraph._virt_deps_visible( +
new_child,
ignore_use=True): +
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 27/10/14 09:22, Alexander Berntsen wrote:
On 27/10/14 08:33, Zac Medico wrote:
+if not
self._depgraph._virt_deps_visible( +
new_child,
ignore_use=True
1 - 100 of 288 matches
Mail list logo
