Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Wed, Mar 11, 2020 at 10:23 PM Zac Medico wrote: > The coupling with --destructive logic complicates matters. It raises the > question, why isn't --time-limit logic also coupled with --destructive > logic? I think "in order to preserve the status quo" is a reasonable > answer to this question.

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Zac Medico
On 3/11/20 9:43 PM, Matt Turner wrote: > On Wed, Mar 11, 2020 at 9:36 PM Matt Turner wrote: >> >> On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote: >>> We can't can't continue above, since that will skip all of the filters >>> that occur later in the loop. So, we have to nest the below

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Wed, Mar 11, 2020 at 9:36 PM Matt Turner wrote: > > On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote: > > > > On 3/6/20 10:11 PM, Matt Turner wrote: > > > Signed-off-by: Matt Turner > > > --- > > > pym/gentoolkit/eclean/cli.py| 7 ++- > > > pym/gentoolkit/eclean/search.py | 24

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Zac Medico
On 3/11/20 9:36 PM, Matt Turner wrote: > On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote: >>> @@ -562,7 +575,16 @@ def findPackages( >>> >>> # Exclude if binpkg exists in the porttree and not --deep >>> if not destructive and port_dbapi.cpv_exists(cpv): >>> -

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Wed, Mar 11, 2020 at 9:31 PM Zac Medico wrote: > > On 3/6/20 10:11 PM, Matt Turner wrote: > > Signed-off-by: Matt Turner > > --- > > pym/gentoolkit/eclean/cli.py| 7 ++- > > pym/gentoolkit/eclean/search.py | 24 +++- > > 2 files changed, 29 insertions(+), 2

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Zac Medico
On 3/11/20 4:32 PM, Matt Turner wrote: > On Tue, Mar 10, 2020 at 8:30 PM Zac Medico wrote: >> >> On 3/6/20 10:11 PM, Matt Turner wrote: >>> +def _deps_equal(deps_a, deps_b, eapi, uselist=None): >>> + """Compare two dependency lists given a set of USE flags""" >>> + if deps_a == deps_b:

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Zac Medico
On 3/6/20 10:11 PM, Matt Turner wrote: > Signed-off-by: Matt Turner > --- > pym/gentoolkit/eclean/cli.py| 7 ++- > pym/gentoolkit/eclean/search.py | 24 +++- > 2 files changed, 29 insertions(+), 2 deletions(-) > > diff --git a/pym/gentoolkit/eclean/cli.py

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-11 Thread Matt Turner
On Tue, Mar 10, 2020 at 8:30 PM Zac Medico wrote: > > On 3/6/20 10:11 PM, Matt Turner wrote: > > +def _deps_equal(deps_a, deps_b, eapi, uselist=None): > > + """Compare two dependency lists given a set of USE flags""" > > + if deps_a == deps_b: return True > > + > > + deps_a =

Re: [gentoo-portage-dev] [PATCH v2 gentoolkit 2/2] eclean: Add option to delete binpkgs with changed deps

2020-03-10 Thread Zac Medico
On 3/6/20 10:11 PM, Matt Turner wrote: > +def _deps_equal(deps_a, deps_b, eapi, uselist=None): > + """Compare two dependency lists given a set of USE flags""" > + if deps_a == deps_b: return True > + > + deps_a = use_reduce(deps_a, uselist=uselist, eapi=eapi, > token_class=Atom) > +