Re: [Geotools-devel] 14-RC round-up

2015-09-10 Thread Jody Garnett
Chewing through the last couple pull requests that have come in - thanks to Torben and Ben for the assistance. - remove spike - [GEOT-5211] App-schema REST: data access containing non-feature types is not removed

Re: [Geotools-devel] App-schema REST: data access containing non-feature types is not removed

2015-09-10 Thread Ben Caradoc-Davies
Done! On 11/09/15 10:03, Jody Garnett wrote: > Ben do you have time to you merge and clean up the unused member? Trying to > close the door for the RC :) -- Ben Caradoc-Davies Director Transient Software Limited New Zealand ---

Re: [Geotools-devel] App-schema REST: data access containing non-feature types is not removed

2015-09-10 Thread Jody Garnett
Ben do you have time to you merge and clean up the unused member? Trying to close the door for the RC :) -- Jody Garnett On 10 September 2015 at 14:59, Ben Caradoc-Davies wrote: > That looks great, Stefano. Your unit test coverage is solid, and full GT > + GWC + GS + GS app-schema online tests

Re: [Geotools-devel] [udig-dev] ConcurrentModificationException on MemoryDataStore Layer

2015-09-10 Thread Jody Garnett
Going to take a bit longer to respond, sorry for my earlier terse email from phone. -- Jody Garnett On 10 September 2015 at 14:43, Frank Gasdorf wrote: > > 2015-09-10 23:13 GMT+02:00 Jody Garnett : > >> Since its not an "Ordered" DataStore that should preserve order I'd >>> suggest to remove thes

Re: [Geotools-devel] App-schema REST: data access containing non-feature types is not removed

2015-09-10 Thread Ben Caradoc-Davies
That looks great, Stefano. Your unit test coverage is solid, and full GT + GWC + GS + GS app-schema online tests against postgis all passed. I found one unused member that should be removed (see comment on PR), then please go ahead and merge on master. Because this PR fixes a bug in app-schema

Re: [Geotools-devel] [udig-dev] ConcurrentModificationException on MemoryDataStore Layer

2015-09-10 Thread Frank Gasdorf
2015-09-10 23:13 GMT+02:00 Jody Garnett : > Since its not an "Ordered" DataStore that should preserve order I'd >> suggest to remove these tests. Opinions? >> > > If you change the functionality, change the test to match. There should > now be several feature collection implementations to choose f

Re: [Geotools-devel] [udig-dev] ConcurrentModificationException on MemoryDataStore Layer

2015-09-10 Thread Jody Garnett
> > Since its not an "Ordered" DataStore that should preserve order I'd > suggest to remove these tests. Opinions? > If you change the functionality, change the test to match. There should now be several feature collection implementations to choose from so code that requires a TreeSet based functi

Re: [Geotools-devel] [udig-dev] ConcurrentModificationException on MemoryDataStore Layer

2015-09-10 Thread Frank Gasdorf
2015-09-09 8:27 GMT+02:00 Andrea Aime : > On Tue, Sep 8, 2015 at 11:02 PM, Jody Garnett > wrote: > >> Pull request is good, in today's GeoTools meeting we discussed the issue. >> Apparently LinkedHashMap was used to preserve order (making test cases >> easier). >> > > The main issue is that the m

[Geotools-devel] [JIRA] (GEOT-5212) DB2 st_dishoint does not work with SELECTIVITY clause

2015-09-10 Thread Chrstian Mueller (JIRA)
Title: Message Title Chrstian Mueller created an issue