Re: [Geotools-devel] PostGIS non-serial sequence support

2006-10-04 Thread Justin Deoliveira
Cool, sounds good, go ahead an apply the patch. -Justin Cory Horner wrote: > Justin Deoliveira wrote: > >> The patch looks good. A couple of comments: >> >> 1. The result sets created in teh method are never closed. This was like >> this before I know, might be a good time to fix it. Not a big i

Re: [Geotools-devel] PostGIS non-serial sequence support

2006-10-04 Thread Cory Horner
Justin Deoliveira wrote: >The patch looks good. A couple of comments: > >1. The result sets created in teh method are never closed. This was like >this before I know, might be a good time to fix it. Not a big issue though. > > done. >2. The pattern matching that is done to find the sequence fro

Re: [Geotools-devel] PostGIS non-serial sequence support

2006-10-04 Thread Justin Deoliveira
Hi Cory, The patch looks good. A couple of comments: 1. The result sets created in teh method are never closed. This was like this before I know, might be a good time to fix it. Not a big issue though. 2. The pattern matching that is done to find the sequence from the system tables. Is there any

[Geotools-devel] PostGIS non-serial sequence support

2006-10-04 Thread Cory Horner
Hi guys, Here is a patch for PostGISAutoIncrementFIDMapper which provides a slightly more intelligent technique for mapping the FID of a non-serial sequence, which has a higher success rate than our current code: http://jira.codehaus.org/browse/GEOT-953 I am ready to commit, although I may cha