Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4903
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f7f7d0353014b7ef8a0c5a7707c91b2613be79a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 2: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/4669/2/OsmoGSMTester/chapters/config.adoc
File OsmoGSMTester/chapters/config.adoc:
Line 73:no longer reserved.
(is there also a LAC / cell id state now?)
--
To view, visit https://gerrit.osmocom.org/4669
To
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4961
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ef60152a31dea25cb839c47edc93d5337ec3a3e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4775
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefdc5b905d76d2cd97f26584261fe5cbefb699cf
Gerrit-PatchSet: 3
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 3: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5023
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a24cc307450efdcd28168fffe477320c59fcd36
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/5010/1/suites/aoip_debug/interactive.py
File suites/aoip_debug/interactive.py:
Line 36: cmd = prompt('Enter command: (q)uit (s)ms (g)et-registered
(w)ait-registered, call-list [], call-dial
, call-wait-incoming ,
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5030
to look at the new patch set (#3).
DTX: avoid illegal character contained in DTX FSM allocation which causes BTS
crash
Problem:
lchan->tch.dtx.dl_amr_fsm struct failed to
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5030
to look at the new patch set (#2).
DTX: avoid illegal character contained in DTX FSM allocation which causes BTS
crash
Problem:
lchan->tch.dtx.dl_amr_fsm struct failed to
Patch Set 2:
> Could you perhaps add the crash output to commit log for reference?
I have just added more inputs to the commit log.
--
To view, visit https://gerrit.osmocom.org/5030
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/5031
cosmetic: remove duplicate logging
The log output of the reset FSM duplicates lots of the built in
FSM log output.
Remove duplicate logging, use more expressive log messages where
needed.
Change-Id: Ie031d947a5b8097bd656c0271081af215605ba02
---
M
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4980
to look at the new patch set (#3).
mgcp: use osmo-mgw to switch rtp streams
in the current implementation we still use osmo-bsc_mgcp, which
has many problems and is also
Patch Set 1:
direct "obviously" refers to the "direct DSP access' where the PH-primitives
are directly exchanged between the DSP and the PCU, and only the MPH-primitives
are exchanged via the PCU socket.
--
To view, visit https://gerrit.osmocom.org/5006
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5009/1/src/osmo_gsm_tester/modem.py
File src/osmo_gsm_tester/modem.py:
Line 340: CTX_PROT_IPv46 = 'dual'
(is this used internally only? I'd suggest using the same strings as you've
chosen for the names of the constants)
wait a
Patch Set 1: Code-Review+1
Could you perhaps add the crash output to commit log for reference?
--
To view, visit https://gerrit.osmocom.org/5030
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5008/1/src/osmo_gsm_tester/bts_octphy.py
File src/osmo_gsm_tester/bts_octphy.py:
Line 51: self._pcu = pcu_osmo.OsmoPcu(self.suite_run, self, self.conf)
prefer to pass OsmoPcu instance in as argument
--
To view,
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/5007/1/src/osmo_gsm_tester/bts_osmotrx.py
File src/osmo_gsm_tester/bts_osmotrx.py:
Line 51: self._pcu = pcu_osmo.OsmoPcu(self.suite_run, self, self.conf)
I'd prefer to pass in the OsmoPcu class instance as argument,
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5006/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 58: 'bts[].direct_pcu': schema.BOOL_STR,
"direct PCU"? do we have an indirect PCU as well? AFAIK osmo-pcu always needs
to be on the same box as
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5005/1/src/osmo_gsm_tester/pcu_osmo.py
File src/osmo_gsm_tester/pcu_osmo.py:
Line 45: event_loop.sleep(self, seconds=20)
ugh, that's ugly ... can't you parse the log outputlike in trx_ready()? seems
trivial enough.
--
To view,
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5003
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbb71df1ad36e5d7eb02f3fdd7987a178d523d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4997
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a289360018aa56fe25b3dd328ffe9194b65f6b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/4985/2/src/osmo-bsc/osmo_bsc_mgcp.c
File src/osmo-bsc/osmo_bsc_mgcp.c:
Line 188: LOGPFSML(fi, LOGL_DEBUG, "fsm-state: %s, fsm-event: %s\n",
I'm getting annoyed by these LOGPFSM of FSM state and event, which are
*clearly* logged by
Patch Set 3: Code-Review-1
(8 comments)
https://gerrit.osmocom.org/#/c/4906/3/include/osmocom/mgcp/mgcp_common.h
File include/osmocom/mgcp/mgcp_common.h:
Line 73: #define MGCP_CONN_ID_MAXLEN 32+1
(technically this is the SIZE, and MAXLEN would be 32 ... but whatever. In
other places we use
Review at https://gerrit.osmocom.org/5030
DTX: avoid illegal character contained in DTX FSM allocation which causes BTS
crash
Change-Id: I929ce3703dc57acf8db569ae0e346265644d0b3c
---
M src/common/l1sap.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/5028
Fix parsing for python3
In python3 we got bytes, not string from the socket so we have to use
bytes argument for split().
Change-Id: I599f9f5a18109929f59386ab4416b8bfd75c74d1
---
M osmopy/osmo_ipa.py
1 file changed, 2 insertions(+), 2 deletions(-)
Review at https://gerrit.osmocom.org/5029
Add rate counter dumper
This simple tool dump all the rate counters available via ctrl interface
to cvs file (or stdout).
Change-Id: I12b369434e4ee9b38f92872f297e1f3d4f0698c2
Fixes: OS#2550
---
M README
M osmopy/__init__.py
A osmopy/rate_ctr2csv.py
M
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4992
to look at the new patch set (#5).
Add *.py from OsmoBSC
Those are generic enough and can be used as advanced example of uzing
CTRL interface from python on top of osmo_ipa.
Change-Id:
Max has submitted this change and it was merged.
Change subject: Improve get_rate_ctr() error handling
..
Improve get_rate_ctr() error handling
Report back expected interval values.
Change-Id:
Patch Set 3:
> ctrl_cmd_reply_printf()
Doh! Completely forgot about it. Good point.
> it is easy to split by '\n' and ignore the first line
And it's even easier if we don't have to put workarounds for weird format.
I don't really think we're breaking compat in here: until
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5023
to look at the new patch set (#3).
ctrl: make response easier to parse
Previously ctrl request for all counters in
group (e. g. 'rate_ctr.abs.msc.0') will
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5021
to look at the new patch set (#3).
vty: Add cmd to configure 3g Early Classmark Sending
In state prior to this patch, "3G Early Classmark Sending Restriction"
bit in SI3 rest octets
Neels Hofmeyr has submitted this change and it was merged.
Change subject: use only 0.23.1 as point code for both A and Iu
..
use only 0.23.1 as point code for both A and Iu
We usually have both A and IuCS on 0.23.1, using
Neels Hofmeyr has submitted this change and it was merged.
Change subject: cosmetic: osmo-hnbgw: log remote SCCP addresses on startup
..
cosmetic: osmo-hnbgw: log remote SCCP addresses on startup
Change-Id:
Patch Set 2:
leaving proper point-code defaults infrastructure to another patch, first
fixing the wrong defaults...
--
To view, visit https://gerrit.osmocom.org/4977
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: osmo-hnbgw: auto-config local and remote PCs if omitted
..
osmo-hnbgw: auto-config local and remote PCs if omitted
The current default point-code for
Patch Set 1:
agreed on need for proper point codes infrastructure
--
To view, visit https://gerrit.osmocom.org/5019
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie11f1dfcdd5889d44fefe6cc10472ef1a794cc64
Gerrit-PatchSet: 1
Neels Hofmeyr has submitted this change and it was merged.
Change subject: use default point-code as listed on Point_Codes wiki page
..
use default point-code as listed on Point_Codes wiki page
see
Patch Set 2: Code-Review-1
(1 comment)
I agree that human readable prose are not really fit for the CTRL response, but
about parsing ease: it is easy to split by '\n' and ignore the first line. With
this patch (we separate the value part and then) split the value by ';' to get
the same
Patch Set 2:
Note: only bulk-request is affected, requesting individual counter by name
works exactly as before.
--
To view, visit https://gerrit.osmocom.org/5023
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4836
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I63c3b300cc9287d1755a3f2c5b5ade7fc6398f6e
Gerrit-PatchSet: 3
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: mobile/vty_interface.c: fix Kc / Ki confusion
..
mobile/vty_interface.c: fix Kc / Ki confusion
Change-Id: Ibbd1d080896b5cadc3d4281fe8f839a103a35088
---
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5027
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibbd1d080896b5cadc3d4281fe8f839a103a35088
Gerrit-PatchSet: 1
Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5007
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I777835345355538a945599fb088630af63dc9140
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5008
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54780971d711d47b23976dd044a4a53134dd4299
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5013
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cc71529fd6e3b99b8a53c0b91377df6d3a636d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5016
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ca7f716342af4f7424b28216ed6c1bf2bd589f
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5009
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I605ba1bb1103a045a9b5d0e7215c05dfc1fe575f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5010
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I991d0329ff068aaa7c101a5f55ad40616faac121
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5012
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9b294ef35e35a5951b72e86e8b967d2a612f177
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
(6 comments)
https://gerrit.osmocom.org/#/c/5006/1/src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-bsc.cfg.tmpl:
PS1, Line 65: gprs
probably one would want to have a template here to decide if GPRS or EGPRS
shall be used / tested ?
PS1,
Patch Set 2: Code-Review+1
I am not aware of any programs querying rate counters, but the vague impression
that some might exist still lingers... maybe ask lynxis and CCM guys?
--
To view, visit https://gerrit.osmocom.org/5023
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5005
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I647f287a7e652df74021093fa5edb330a333c7c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5002/1/src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-sgsn.cfg.tmpl:
PS1, Line 15: ggsn_tun_ip_address
why is this called ggsn_tun_ip_address? This is not the address of a tun
device. It is
Review at https://gerrit.osmocom.org/5027
mobile/vty_interface.c: fix Kc / Ki confusion
Change-Id: Ibbd1d080896b5cadc3d4281fe8f839a103a35088
---
M src/host/layer23/src/mobile/vty_interface.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmocom-bb
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/5003
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbb71df1ad36e5d7eb02f3fdd7987a178d523d3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5001/1/src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl
File src/osmo_gsm_tester/templates/osmo-ggsn.cfg.tmpl:
PS1, Line 55: 2001:780:44:2000:0:0:0:0/56
it would be good to use IPv6 prefixes that are not public IPv6 addresses that
are
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5004
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I04d8ed5e02b090d07e91669df44ce354bc6ee749
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4998
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I47845f36864d494be474fdd447a4e9e0cbed1abd
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4997
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56a289360018aa56fe25b3dd328ffe9194b65f6b
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4999
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I99a1e8c2fbd3856f5c1978449292871498c6bf18
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4996
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd5de7a828f0a627f69876a990f2ac1af0b578aa
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4979
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c11abaeff62749cbc365dfef671c4e15a85fc95
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4983
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9bf49df167d94b33ad65d8b9382a01f160b5aec0
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+1
should we really spend our time on this?
--
To view, visit https://gerrit.osmocom.org/4984
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2e37630e315b3602da2f14e2364bb76be9dd2894
Gerrit-PatchSet: 2
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4985
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I05ff62e7e2de64c2dbf5ea2736f5e58faf16df0b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4981
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iea5ea9e54f4b5c998b1d5fe18a98a94abd7b728b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4964
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib379a6f40875bb8f2cf29038a5b5b7a40a21adab
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4982
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia117e4099046fefcf35ccb94400554062e667869
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4906
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0531a1b670d00cec50078423a2868207135b2436
Gerrit-PatchSet: 3
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/4905
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab6a6038e7610c62f34e642cd49c93d11151252c
Gerrit-PatchSet: 3
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Patch Set 2: Code-Review+1
looks fine to me. I just hope we don't break any existing uses of the
interface. Holger? Neels?
--
To view, visit https://gerrit.osmocom.org/5023
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5025
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I544001d3072e5f12a96a67e4178f9b945c5f6b6c
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5022
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id22e157d1bee453babdfa7ed04c506390b0f17bb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/5026
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0981fca96f4927717ca335be1dab00a5d17fd6c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/5021/1/src/libbsc/system_information.c
File src/libbsc/system_information.c:
PS1, Line 875: s
> According to specs in 44.018:
Don't ever treat L as 0 and H as 1. 0/1/L/H are completely different symbols
next to each other!
In your code,
Patch Set 2:
I leave here for the record the rationale for implementing 2 cmds instead of 1:
"Regarding the early-classmark-3g option, I'm not entirely sure I like the idea
of using only 1 cmd line, because then we have different behaviour depending on
whether the cmd is set or not, and
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5022
to look at the new patch set (#2).
tests: Fix selection of python version
According to documentation (and personal experience), AM_PATH_PYTHON
selects the highest version of python, no
Review at https://gerrit.osmocom.org/5026
Use type bool for boolean fields in gsm48_si_ro_info
Change-Id: Ic0981fca96f4927717ca335be1dab00a5d17fd6c
---
M include/osmocom/bsc/rest_octets.h
M src/libbsc/system_information.c
2 files changed, 10 insertions(+), 10 deletions(-)
git pull
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5021
to look at the new patch set (#2).
vty: Add cmd to configure 3g Early Classmark Sending
In state prior to this patch, "3G Early Classmark Sending Restriction"
bit in SI3 rest octets
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5023
to look at the new patch set (#2).
ctrl: make response easier to parse
Previously ctrl request for all counters in
group (e. g. 'rate_ctr.abs.msc.0') will result in
Review at https://gerrit.osmocom.org/5025
ctrl: log incorrect interval values
This should never happen with the current code, but if it ever does, we
should log the error instead of silently returning 0.
Change-Id: I544001d3072e5f12a96a67e4178f9b945c5f6b6c
Related: OS#2550
---
M
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/4779/3/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:
Line 1296: g_cfg->trunk.number_endpoints =
g_cfg->trunk.vty_number_endpoints;
> hmm ok, I see the mgcp_endpoints_allocate() kind of uses the number_endpoin
or duh,
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/4779/3/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:
Line 1296: g_cfg->trunk.number_endpoints =
g_cfg->trunk.vty_number_endpoints;
> -1: rather assign the number of allocated endpoints only after allocation,
hmm ok,
Patch Set 3: Code-Review-1
(3 comments)
sorry to have to annoy once more, but it needs to be safe plz
https://gerrit.osmocom.org/#/c/4779/3/src/libosmo-mgcp/mgcp_vty.c
File src/libosmo-mgcp/mgcp_vty.c:
Line 1283:
unrelated ws
Line 1296: g_cfg->trunk.number_endpoints =
Patch Set 1:
(1 comment)
I see a number of other strcpy and strncpy instances around osmo-mgw.git. I
think at some point I replaced all with osmo_strlcpy(), I wonder where all
these are coming from now. Would you mind to replace all of the occurences in
one fell swoop?
Patch Set 1: Code-Review+1
would be excellent to see in the commit log an example of what is returned
before and after this patch.
Tweaking the logging should rather be a separate patch.
--
To view, visit https://gerrit.osmocom.org/5023
To unsubscribe, visit
Patch Set 1:
(1 comment)
what was the cause for you needing this change? Apparently the tests work fine
on our build slaves though they have both py2 and py3? I didn't face any such
problems on my box either, AFAICT?
(BTW, in general, an alternative could be to move to the
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4906
to look at the new patch set (#3).
MGCP: Connection Identifiers are hex strings
The MGCP spec in RFC3435 is quite clear: Connection Identifiers are
hexadecimal strings of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4905
to look at the new patch set (#3).
libosmo-mgcp: Connection Identifiers are allocated by MGW, not CA
The MGCP connection identifier is allocated by the MGW while processing
the CRCX,
Review at https://gerrit.osmocom.org/5024
client: use osmo_strlcpy instead of strncpy
simplify null termination of the ip_addr string
Change-Id: I94e3815f45d08e0d40faf41e580547de937c4ce8
---
M src/libosmo-mgcp-client/mgcp_client.c
M src/libosmo-mgcp/mgcp_conn.c
2 files changed, 3
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4836
to look at the new patch set (#3).
cosmetic: use correct VTY port number constant
osmo-mgw currently uses VTY port number constant of osmo-bsc_mgwp,
however, libosmore now offers a
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4779
to look at the new patch set (#3).
vty: do not change number_endpoints at runtime
The variable number_endpoints is used as a length indicator
for the array that contains
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4779
to look at the new patch set (#2).
vty: do not change number_endpoints at runtime
The variable number_endpoints is used as a length indicator
for the array that contains
Review at https://gerrit.osmocom.org/5023
ctrl: make response easier to parse
Previously ctrl request for all counters in
group (e. g. 'rate_ctr.abs.msc.0') will result in human-readable
description which is not regular enough and is hard to both parse and
generate. The ctrl interface is
Review at https://gerrit.osmocom.org/5022
tests: Fix selection of python version
According to documentation (and personal experience), AM_PATH_PYTHON
selects the highest version of python, no matter if major version is
different, which means if both python2 and 3 are available, 3 will be
Max has submitted this change and it was merged.
Change subject: Remove unused check
..
Remove unused check
We do not test on FreeBSD in jenkins anymore.
Change-Id: I1578306244f6ee218e464a6c378ff60605cf1d5c
---
M
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/4992
to look at the new patch set (#4).
Add *.py from OsmoBSC
Those are generic enough and can be used as advanced example of uzing
CTRL interface from python on top of osmo_ipa.
Change-Id:
Patch Set 5:
(1 comment)
Please use bits.h in both files.
https://gerrit.osmocom.org/#/c/4915/5/tests/gtp/gtpie_test.c
File tests/gtp/gtpie_test.c:
Line 11: #include
Weird. I'm sure I've seen bits.h used in here before.
--
To view, visit https://gerrit.osmocom.org/4915
To unsubscribe,
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/4987
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf6304d23585f2ed45e050fa27c787f2d66fd3f7
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5016
to look at the new patch set (#2).
Improve get_rate_ctr() error handling
Report back expected interval values.
Change-Id: I05ca7f716342af4f7424b28216ed6c1bf2bd589f
Related: OS#2550
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/5014
to look at the new patch set (#3).
Update rate_ctr description
* use example new counter names with ':' separator
* mention that 'counter' is obsolete
* mention group
1 - 100 of 116 matches
Mail list logo
