Change in osmo-trx[master]: sigProcLib: introduce both TS1 and TS2 RACH synch. sequences

2018-10-21 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/11390 ) Change subject: sigProcLib: introduce both TS1 and TS2 RACH synch. sequences .. Set Ready For Review -- To view, visit

Change in osmo-trx[master]: VTY: add extended (11-bit) RACH detection toggle

2018-10-21 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11423 Change subject: VTY: add extended (11-bit) RACH detection toggle .. VTY: add extended (11-bit) RACH detection toggle Since

Change in osmo-trx[master]: sigProcLib: add a CorrType for extended (11-bit) RACH

2018-10-21 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/11422 Change subject: sigProcLib: add a CorrType for extended (11-bit) RACH .. sigProcLib: add a CorrType for extended (11-bit) RACH This is a

Build failed in Jenkins: master-asn1c ยป a1=default,a2=default,a3=default,osmocom-master-debian9 #283

2018-10-21 Thread jenkins
See -- [...truncated 3.67 KB...] + ./configure checking build system type... x86_64-unknown-linux-gnu checking host

Change in libosmo-sccp[master]: build: move include/{mtp, sccp} to include/osmocom/

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11120 ) Change subject: build: move include/{mtp,sccp} to include/osmocom/ .. build: move include/{mtp,sccp} to include/osmocom/ Anywhere

Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. libosmogsm/gsup.c: fix error code in osmo_gsup_encode()

Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. Patch Set 2: Code-Review+2 -- To view, visit

Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()

2018-10-21 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() .. Patch Set 2: We can use __attribute__((warn_unused_result)) to force

Change in libosmocore[master]: libosmogsm/gsup.c: fix error code in osmo_gsup_encode()

2018-10-21 Thread Vadim Yanitskiy
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11325 to look at the new patch set (#2). Change subject: libosmogsm/gsup.c: fix error code in osmo_gsup_encode() ..

Change in osmo-sgsn[master]: gtphub: Add --version cmdline option

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11385 ) Change subject: gtphub: Add --version cmdline option .. gtphub: Add --version cmdline option Related: OS#3576 Change-Id:

Change in osmo-sgsn[master]: gtphub: Add --version cmdline option

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11385 ) Change subject: gtphub: Add --version cmdline option .. Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11385 To

Change in osmo-sgsn[master]: gtphub: Add --version cmdline option

2018-10-21 Thread Harald Welte
Harald Welte has uploaded a new patch set (#2) to the change originally created by osmith. ( https://gerrit.osmocom.org/11385 ) Change subject: gtphub: Add --version cmdline option .. gtphub: Add --version cmdline option

Change in simtrace2[master]: remsim: fix TPDU response size transmission

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11362 ) Change subject: remsim: fix TPDU response size transmission .. remsim: fix TPDU response size transmission the TDPU response data

Change in libosmocore[master]: SGsAP protocol definitions (header + C file)

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11412 ) Change subject: SGsAP protocol definitions (header + C file) .. SGsAP protocol definitions (header + C file) Change-Id:

Change in libosmo-sccp[master]: build: move include/{mtp, sccp} to include/osmocom/

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11120 ) Change subject: build: move include/{mtp,sccp} to include/osmocom/ .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: handover_decision_2.c: implement HO to remote BSS

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11321 ) Change subject: handover_decision_2.c: implement HO to remote BSS .. handover_decision_2.c: implement HO to remote BSS Implement

Change in osmo-bsc[master]: handover_decision_2.c: implement HO to remote BSS

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11321 ) Change subject: handover_decision_2.c: implement HO to remote BSS .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: handover_decision_2.c: refactor trigger_*()

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11320 ) Change subject: handover_decision_2.c: refactor trigger_*() .. handover_decision_2.c: refactor trigger_*() a) Prepare for

Change in osmo-bsc[master]: handover_decision_2.c: refactor trigger_*()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11320 ) Change subject: handover_decision_2.c: refactor trigger_*() .. Patch Set 4: Code-Review+2 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix: don't overwrite the expected meas results

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11228 ) Change subject: BTS_Tests.ttcn: fix: don't overwrite the expected meas results .. BTS_Tests.ttcn: fix: don't overwrite the expected

Change in simtrace2[master]: remsim: update copyright

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11360 ) Change subject: remsim: update copyright .. remsim: update copyright Change-Id: Ibcf093877ee53f8446c97bfa50c8370ceda24c53 --- M

Change in osmo-hlr[master]: fix and re-enable osmo_hlr_subscriber_update_notify()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11233 ) Change subject: fix and re-enable osmo_hlr_subscriber_update_notify() .. Patch Set 6: Code-Review+2 -- To view, visit

Change in simtrace2[master]: remsim: add already parsed USB path argument info

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11359 ) Change subject: remsim: add already parsed USB path argument info .. remsim: add already parsed USB path argument info Change-Id:

Change in osmo-hlr[master]: Store identity of VLR/SGSN in UpdateLocation

2018-10-21 Thread Harald Welte
Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/9723 ) Change subject: Store identity of VLR/SGSN in UpdateLocation .. Abandoned -- To view, visit https://gerrit.osmocom.org/9723 To unsubscribe, or for help

Change in osmo-hlr[master]: fix and re-enable osmo_hlr_subscriber_update_notify()

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11233 ) Change subject: fix and re-enable osmo_hlr_subscriber_update_notify() .. fix and re-enable osmo_hlr_subscriber_update_notify() Send

Change in osmo-sgsn[master]: Add --version cmdline option

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11385 ) Change subject: Add --version cmdline option .. Patch Set 1: Code-Review+1 the commit log mesage should state to *what* it's adding the

Change in osmo-sip-connector[master]: Add --version cmdline option

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11384 ) Change subject: Add --version cmdline option .. Add --version cmdline option Related: OS#3577 Change-Id:

Change in osmo-sip-connector[master]: Add --version cmdline option

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11384 ) Change subject: Add --version cmdline option .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11384 To

Change in docker-playground[master]: rename m3ua-test, sua-test to nplab-*-test

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11368 ) Change subject: rename m3ua-test, sua-test to nplab-*-test .. Patch Set 4: Code-Review+2 -- To view, visit

Change in libosmocore[master]: gsm_08_58.h: Introduce struct abis_rsl_chan_nr

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11303 ) Change subject: gsm_08_58.h: Introduce struct abis_rsl_chan_nr .. gsm_08_58.h: Introduce struct abis_rsl_chan_nr It will allow to

Change in osmo-trx[master]: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11390 ) Change subject: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-trx[master]: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11390 ) Change subject: sigProcLib: also detect both TS1 and TS2 RACH synch. sequences .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: SGsAP protocol definitions (header + C file)

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11412 ) Change subject: SGsAP protocol definitions (header + C file) .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/11412 To

Change in libosmocore[master]: SGsAP protocol definitions (header + C file)

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11412 ) Change subject: SGsAP protocol definitions (header + C file) .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11407 ) Change subject: ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing .. ipaccess-proxy: Add error handling to IAP CCM ID

Change in osmo-bsc[master]: acc_ramp: An unsigned int is always >= 0

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11408 ) Change subject: acc_ramp: An unsigned int is always >= 0 .. acc_ramp: An unsigned int is always >= 0 Change-Id:

Change in osmo-bsc[master]: bssmap_handle_cipher_mode(): Don't sent reject if !conn

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11420 ) Change subject: bssmap_handle_cipher_mode(): Don't sent reject if !conn .. bssmap_handle_cipher_mode(): Don't sent reject if !conn

Change in osmo-bsc[master]: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11409 ) Change subject: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC .. subscr_conn_fsm: Fix null-pointer deref

Change in osmo-bsc[master]: ipaccess-config: Fix open() return value checking

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11421 ) Change subject: ipaccess-config: Fix open() return value checking .. ipaccess-config: Fix open() return value checking open()

Change in libosmocore[master]: libosmogsm/gsup.c: assert message type in osmo_gsup_encode()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11325 ) Change subject: libosmogsm/gsup.c: assert message type in osmo_gsup_encode() .. Patch Set 1: It's debatable. -ENOMEM for sure is an odd

Change in docker-playground[master]: osmo-*-latest: s/nightly/latest/g in Dockerfile

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11364 ) Change subject: osmo-*-latest: s/nightly/latest/g in Dockerfile .. Patch Set 1: this repository has no job that can set the "verified"

Change in docker-playground[master]: Remove top-level Makefile

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11369 ) Change subject: Remove top-level Makefile .. Patch Set 4: Verified+1 -- To view, visit https://gerrit.osmocom.org/11369 To unsubscribe, or

Change in osmo-bsc[master]: gsm_08_08: do not include zero length speech codec list.

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11388 ) Change subject: gsm_08_08: do not include zero length speech codec list. .. gsm_08_08: do not include zero length speech codec list.

Change in libosmocore[master]: telnet_interface: avoid double-close of fd()

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11416 ) Change subject: telnet_interface: avoid double-close of fd() .. telnet_interface: avoid double-close of fd() Change-Id:

Change in osmo-bsc[master]: handover_start_inter_bsc_in(): Uninitialized variable

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11398 ) Change subject: handover_start_inter_bsc_in(): Uninitialized variable .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: handover_start_inter_bsc_in(): Uninitialized variable

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11398 ) Change subject: handover_start_inter_bsc_in(): Uninitialized variable .. handover_start_inter_bsc_in(): Uninitialized variable This

Change in osmo-bsc[master]: range_enc_determine_range(): Don't dereference array on size=0

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11397 ) Change subject: range_enc_determine_range(): Don't dereference array on size=0 .. range_enc_determine_range(): Don't dereference

Change in libosmocore[master]: vty.c: Set vty->fd to -1 after closing the FD

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11417 ) Change subject: vty.c: Set vty->fd to -1 after closing the FD .. vty.c: Set vty->fd to -1 after closing the FD Change-Id:

Change in libosmocore[master]: timerfd_create(): Fix error handling of osmo_fd_register()

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11413 ) Change subject: timerfd_create(): Fix error handling of osmo_fd_register() .. timerfd_create(): Fix error handling of

Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11414 ) Change subject: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin() .. gsm0407_is_duplicate(): Handle error ret of

Change in osmo-trx[master]: trx_validate_config(): Fix validation of rx_sps

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11406 ) Change subject: trx_validate_config(): Fix validation of rx_sps .. trx_validate_config(): Fix validation of rx_sps Change-Id:

Change in osmo-pcu[master]: gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11401 ) Change subject: gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv .. gprs_rlcmac_received_lost(): Fix regression /

Change in osmo-pcu[master]: gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11401 ) Change subject: gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11414 ) Change subject: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: trx_validate_config(): Fix validation of rx_sps

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11406 ) Change subject: trx_validate_config(): Fix validation of rx_sps .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: trx_validate_config(): Fix validation of rx_sps

2018-10-21 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11406 to look at the new patch set (#2). Change subject: trx_validate_config(): Fix validation of rx_sps ..

Change in osmo-trx[master]: SocketsTest.testReaderIP(): Zero terminate received buffer

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11405 ) Change subject: SocketsTest.testReaderIP(): Zero terminate received buffer .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: SocketsTest.testReaderIP(): Zero terminate received buffer

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11405 ) Change subject: SocketsTest.testReaderIP(): Zero terminate received buffer .. SocketsTest.testReaderIP(): Zero terminate received

Change in osmo-bts[master]: scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11415 ) Change subject: scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0 .. scheduler_trx.c: Switch to osmo_timerfd() of

Change in osmo-bts[master]: scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11415 ) Change subject: scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: timerfd_create(): Fix error handling of osmo_fd_register()

2018-10-21 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/11413 to look at the new patch set (#3). Change subject: timerfd_create(): Fix error handling of osmo_fd_register() ..

Change in libosmocore[master]: timerfd_create(): Fix error handling of osmo_fd_register()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11413 ) Change subject: timerfd_create(): Fix error handling of osmo_fd_register() .. Patch Set 3: Code-Review+2 -- To view, visit

Change in libosmocore[master]: vty.c: Set vty->fd to -1 after closing the FD

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11417 ) Change subject: vty.c: Set vty->fd to -1 after closing the FD .. Patch Set 1: Code-Review+2 -- To view, visit

Change in libosmocore[master]: telnet_interface: avoid double-close of fd()

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11416 ) Change subject: telnet_interface: avoid double-close of fd() .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ggsn[master]: sgsnemu: Fix printing of tun device name

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11418 ) Change subject: sgsnemu: Fix printing of tun device name .. sgsnemu: Fix printing of tun device name Change-Id:

Change in osmo-ggsn[master]: sgsnemu: Fix printing of tun device name

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11418 ) Change subject: sgsnemu: Fix printing of tun device name .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11418

Change in osmo-bsc[master]: ipaccess-config: Fix open() return value checking

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11421 ) Change subject: ipaccess-config: Fix open() return value checking .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ggsn[master]: ippool.c: Use "%td" format string for ptrdiff_t

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11419 ) Change subject: ippool.c: Use "%td" format string for ptrdiff_t .. ippool.c: Use "%td" format string for ptrdiff_t Change-Id:

Change in osmo-ggsn[master]: ippool.c: Use "%td" format string for ptrdiff_t

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11419 ) Change subject: ippool.c: Use "%td" format string for ptrdiff_t .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: bssmap_handle_cipher_mode(): Don't sent reject if !conn

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11420 ) Change subject: bssmap_handle_cipher_mode(): Don't sent reject if !conn .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: range_enc_determine_range(): Don't dereference array on size=0

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11397 ) Change subject: range_enc_determine_range(): Don't dereference array on size=0 .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11407 ) Change subject: ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-bsc[master]: acc_ramp: An unsigned int is always >= 0

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11408 ) Change subject: acc_ramp: An unsigned int is always >= 0 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/11408

Change in osmo-bsc[master]: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11409 ) Change subject: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: check_rtp_origin(): Avoid using memcmp for comparing integer types

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11403 ) Change subject: check_rtp_origin(): Avoid using memcmp for comparing integer types .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-mgw[master]: check_rtp_origin(): Don't memcmp sockadd_in and in_addr

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11402 ) Change subject: check_rtp_origin(): Don't memcmp sockadd_in and in_addr .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-iuh[master]: hnbgw_tx_hnb_register_rej(): Missing return statement

2018-10-21 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11400 ) Change subject: hnbgw_tx_hnb_register_rej(): Missing return statement .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-ggsn[master]: sgsnemu: Use in46a_from_eua() with array of in46_addr

2018-10-21 Thread Harald Welte
Harald Welte has abandoned this change. ( https://gerrit.osmocom.org/11404 ) Change subject: sgsnemu: Use in46a_from_eua() with array of in46_addr .. Abandoned -- To view, visit https://gerrit.osmocom.org/11404 To unsubscribe,

Change in osmo-iuh[master]: hnbgw_tx_hnb_register_rej(): Missing return statement

2018-10-21 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/11400 ) Change subject: hnbgw_tx_hnb_register_rej(): Missing return statement .. hnbgw_tx_hnb_register_rej(): Missing return statement

Change in osmo-bsc[master]: bssmap_handle_cipher_mode(): Don't sent reject if !conn

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11420 Change subject: bssmap_handle_cipher_mode(): Don't sent reject if !conn .. bssmap_handle_cipher_mode(): Don't sent reject if !conn We can

Change in osmo-bsc[master]: ipaccess-config: Fix open() return value checking

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11421 Change subject: ipaccess-config: Fix open() return value checking .. ipaccess-config: Fix open() return value checking open() returning 0 is

Change in osmo-ggsn[master]: sgsnemu: Fix printing of tun device name

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11418 Change subject: sgsnemu: Fix printing of tun device name .. sgsnemu: Fix printing of tun device name Change-Id:

Change in osmo-ggsn[master]: ippool.c: Use "%td" format string for ptrdiff_t

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11419 Change subject: ippool.c: Use "%td" format string for ptrdiff_t .. ippool.c: Use "%td" format string for ptrdiff_t Change-Id:

Change in libosmocore[master]: telnet_interface: avoid double-close of fd()

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11416 Change subject: telnet_interface: avoid double-close of fd() .. telnet_interface: avoid double-close of fd() Change-Id:

Change in libosmocore[master]: vty.c: Set vty->fd to -1 after closing the FD

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11417 Change subject: vty.c: Set vty->fd to -1 after closing the FD .. vty.c: Set vty->fd to -1 after closing the FD Change-Id:

Change in osmo-bts[master]: scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11415 Change subject: scheduler_trx.c: Switch to osmo_timerfd() of libosmocore >= 0.12.0 .. scheduler_trx.c: Switch to osmo_timerfd() of

Change in osmo-msc[master]: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin()

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11414 Change subject: gsm0407_is_duplicate(): Handle error ret of gsm0407_pdisc_ctr_bin() .. gsm0407_is_duplicate(): Handle error ret of

Change in libosmocore[master]: gsm23003: Add MME domain name related helper functions

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11411 Change subject: gsm23003: Add MME domain name related helper functions .. gsm23003: Add MME domain name related helper functions

Change in libosmocore[master]: timerfd_create(): Fix error handling of osmo_fd_register()

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11413 Change subject: timerfd_create(): Fix error handling of osmo_fd_register() .. timerfd_create(): Fix error handling of osmo_fd_register()

Change in libosmocore[master]: WIP: gsm_412 Cell Broadcast

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11410 Change subject: WIP: gsm_412 Cell Broadcast .. WIP: gsm_412 Cell Broadcast Change-Id: I1a17c2ae8bf62150327956c10cb5bb896939e3fd --- M

Change in libosmocore[master]: SGsAP protocol definitions (header + C file)

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11412 Change subject: SGsAP protocol definitions (header + C file) .. SGsAP protocol definitions (header + C file) Change-Id:

Change in osmo-bsc[master]: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11409 Change subject: subscr_conn_fsm: Fix null-pointer deref / N-CONNECT.ind from unknown MSC .. subscr_conn_fsm: Fix null-pointer deref /

Change in osmo-bsc[master]: ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11407 Change subject: ipaccess-proxy: Add error handling to IAP CCM ID RESP parsing .. ipaccess-proxy: Add error handling to IAP CCM ID RESP

Change in osmo-bsc[master]: acc_ramp: An unsigned int is always >= 0

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11408 Change subject: acc_ramp: An unsigned int is always >= 0 .. acc_ramp: An unsigned int is always >= 0 Change-Id:

Change in osmo-trx[master]: SocketsTest.testReaderIP(): Zero terminate received buffer

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11405 Change subject: SocketsTest.testReaderIP(): Zero terminate received buffer .. SocketsTest.testReaderIP(): Zero terminate received buffer

Change in osmo-trx[master]: trx_validate_config(): Fix validation of rx_sps

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11406 Change subject: trx_validate_config(): Fix validation of rx_sps .. trx_validate_config(): Fix validation of rx_sps Change-Id:

Change in osmo-ggsn[master]: sgsnemu: Use in46a_from_eua() with array of in46_addr

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11404 Change subject: sgsnemu: Use in46a_from_eua() with array of in46_addr .. sgsnemu: Use in46a_from_eua() with array of in46_addr Change-Id:

Change in osmo-mgw[master]: check_rtp_origin(): Avoid using memcmp for comparing integer types

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11403 Change subject: check_rtp_origin(): Avoid using memcmp for comparing integer types .. check_rtp_origin(): Avoid using memcmp for comparing

Change in osmo-mgw[master]: check_rtp_origin(): Don't memcmp sockadd_in and in_addr

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11402 Change subject: check_rtp_origin(): Don't memcmp sockadd_in and in_addr .. check_rtp_origin(): Don't memcmp sockadd_in and in_addr We were

Change in osmo-pcu[master]: gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv

2018-10-21 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/11401 Change subject: gprs_rlcmac_received_lost(): Fix regression / uninitialized now_tv .. gprs_rlcmac_received_lost(): Fix regression /

  1   2   >