Change in osmo-pcu[master]: MCS: add Channel Coding Command encoder

2019-03-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13215 ) Change subject: MCS: add Channel Coding Command encoder .. Patch Set 6: (1 comment)

Change in osmo-pcu[master]: MCS: add mcs_is_*() helpers

2019-03-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13214 ) Change subject: MCS: add mcs_is_*() helpers .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13214 To

Change in osmo-pcu[master]: cosmetic: use const pointer for bts_data

2019-03-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12246 ) Change subject: cosmetic: use const pointer for bts_data .. Patch Set 3: (1 comment)

Change in osmo-pcu[master]: vty: add commands to show TBF of a certain kind

2019-03-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/6239 ) Change subject: vty: add commands to show TBF of a certain kind .. Patch Set 6: Code-Review+1 -- To view, visit

Change in osmo-ttcn3-hacks[master]: BSC_Tests: execute S15-S0 related tests only on AoIP

2019-03-26 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/13424 Change subject: BSC_Tests: execute S15-S0 related tests only on AoIP .. BSC_Tests: execute S15-S0 related tests only on AoIP Make sure that the

Change in osmo-bts[master]: contrib: Remove deprecated screen script helpers

2019-03-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13423 Change subject: contrib: Remove deprecated screen script helpers .. contrib: Remove deprecated screen script helpers Nowadays only known

Change in osmo-bsc[master]: nanobts: use libosmocore's osmo_store*() for OML attr. patching

2019-03-26 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13418 ) Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching .. Patch Set 1: (2 comments)

Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13057 ) Change subject: Use boolean for DL resegmentation parameter .. Patch Set 8: (1 comment) https://gerrit.osmocom.org/#/c/13057/8/src/pcu_main.cpp

Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13057 ) Change subject: Use boolean for DL resegmentation parameter .. Patch Set 8: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13057 To

Change in osmo-pcu[master]: Add ARQ type helpers

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13406 ) Change subject: Add ARQ type helpers .. Patch Set 3: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/13406/3/src/coding_scheme.c File

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 7: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13415 To

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 6: (1 comment)

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
Hello Pau Espin Pedrol, Max, Harald Welte, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13415 to look at the new patch set (#7). Change subject: Add osmocom-build-old-tags-against-master.sh

Change in libosmocore[master]: BSSGP: use variable for NSEI

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13204 ) Change subject: BSSGP: use variable for NSEI .. Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/13204/3/src/gb/gprs_bssgp.c File

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13421 ) Change subject: Add vty option to globally enable LCLS .. Patch Set 5: This change is ready for review. -- To view, visit

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 6: (1 comment) Btw, is there stable URL which could use instead of

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 6: Code-Review+1 Neat. Now it's rather obvious that we should make OsmoSGSN

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 6: > Looking at other FOSS projects, it seems likely that eventually

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 6: (2 comments) > I think the entire test should not stop/fail if one

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
Hello Pau Espin Pedrol, Max, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13415 to look at the new patch set (#6). Change subject: Add osmocom-build-old-tags-against-master.sh .. Add

Change in python/osmo-python-tests[master]: deb: fix wrong changelog date

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/12487 ) Change subject: deb: fix wrong changelog date .. Patch Set 3: Code-Review+1 checked with a calendar this time, this is a valid date ;) -- To

Change in osmo-msc[master]: Autofill LCLS parameters for A-interface transactions

2019-03-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13422 Change subject: Autofill LCLS parameters for A-interface transactions .. Autofill LCLS parameters for A-interface transactions That's experimental

Change in openbsc[master]: Drop Iu*S support and related dependencies

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13417 ) Change subject: Drop Iu*S support and related dependencies .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13417 To

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13421 ) Change subject: Add vty option to globally enable LCLS .. Patch Set 2: This change is ready for review. -- To view, visit

Change in osmo-bsc[master]: Use osmo_lcls instead of anonymous struct

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13419 ) Change subject: Use osmo_lcls instead of anonymous struct .. Patch Set 1: This change is ready for review. -- To view, visit

Change in osmo-msc[master]: Log protocol for which transaction is allocated

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13420 ) Change subject: Log protocol for which transaction is allocated .. Patch Set 2: This change is ready for review. -- To view, visit

Change in osmo-msc[master]: Add vty option to globally enable LCLS

2019-03-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13421 Change subject: Add vty option to globally enable LCLS .. Add vty option to globally enable LCLS It's disabled by default and will be used in

Change in osmo-msc[master]: Log protocol for which transaction is allocated

2019-03-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13420 Change subject: Log protocol for which transaction is allocated .. Log protocol for which transaction is allocated Change-Id:

Change in osmo-pcu[master]: cosmetic: use const pointer for bts_data

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12246 ) Change subject: cosmetic: use const pointer for bts_data .. Patch Set 3: This change is ready for review. -- To view, visit

Change in osmo-bsc[master]: Use osmo_lcls instead of anonymous struct

2019-03-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13419 Change subject: Use osmo_lcls instead of anonymous struct .. Use osmo_lcls instead of anonymous struct This allows us to (re)use code from libosmocore

Change in osmo-pcu[master]: vty: add commands to show TBF of a certain kind

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/6239 ) Change subject: vty: add commands to show TBF of a certain kind .. Patch Set 6: (1 comment) Doh! Somehow lost it during patch rebase before

Change in osmo-pcu[master]: TS alloc: expand tests log

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/3895 ) Change subject: TS alloc: expand tests log .. Patch Set 28: (1 comment) Should have replied year ago but thanks to underwhelming pace of OsmoPCU

Change in osmo-pcu[master]: Add test for MS mode and (M)CS settings

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13164 ) Change subject: Add test for MS mode and (M)CS settings .. Patch Set 3: This change is ready for review. -- To view, visit

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 5: (1 comment) Looking at other FOSS projects, it seems likely that

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 5: (1 comment) I think the entire test should not stop/fail if one

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 5: > osmo-sgsn (no tags configured) So it was manually disabled

Change in osmo-pcu[master]: Use boolean for DL resegmentation parameter

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13057 ) Change subject: Use boolean for DL resegmentation parameter .. Patch Set 8: This change is ready for review. -- To view, visit

Change in osmo-pcu[master]: oc2g: Change log type (Litecell15->Oc2g)

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13362 ) Change subject: oc2g: Change log type (Litecell15->Oc2g) .. Patch Set 2: > I want to keep the commit from others unchanged as much as a can - even if

Change in osmo-pcu[master]: Add ARQ type helpers

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13406 ) Change subject: Add ARQ type helpers .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/13406 To

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13319 ) Change subject: a_iface_bssap: add context information to log output .. Patch Set 5: Code-Review+1 -- To view, visit

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 5: Failing tags disabled, it runs through now:

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/13415 To

Change in libosmocore[master]: BSSGP: use variable for NSEI

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13204 ) Change subject: BSSGP: use variable for NSEI .. Patch Set 3: (1 comment) This change is ready for review.

Change in python/osmo-python-tests[master]: deb: fix wrong changelog date

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/12487 ) Change subject: deb: fix wrong changelog date .. Patch Set 3: This change is ready for review. -- To view, visit https://gerrit.osmocom.org/12487

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-03-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13319 to look at the new patch set (#5). Change subject: a_iface_bssap: add context information to log output ..

Change in osmo-msc[master]: a_iface_bssap: add context information to log output

2019-03-26 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13319 to look at the new patch set (#4). Change subject: a_iface_bssap: add context information to log output ..

Change in osmo-ci[master]: jobs: add osmocom-build-tags-against-master.yml

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13416 ) Change subject: jobs: add osmocom-build-tags-against-master.yml .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13416 To

Change in osmo-ci[master]: jobs: add osmocom-build-tags-against-master.yml

2019-03-26 Thread osmith
Hello Pau Espin Pedrol, Max, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13416 to look at the new patch set (#4). Change subject: jobs: add osmocom-build-tags-against-master.yml .. jobs:

Change in osmo-bsc[master]: nanobts: use libosmocore's osmo_store*() for OML attr. patching

2019-03-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13418 Change subject: nanobts: use libosmocore's osmo_store*() for OML attr. patching .. nanobts: use libosmocore's osmo_store*() for OML attr. patching

Change in osmo-ci[master]: jobs: add osmocom-build-tags-against-master.yml

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13416 ) Change subject: jobs: add osmocom-build-tags-against-master.yml .. Patch Set 2: (1 comment)

Change in osmo-ci[master]: osmo-build-dep.sh: cd into subdir before building

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13413 ) Change subject: osmo-build-dep.sh: cd into subdir before building .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13413

Change in osmo-ci[master]: osmo-build-dep.sh: run 'make check' when CHECK=1

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13414 ) Change subject: osmo-build-dep.sh: run 'make check' when CHECK=1 .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13414 To

Change in osmo-ci[master]: osmocom-list-commits.sh: move functions to common.sh

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13412 ) Change subject: osmocom-list-commits.sh: move functions to common.sh .. Patch Set 1: Code-Review+1 -- To view, visit

Change in openbsc[master]: Drop Iu*S support and related dependencies

2019-03-26 Thread Max
Max has uploaded this change for review. ( https://gerrit.osmocom.org/13417 Change subject: Drop Iu*S support and related dependencies .. Drop Iu*S support and related dependencies There's optional libiu for Iu*S support but

Change in pysim[master]: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT an...

2019-03-26 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13340 ) Change subject: cards: sysmo-usim-sjs1: add programming of EF.PLMNsel, EF.PLMNwAcT and EF.OPLMNwAcT .. Patch Set 3: (1 comment) > Patch Set 3:

Change in osmo-ci[master]: jobs: add osmocom-build-tags-against-master.yml

2019-03-26 Thread osmith
Hello Pau Espin Pedrol, Max, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13416 to look at the new patch set (#2). Change subject: jobs: add osmocom-build-tags-against-master.yml .. jobs:

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
Hello Pau Espin Pedrol, Max, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13415 to look at the new patch set (#2). Change subject: Add osmocom-build-old-tags-against-master.sh .. Add

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13415 ) Change subject: Add osmocom-build-old-tags-against-master.sh .. Patch Set 1: Here's how the output looks like:

Change in osmo-ci[master]: osmocom-list-commits.sh: move functions to common.sh

2019-03-26 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13412 Change subject: osmocom-list-commits.sh: move functions to common.sh .. osmocom-list-commits.sh: move functions to common.sh Prepare for the

Change in osmo-ci[master]: osmo-build-dep.sh: run 'make check' when CHECK=1

2019-03-26 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13414 Change subject: osmo-build-dep.sh: run 'make check' when CHECK=1 .. osmo-build-dep.sh: run 'make check' when CHECK=1 Prepare for

Change in osmo-ci[master]: jobs: add osmocom-build-tags-against-master.yml

2019-03-26 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13416 Change subject: jobs: add osmocom-build-tags-against-master.yml .. jobs: add osmocom-build-tags-against-master.yml Run

Change in osmo-ci[master]: osmo-build-dep.sh: cd into subdir before building

2019-03-26 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13413 Change subject: osmo-build-dep.sh: cd into subdir before building .. osmo-build-dep.sh: cd into subdir before building Support building the legacy

Change in osmo-ci[master]: Add osmocom-build-old-tags-against-master.sh

2019-03-26 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13415 Change subject: Add osmocom-build-old-tags-against-master.sh .. Add osmocom-build-old-tags-against-master.sh Build old releases of Osmocom programs

Change in openbsc[master]: Drop openggsn from build dependencies

2019-03-26 Thread Max
Max has submitted this change and it was merged. ( https://gerrit.osmocom.org/13345 ) Change subject: Drop openggsn from build dependencies .. Drop openggsn from build dependencies We don't have SGSN-related code here anymore

Change in openbsc[master]: Drop openggsn from build dependencies

2019-03-26 Thread Max
Max has posted comments on this change. ( https://gerrit.osmocom.org/13345 ) Change subject: Drop openggsn from build dependencies .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13345 To

Change in osmo-pcu[master]: Include pdch.h in bts.h even if we're not compiling C++

2019-03-26 Thread Daniel Willmann
Daniel Willmann has submitted this change and it was merged. ( https://gerrit.osmocom.org/13361 ) Change subject: Include pdch.h in bts.h even if we're not compiling C++ .. Include pdch.h in bts.h even if we're not compiling

Change in osmo-pcu[master]: Fix Channel Coding Command for MCS

2019-03-26 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13216 ) Change subject: Fix Channel Coding Command for MCS .. Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13216 To

Change in pysim[master]: commands: correct case of a TLV tag (A5 => a5)

2019-03-26 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13339 ) Change subject: commands: correct case of a TLV tag (A5 => a5) .. commands: correct case of a TLV tag (A5 => a5) The hexadecimal tag