Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14632 ) Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts .. Patch Set 3: Code-Review+1 -- To view, visi

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Patch Set 1: (2 comments) Do we have osmo_select_loop

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 1: > I'm not quite sure this (like many o

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Patch Set 1: Code-Review+1

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Patch Set 1: Code-Review+1 -- To view, visit http

Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.o

Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct .. Patch Set 4: Code-Review+1 -- To view, visit htt

Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 ) Change subject: Transceiver: Support SETFORMAT command .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/146

Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 ) Change subject: Logger: global Log mutex is now available from C code .. Patch Set 1: Code-Review+1 why do we have a log mutex in th

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 ) Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Patch Set 1: Code-Review+1 I understand that the old c

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 ) Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Patch Set 1: Code-Review+1 tbh, I'm not quite sure

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 ) Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Patch Set 1: Code-Review+1 -- To view, visit https://ge

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 ) Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Patch Set 1: Code-Review+1 -- To view, visit http

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 ) Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Patch Set 1: Code-Review+1

Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 ) Change subject: Transceiver: Drop unused rssi_valid struct field .. Patch Set 2: Code-Review+1 are the nbits related changes suppose

Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct .. Patch Set 4: Code-Review+1 -- To view, visit htt

Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

2019-07-01 Thread laforge
laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets .. Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org

Build failure of network:osmocom:nightly/osmo-sgsn in Raspbian_9.0/armv7l

2019-07-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-sgsn/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-sgsn failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-sgsn Last lines of build

Build failure of network:osmocom:nightly/osmo-msc in Raspbian_9.0/armv7l

2019-07-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-msc/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-msc failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-msc Last lines of build log

Build failure of network:osmocom:nightly/osmo-bts in Raspbian_9.0/armv7l

2019-07-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bts/Raspbian_9.0/armv7l Package network:osmocom:nightly/osmo-bts failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly osmo-bts Last lines of build log

Build failure of network:osmocom:nightly/libosmocore in Raspbian_9.0/armv7l

2019-07-01 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Raspbian_9.0/armv7l Package network:osmocom:nightly/libosmocore failed to build in Raspbian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmocore Last lines of

Change in ...osmo-trx[master]: Transceiver: replace UDPSocket with libosmocore socket API

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14644 Change subject: Transceiver: replace UDPSocket with libosmocore socket API .. Transceiver: replace UDPSocket with libosmocore socket AP

Change in ...osmo-trx[master]: Transceiver: Support SETFORMAT command

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14646 Change subject: Transceiver: Support SETFORMAT command .. Transceiver: Support SETFORMAT command Only old v0 is supported so far. TRXD

Change in ...osmo-trx[master]: Transceiver: Move soft bits normalization to pullRadioVector()

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14641 Change subject: Transceiver: Move soft bits normalization to pullRadioVector() .. Transceiver: Move soft bits normalization to pullRadi

Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts

2019-07-01 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 to look at the new patch set (#3). Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts .

Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

2019-07-01 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets .. Patch Set 4: This change is ready for review. -- To view, visit https:/

Change in ...osmo-trx[master]: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14643 Change subject: Transceiver: Get rid of SoftVector in struct trx_ul_burst_ind .. Transceiver: Get rid of SoftVector in struct trx_ul_bu

Change in ...osmo-trx[master]: Logger: global Log mutex is now available from C code

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14645 Change subject: Logger: global Log mutex is now available from C code .. Logger: global Log mutex is now available from C code This wa

Change in ...osmo-trx[master]: Transceiver: Move calculation of normalized values (rssiOffset) to pu...

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14640 Change subject: Transceiver: Move calculation of normalized values (rssiOffset) to pullRadioVector() .. Transceiver: Move calculation

Change in ...osmo-trx[master]: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14642 Change subject: Transceiver: Drop use of GSM::Time from trx_ul_burst_ind .. Transceiver: Drop use of GSM::Time from trx_ul_burst_ind U

Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field

2019-07-01 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14639 to look at the new patch set (#2). Change subject: Transceiver: Drop unused rssi_valid struct field .. T

Change in ...osmo-mgw[master]: mgw: Support receiving lowercase LCO codec

2019-07-01 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/14596 ) Change subject: mgw: Support receiving lowercase LCO codec .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.or

Change in ...osmo-ttcn3-hacks[master]: cosmetic: bsc: Document timer timing out in f_tc_ho_out_fail_no_ho_de...

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14606 ) Change subject: cosmetic: bsc: Document timer timing out in f_tc_ho_out_fail_no_ho_detect .. cosmetic: bsc: Document

Change in ...osmo-ggsn[master]: configure.ac: Replace obosolete macro AC_CANONICAL_SYSTEM

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14621 ) Change subject: configure.ac: Replace obosolete macro AC_CANONICAL_SYSTEM .. configure.ac: Replace obosolete macro AC_CANONIC

Change in ...osmo-ggsn[master]: ggsn: Use structures instead of raw arrays when parsing ipcp_hdr

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14620 ) Change subject: ggsn: Use structures instead of raw arrays when parsing ipcp_hdr .. ggsn: Use structures instead of raw array

Change in ...osmo-ggsn[master]: ggsn: Avoid unaligned mem access reading PCO proto id

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14619 ) Change subject: ggsn: Avoid unaligned mem access reading PCO proto id .. ggsn: Avoid unaligned mem access reading PCO proto i

Change in ...osmo-ggsn[master]: ggsn: More logging from PCO handling (e.g. in case of malconfiguration)

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13609 ) Change subject: ggsn: More logging from PCO handling (e.g. in case of malconfiguration) .. ggsn: More logging from PCO handl

Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support .. ggsn: Add minimalistic PAP support Some modems are configured to use P

Change in ...osmo-ggsn[master]: configure.ac: Use brackets in AC_INIT params

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14622 ) Change subject: configure.ac: Use brackets in AC_INIT params .. configure.ac: Use brackets in AC_INIT params Change applied

Change in ...osmo-ggsn[master]: configure.ac: some versions of linux/if.h require including sys/socket.h

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 ) Change subject: configure.ac: some versions of linux/if.h require including sys/socket.h .. configure.ac: some versions of l

Change in ...osmo-ggsn[master]: configure.ac: Use prefered AC_CONFIG_HEADERS over AM_CONFIG_HEADER

2019-07-01 Thread pespin
pespin has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14623 ) Change subject: configure.ac: Use prefered AC_CONFIG_HEADERS over AM_CONFIG_HEADER .. configure.ac: Use prefered AC_CONFIG_H

Change in ...osmo-ggsn[master]: configure.ac: some versions of linux/if.h require including sys/socket.h

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 ) Change subject: configure.ac: some versions of linux/if.h require including sys/socket.h .. Patch Set 2: Verified+1 Code-Review+2

Change in ...osmo-ggsn[master]: configure.ac: some versions of linux/if.h require including sys/socket.h

2019-07-01 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/14624 ) Change subject: configure.ac: some versions of linux/if.h require including sys/socket.h .. Patch Set 2: This change is ready for r

Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/os

Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-07-01 Thread pespin
pespin has uploaded a new patch set (#6) to the change originally created by laforge. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support .. ggsn: Add minimalistic PAP support S

Change in ...osmo-ggsn[master]: ggsn: Add minimalistic PAP support

2019-07-01 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/13608 ) Change subject: ggsn: Add minimalistic PAP support .. Patch Set 5: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/13608/

Change in ...osmo-trx[master]: Transceiver: Drop unused rssi_valid struct field

2019-07-01 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-trx/+/14639 Change subject: Transceiver: Drop unused rssi_valid struct field .. Transceiver: Drop unused rssi_valid struct field That field is act

Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

2019-07-01 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14629 to look at the new patch set (#3). Change subject: Introduce structs to encode TRXD packets ..

Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct

2019-07-01 Thread pespin
Hello laforge, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14630 to look at the new patch set (#3). Change subject: Transceiver: refactor: gather uplink burst parameters in struct .

Change in ...osmo-trx[master]: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts

2019-07-01 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-trx/+/14632 to look at the new patch set (#2). Change subject: Transceiver: Drop last 2 garbage bytes sent at end in uplink bursts .

Change in ...osmo-trx[master]: Transceiver: refactor: gather uplink burst parameters in struct

2019-07-01 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14630 ) Change subject: Transceiver: refactor: gather uplink burst parameters in struct .. Patch Set 2: (1 comment) https://gerrit.osmocom.o

Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

2019-07-01 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets .. Patch Set 2: > Patch Set 2: > > Also, it would be great to split TRX prot

Change in ...osmo-trx[master]: Introduce structs to encode TRXD packets

2019-07-01 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14629 ) Change subject: Introduce structs to encode TRXD packets .. Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14629/2/Transce

Change in ...osmocom-bb[master]: trxcon/scheduler: enrich GSM 05.03 encoding error messages

2019-07-01 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14637 ) Change subject: trxcon/scheduler: enrich GSM 05.03 encoding error messages .. trxcon/scheduler: enrich GSM 05.03 encoding e

Change in ...osmocom-bb[master]: trxcon/scheduer: fix: properly check rc of gsm0503_pdtch_encode()

2019-07-01 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14638 ) Change subject: trxcon/scheduer: fix: properly check rc of gsm0503_pdtch_encode() .. trxcon/scheduer: fix: properly check