Stefan Sperling has submitted this change and it was merged.
Change subject: support for more cell ID list types in libosmocore
..
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with
Patch Set 17: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/6509/17/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 699: const size_t elemlen = sizeof(struct gsm48_loc_area_id) +
sizeof(*ci_be);
how about "emellen" ;) lol
--
To view, visit
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#17).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types
Patch Set 16:
(2 comments)
https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 705: if (decode_lai([lai_offset], >lai.plmn.mcc,
>lai.plmn.mnc, >lai.lac) != 0)
> error here: lai_offset is unset in the first loop, and uses the value of
Patch Set 16:
(3 comments)
https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 711: remain -= sizeof(struct gsm48_loc_area_id) +
sizeof(*ci_be);
and might be nice to define a local var for
sizeof(struct gsm48_loc_area_id) +
Patch Set 16: Code-Review-1
(1 comment)
found an error
https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c
File src/gsm/gsm0808_utils.c:
Line 705: if (decode_lai([lai_offset], >lai.plmn.mcc,
>lai.plmn.mnc, >lai.lac) != 0)
error here: lai_offset is unset in the first
Patch Set 16: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Gerrit-PatchSet: 16
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 16: Code-Review+1
leaving it to Neels to see if his comments are all addressed.
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb
Patch Set 14:
(2 comments)
https://gerrit.osmocom.org/#/c/6509/14/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:
Line 33: struct gsm0808_cell_id_list;
> this structs is defined in above protocol/gsm_08_08.h so no real point in a
Yep, will do in next patch set.
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#16).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#15).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Patch Set 14: Code-Review+1
(2 comments)
https://gerrit.osmocom.org/#/c/6509/14/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:
Line 33: struct gsm0808_cell_id_list;
this structs is defined in above protocol/gsm_08_08.h so no real point in
adding it here again
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#14).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#13).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#12).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Patch Set 11: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/6509/11/include/osmocom/gsm/gsm0808.h
File include/osmocom/gsm/gsm0808.h:
Line 74: /* deprecated */
OSMO_DEPRECATED()?
https://gerrit.osmocom.org/#/c/6509/11/tests/gsm0808/gsm0808_test.c
File
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#11).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#10).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Patch Set 9:
(11 comments)
https://gerrit.osmocom.org/#/c/6509/9/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 32: #define GSM0808_CELL_ID_LIST2_MAXLEN 128
> from (255-1)/2 the theoretical max is 127, would be nice to explain that in
Yes, comment
Patch Set 9: Code-Review-1
(16 comments)
erm, sorry to bombard with another burst of comments. Many are purely cosmetic,
a few notable ones in-between. I believe you can tell the difference and make
your choices...
https://gerrit.osmocom.org/#/c/6509/9/include/osmocom/gsm/gsm0808_utils.h
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#9).
support for more cell ID list types in libosmocore
Introduce gsm0808_dec_cell_id_list2() with supports additional types of
cell
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#7).
support for more cell ID list types in libosmocore
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell
Patch Set 7:
> Uploaded patch set 7.
This new patch set keeps the old API around (deprecated) and introduces a
separate API which supports all types of cell identifier lists.
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 6:
> the question was who is *using* this API from any tagged/relesed
> version. Like: "Did we tag any osmobsc version that uses this
> API".
Ah, right, that makes sense.
The answer would be: osmo-msc-1.1.0 and above.
--
To view, visit https://gerrit.osmocom.org/6509
To
Patch Set 6:
the question was who is *using* this API from any tagged/relesed version.
Like: "Did we tag any osmobsc version that uses this API".
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 6:
> > > Understood. Are we willing to make an exception and break the
> API
> > > in this case or not? When we spoke some days ago, my take-away
> > was
> > > that were were willing to make a breaking change in this
> > particular
> > > case.
> >
> > when was the API
Patch Set 6:
> > Understood. Are we willing to make an exception and break the API
> > in this case or not? When we spoke some days ago, my take-away
> was
> > that were were willing to make a breaking change in this
> particular
> > case.
>
> when was the API introduced? Which users are
Patch Set 6:
> Understood. Are we willing to make an exception and break the API
> in this case or not? When we spoke some days ago, my take-away was
> that were were willing to make a breaking change in this particular
> case.
when was the API introduced? Which users are using it? Are
Patch Set 6:
> My main concern is API compatibility in a sense that old
> applications should always work with new/future library code. ABI
> compatibility is important but less so, as we keep incrementing the
> LIBVERSION every so often anyway (in fact, right now such a
> libversion change
Patch Set 6:
My main concern is API compatibility in a sense that old applications should
always work with new/future library code. ABI compatibility is important but
less so, as we keep incrementing the LIBVERSION every so often anyway (in fact,
right now such a libversion change is going
Patch Set 6:
(8 comments)
https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 64: #define CELL_ID_LIST_GLOBAL_MAXLEN (CELL_ID_LIST_MAXLEN /
sizeof(struct osmo_cell_global_id))
> I see now, you're limiting by the maximum
Patch Set 6:
48.008 is the renamed successor of 08.08 so naming is correct.
osmo_ prefix is *added* for need api, but not for functions that align with
existing API and it is an addition and not a replacement!
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 64: #define CELL_ID_LIST_GLOBAL_MAXLEN (CELL_ID_LIST_MAXLEN /
sizeof(struct osmo_cell_global_id))
> gosh, I'd just define like 128 items for
Patch Set 6: Code-Review-1
(8 comments)
I'd go more towards API stability (deprecate old and add new API naming); and
I'd go for less definitions. My opinions are of course not imperative, let's
see what others think of my remarks...
Patch Set 6:
(1 comment)
https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 70:uint8_t id_discr;
> Sorry, I don't understand what you want.
I meant "neither an enum nor is there a comment" ;)
In general, we tend to
Patch Set 6:
(2 comments)
https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 44: /* Parsed Location Area Code and Cell Identity (CELL_IDENT_LAC_AND_CI)
*/
> documentation in libraries should generally use Doxygen formatting
Patch Set 6:
(2 comments)
https://gerrit.osmocom.org/#/c/6509/6/include/osmocom/gsm/gsm0808_utils.h
File include/osmocom/gsm/gsm0808_utils.h:
Line 44: /* Parsed Location Area Code and Cell Identity (CELL_IDENT_LAC_AND_CI)
*/
documentation in libraries should generally use Doxygen formatting
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#6).
support for more cell ID list types in libosmocore
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell identifier lists. The
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#5).
Support for more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell identifier lists. The
Patch Set 4:
> > The concept oft lac/RAC/Rai/cid/CGI is mich More generic than
> > 08.08. We should use some generic type to represent one such
> > identity
>
> In gsm23003.h we alreay have various structures that could be
> re-used, I presume?
Two of them can be used: osmo_cell_global_id
Patch Set 4:
> The concept oft lac/RAC/Rai/cid/CGI is mich More generic than
> 08.08. We should use some generic type to represent one such
> identity
In gsm23003.h we alreay have various structures that could be re-used, I
presume?
--
To view, visit https://gerrit.osmocom.org/6509
To
Patch Set 4:
The concept oft lac/RAC/Rai/cid/CGI is mich More generic than 08.08. We should
use some generic type to represent one such identity
--
To view, visit https://gerrit.osmocom.org/6509
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6509
to look at the new patch set (#4).
Support for more cell ID list types in libosmocore.
Extend gsm0808_dec_cell_id_list() with support for additional types of
cell identifier lists. The
43 matches
Mail list logo
