Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3524
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0901ddadb5f72e1585cb1797ac22c8ab95e83146
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Harald Welte has submitted this change and it was merged.
Change subject: smpp: Fix compilation warning
..
smpp: Fix compilation warning
I already stumbled into 2 compilation environments which had Werror
enabled for -Wmaybe-un
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3524/2/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 120: }
> maybe initialize this before the msg_payload call?
I tried doing this:
case TLVID_message_payload:
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3524/2/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 120: }
maybe initialize this before the msg_payload call?
--
To view, visit https://gerrit.osmocom.org/3524
To unsubscribe, visi
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3524
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0901ddadb5f72e1585cb1797ac22c8ab95e83146
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3524
to look at the new patch set (#2).
smpp: Fix compilation warning
I already stumbled into 2 compilation environments which had Werror
enabled for -Wmaybe-uninitialized and the build fail
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3524/1/openbsc/src/libmsc/smpp_openbsc.c
File openbsc/src/libmsc/smpp_openbsc.c:
Line 100: unsigned int sms_msg_len = 0; /* initialization not needed but
compilers cry with -Wmaybe-uninitialized */
This comment on the right is too m
Review at https://gerrit.osmocom.org/3524
smpp: Fix compilation warning
I already stumbled into 2 compilation environments which had Werror
enabled for -Wmaybe-uninitialized and the build failed, so let's
workaround this warning.
| smpp_openbsc.c: In function 'handle_smpp_submit':
| smpp_openb
