[MERGED] osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-13 Thread Pau Espin Pedrol
Pau Espin Pedrol has submitted this change and it was merged. Change subject: log: Use sys._getframe() to avoid stat(2) calls .. log: Use sys._getframe() to avoid stat(2) calls The Osmo MS driver is launching many many

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-13 Thread Pau Espin Pedrol
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6377 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8f6bacadcf74d3aa25db1e1f41644f64aa19cf92 Gerrit-PatchSet: 2 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-13 Thread Holger Freyther
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/6377/1/src/osmo_gsm_tester/log.py File src/osmo_gsm_tester/log.py: Line 278: # Poke into internal to avoid hitting the linecache which will make one or > According to [1], _getframe() can have a depth parameter, which if I unders

[PATCH] osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-13 Thread Holger Freyther
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6377 to look at the new patch set (#2). log: Use sys._getframe() to avoid stat(2) calls The Osmo MS driver is launching many many processes and I would like to use the

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Pau Espin Pedrol
Patch Set 1: Code-Review-1 (1 comment) Regarding the test failure: We recently updated the unit running osmo-gsm-tester to debian9 using new ansible recipes and we are experiencing some ofono modems stability issues and I need to restart ofono every few hours. I restarted ofono and

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Holger Freyther
Patch Set 1: And the test failure seems unrelated to my change? Is the setup currently running/working? -- To view, visit https://gerrit.osmocom.org/6377 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Holger Freyther
Patch Set 1: Motivated by https://osmocom.org/issues/2927. I have not fully tested it and didn't check how inspect behaves when we want to skip more levels than frames we have. -- To view, visit https://gerrit.osmocom.org/6377 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] osmo-gsm-tester[master]: log: Use sys._getframe() to avoid stat(2) calls

2018-02-12 Thread Holger Freyther
Review at https://gerrit.osmocom.org/6377 log: Use sys._getframe() to avoid stat(2) calls The Osmo MS driver is launching many many processes and I would like to use the logging framework for the code as well. Unfortunately the inspect/traceback code will use a linecache which will execute