Patch Set 7:
(3 comments)
some replies...
https://gerrit.osmocom.org/#/c/2465/7/scripts/osmo-build.sh
File scripts/osmo-build.sh:
Line 86:job_name="${JOB_NAME//\//#}"
> It replaces '/' with '#' to avoid slashes in the artifact filename. Will ad
Ah, this is a bash-ism that I don't
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2714
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I71a5ef153b7156b0644253f5aa8a0c848f42ab3b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2716
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0e0ed9bb7fbd87ebe630c32ef59659117d77ed8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2: Code-Review-1
(8 comments)
https://gerrit.osmocom.org/#/c/2719/2/example/defaults.conf
File example/defaults.conf:
Line 14: short_name: osmo-gsm-tester-msc
Shall both msc and bsc have a short_name and long_name?
Patch Set 2: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2715/2/src/osmo_gsm_tester/bts_osmotrx.py
File src/osmo_gsm_tester/bts_osmotrx.py:
Line 47: return '127.0.0.1'
You can just do as in sysmobts, conf.get('addr') then set it to 127.0.0.1 by
default in the config.
Patch Set 2: Code-Review+2
(2 comments)
https://gerrit.osmocom.org/#/c/2718/2/contrib/jenkins-build-osmo-hlr.sh
File contrib/jenkins-build-osmo-hlr.sh:
Line 11: have_repo() {
In future patches we should move this functions (have_repo, build repo) to a
unique file and import it in all build
Review at https://gerrit.osmocom.org/2724
trial.py: Remove accidental double creation of file
This file is already created in run_suites().
Creating it in here too makes a new file name()_2.xml created and
populated instead of the original name().xml one.
Change-Id:
Review at https://gerrit.osmocom.org/2722
OsmoGSMTester: add rtprio conf, tweak core dump conf
Change-Id: I284c3bfb15e914f1f6ab00f15874fe5ea6190c5c
---
M OsmoGSMTester/chapters/install.adoc
1 file changed, 16 insertions(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/2725
Print human-readable BSSGP PDU type
Change-Id: Ief4b5ce4e4020edaf771eaa24f4382ec368dd18c
---
M src/gprs_bssgp_pcu.cpp
1 file changed, 9 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/25/2725/1
diff
Patch Set 7:
(3 comments)
https://gerrit.osmocom.org/#/c/2465/7/scripts/osmo-build.sh
File scripts/osmo-build.sh:
Line 86:job_name="${JOB_NAME//\//#}"
> Ah, this is a bash-ism that I don't know. My personal preference would be t
double-underscores it will be! Thanks for pointing it
Patch Set 9: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2454/9/src/viterbi_sse.c
File src/viterbi_sse.c:
PS9, Line 68: M3 = _mm_or_si128(_mm_cmpgt_epi16(M3, M4), _mm_cmpeq_epi16(M3,
M4));
> Same >= vs > handling that we saw in the non-SSE case. SSE does not provide
Done
--
To
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2701/1/contrib/jenkins-build-osmo-bts-sysmo.sh
File contrib/jenkins-build-osmo-bts-sysmo.sh:
Line 69: rm -rf "$prefix_real/share/doc/libosmocore"
Can we avoid building the doc in first place instead by using --disable-doc at
configure
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2702
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I55c118c6b277a2c8cddc251e3d36571b12504266
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2704
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I370789a4dc048cf71c1951f2eb70bfec261583a2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2703
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5d5750d440ae7019634b51fa1efe7bbb2a1d1e2
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
What about file selftest/template_test/osmo-nitb.cfg.tmpl ? I see it still has
"logging color 0"
--
To view, visit https://gerrit.osmocom.org/2706
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/2705/1/src/osmo_gsm_tester/resource.py
File src/osmo_gsm_tester/resource.py:
Line 468: self.count(kind) + 1,
I'd move this line up together with kind
Line 500: def counts(self):
Do we need this?
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/2712/1//COMMIT_MSG
Commit Message:
Line 20: type: loopback
Do we really need the type? Cannot we just infer it is a loopback addr by
analyzing the address?
--
To view, visit https://gerrit.osmocom.org/2712
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2707
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e1c1d3ce8163d5b40c17b7d0fb0847a068ced76
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
19 matches
Mail list logo