[PATCH] osmo-trx[master]: uhd: Use map container for for device parameter access

2017-06-09 Thread Tom Tsou
Review at https://gerrit.osmocom.org/2871 uhd: Use map container for for device parameter access OsmoTRX is written in C++ so we might as well use built-in container types when applicable. Map access allows removal of significant amounts of special device handling code. Aggregate device rates

[PATCH] osmo-trx[master]: uhd: Add non-UmTRX channel swap support

2017-06-09 Thread Tom Tsou
Review at https://gerrit.osmocom.org/2872 uhd: Add non-UmTRX channel swap support Previously an UmTRX-only feature. Change-Id: I4a0e0c1d69e89993158e948535ad33f54e568d2d Signed-off-by: Tom Tsou --- M Transceiver52M/UHDDevice.cpp 1 file changed, 44 insertions(+), 21

[MERGED] osmo-gsm-manuals[master]: BSC: Add series of message sequence charts about MGCP handling

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC: Add series of message sequence charts about MGCP handling .. BSC: Add series of message sequence charts about MGCP handling Change-Id:

osmo-gsm-tester[master]: error log: clarify for using more resources than reserved

2017-06-09 Thread Pau Espin Pedrol
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/2852/1/src/osmo_gsm_tester/resource.py File src/osmo_gsm_tester/resource.py: Line 483: msg = 'suite.conf reserved only %d x %r.' % (len(kind_reserved), kind) > exactly, this is correct. I could check for used_count ==

[MERGED] osmo-bts[master]: measurement: fix measurement computation

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: measurement: fix measurement computation .. measurement: fix measurement computation Timing advance is currently not taken into account when computing

openbsc[master]: Request and parse BTS feature list via OML

2017-06-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2800 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic35b2865998bca3c2c0cb4b77e4e73d12e08bd7e Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master

libosmo-abis[master]: src: use osmo_timer_setup()

2017-06-09 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2855 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4ca4950e49a09c63b608b13ac7561ebbd351889a Gerrit-PatchSet: 1 Gerrit-Project: libosmo-abis Gerrit-Branch: master

libosmo-netif[master]: src: use osmo_timer_setup()

2017-06-09 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2856 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id3dd32102c7362f3b280d2c058c2decebccb357a Gerrit-PatchSet: 1 Gerrit-Project: libosmo-netif Gerrit-Branch: master

libosmocore[master]: Update L3 protocol discriminator definitions

2017-06-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2787 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia699d3494b93b7f88c36338e4960b35c42a29b9c Gerrit-PatchSet: 2 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] libosmocore[master]: osmo_{fr, hr}_check_sid(): Use const input argument

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo_{fr,hr}_check_sid(): Use const input argument .. osmo_{fr,hr}_check_sid(): Use const input argument Change-Id:

[MERGED] libosmocore[master]: Update L3 protocol discriminator definitions

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Update L3 protocol discriminator definitions .. Update L3 protocol discriminator definitions Change-Id: Ia699d3494b93b7f88c36338e4960b35c42a29b9c --- M

osmo-bts[master]: Re-add version to phy_instance

2017-06-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2844 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02ae6fffdc808c1ea14185dbb4a720d27a62d4bb Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: Re-add version to phy_instance

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Re-add version to phy_instance .. Re-add version to phy_instance This is resubmission of 9eeb0b1a136fc8c24a86cb4d832c264674c10db0 with errorneous use of

osmo-bts[master]: Extend Get Attribute responder

2017-06-09 Thread Harald Welte
Patch Set 5: > > get_p_max_out_mdBm() should be used in this context, with no > fall-back > > See updated revision, not sure if I'm doing it right - is there > some limit on returned value? the limit implied by physical reality. It's very rare that you would see a value in excess of ~ 46

osmo-gsm-manuals[master]: BSC: Add series of message sequence charts about MGCP handling

2017-06-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2816 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5948677d23a58ce112b57f91bea953a93baab4c Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

[MERGED] libosmocore[master]: Fix wrongful GSM FR codec SID frame detection in DTX.

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix wrongful GSM FR codec SID frame detection in DTX. .. Fix wrongful GSM FR codec SID frame detection in DTX. Based on ETSI TS 101 318 section 5.1.2

osmo-gsm-tester[master]: junit result: also write for aborted runs

2017-06-09 Thread Pau Espin Pedrol
Patch Set 7: Code-Review-1 (1 comment) You can merge once you push a new version removing the line I pointed in the comment. https://gerrit.osmocom.org/#/c/2854/7/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 179: self.status = SuiteRun.UNKNOWN This is already

osmo-gsm-tester[master]: refactor: fix error handling; fix log.Origin; only one trial

2017-06-09 Thread Pau Espin Pedrol
Patch Set 7: Code-Review+2 Nice work, output looks much cleaner now. -- To view, visit https://gerrit.osmocom.org/2853 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibf0846d457cab26f54c25e6906a8bb304724e2d8 Gerrit-PatchSet: 7

[MERGED] openbsc[master]: don't re-implement osmo_talloc_replace_string()

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: don't re-implement osmo_talloc_replace_string() .. don't re-implement osmo_talloc_replace_string() osmo_talloc_replace_string() was introducd into

osmo-gsm-manuals[master]: osmo-nitb: Update VTY command reference

2017-06-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2014 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4c2d71eeca853ef277e802e9e8e200eb3414bca Gerrit-PatchSet: 3 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch:

osmo-gsm-tester[master]: error log: clarify for using more resources than reserved

2017-06-09 Thread Pau Espin Pedrol
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2852 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c67600ba69351859e46b8b2f368ee8106db0993 Gerrit-PatchSet: 4 Gerrit-Project: osmo-gsm-tester Gerrit-Branch:

openbsc[master]: Get TRX attributes

2017-06-09 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2783 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46 Gerrit-PatchSet: 6 Gerrit-Project: openbsc Gerrit-Branch: master

[MERGED] openbsc[master]: Get TRX attributes

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Get TRX attributes .. Get TRX attributes Request per-TRX attributes in addition to BTS attributes. Change-Id: I2b61131b9930afd03357c0b66947ee856d58cc46

[MERGED] openbsc[master]: Request and parse BTS feature list via OML

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Request and parse BTS feature list via OML .. Request and parse BTS feature list via OML Request features supported by BTS when getting attributes over

[MERGED] libosmocore[master]: Include codec.h file from codec C files

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Include codec.h file from codec C files .. Include codec.h file from codec C files failure to do so would prevent the compiler from catching

[MERGED] libosmocore[master]: introduce proper test case for GSM FR detection

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: introduce proper test case for GSM FR detection .. introduce proper test case for GSM FR detection our code is actually wrong, so let's skip the test

libosmocore[master]: introduce proper test case for GSM FR detection

2017-06-09 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2802 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I710c7871f959671deb3d18ab9062588f3056fd7c Gerrit-PatchSet: 3 Gerrit-Project: libosmocore Gerrit-Branch: master

[MERGED] openggsn[master]: libgtp: improve error logging and propagation

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: libgtp: improve error logging and propagation .. libgtp: improve error logging and propagation * propagate error code from gtp_new() to caller instead

[MERGED] osmo-gsm-manuals[master]: osmo-sgsn: fix arrow tips in flow diagrams

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-sgsn: fix arrow tips in flow diagrams .. osmo-sgsn: fix arrow tips in flow diagrams The arrow style used to desribe the flowcharts in gsup.adoc

[MERGED] osmo-gsm-manuals[master]: osmo-nitb: Update VTY command reference

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: osmo-nitb: Update VTY command reference .. osmo-nitb: Update VTY command reference Change-Id: Ia4c2d71eeca853ef277e802e9e8e200eb3414bca --- M

openggsn[master]: libgtp: improve error logging and propagation

2017-06-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2655 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie07f1e4246eb178838b7df21946a08a1f60f2084 Gerrit-PatchSet: 2 Gerrit-Project: openggsn Gerrit-Branch: master

[ABANDON] osmo-bts[master]: Remove incorrect BTS number check

2017-06-09 Thread Max
Max has abandoned this change. Change subject: Remove incorrect BTS number check .. Abandoned -- To view, visit https://gerrit.osmocom.org/2846 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType:

[PATCH] osmo-bts[master]: octphy: fix segfault

2017-06-09 Thread dexter
Review at https://gerrit.osmocom.org/2865 octphy: fix segfault The priv pointer of the callback function app_info_compl_cb() is set to null by the pointer. It should be set to pinst instead. Besides of that there is a memory violation while accessing the local variable ver_hdr using

[PATCH] osmo-bts[master]: osmo-bts-litecell15: Fix missing frame number in MEAS IND

2017-06-09 Thread dexter
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2861 to look at the new patch set (#3). osmo-bts-litecell15: Fix missing frame number in MEAS IND The layer 1 interface (l1_if.c) for osmo-bts-litecell15 does not include the frame

[MERGED] osmo-bts[master]: octphy: fix segfault

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: octphy: fix segfault .. octphy: fix segfault The priv pointer of the callback function app_info_compl_cb() is set to null by the pointer. It should be

osmo-bts[master]: octphy: fix segfault

2017-06-09 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2865 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558d78ef29e9a4d8f45f4142611f11289d3ed806 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: cosmetic: remove unused variable

2017-06-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2864 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40c393f6864fe72b88a70da265b7775da8fb469c Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: Extend Get Attribute responder

2017-06-09 Thread Max
Patch Set 5: I'll move stuff related to nominal power into separate patch and will implement using new IE there. -- To view, visit https://gerrit.osmocom.org/2786 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] osmo-bts[master]: Extend Get Attribute responder

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2786 to look at the new patch set (#6). Extend Get Attribute responder * detect if attributes are requested for BTS or TRX and act accordingly * report TRX phy version

[PATCH] osmo-bts[master]: Extend Get Attribute responder

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2786 to look at the new patch set (#8). Extend Get Attribute responder * detect if attributes are requested for BTS or TRX and act accordingly * report TRX phy version

osmo-bts[master]: Revert "measurement: exclude idle channels from uplink measu...

2017-06-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2862 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8acab50cc1bb1cb133831c6a145f4d790e99176c Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: sysmobts: normalize frame number in measurement indication

2017-06-09 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/2863 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90bd01479e41f04a6b0aefe3845d071e3148d0c6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: octphy: fix segfault

2017-06-09 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2865 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I558d78ef29e9a4d8f45f4142611f11289d3ed806 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: cosmetic: remove unused variable

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: remove unused variable .. cosmetic: remove unused variable Tha variable ms_timing_offset in lchan_meas_check_compute is not used anymore.

[MERGED] osmo-bts[master]: Revert "measurement: exclude idle channels from uplink measu...

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Revert "measurement: exclude idle channels from uplink measurement" .. Revert "measurement: exclude idle channels from uplink measurement" The offsets

[MERGED] osmo-bts[master]: sysmobts: normalize frame number in measurement indication

2017-06-09 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: sysmobts: normalize frame number in measurement indication .. sysmobts: normalize frame number in measurement indication The higher layers relay on a

[PATCH] osmo-bts[master]: OML: move BTS number check into separate function

2017-06-09 Thread Max
Review at https://gerrit.osmocom.org/2866 OML: move BTS number check into separate function * move code which checks for BTS number (obtained via OML) validity into separate function * adjust log messages to match the check * add spec reference and comments Change-Id:

[PATCH] osmo-bts[master]: osmo-bts-octphy: normalize frame number in MEAS IND

2017-06-09 Thread dexter
Review at https://gerrit.osmocom.org/2867 osmo-bts-octphy: normalize frame number in MEAS IND The higher layers will no longer care for the alignment of the frame number in order to detect when a measurement period ends. This patch normalizes the frame number directly in the measurement

[PATCH] osmo-bts[master]: Extend Get Attribute responder

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2786 to look at the new patch set (#7). Extend Get Attribute responder * detect if attributes are requested for BTS or TRX and act accordingly * report TRX phy version

[PATCH] openbsc[master]: Fix BTS number in attribute requests

2017-06-09 Thread Max
Review at https://gerrit.osmocom.org/2868 Fix BTS number in attribute requests Use 0 to indicate given BTS and 0xFF to indicate all BTS' as it's explained in 3GPP TS 52.021 ยง9.3. Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b Fixes: OS#2317 --- M openbsc/src/libbsc/bsc_init.c 1 file

osmo-bts[master]: Remove incorrect BTS number check

2017-06-09 Thread Max
Patch Set 1: I'll update OS#2317 with related questions - please follow-up discussion there. -- To view, visit https://gerrit.osmocom.org/2846 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia3d5078ed1239d553c7200ceb5b08b638df33a15

[PATCH] osmo-bts[master]: osmo-bts-trx: fix missing frame number in MEAS IND

2017-06-09 Thread dexter
Hello Max, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2813 to look at the new patch set (#3). osmo-bts-trx: fix missing frame number in MEAS IND The layer 1 interface (l1_if.c) for osmo-trx does not include the frame number into the

[PATCH] osmo-bts[master]: sysmobts: normalize frame number in measurement indication

2017-06-09 Thread dexter
Review at https://gerrit.osmocom.org/2863 sysmobts: normalize frame number in measurement indication The higher layers relay on a normalized version of frame number in order to detect the end of a measurement period. The frame number on which the measurement reports are sent may depend on the

[PATCH] osmo-bts[master]: Revert "measurement: exclude idle channels from uplink measu...

2017-06-09 Thread dexter
Review at https://gerrit.osmocom.org/2862 Revert "measurement: exclude idle channels from uplink measurement" The offsets used in the lookup tables may be phy dependand. So we will have to do the alignment in the layer 1 interface of the phy dependand code before we report the frame number up

[PATCH] osmo-bts[master]: cosmetic: remove unused variable

2017-06-09 Thread dexter
Review at https://gerrit.osmocom.org/2864 cosmetic: remove unused variable Tha variable ms_timing_offset in lchan_meas_check_compute is not used anymore. Change-Id: I40c393f6864fe72b88a70da265b7775da8fb469c --- M src/common/measurement.c 1 file changed, 0 insertions(+), 1 deletion(-) git

osmo-bts[master]: osmo-bts-litecell15: Fix missing frame number in MEAS IND

2017-06-09 Thread Max
Patch Set 2: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/2861/2/src/osmo-bts-litecell15/l1_if.c File src/osmo-bts-litecell15/l1_if.c: Line 898: LOGPC(DL1C, ll, ", Meas: RSSI %-3.2f dBm, Qual %-3. l1sap->u.info.u.meas_ind.fn = fn;2f dB, " Looks like typo. If not than

libosmocore[master]: Add function to generate random identifier

2017-06-09 Thread Max
Patch Set 3: Note: the current version does not implement direct reading from /dev/urandom as a fallback when getrandom() is missing. Instead insecure rand() used and error is reported to caller. The reasons are twofold: 1) it's much simpler 2) that matches the way RAND_bytes() is used

[PATCH] libosmocore[master]: Add function to generate random identifier

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/1526 to look at the new patch set (#5). Add function to generate random identifier The function is a wrapper on top of getrandom() (if available via glibc) or corresponding

[PATCH] osmo-gsm-tester[master]: junit result: also write for aborted runs

2017-06-09 Thread Neels Hofmeyr
Hello Pau Espin Pedrol, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2854 to look at the new patch set (#8). junit result: also write for aborted runs Even if aborted due to signal, write a JUnit report XML, and make sure to indicate the

[MERGED] osmo-gsm-tester[master]: error log: clarify for using more resources than reserved

2017-06-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: error log: clarify for using more resources than reserved .. error log: clarify for using more resources than reserved Figure out how many resources

osmo-gsm-tester[master]: junit result: also write for aborted runs

2017-06-09 Thread Neels Hofmeyr
Patch Set 7: (1 comment) https://gerrit.osmocom.org/#/c/2854/7/src/osmo_gsm_tester/suite.py File src/osmo_gsm_tester/suite.py: Line 179: self.status = SuiteRun.UNKNOWN > This is already set two lines below, no need for this line. heh, thanks. I think it came from rebase confusion: I

[MERGED] osmo-gsm-tester[master]: refactor: fix error handling; fix log.Origin; only one trial

2017-06-09 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: refactor: fix error handling; fix log.Origin; only one trial .. refactor: fix error handling; fix log.Origin; only one trial A bit of refactoring to

[ABANDON] osmo-bts[master]: measurement: Fix measurement reporting period tables

2017-06-09 Thread dexter
dexter has abandoned this change. Change subject: measurement: Fix measurement reporting period tables .. Abandoned -- To view, visit https://gerrit.osmocom.org/2795 To unsubscribe, visit https://gerrit.osmocom.org/settings

[PATCH] openbsc[master]: Migrate from OpenSSL to osmo_get_rand_id()

2017-06-09 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/1464 to look at the new patch set (#7). Migrate from OpenSSL to osmo_get_rand_id() This avoids potential licensing incompatibility and makes integration of Debian packaging patches easier.

[PATCH] libosmocore[master]: Add function to generate random identifier

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/1526 to look at the new patch set (#3). Add function to generate random identifier The function is a wrapper on top of getrandom() (if available via glibc) or corresponding

[PATCH] libosmocore[master]: Add function to generate random identifier

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/1526 to look at the new patch set (#4). Add function to generate random identifier The function is a wrapper on top of getrandom() (if available via glibc) or corresponding

osmo-bts[master]: cosmetic: remove unused variable

2017-06-09 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2864 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40c393f6864fe72b88a70da265b7775da8fb469c Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: sysmobts: normalize frame number in measurement indication

2017-06-09 Thread Max
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/2863 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I90bd01479e41f04a6b0aefe3845d071e3148d0c6 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: Extend Get Attribute responder

2017-06-09 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2786 to look at the new patch set (#9). Extend Get Attribute responder * detect if attributes are requested for BTS or TRX and act accordingly * report TRX phy version

[PATCH] osmo-bts[master]: Set and report BTS features

2017-06-09 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/2799 to look at the new patch set (#7). Set and report BTS features Set (possibly incomplete) list of BTS model-specific features and report them in response to attribute request via OML.

[PATCH] osmo-trx[master]: build: Require and check for gcc C++11 support

2017-06-09 Thread Tom Tsou
Review at https://gerrit.osmocom.org/2869 build: Require and check for gcc C++11 support It is now 2017. We can and should be able to use C++11 features now. Change-Id: I96477e4125390b17b43a3705bb1daf98fa01c9bb Signed-off-by: Tom Tsou --- A config/ax_cxx_compile_stdcxx.m4

[PATCH] openggsn[master]: IPv6 support

2017-06-09 Thread gr...@xiplink.com
Review at https://gerrit.osmocom.org/2870 IPv6 support Change-Id: If8ce8b4b8cd2ba97f7ba122de4703983111046e4 --- M ggsn/ggsn.c M ggsn/ippool.c M ggsn/ippool.h M ggsn/tun.c M ggsn/tun.h M gtp/gtp.c M gtp/gtp.h M gtp/pdp.c M gtp/pdp.h M gtp/queue.c M gtp/queue.h M sgsnemu/ippool.c M