Review at  https://gerrit.osmocom.org/2868

Fix BTS number in attribute requests

Use 0 to indicate given BTS and 0xFF to indicate all BTS' as it's
explained in 3GPP TS 52.021 ยง9.3.

Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b
Fixes: OS#2317
---
M openbsc/src/libbsc/bsc_init.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/68/2868/1

diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c
index e5226a9..2a91b1c 100644
--- a/openbsc/src/libbsc/bsc_init.c
+++ b/openbsc/src/libbsc/bsc_init.c
@@ -343,12 +343,12 @@
                        generate_cell_chan_list(ca, trx->bts);
 
                        /* Request generic BTS-level attributes */
-                       abis_nm_get_attr(trx->bts, NM_OC_BTS, trx->bts->nr, 
trx->nr, 0xFF, bts_attr, sizeof(bts_attr));
+                       abis_nm_get_attr(trx->bts, NM_OC_BTS, 0xFF, 0xFF, 0xFF, 
bts_attr, sizeof(bts_attr));
 
                        llist_for_each_entry(cur_trx, &trx->bts->trx_list, 
list) {
                                int i;
                                /* Request TRX-level attributes */
-                               abis_nm_get_attr(cur_trx->bts, 
NM_OC_BASEB_TRANSC, cur_trx->bts->nr, cur_trx->nr, 0xFF,
+                               abis_nm_get_attr(cur_trx->bts, 
NM_OC_BASEB_TRANSC, 0, cur_trx->nr, 0xFF,
                                                 trx_attr, sizeof(trx_attr));
                                for (i = 0; i < ARRAY_SIZE(cur_trx->ts); i++)
                                        generate_ma_for_ts(&cur_trx->ts[i]);

-- 
To view, visit https://gerrit.osmocom.org/2868
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8f43055c38000248033a8ff9ddaf0910d68d794b
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <[email protected]>

Reply via email to