[PATCH] osmo-bsc[master]: Remove dead code

2017-12-18 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5475 to look at the new patch set (#2). Remove dead code There still is a lot of dead code that we inherited from the NITB days, let's remove more of it. libtrau will be re-introduced as

[MERGED] osmo-msc[master]: vlr: debug log: log Ciphering Mode details

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: vlr: debug log: log Ciphering Mode details .. vlr: debug log: log Ciphering Mode details Change-Id: Ib19dfd7255bda01ebace62386df4ec89697d9d14 --- M

[MERGED] osmo-msc[master]: fix BSSMAP Cipher Mode Cmd: properly set permitted algorithms

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: fix BSSMAP Cipher Mode Cmd: properly set permitted algorithms .. fix BSSMAP Cipher Mode Cmd: properly set permitted algorithms The bit shifting is

osmo-msc[master]: cosmetic: msc_vlr_tests: log SMS details when invoked with -v

2017-12-18 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5465 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b7d2fd3fb38bf50eeabd6f7ef736d70a17de7a6 Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-msc[master]: cosmetic: msc_vlr_tests: log SMS details when invoked with -v

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: msc_vlr_tests: log SMS details when invoked with -v .. cosmetic: msc_vlr_tests: log SMS details when invoked with -v DLSMS logs SMS pointers,

[MERGED] osmo-msc[master]: compiler warning: drop double 'const' in a_iface_tx_cipher_m...

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: compiler warning: drop double 'const' in a_iface_tx_cipher_mode() .. compiler warning: drop double 'const' in a_iface_tx_cipher_mode() Change-Id:

[MERGED] osmo-msc[master]: debug log: a_iface_tx_cipher_mode(): log cipher and key

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: debug log: a_iface_tx_cipher_mode(): log cipher and key .. debug log: a_iface_tx_cipher_mode(): log cipher and key Introduce LOGPCONN() which would also

osmo-msc[master]: debug log: a_iface_tx_cipher_mode(): log cipher and key

2017-12-18 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5374 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib406d6e6784342341e716206997e382c702ac9d2 Gerrit-PatchSet: 3 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-msc[master]: log: a_iface.c: revisit logging, use LOGPCONN

2017-12-18 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5474 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If9cb0e7a5cef2ec37a1a7c548aecf11a11c22eec Gerrit-PatchSet: 1 Gerrit-Project: osmo-msc Gerrit-Branch: master

[MERGED] osmo-ttcn3-hacks[master]: BSC_Tests: remove bogus line sfrom osmo-bsc.cfg

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BSC_Tests: remove bogus line sfrom osmo-bsc.cfg .. BSC_Tests: remove bogus line sfrom osmo-bsc.cfg Those lines serve no purpose (and are being removed

osmo-ttcn3-hacks[master]: BSC_Tests: remove bogus line sfrom osmo-bsc.cfg

2017-12-18 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5480 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf037e8cd9a51e676eac472b29c0d616a5632c5d Gerrit-PatchSet: 1 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-msc[master]: cosmetic prep: publish vlr_use_umts_aka() decision

2017-12-18 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5468 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I85d784c62ecbabdb6186a3dae4dcd554e7921041 Gerrit-PatchSet: 4 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] osmo-bts[master]: octphy: l1_oml: check returncode of trx_by_l1h()

2017-12-18 Thread dexter
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5402 to look at the new patch set (#2). octphy: l1_oml: check returncode of trx_by_l1h() The function trx_by_l1h() is used to fetch the pointer to a an osmo_bts_trx from a list. The ID that

osmo-sgsn[master]: .service: remove OpenBSC from service desription

2017-12-18 Thread Max
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5443 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I555939235437a0b3253a1236a918e1f491ed9d3a Gerrit-PatchSet: 2 Gerrit-Project: osmo-sgsn Gerrit-Branch: master

libosmocore[master]: libosmocodec: implement ECU (Error Concealment Unit) for FR

2017-12-18 Thread dexter
Patch Set 3: Code-Review+1 > BTW: I've changed the license header from AGPL V3+ to GPL V2+ > in order to avoid license mix in libosmocore. > > @dexter, @Harald, is it ok? Thanks for correcting this (cut and past error). -- To view, visit https://gerrit.osmocom.org/5421 To unsubscribe,

[MERGED] osmo-msc[master]: cosmetic prep: publish vlr_use_umts_aka() decision

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic prep: publish vlr_use_umts_aka() decision .. cosmetic prep: publish vlr_use_umts_aka() decision During Set Ciphering Mode on GERAN, it is

[MERGED] osmo-msc[master]: cosmetic prep: tell vlr_ops.set_ciph_mode() whether UMTS AKA...

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic prep: tell vlr_ops.set_ciph_mode() whether UMTS AKA is used .. cosmetic prep: tell vlr_ops.set_ciph_mode() whether UMTS AKA is used In case of

osmo-msc[master]: cosmetic: move translation of vlr_ciph into msc_vlr_set_ciph...

2017-12-18 Thread Harald Welte
Patch Set 6: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5377 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id46f9a513b555d0a481f7124c9984c2b5b196b3e Gerrit-PatchSet: 6 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] python/osmo-python-tests[master]: Explicitly check syntax in jenkins tests

2017-12-18 Thread Max
Review at https://gerrit.osmocom.org/5481 Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure that it fails if any errorsis encountered bymanually call compilation step. Change-Id:

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-18 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5280 to look at the new patch set (#9). Fix python3 compatibility Use print() function with proper import. Change-Id:

[PATCH] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-18 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5278 to look at the new patch set (#9). Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed

[PATCH] python/osmo-python-tests[master]: Expand CI tests

2017-12-18 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5277 to look at the new patch set (#8). Expand CI tests * make sure jenkins.sh fails on any errors similar to other jenkins jobs * always explicitly use python2 instead of

[MERGED] osmo-msc[master]: cosmetic: move translation of vlr_ciph into msc_vlr_set_ciph...

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: cosmetic: move translation of vlr_ciph into msc_vlr_set_ciph_mode() .. cosmetic: move translation of vlr_ciph into msc_vlr_set_ciph_mode()

osmo-msc[master]: fix GSM-Milenage in presence of 2G keys

2017-12-18 Thread Harald Welte
Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04e405426c55a81341747a9b450a69188525d5c Gerrit-PatchSet: 4 Gerrit-Project: osmo-msc Gerrit-Branch: master

[PATCH] python/osmo-python-tests[master]: Explicitly check syntax in jenkins tests

2017-12-18 Thread Max
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5481 to look at the new patch set (#2). Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure that it fails

[MERGED] python/osmo-python-tests[master]: Expand CI tests

2017-12-18 Thread Max
Max has submitted this change and it was merged. Change subject: Expand CI tests .. Expand CI tests * make sure jenkins.sh fails on any errors similar to other jenkins jobs * always explicitly use python2 instead of generic

[PATCH] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-18 Thread Max
Hello Pau Espin Pedrol, Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5280 to look at the new patch set (#10). Fix python3 compatibility Use print() function with proper import. Change-Id:

[PATCH] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-18 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5278 to look at the new patch set (#10). Move scripts to appropriate directory Having the scripts in the same directory with library code means that it'll be installed

[PATCH] python/osmo-python-tests[master]: Explicitly check syntax in jenkins tests

2017-12-18 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5481 to look at the new patch set (#3). Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with installation anyway. Make sure

libosmocore[master]: ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP

2017-12-18 Thread Max
Patch Set 4: That looks like lot's of code duplication. Can we just set error string and call some generic function with it as parameter? Smth like case CTRL_TRAP: handle_incoming("TRAP",...)... -- To view, visit https://gerrit.osmocom.org/5439 To unsubscribe, visit

[MERGED] python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix python3 compatibility .. Fix python3 compatibility Use print() function with proper import. Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60

python/osmo-python-tests[master]: Explicitly check syntax in jenkins tests

2017-12-18 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5481 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2235e3fff21b7c09d3fba00ecdccca7f4515e071 Gerrit-PatchSet: 3 Gerrit-Project: python/osmo-python-tests

[PATCH] python/osmo-python-tests[master]: Add rate counter dumper

2017-12-18 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5029 to look at the new patch set (#5). Add rate counter dumper This simple tool dump all the rate counters available via ctrl interface to cvs file (or stdout). Change-Id:

[PATCH] python/osmo-python-tests[master]: Fix ctrl command parsing for python3

2017-12-18 Thread Max
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5028 to look at the new patch set (#4). Fix ctrl command parsing for python3 In python3 we got bytes, not string from the socket so we have to decode it properly before using

[PATCH] python/osmo-python-tests[master]: Improve python3 compatibility

2017-12-18 Thread Max
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5038 to look at the new patch set (#3). Improve python3 compatibility Use proper print() function to make scripts compatible with both python 2 and 3.

osmo-iuh[master]: iu client: store multiple LAC, RAC per RNC = fix paging for m...

2017-12-18 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (2 comments) Let me revisit this one; VTY and cleanup extensions might go in separate patch submissions... https://gerrit.osmocom.org/#/c/5381/1/src/iu_client.c File src/iu_client.c: Line 182: llist_for_each_entry(e, >lac_rac_list, entry) { > we

[PATCH] python/osmo-python-tests[master]: Use python3 for osmo_ctrl.py

2017-12-18 Thread Max
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5061 to look at the new patch set (#2). Use python3 for osmo_ctrl.py It's a standalone script illustrating the use of ctrl protocol from python. Since it's not used as a

osmo-msc[master]: fix paging: add timeout to discard unsuccessful paging

2017-12-18 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5463/1/include/osmocom/msc/gsm_data.h File include/osmocom/msc/gsm_data.h: Line 347: #define MSC_PAGING_TIMEOUT_DEFAULT 60 when looking at https://osmocom.org/issues/2756 "T3113 default of 60s seems way too large" it appears that this

libosmocore[master]: ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP

2017-12-18 Thread Neels Hofmeyr
Patch Set 4: > That looks like lot's of code duplication. Can we just set error > string and call some generic function with it as parameter? Smth > like > case CTRL_TRAP: handle_incoming("TRAP",...)... yes, you're right. I thought about the same but in the end didn't get around to it...

[PATCH] libosmocore[master]: ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP

2017-12-18 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5439 to look at the new patch set (#5). ctrl: separate handling of GET_REPLY, SET_REPLY and TRAP So far, error reporting just says "Trap/Reply", more accurately report 'GET REPLY', 'SET

libosmocore[master]: ctrl: tighten CTRL input parsing

2017-12-18 Thread Neels Hofmeyr
Patch Set 4: (4 comments) https://gerrit.osmocom.org/#/c/5438/4/src/ctrl/control_cmd.c File src/ctrl/control_cmd.c: Line 284: static bool id_str_valid(const char *str) > Are we absolutely sure that all current and future users of this function a yes, the strtok actually places a '\0' after

[MERGED] libosmocore[master]: rate_ctr: print proper error message if rate_ctr already exists

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: rate_ctr: print proper error message if rate_ctr already exists .. rate_ctr: print proper error message if rate_ctr already exists Change-Id:

libosmocore[master]: rate_ctr: print proper error message if rate_ctr already exists

2017-12-18 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5484 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b7ccb0931f5a2a489bb8c7c6aee0894a126eb8 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

python/osmo-python-tests[master]: Fix ctrl command parsing for python3

2017-12-18 Thread Max
Patch Set 4: Code-Review-1 This should be merged alongside with appropriate test showing the error fixed. -- To view, visit https://gerrit.osmocom.org/5028 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[PATCH] libosmocore[master]: rate_ctr: print proper error message if rate_ctr already exists

2017-12-18 Thread Harald Welte
Review at https://gerrit.osmocom.org/5484 rate_ctr: print proper error message if rate_ctr already exists Change-Id: I86b7ccb0931f5a2a489bb8c7c6aee0894a126eb8 --- M src/rate_ctr.c 1 file changed, 4 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/libosmocore

[MERGED] python/osmo-python-tests[master]: Move scripts to appropriate directory

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Move scripts to appropriate directory .. Move scripts to appropriate directory Having the scripts in the same directory with library code means that

python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-18 Thread Harald Welte
Patch Set 10: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5280 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 Gerrit-PatchSet: 10 Gerrit-Project: python/osmo-python-tests

[MERGED] python/osmo-python-tests[master]: Explicitly check syntax in jenkins tests

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Explicitly check syntax in jenkins tests .. Explicitly check syntax in jenkins tests By default setup.py ignores compilation errorsand proceed with

osmo-bts[master]: octphy: l1_oml: check returncode of trx_by_l1h()

2017-12-18 Thread Neels Hofmeyr
Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/5402/2/src/osmo-bts-octphy/l1_oml.c File src/osmo-bts-octphy/l1_oml.c: Line 381: LOGP(DL1C, LOGL_ERROR, "response with unexpected physical transceiver-id (ar->TrxId.byTrxId=%u) while lchan act\n", along the lines of

osmo-msc[master]: libmsc: a_iface: Remove duplicated 'const' keyword

2017-12-18 Thread Neels Hofmeyr
Patch Set 1: heh i did the same in https://gerrit.osmocom.org/5373 -- yours is nicer since it shows the actual warnings, but mine already got merged... -- To view, visit https://gerrit.osmocom.org/5422 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

osmo-msc[master]: fix GSM-Milenage in presence of 2G keys

2017-12-18 Thread Neels Hofmeyr
Patch Set 4: this still needs https://gerrit.osmocom.org/5466 to compile -- To view, visit https://gerrit.osmocom.org/5470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If04e405426c55a81341747a9b450a69188525d5c Gerrit-PatchSet: 4

[PATCH] python/osmo-python-tests[master]: Add scripts to compilation tests in jenkins

2017-12-18 Thread Max
Review at https://gerrit.osmocom.org/5482 Add scripts to compilation tests in jenkins Related: OS#2684 Change-Id: If098c20b1ad17c3868073b9fe07fd3795217c526 --- M contrib/jenkins.sh 1 file changed, 17 insertions(+), 0 deletions(-) git pull

[PATCH] python/osmo-python-tests[master]: Ignore compilation byproducts

2017-12-18 Thread Max
Review at https://gerrit.osmocom.org/5483 Ignore compilation byproducts Change-Id: Ic04a1b9411b851547ef7ce7a9b562cb290081ca9 --- M .gitignore 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/python/osmo-python-tests refs/changes/83/5483/1 diff --git

libosmocore[master]: libosmocodec: add FR/HR/EFR frame length definitions

2017-12-18 Thread Neels Hofmeyr
Patch Set 1: Code-Review+1 * Would there be a naming conflict when this is merged to libosmocore? * are there patches that move osmo-bts and osmocombb to these definitions, which we could hint to from the commit log? (I think we want to add OSMO_ or osmo_ prefix to all new additions to

python/osmo-python-tests[master]: Improve python3 compatibility

2017-12-18 Thread Max
Patch Set 3: > osmo_interact_vty.py --gen-xml-ref That's cool, didn't know about it. Is there example use somewhere in osmo*? Also, is there equivalent counterpart for osmotestvty.py? -- To view, visit https://gerrit.osmocom.org/5038 To unsubscribe, visit https://gerrit.osmocom.org/settings

python/osmo-python-tests[master]: Fix python3 compatibility

2017-12-18 Thread Harald Welte
Patch Set 9: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5280 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib10dfbec18202245031a634fc3f19677fc952e60 Gerrit-PatchSet: 9 Gerrit-Project: python/osmo-python-tests

python/osmo-python-tests[master]: Expand CI tests

2017-12-18 Thread Harald Welte
Patch Set 8: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5277 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f4639537d227c513859d4552533ce1e41df9deb Gerrit-PatchSet: 8 Gerrit-Project: python/osmo-python-tests

python/osmo-python-tests[master]: Explicitly check syntax in jenkins tests

2017-12-18 Thread Harald Welte
Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5481 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2235e3fff21b7c09d3fba00ecdccca7f4515e071 Gerrit-PatchSet: 2 Gerrit-Project: python/osmo-python-tests

libosmocore[master]: ctrl: tighten CTRL input parsing

2017-12-18 Thread Max
Patch Set 4: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/5438/4/src/ctrl/control_cmd.c File src/ctrl/control_cmd.c: Line 284: static bool id_str_valid(const char *str) Are we absolutely sure that all current and future users of this function always use null-terminated strings

libosmocore[master]: ctrl: fix mem leak when handling GET_REPLY and SET_REPLY

2017-12-18 Thread Max
Patch Set 4: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/5434 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id583b413f8b8bd16e5cf92a8a9e8663903646381 Gerrit-PatchSet: 4 Gerrit-Project: libosmocore Gerrit-Branch: master

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_8.0/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_8.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.10/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log:

Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.04/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log:

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.10/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 282s]

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.10/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/i586 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log:

Build failure of network:osmocom:nightly/osmo-bsc in Debian_8.0/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_8.0/i586 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log:

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.10/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.10/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/i586

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/i586 Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/aarch64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-pcu Last lines of build log:

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.04/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build

python/osmo-python-tests[master]: Add rate counter dumper

2017-12-18 Thread Harald Welte
Patch Set 5: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5029 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12b369434e4ee9b38f92872f297e1f3d4f0698c2 Gerrit-PatchSet: 5 Gerrit-Project: python/osmo-python-tests

osmo-pcu[master]: Fix tests after rate_ctr change

2017-12-18 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5487 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7c552ce653b44ec3a31049641728926adc07361d Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

[MERGED] osmo-pcu[master]: Fix tests after rate_ctr change

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix tests after rate_ctr change .. Fix tests after rate_ctr change Recent change lin libosmocore disallow registering rate_ctr with the same name and

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_17.04/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build

osmo-bsc[master]: Fix tests after rate_ctr change

2017-12-18 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5486 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie1537a1ee9ee812eaaf9f58dc4bc86d4add8c31f Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: Fix tests after rate_ctr change

2017-12-18 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Fix tests after rate_ctr change .. Fix tests after rate_ctr change Recent change lin libosmocore disallow registering rate_ctr with the same name and

osmo-msc[master]: cosmetic: msc_paging_request: drop obsolete comment

2017-12-18 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5462 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb5b7dbbca3ca0db3d80a4b693c57c6d67fd823e Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

osmo-pcu[master]: Remove unused includes and forward declarations

2017-12-18 Thread Max
Patch Set 1: I've used (iwyu) include-what-you-use but unfortunatelyit seems to works with c++ only and gives plenty of false positives. Nevertheless, better than nothing. -- To view, visit https://gerrit.osmocom.org/5403 To unsubscribe, visit https://gerrit.osmocom.org/settings

Build failure of network:osmocom:nightly/osmo-bsc in Debian_9.0/aarch64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/Debian_9.0/aarch64 Package network:osmocom:nightly/osmo-bsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/aarch64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/aarch64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/aarch64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/armv7l

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/armv7l Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/osmo-bsc in xUbuntu_16.10/x86_64

2017-12-18 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-bsc/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/osmo-bsc failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly osmo-bsc Last lines of build

  1   2   >