Patch Set 1:
> Build Failed
>
> https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-msc/467/ :
> FAILURE
nice, stow prevented me from using a header without proper CFLAGS
--
To view, visit https://gerrit.osmocom.org/7296
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/7307
fix cell identifier decoding in libosmocore
The cell ID list decoder merged in 11a4d9dd91216fe353e94bfdbbab53bc4f891c0d
has a bug which was introduced part-way through the review process in
gerrit at https://gerrit.osmocom.org/#/c/6509/
When Neels
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7160
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13133e61abda73a8b507c1a1bd7b98c677460f9
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7166
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37ba38f7d81134e5f0ca28fa684fdb09c753bb04
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 5: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
> This change improves legibility of the code by correctly sorting the file f
I still disagree and believe
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7158
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia3fd4551d1f2932362f99f7d44d65f8ae4fd1979
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7168
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
Gerrit-PatchSet: 6
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 1:
> Build Failed
>
> https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-sgsn/86/ :
> FAILURE
same on a debian 9 build slave. Hmm, weird that my debian doesn't report these
warnings. Has something changed from deb9 to testing that silences these
warnings??
--
To view, visit
Hello Harald Welte,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7307
to look at the new patch set (#2).
fix cell identifier decoding in libosmocore
The cell ID list decoder merged in 11a4d9dd91216fe353e94bfdbbab53bc4f891c0d
has a bug which was introduced
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7307
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a5a9d858226be578cf11a03cf996d509bd51fb
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: fix cell identifier decoding in libosmocore
..
fix cell identifier decoding in libosmocore
The cell ID list decoder merged in
Review at https://gerrit.osmocom.org/7305
MSC_Tests: Support wildcarded endpoints (follow up)
The following tests still lack support for wildcarded endpoints:
MSC_Tests.TC_lu_and_mo_call
MSC_Tests.TC_emerg_call_imsi
MSC_Tests.TC_mo_crcx_ran_reject
MSC_Tests.TC_mt_crcx_ran_reject
- Also add
Patch Set 1: Code-Review+1
Thanks, good catch from the redmine discussion :)
--
To view, visit https://gerrit.osmocom.org/7304
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I564cac73e610d71df5ab244e04d08dd2c5ff2324
Gerrit-PatchSet: 1
Stefan Sperling has submitted this change and it was merged.
Change subject: use libosmocore to parse cell identifiers in osmo-bsc
..
use libosmocore to parse cell identifiers in osmo-bsc
This replaces custom cell identifier
Patch Set 1:
> Build Failed
>
> https://jenkins.osmocom.org/jenkins/job/gerrit-osmo-sgsn/85/ :
> FAILURE
Interesting, I cannot reproduce this failure locally.
--
To view, visit https://gerrit.osmocom.org/7298
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType:
Review at https://gerrit.osmocom.org/7308
osmo-gbproxy: use 'osmo-gbproxy.cfg' as default config name
Like we did in osmo-sgsn in If804da17a7481e79e000fe40ae0d9c4be9722e61, move
from 'osmo_gbproxy.cfg' to 'osmo-gbproxy.cfg' as default config file name.
Still look for the legacy file name to
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7167
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I981c260eca1a61657147e6d83b4226618088223c
Gerrit-PatchSet: 5
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Patch Set 2:
I'm trying to achieve the same as this patch in https://gerrit.osmocom.org/7297
and https://gerrit.osmocom.org/7298
--
To view, visit https://gerrit.osmocom.org/5672
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7307
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1a5a9d858226be578cf11a03cf996d509bd51fb
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7296
to look at the new patch set (#2).
cosmetic: use enum ranap_nsap_addr_enc instead of int
The only reason to use int instead of the enum was the lack of header
iu_client.h when not
Review at https://gerrit.osmocom.org/7306
build osmo-msc: add "missing" LIBASN1C_LIBS
in osmo-msc/Makefile.am, osmo-msc was actually missing the LIBASN1C_LIBS even
though it included LIBASN1C_CFLAGS. Probably libasn1c is implicitly linked from
libranap.so, but doesn't hurt to name it.
When
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/7159/3/src/osmo_gsm_tester/bts_osmo.py
File src/osmo_gsm_tester/bts_osmo.py:
Line 80: def ready_for_pcu(self):
> I still disagree and believe non-public member functions should have leadin
ready_for_pcu is public so it's fine if it
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7167
to look at the new patch set (#7).
Introduce PowerSupply interface and PowerSupplySispm
File powersupply.py defines the interface to be used by child
Patch Set 7:
Job running all nanobts related test in prod can be found in:
https://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_manual-run-all/677/
It seems the libusb issues are fixed now.
--
To view, visit https://gerrit.osmocom.org/7168
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7310/1/src/gsm/auth_xor.c
File src/gsm/auth_xor.c:
Line 90: * kc = c3(ck, ik) = ck[0-3] ^ ck[4-7] ^ ik[0-3] ^ ik[4-7]
BTW: the osmo_auth_c3() could be used here.
--
To view, visit https://gerrit.osmocom.org/7310
To unsubscribe,
Patch Set 2:
> Do we have any tests for this yet?
IIUC the conn does close after a given timeout. To test in ttcn3 we would need
to choose a timeout that is smaller than the conn fsm timeout. That is opening
doors to false positives, if ttcn3 ends up slightly slower than osmo-msc so
that
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/7286/2/src/fsm.c
File src/fsm.c:
Line 223: fi->name = talloc_asprintf(fi, "%s(%s)[%p]",
fi->fsm->name, id, fi);
and this one was an actual error, was missing the id arg
--
To view, visit
Patch Set 2:
@daniel, I fixed a few compiler warnings for you
--
To view, visit https://gerrit.osmocom.org/7286
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6b01eb10b8a05fee3e4a5cdefdcf3ce9f79545b4
Gerrit-PatchSet: 2
Gerrit-Project:
Patch Set 1: Verified-1
(5 comments)
And in general, do we have any expected values, that
could be used to make basic test coverage?
https://gerrit.osmocom.org/#/c/7310/1/src/gsm/auth_xor.c
File src/gsm/auth_xor.c:
Line 52:if (aud->type == OSMO_AUTH_TYPE_GSM)
I've manually added this,
Patch Set 3:
as mentioned in https://osmocom.org/issues/3010#note-8, I tested the gb-proxy
changes in this patch manually.
--
To view, visit https://gerrit.osmocom.org/6672
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Review at https://gerrit.osmocom.org/7309
use gsm48_decode_lai2() in gsm0808_dec_cell_id_list()
This makes gsm0808_dec_cell_id_list() properly decode 3-digit MNCs.
Add a test which encodes/decodes a LAI_AND_LAC list with 3-digit MNCs.
Change-Id: If6b941720de33dca66b6b1aa2cb95a3275708b7f
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7286
to look at the new patch set (#2).
fsm: Update the name as well if the id is updated and accept NULL
If the name stays the same the log messages will still log with the old
id. Since
Patch Set 2:
(4 comments)
I've placed some comments, but.
My reflection on the conn FSM as I wrote it makes me come to the conclusion
that the root cause for the need for this patch is that I lack a state.
Currently it's like
1. INIT (initial state on allocation)
2. NEW (we're busy with
Patch Set 2: Code-Review-1
--
To view, visit https://gerrit.osmocom.org/6503
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idfa39fdbe5bb764f8ea2bbf8c5442e15e01cadbb
Gerrit-PatchSet: 2
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-gbproxy: use 'osmo-gbproxy.cfg' as default config name
..
osmo-gbproxy: use 'osmo-gbproxy.cfg' as default config name
Like we did in osmo-sgsn in
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7308
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9448908d94a23001f04b6334a78739a839b91313
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6672
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7437dfaa586689e2bef0d4be6537e5577a8f6c26
Gerrit-PatchSet: 3
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
roox has abandoned this change.
Change subject: build: check if libosmogsm is available
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/7283
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7167
to look at the new patch set (#6).
Introduce PowerSupply interface and PowerSupplySispm
File powersupply.py defines the interface to be used by child
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7303/1/src/libmsc/transaction.c
File src/libmsc/transaction.c:
PS1, Line 155: msc_subscr_conn_put
> What I'm surprised is why the msc_subscr_conn_put() is not sufficient here.
Hmm, might do the subscr_conn_release_when_unused() call in
Patch Set 6: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/7167/6/src/osmo_gsm_tester/powersupply_sispm.py
File src/osmo_gsm_tester/powersupply_sispm.py:
Line 33: nthe smallest scope possible, and we re-try if we receive a
"Resource Busy"
typo "i nthe"
--
To view, visit
Patch Set 2:
https://gerrit.osmocom.org/7303 duplicates this patch
--
To view, visit https://gerrit.osmocom.org/6504
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I131313aa326dd01b3e81e1ade18a4afd32385c15
Gerrit-PatchSet: 2
Review at https://gerrit.osmocom.org/7310
libosmogsm: add support for XOR authentication
Change-Id: I1afaf0a9e2dce43aec87964bacefb21ed4d3d565
---
M src/gsm/Makefile.am
A src/gsm/auth_xor.c
2 files changed, 151 insertions(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
Patch Set 1:
> I don't know why one would run git status all the time.
I don't know how you get by without it.
> A manually maintained list of files is not
> acceptable. It would change almost every day or at least multiple
> times a week at the current development pace (which is mostly
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7167
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I981c260eca1a61657147e6d83b4226618088223c
Gerrit-PatchSet: 7
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Create Bts abstract class and make OsmoBts inherit from it
..
Create Bts abstract class and make OsmoBts inherit from it
This base class will be
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: pcu.py: Introduce PcuDummy class
..
pcu.py: Introduce PcuDummy class
It will be used in later commits by BTS without proper PCU control such
as
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Create Pcu abstract class and make OsmoPcu inherit from it
..
Create Pcu abstract class and make OsmoPcu inherit from it
This base class will be
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Introduce PowerSupply interface and PowerSupplySispm
..
Introduce PowerSupply interface and PowerSupplySispm
File powersupply.py defines the
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: default-suites.conf: Add nanobts related tests
..
default-suites.conf: Add nanobts related tests
Change-Id:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: bts_osmo.py: ready_for_pcu is of public access from tests, move
it accordingly
..
bts_osmo.py: ready_for_pcu is of public access from tests, move it
Review at https://gerrit.osmocom.org/7314
gitignore Makefiles produced by 'make compile'
Change-Id: Ia71e76f0dce2ba2f9f5837f4d3d099dff92e8787
---
M .gitignore
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
refs/changes/14/7314/1
Review at https://gerrit.osmocom.org/7311
fix gen_links.sh: don't include source dir as link target
First of all, use one common place to define the gen_links() macro, in
gen_links.sh.inc.
In this new file, add a 'shift' to exclude the $DIR arg from also appearing in
$FILES.
This prevents
Neels Hofmeyr has abandoned this change.
Change subject: gitignore symlinks
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/7198
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: abandon
Neels Hofmeyr has abandoned this change.
Change subject: gitignore final 'make' generated files
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/7200
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/7313
gitignore */*.cc and */*.hh
ttcn3 creates these files, and they clutter 'git status' output.
The first patch explicitly ignored all *.cc and *.hh that we know are created
by ttcn; while I still think that would be the best way, here is an alternative
Review at https://gerrit.osmocom.org/7315
ignore results of .ttcnpp files
Add another macro ignore_pp_results to gen_links.sh.inc and call from all
gen_links.sh files, to add results of *.ttcnpp files, i.e. generated *.ttcn
files, to .gitignore.
Change-Id:
Review at https://gerrit.osmocom.org/7312
gen_links.sh: auto-generate .gitignore files to ignore symlinks
In each subdir that is a target for symlinks, automatically ignore the results
of gen_links():
- At the top of gen_links.sh.inc, clear the .gitignore.
- In the loop, add each link name to
Neels Hofmeyr has abandoned this change.
Change subject: gitignore 'make compile' generated files
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/7199
To unsubscribe, visit https://gerrit.osmocom.org/settings
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: Introduce ip.access nanobts support
..
Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M
Review at https://gerrit.osmocom.org/7316
sgsn: test GMM Attach with 3-digit leading-zero MNC
Add general infrastructure to
- pass an MCC-MNC for BSSGP to use into f_init();
- verify that the Attach Accept PLMN matches the BSSGP one.
Add TC_attach_mnc3() to feed an MNC with three digits and a
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7281
to look at the new patch set (#4).
use libosmocom to parse cell identifier in bssmap_rx_l3_compl()
Use the new gsm0808_dec_cell_id_list2() API to decode the cell
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7291
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief052cac5a862d6ef9391d40c294ba017387506c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: modem: workaround ofono crash
..
modem: workaround ofono crash
Since commit bfd0b2310cf09e32cb7d5dbe74ec57606a7d2aab, the IMSI is
retreived from
Patch Set 6:
I think your new cdf_test is not yet being executed. I had to add the import
_prep to successfully run them locally. Did you try yourself?
--
To view, visit https://gerrit.osmocom.org/6230
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Harald Welte has submitted this change and it was merged.
Change subject: use libosmocom to parse cell identifier in bssmap_rx_l3_compl()
..
use libosmocom to parse cell identifier in bssmap_rx_l3_compl()
Use the new
Harald Welte has submitted this change and it was merged.
Change subject: fix a cell identifier parsing bug in libosmocore
..
fix a cell identifier parsing bug in libosmocore
Global and LAI+LAC cell IDs were being misparsed
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7281
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I855477507e4d65fb9890da0ceea26dd2c4dfaf82
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7296
cosmetic: use enum ranap_nsap_addr_enc instead of int
The only reason to use int instead of the enum was the lack of header
iu_client.h when not building with Iu support. Rather use the configure result
properly, include the header when Iu support is
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7167
to look at the new patch set (#5).
Introduce PowerSupply interface and PowerSupplySispm
File powersupply.py defines the interface to be used by child
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7168
to look at the new patch set (#6).
Introduce ip.access nanobts support
Change-Id: Ibaea025b3a503dfe897d36701234445de6d49f82
---
M example/defaults.conf
M
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: remove disabled (debug) code gsm_04_08.c
..
cosmetic: remove disabled (debug) code gsm_04_08.c
gsm_04_08.c seems to contain some lines of old
Harald Welte has submitted this change and it was merged.
Change subject: Add stat items for the BTS's channel load average and T3122.
..
Add stat items for the BTS's channel load average and T3122.
In addition to logging the
Harald Welte has submitted this change and it was merged.
Change subject: Add support for Access Control Class ramping.
..
Add support for Access Control Class ramping.
Access Control Class (ACC) ramping is used to slowly make
Review at https://gerrit.osmocom.org/7297
compiler warnings: use enum ranap_nsap_addr_enc, constify local var
Use the proper enum ranap_nsap_addr_enc instead of int, and properly exclude
that member when we're building without Iu support:
sgsn_vty.c:1323:31: error: passing argument 2 of
Review at https://gerrit.osmocom.org/7298
jenkins.sh: add --enable-werror to configure flags
Change-Id: I76eb9ff1b2c334d70838a9d4f0aa0a77f199368d
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-sgsn refs/changes/98/7298/1
Patch Set 1:
See for reference: https://gerrit.osmocom.org/#/c/5672/
--
To view, visit https://gerrit.osmocom.org/7298
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76eb9ff1b2c334d70838a9d4f0aa0a77f199368d
Gerrit-PatchSet: 1
Patch Set 1:
Until we fix the osmo-iuh warnings, I bet this one is not going to pass :)
--
To view, visit https://gerrit.osmocom.org/7298
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I76eb9ff1b2c334d70838a9d4f0aa0a77f199368d
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7301
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dcc55f536f63b13a3da29fff1df5fe16751f83a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/7303
trans_free: tear down conn when last transaction is done
In trans_free(), call subscr_conn_release_when_unused(), so that we are sure to
clean up after the last transaction is done.
This fixes an error where a conn lingered after a CC failure, because
Review at https://gerrit.osmocom.org/7302
msc_vlr_tests: add CC Release test and test to catch OS#2779
These tests helped to debug issue OS#2779. Now that they're here we might as
well keep them.
The test test_call_mo_to_unknown shows that an MS answering to the Release
Request works as it
Review at https://gerrit.osmocom.org/7299
cosmetic: vlr_auth: log decision to send UMTS or GSM AKA challenge
Also indicate in msc_vlr_test_gsm_authen.c that we're indeed sending no
capability to do R99 in the Classmark 1 during LU request.
Change-Id: Id79a77ca1f218d55dad21d9dd3de92445fb5d6bf
Review at https://gerrit.osmocom.org/7300
cosmetic: msc_vlr_tests: enable CC logging in debug
There are a number of bad failures in CC teardown handling we're solving. It
helps to see CC logging in the msc_vlr_tests.
Change-Id: I56ac269d46b48b6b85efad81c4d2343bfc41ea90
---
M
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7302
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic3c84520bff8c3fc82512d03ff6ab97d21b8fb7a
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: msc_vlr_tests: add CC Release test and test to catch OS#2779
..
msc_vlr_tests: add CC Release test and test to catch OS#2779
These tests helped to debug
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/7303/1/src/libmsc/transaction.c
File src/libmsc/transaction.c:
PS1, Line 155: msc_subscr_conn_put
What I'm surprised is why the msc_subscr_conn_put() is not sufficient here. I
have the feeling that we have multiple
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: msc_vlr_tests: enable CC logging in debug
..
cosmetic: msc_vlr_tests: enable CC logging in debug
There are a number of bad failures in CC
Patch Set 1:
> I just checked the dependencies of *all* osmocom-related
> devel-packages a and also found (and fixed) issues in
> libosmocoding-devel
> libosmogb-devel
> libosmoctrl-devel
Great. Now, I think it makes sense to abandon this change.
--
To view, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7299
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id79a77ca1f218d55dad21d9dd3de92445fb5d6bf
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/7300
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I56ac269d46b48b6b85efad81c4d2343bfc41ea90
Gerrit-PatchSet: 1
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: vlr_auth: log decision to send UMTS or GSM AKA
challenge
..
cosmetic: vlr_auth: log decision to send UMTS or GSM AKA challenge
Also indicate
Review at https://gerrit.osmocom.org/7304
doc/examples: use NECI = 1 by default
Every setup should run with NECI = 1.
NECI = 0 is an ancient legacy setting.
Change-Id: I564cac73e610d71df5ab244e04d08dd2c5ff2324
---
M doc/examples/osmo-bsc/osmo-bsc.cfg
M
92 matches
Mail list logo
