Change in osmo-gsm-manuals[master]: debian/control: depends: add texlive-htmlxml

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13656 ) Change subject: debian/control: depends: add texlive-htmlxml .. Patch Set 1: See https://osmocom.org/issues/2537#note-5 -- To view,

Change in osmo-trx[master]: cleanup: remove comment copied from -uhd

2019-04-16 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/13660 Change subject: cleanup: remove comment copied from -uhd .. cleanup: remove comment copied from -uhd Change-Id:

Change in osmo-trx[master]: use BSC_FD_READ and not OSMO_FD_READ

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13659 ) Change subject: use BSC_FD_READ and not OSMO_FD_READ .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13659

Change in osmo-gsm-manuals[master]: debian/control: depends: add texlive-htmlxml

2019-04-16 Thread osmith
osmith has abandoned this change. ( https://gerrit.osmocom.org/13656 ) Change subject: debian/control: depends: add texlive-htmlxml .. Abandoned This patch is not needed, one can set the following in the OBS project config

Change in osmo-mgw[master]: mgcp-client: whitespace cleanup in mgcp_client.c

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13664 Change subject: mgcp-client: whitespace cleanup in mgcp_client.c .. mgcp-client: whitespace cleanup in mgcp_client.c Change-Id:

Change in osmo-mgw[master]: mgcp-client: Sanitize implementation of mgcp_client_rtpbridge_wildcard

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has uploaded this change for review. ( https://gerrit.osmocom.org/13665 Change subject: mgcp-client: Sanitize implementation of mgcp_client_rtpbridge_wildcard .. mgcp-client: Sanitize implementation of

Change in osmo-gsm-manuals[master]: debian: add patch for debian 8

2019-04-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13657 Change subject: debian: add patch for debian 8 .. debian: add patch for debian 8 Add a patch that changes the dependencies in debian/control, so

Change in osmo-gsm-manuals[master]: debian/control: depends: add texlive-htmlxml

2019-04-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13656 Change subject: debian/control: depends: add texlive-htmlxml .. debian/control: depends: add texlive-htmlxml Try to fix the "unresolvable" error in

Change in osmo-gsm-manuals[master]: debian/control: depends: add texlive-htmlxml

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13656 ) Change subject: debian/control: depends: add texlive-htmlxml .. Patch Set 1: I think for this kind of scenario (2 packets providing

Change in osmo-ci[master]: nightly-packages: add osmo-gsm-manuals-debian8-jessie

2019-04-16 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13658 ) Change subject: nightly-packages: add osmo-gsm-manuals-debian8-jessie .. Patch Set 1: Verified+1 I did: $ ln -s /bin/true /usr/local/bin/osc and

Change in osmo-ci[master]: nightly-packages: add osmo-gsm-manuals-debian8-jessie

2019-04-16 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/13658 Change subject: nightly-packages: add osmo-gsm-manuals-debian8-jessie .. nightly-packages: add osmo-gsm-manuals-debian8-jessie Create a compatible

Change in osmo-trx[master]: add device type detection

2019-04-16 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/13663 Change subject: add device type detection .. add device type detection device dependant max gain setup rework clock reference setup remove now unused

Change in osmo-trx[master]: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start (bw...

2019-04-16 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/13662 Change subject: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start (bw, freq, power need to be set) .. move LMS_GetLPFBWRange and

Change in osmo-trx[master]: move LMS_EnableChannel from Start/Stop to Open/Close device

2019-04-16 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/13661 Change subject: move LMS_EnableChannel from Start/Stop to Open/Close device .. move LMS_EnableChannel from Start/Stop to Open/Close device Change-Id:

Change in osmo-trx[master]: move LMS_EnableChannel from Start/Stop to Open/Close device

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13661 ) Change subject: move LMS_EnableChannel from Start/Stop to Open/Close device .. Patch Set 1: (1 comment)

Change in osmo-trx[master]: use BSC_FD_READ and not OSMO_FD_READ

2019-04-16 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13659 Change subject: use BSC_FD_READ and not OSMO_FD_READ .. use BSC_FD_READ and not OSMO_FD_READ We haven't even released any tagged version of

Change in osmo-trx[master]: add device type detection

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13663 ) Change subject: add device type detection .. Patch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/13663/1//COMMIT_MSG

Change in osmo-gsm-manuals[master]: debian/control: depends: add texlive-htmlxml

2019-04-16 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/13656 ) Change subject: debian/control: depends: add texlive-htmlxml .. Patch Set 1: Oh, that is how it works. Thanks for explaining, I'll adjust the OBS

Change in osmo-mgw[master]: mgcp-client: whitespace cleanup in mgcp_client.c

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13664 ) Change subject: mgcp-client: whitespace cleanup in mgcp_client.c .. Patch Set 1: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: cleanup: remove comment copied from -uhd

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13660 ) Change subject: cleanup: remove comment copied from -uhd .. Patch Set 1: (2 comments)

Change in osmo-trx[master]: lms: Remove wrong unused code copied from -uhd

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13660 ) Change subject: lms: Remove wrong unused code copied from -uhd .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: properly call close if set_antennas() fails, add some comments

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13667 ) Change subject: lms: properly call close if set_antennas() fails, add some comments .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-trx[master]: lms: add device type detection and device specific gains

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13663 ) Change subject: lms: add device type detection and device specific gains .. Patch Set 2: (1 comment)

Change in osmo-ccid-firmware[master]: ncn8025: Invert the software logic of RSTIN

2019-04-16 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13668 Change subject: ncn8025: Invert the software logic of RSTIN .. ncn8025: Invert the software logic of RSTIN In hardware, the Card RST pin is

Change in osmo-ccid-firmware[master]: manual_test.c: New manual board testing mode

2019-04-16 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13669 Change subject: manual_test.c: New manual board testing mode .. manual_test.c: New manual board testing mode Change-Id:

Change in osmo-trx[master]: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start (bw...

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13662 ) Change subject: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start (bw, freq, power need to be set) .. Patch Set 1: (2

Change in osmo-ccid-firmware[master]: main.c: Call ncn8025_init also for SIM7

2019-04-16 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13666 Change subject: main.c: Call ncn8025_init also for SIM7 .. main.c: Call ncn8025_init also for SIM7 The ncn8025 has no impact on the UART, so

Change in osmo-mgw[master]: mgcp-client: Sanitize implementation of mgcp_client_rtpbridge_wildcard

2019-04-16 Thread Pau Espin Pedrol
Hello Vadim Yanitskiy, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13665 to look at the new patch set (#2). Change subject: mgcp-client: Sanitize implementation of mgcp_client_rtpbridge_wildcard

Change in osmo-ccid-firmware[master]: manual_test.c: New manual board testing mode

2019-04-16 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13669 to look at the new patch set (#2). Change subject: manual_test.c: New manual board testing mode .. manual_test.c:

Change in osmo-ccid-firmware[master]: command.c: Print prompt when starting up

2019-04-16 Thread Harald Welte
Harald Welte has uploaded this change for review. ( https://gerrit.osmocom.org/13670 Change subject: command.c: Print prompt when starting up .. command.c: Print prompt when starting up Change-Id:

Change in osmo-trx[master]: move LMS_EnableChannel from Start/Stop to Open/Close device

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13661 ) Change subject: move LMS_EnableChannel from Start/Stop to Open/Close device .. Patch Set 1: (1 comment)

Change in osmo-trx[master]: move LMS_EnableChannel from Start/Stop to Open/Close device

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13661 ) Change subject: move LMS_EnableChannel from Start/Stop to Open/Close device .. Patch Set 1: (1 comment)

Change in osmo-trx[master]: add device type detection

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13663 ) Change subject: add device type detection .. Patch Set 1: (4 comments)

Change in osmo-trx[master]: lms: add device type detection and device specific gains

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13663 ) Change subject: lms: add device type detection and device specific gains .. Patch Set 2: Code-Review-1 (1 comment)

Change in osmo-ccid-firmware[master]: main.c: Call ncn8025_init also for SIM7

2019-04-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13666 ) Change subject: main.c: Call ncn8025_init also for SIM7 .. main.c: Call ncn8025_init also for SIM7 The ncn8025 has no impact on the

Change in osmo-ccid-firmware[master]: main.c: Call ncn8025_init also for SIM7

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13666 ) Change subject: main.c: Call ncn8025_init also for SIM7 .. Patch Set 1: Verified+1 -- To view, visit https://gerrit.osmocom.org/13666 To

Change in osmo-ccid-firmware[master]: main.c: Call ncn8025_init also for SIM7

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13666 ) Change subject: main.c: Call ncn8025_init also for SIM7 .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13666

Change in osmo-trx[master]: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start

2019-04-16 Thread roh
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13662 to look at the new patch set (#2). Change subject: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start

Change in osmo-trx[master]: lms: add device type detection and device specific gains

2019-04-16 Thread roh
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13663 to look at the new patch set (#2). Change subject: lms: add device type detection and device specific gains

Change in osmo-trx[master]: lms: properly call close if set_antennas() fails, add some comments

2019-04-16 Thread roh
roh has uploaded this change for review. ( https://gerrit.osmocom.org/13667 Change subject: lms: properly call close if set_antennas() fails, add some comments .. lms: properly call close if set_antennas() fails, add some

Change in osmo-trx[master]: lms: Remove wrong unused code copied from -uhd

2019-04-16 Thread roh
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13660 to look at the new patch set (#2). Change subject: lms: Remove wrong unused code copied from -uhd .. lms: Remove

Change in osmo-trx[master]: lms: move LMS_EnableChannel from Start/Stop to Open/Close device

2019-04-16 Thread roh
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13661 to look at the new patch set (#2). Change subject: lms: move LMS_EnableChannel from Start/Stop to Open/Close device

Change in osmo-mgw[master]: mgcp-client: Sanitize implementation of mgcp_client_rtpbridge_wildcard

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13665 ) Change subject: mgcp-client: Sanitize implementation of mgcp_client_rtpbridge_wildcard .. Patch Set 1: Code-Review+1 (1 comment)

Change in osmo-trx[master]: lms: move LMS_EnableChannel from Start/Stop to Open/Close device

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13661 ) Change subject: lms: move LMS_EnableChannel from Start/Stop to Open/Close device .. Patch Set 2: Code-Review+1 -- To view, visit

Change in osmo-trx[master]: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13662 ) Change subject: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start .. Patch Set 2: Code-Review-1 (1 comment)

Change in osmo-trx[master]: lms: add device type detection and device specific gains

2019-04-16 Thread roh
Hello Pau Espin Pedrol, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13663 to look at the new patch set (#3). Change subject: lms: add device type detection and device specific gains

Change in osmo-ccid-firmware[master]: manual_test.c: New manual board testing mode

2019-04-16 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13669 to look at the new patch set (#3). Change subject: manual_test.c: New manual board testing mode .. manual_test.c:

Change in osmo-ccid-firmware[master]: command.c: Print prompt when starting up

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13670 ) Change subject: command.c: Print prompt when starting up .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/13670

Change in osmo-ccid-firmware[master]: ncn8025: Invert the software logic of RSTIN

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13668 ) Change subject: ncn8025: Invert the software logic of RSTIN .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-ccid-firmware[master]: command.c: Print prompt when starting up

2019-04-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13670 ) Change subject: command.c: Print prompt when starting up .. command.c: Print prompt when starting up Change-Id:

Change in gr-gsm[master]: grgsm_capture: Fix device arguments

2019-04-16 Thread Vasil Velichkov
Hello Piotr Krysik, Vadim Yanitskiy, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/13672 to review the following change. Change subject: grgsm_capture: Fix device arguments .. grgsm_capture:

Change in osmo-trx[master]: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start

2019-04-16 Thread roh
roh has posted comments on this change. ( https://gerrit.osmocom.org/13662 ) Change subject: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start .. Patch Set 2: (1 comment)

Change in osmo-ccid-firmware[master]: switch UART_debug to ASYNC

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13673 Change subject: switch UART_debug to ASYNC .. switch UART_debug to ASYNC using the synchronous HAL library causes RX overflow after 5 bytes

Change in osmo-ccid-firmware[master]: add sim-atr command

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13681 Change subject: add sim-atr command .. add sim-atr command the sim-atr command resets the card and read the resulting answer to reset.

Change in osmo-ccid-firmware[master]: change SERCOM clock to 3.3 MHz

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13680 Change subject: change SERCOM clock to 3.3 MHz .. change SERCOM clock to 3.3 MHz we use the SERCOM peripheral for USART (in 7816 mode SIM

Change in osmo-ccid-firmware[master]: minor: change variable type to remove compiler warning

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13684 Change subject: minor: change variable type to remove compiler warning .. minor: change variable type to remove compiler warning Change-Id:

Change in osmo-ccid-firmware[master]: UART_debug now uses the async library with tx ring

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13678 Change subject: UART_debug now uses the async library with tx ring .. UART_debug now uses the async library with tx ring Change-Id:

Change in osmo-ccid-firmware[master]: add async library with ring on TX

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13677 Change subject: add async library with ring on TX .. add async library with ring on TX the standard async library expected the caller to wait

Change in osmo-ccid-firmware[master]: remove example code

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13676 Change subject: remove example code .. remove example code as the code will use alternative libraries, the examples will not be able to

Change in osmo-ccid-firmware[master]: minor: fix typo

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13682 Change subject: minor: fix typo .. minor: fix typo Change-Id: I57c743250af19713e7438606bc1c737cfe0c383c --- M

Change in osmo-ccid-firmware[master]: add ASFv4 M2M middleware

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13675 Change subject: add ASFv4 M2M middleware .. add ASFv4 M2M middleware Change-Id: Ib07755b2c5974af70817f5460fb0f358c631452a --- M

Change in osmo-ccid-firmware[master]: change ISO baud rate default to 6720 bps

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13679 Change subject: change ISO baud rate default to 6720 bps .. change ISO baud rate default to 6720 bps the ISO7816 I/O baud rate is f / (Fd /

Change in osmo-ccid-firmware[master]: minor: improve documentation

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13683 Change subject: minor: improve documentation .. minor: improve documentation Change-Id: I250209d45a57c5ad7d1265a68aa71fc31ec06f69 --- M

Change in osmo-ccid-firmware[master]: remove SWO pin initialisation

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13674 Change subject: remove SWO pin initialisation .. remove SWO pin initialisation Change-Id: I199d6e356129526e65d5d1075a264eb35904d099 --- M

Change in osmo-ccid-firmware[master]: minor: remove unnecessary hellow world command

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13685 Change subject: minor: remove unnecessary hellow world command .. minor: remove unnecessary hellow world command Change-Id:

Change in osmo-ccid-firmware[master]: manual_test.c: New manual board testing mode

2019-04-16 Thread Harald Welte
Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13669 ) Change subject: manual_test.c: New manual board testing mode .. Patch Set 3: Code-Review+2 -- To view, visit

Change in gr-gsm[master]: Improve the TCH/H decoder logs

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13671 ) Change subject: Improve the TCH/H decoder logs .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13671 To

Build failure of network:osmocom:nightly/libosmo-netif in Debian_9.0/armv7l

2019-04-16 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmo-netif/Debian_9.0/armv7l Package network:osmocom:nightly/libosmo-netif failed to build in Debian_9.0/armv7l Check out the package for editing: osc checkout network:osmocom:nightly libosmo-netif Last lines

Change in osmo-ccid-firmware[master]: manual_test.c: New manual board testing mode

2019-04-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13669 ) Change subject: manual_test.c: New manual board testing mode .. manual_test.c: New manual board testing mode Change-Id:

Change in osmo-ccid-firmware[master]: ncn8025: Invert the software logic of RSTIN

2019-04-16 Thread Harald Welte
Harald Welte has submitted this change and it was merged. ( https://gerrit.osmocom.org/13668 ) Change subject: ncn8025: Invert the software logic of RSTIN .. ncn8025: Invert the software logic of RSTIN In hardware, the Card

Change in osmo-trx[master]: lms: properly call close if set_antennas() fails, add some comments

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13667 ) Change subject: lms: properly call close if set_antennas() fails, add some comments .. Patch Set 2: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: add device type detection and device specific gains

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13663 ) Change subject: lms: add device type detection and device specific gains .. Patch Set 3: Code-Review+2 -- To view, visit

Change in osmo-trx[master]: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13662 ) Change subject: lms: move LMS_GetLPFBWRange and LMS_Calibrate calls from open to start .. Patch Set 2: Code-Review+1 -- To view,

Change in gr-gsm[master]: Improve the TCH/H decoder logs

2019-04-16 Thread Vasil Velichkov
Hello Piotr Krysik, Vadim Yanitskiy, I'd like you to do a code review. Please visit https://gerrit.osmocom.org/13671 to review the following change. Change subject: Improve the TCH/H decoder logs .. Improve the TCH/H

Change in gr-gsm[master]: grgsm_capture: Fix device arguments

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13672 ) Change subject: grgsm_capture: Fix device arguments .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/13672 To

Change in gr-gsm[master]: Improve the TCH/H decoder logs

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13671 ) Change subject: Improve the TCH/H decoder logs .. Patch Set 1: (1 comment)

Change in osmo-ccid-firmware[master]: update ASFv4 library to 1.0.1465

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13688 Change subject: update ASFv4 library to 1.0.1465 .. update ASFv4 library to 1.0.1465 Change-Id: I828e87c7ededbb50a999d672cf0b738eef9a093a ---

Change in osmo-ccid-firmware[master]: minor: update atmel start project configuration

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13686 Change subject: minor: update atmel start project configuration .. minor: update atmel start project configuration Change-Id:

Change in osmo-ccid-firmware[master]: add sim-atr command

2019-04-16 Thread Kévin Redon
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13681 to look at the new patch set (#2). Change subject: add sim-atr command .. add sim-atr command the sim-atr command

Change in osmo-ccid-firmware[master]: update CMSIS to 5.1.2

2019-04-16 Thread Kévin Redon
Kévin Redon has uploaded this change for review. ( https://gerrit.osmocom.org/13687 Change subject: update CMSIS to 5.1.2 .. update CMSIS to 5.1.2 this changes comes from Atmel START Change-Id:

Change in osmo-ttcn3-hacks[master]: BSSMAP_Emulation: Check for ==/!= null instead of isvalue()

2019-04-16 Thread dexter
dexter has submitted this change and it was merged. ( https://gerrit.osmocom.org/13648 ) Change subject: BSSMAP_Emulation: Check for ==/!= null instead of isvalue() .. BSSMAP_Emulation: Check for ==/!= null instead of isvalue()

Change in osmo-ttcn3-hacks[master]: BSSMAP_Emulation: Check for ==/!= null instead of isvalue()

2019-04-16 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/13648 ) Change subject: BSSMAP_Emulation: Check for ==/!= null instead of isvalue() .. Patch Set 1: Verified+1 Code-Review+1 > Patch Set 1: Code-Review+2

Change in osmo-ttcn3-hacks[master]: Rename BSSMAP_Emulation -> RAN_Emulation

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13650 ) Change subject: Rename BSSMAP_Emulation -> RAN_Emulation .. Patch Set 1: Looks like you need to rebase your patchset. -- To view,

Change in osmo-bts[master]: pcu_sock: use %zu conversion specifier for printing sizeof() result

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has posted comments on this change. ( https://gerrit.osmocom.org/13267 ) Change subject: pcu_sock: use %zu conversion specifier for printing sizeof() result .. Patch Set 5: Code-Review+2 -- To view, visit

Change in osmo-sgsn[master]: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling G...

2019-04-16 Thread Pau Espin Pedrol
Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13654 ) Change subject: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests .. Patch Set 1: (1 comment)

Change in osmo-bts[master]: pcu_sock: use %zu conversion specifier for printing sizeof() result

2019-04-16 Thread dexter
Hello Vadim Yanitskiy, Pau Espin Pedrol, Daniel Willmann, Max, Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13267 to look at the new patch set (#5). Change subject: pcu_sock: use %zu conversion specifier for printing sizeof()

Change in osmo-sgsn[master]: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling G...

2019-04-16 Thread lynxis lazus
lynxis lazus has uploaded this change for review. ( https://gerrit.osmocom.org/13654 Change subject: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests .. gprs_gmm: reintroduce calling

Change in osmo-msc[master]: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length

2019-04-16 Thread Vadim Yanitskiy
Vadim Yanitskiy has uploaded this change for review. ( https://gerrit.osmocom.org/13655 Change subject: libmsc/gsm_04_11.c: properly handle TP-User-Data-Length .. libmsc/gsm_04_11.c: properly handle TP-User-Data-Length As per

Change in osmo-sgsn[master]: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling G...

2019-04-16 Thread lynxis lazus
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/13654 to look at the new patch set (#2). Change subject: gprs_gmm: reintroduce calling gsm48_gmm_authorize when not handling GMM Attach Requests