[S] Change in libosmocore[master]: Fix union abis_rsl_chan_nr and abis_rsl_link_id

2023-11-29 Thread jolly
jolly has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email ) Change subject: Fix union abis_rsl_chan_nr and abis_rsl_link_id .. Fix union abis_rsl_chan_nr and abis_rsl_link_id All

[S] Change in libosmocore[master]: Fix union abis_rsl_chan_nr and abis_rsl_link_id

2023-11-29 Thread laforge
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email ) Change subject: Fix union abis_rsl_chan_nr and abis_rsl_link_id .. Patch

[S] Change in libosmocore[master]: Fix union abis_rsl_chan_nr and abis_rsl_link_id

2023-11-29 Thread fixeria
Attention is currently required from: jolly. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email ) Change subject: Fix union abis_rsl_chan_nr and abis_rsl_link_id .. Patch

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
osmith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Update git URLs git.osmocom.org has been deprecated, use gerrit or gitea urls

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-29 Thread laforge
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers .. Patch Set 6:

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-29 Thread laforge
Attention is currently required from: jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email ) Change subject: Use polling based LAPDm with frame numbers .. Patch Set 6:

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number

2023-11-29 Thread dexter
Attention is currently required from: fixeria. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number ..

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number

2023-11-29 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35136?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number .. ttcn3-pcu-test/sns: fix PCUIF version number The current

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 1: Verified+1 (1 comment) Patchset: PS1: I've verified that this

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Removed Verified-1 by Jenkins Builder (102) -- To view, visit

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

2023-11-29 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch) .. ttcn3-pcu-test/sns: fix PCUIF

[S] Change in docker-playground[master]: Revert "ttcn3-pcu-test/sns: fix PCUIF version number"

2023-11-29 Thread dexter
dexter has uploaded this change for review. ( https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email ) Change subject: Revert "ttcn3-pcu-test/sns: fix PCUIF version number" .. Revert "ttcn3-pcu-test/sns: fix PCUIF

[S] Change in docker-playground[master]: Revert "ttcn3-pcu-test/sns: fix PCUIF version number"

2023-11-29 Thread dexter
dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email ) Change subject: Revert "ttcn3-pcu-test/sns: fix PCUIF version number" .. Patch Set 1: Code-Review+2 -- To view,

[S] Change in docker-playground[master]: Revert "ttcn3-pcu-test/sns: fix PCUIF version number"

2023-11-29 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35158?usp=email ) Change subject: Revert "ttcn3-pcu-test/sns: fix PCUIF version number" .. Revert "ttcn3-pcu-test/sns: fix PCUIF version

[S] Change in libosmocore[master]: Fix union abis_rsl_chan_nr and abis_rsl_link_id

2023-11-29 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35156?usp=email ) Change subject: Fix union abis_rsl_chan_nr and abis_rsl_link_id .. Fix union abis_rsl_chan_nr and abis_rsl_link_id All bit

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

2023-11-29 Thread jolly
Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email to look at the new patch set (#5). The following approvals got outdated and were

[M] Change in osmo-hnbgw[master]: mgw_fsm: Modify RAB on HNB if IuUP local IP addr at MGW changes durin...

2023-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168?usp=email ) Change subject: mgw_fsm: Modify RAB on HNB if IuUP local IP addr at MGW changes during MDCX .. mgw_fsm: Modify RAB on

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Rename record CrcxResponse->MgwResponse

2023-11-29 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35165?usp=email ) Change subject: hnbgw: Rename record CrcxResponse->MgwResponse ..

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Rename mgcp conns to reflect each side peer

2023-11-29 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35164?usp=email ) Change subject: hnbgw: Rename mgcp conns to reflect each side peer ..

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

2023-11-29 Thread pespin
Attention is currently required from: dexter, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-29 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (2 comments) File

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
Attention is currently required from: pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 2: (2 comments) Commit

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

2023-11-29 Thread pespin
Attention is currently required from: arehbein, daniel, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread fixeria
Attention is currently required from: daniel, jolly, laforge. fixeria has removed fixeria from this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references

[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend

2023-11-29 Thread pespin
Attention is currently required from: daniel, laforge, lynxis lazus. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email ) Change subject: osmo_io: Factor out and use common send function from backend

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

2023-11-29 Thread jolly
Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email to look at the new patch set (#6). The following approvals got outdated and were

[M] Change in osmo-bts[master]: Use polling based LAPDm with frame numbers

2023-11-29 Thread jolly
Attention is currently required from: fixeria, jolly, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bts/+/35007?usp=email to look at the new patch set (#7). The following approvals got outdated and were

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

2023-11-29 Thread Jenkins Builder
Attention is currently required from: fixeria, jolly, laforge. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) Change subject: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Allow announcing a different mgw-local IuUP address after MDCX

2023-11-29 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35166?usp=email ) Change subject: hnbgw: Allow announcing a different mgw-local IuUP address after MDCX

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_rab_assign_mgw_iuup_addr_chg

2023-11-29 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35167?usp=email ) Change subject: hnbgw: Introduce test TC_rab_assign_mgw_iuup_addr_chg

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread laforge
Attention is currently required from: daniel, fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread fixeria
Attention is currently required from: daniel, fixeria, jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread fixeria
Attention is currently required from: daniel, fixeria, jolly, laforge. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

2023-11-29 Thread daniel
Attention is currently required from: arehbein. Hello Jenkins Builder, arehbein, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email to look at the new patch set (#4). Change subject: osmo_io: Remove union in struct osmo_io_ops

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Rename mgcp conns to reflect each side peer

2023-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35164?usp=email ) Change subject: hnbgw: Rename mgcp conns to reflect each side peer .. hnbgw: Rename mgcp conns to reflect each

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Rename record CrcxResponse->MgwResponse

2023-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35165?usp=email ) Change subject: hnbgw: Rename record CrcxResponse->MgwResponse .. hnbgw: Rename record CrcxResponse->MgwResponse

[S] Change in osmo-ttcn3-hacks[master]: hnbgw: Allow announcing a different mgw-local IuUP address after MDCX

2023-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35166?usp=email ) Change subject: hnbgw: Allow announcing a different mgw-local IuUP address after MDCX .. hnbgw: Allow announcing

[M] Change in osmo-ttcn3-hacks[master]: hnbgw: Introduce test TC_rab_assign_mgw_iuup_addr_chg

2023-11-29 Thread pespin
pespin has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35167?usp=email ) Change subject: hnbgw: Introduce test TC_rab_assign_mgw_iuup_addr_chg .. hnbgw: Introduce test

[M] Change in osmo-hnbgw[master]: mgw_fsm: Modify RAB on HNB if IuUP local IP addr at MGW changes durin...

2023-11-29 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35168?usp=email ) Change subject: mgw_fsm: Modify RAB on HNB if IuUP local IP addr at MGW changes during MDCX

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
Attention is currently required from: fixeria, osmith, pespin. osmith has removed a vote from this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Removed

[M] Change in osmo-hnbgw[master]: mgw_fsm: Assume IuUP HNB IP addr = Iuh during MGCP CRCX on RAN side

2023-11-29 Thread pespin
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/35153?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: mgw_fsm: Assume IuUP

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread pespin
Attention is currently required from: fixeria, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 2:

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread fixeria
Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 2: (2 comments)

[S] Change in libosmocore[master]: Add flag to enable RTS based polling

2023-11-29 Thread jolly
jolly has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35160?usp=email ) Change subject: Add flag to enable RTS based polling .. Add flag to enable RTS based polling RTS based polling in LAPDm code is

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread dexter
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35161?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread dexter
Attention is currently required from: fixeria, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35161?usp=email ) Change subject: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

[M] Change in osmo-hnbgw[master]: mgw_fsm: Assume IuUP HNB IP addr = Iuh during MGCP CRCX on RAN side

2023-11-29 Thread laforge
Attention is currently required from: pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35153?usp=email ) Change subject: mgw_fsm: Assume IuUP HNB IP addr = Iuh during MGCP CRCX on RAN side

[S] Change in osmo-ggsn[master]: libgtp: Remove defines for reserved causes in gtp.h

2023-11-29 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35162?usp=email ) Change subject: libgtp: Remove defines for reserved causes in gtp.h .. libgtp: Remove defines for reserved causes in

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
osmith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Update git URLs git.osmocom.org has been deprecated, use gerrit or gitea urls instead.

[S] Change in osmo-pcu[master]: gprs_rlcmac_sched: rewrite logic around idle block skip

2023-11-29 Thread fixeria
Attention is currently required from: dexter, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email ) Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip

[S] Change in osmo-pcu[master]: gprs_rlcmac_sched: rewrite logic around idle block skip

2023-11-29 Thread pespin
Attention is currently required from: dexter, fixeria. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35151?usp=email ) Change subject: gprs_rlcmac_sched: rewrite logic around idle block skip

[S] Change in osmo-ggsn[master]: libgtp: Remove defines for reserved causes in gtp.h

2023-11-29 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35162?usp=email ) Change subject: libgtp: Remove defines for reserved causes in gtp.h .. Patch Set 1: Code-Review+2 -- To view, visit

[S] Change in osmo-ggsn[master]: libgtp: Remove defines for reserved causes in gtp.h

2023-11-29 Thread daniel
daniel has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35162?usp=email ) Change subject: libgtp: Remove defines for reserved causes in gtp.h .. libgtp: Remove defines for reserved causes in gtp.h As

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

2023-11-29 Thread daniel
Attention is currently required from: arehbein, daniel. Hello Jenkins Builder, arehbein, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

2023-11-29 Thread Jenkins Builder
Attention is currently required from: arehbein, daniel. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops

[S] Change in osmo-bts[master]: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

2023-11-29 Thread laforge
Attention is currently required from: fixeria, jolly. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/35082?usp=email ) Change subject: LAPDm: Reject (release) establishment on DCCH, SAPI 0 without L3 payload

[L] Change in libosmocore[master]: Add a GSM RLP decoder and encoder

2023-11-29 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email ) Change subject: Add a GSM RLP decoder and encoder .. Add a GSM RLP decoder and encoder This code implements a decoder and

[M] Change in osmo-mgw[master]: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0

2023-11-29 Thread laforge
Attention is currently required from: dexter, neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email ) Change subject: mgcp-cli: Transmit remote IP addr in CRCX if known and port=0

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-29 Thread pespin
Attention is currently required from: daniel. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

2023-11-29 Thread daniel
Attention is currently required from: arehbein. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops .. Patch

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread dexter
Attention is currently required from: fixeria, laforge. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35161?usp=email ) Change subject: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

[S] Change in osmo-ggsn[master]: gtp: Add net GTP cause values and a function to check for success

2023-11-29 Thread daniel
daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35084?usp=email ) Change subject: gtp: Add net GTP cause values and a function to check for success .. Patch Set 2: (1 comment) File

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread pespin
Attention is currently required from: daniel, fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 1: Verified+1

[S] Change in libosmocore[master]: Add flag to enable RTS based polling

2023-11-29 Thread pespin
Attention is currently required from: fixeria, jolly, laforge. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35160?usp=email ) Change subject: Add flag to enable RTS based polling ..

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
Attention is currently required from: fixeria, osmith. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email to look at the new patch set (#2). The following approvals got outdated and were

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread osmith
Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 2: Verified+1

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

2023-11-29 Thread dexter
Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

[L] Change in libosmocore[master]: Add a GSM RLP decoder and encoder

2023-11-29 Thread laforge
Attention is currently required from: osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35123?usp=email ) Change subject: Add a GSM RLP decoder and encoder .. Patch Set 8:

[S] Change in osmo-gsm-tester[master]: Update git URLs

2023-11-29 Thread laforge
Attention is currently required from: fixeria, osmith. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-gsm-tester/+/35157?usp=email ) Change subject: Update git URLs .. Patch Set 2:

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

2023-11-29 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

2023-11-29 Thread laforge
laforge has submitted this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch) .. ttcn3-pcu-test/sns: fix PCUIF version

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread laforge
Attention is currently required from: dexter, fixeria. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35161?usp=email ) Change subject: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread fixeria
Attention is currently required from: dexter. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/pysim/+/35161?usp=email ) Change subject: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend

2023-11-29 Thread daniel
Attention is currently required from: laforge, lynxis lazus, pespin. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email ) Change subject: osmo_io: Factor out and use common send function from backend

[M] Change in libosmocore[master]: osmo_io: Factor out and use common send function from backend

2023-11-29 Thread daniel
Attention is currently required from: laforge, lynxis lazus, pespin. Hello Jenkins Builder, lynxis lazus, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35078?usp=email to look at the new patch set (#2). The following approvals got outdated and

[M] Change in libosmocore[master]: osmo_io: Remove union in struct osmo_io_ops

2023-11-29 Thread daniel
Attention is currently required from: arehbein. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35079?usp=email ) Change subject: osmo_io: Remove union in struct osmo_io_ops .. Set

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread dexter
dexter has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/35161?usp=email ) Change subject: pySim-shell: Do not use self.lchan.scc when sending raw APDUs. .. pySim-shell: Do not use self.lchan.scc when sending

[S] Change in docker-playground[master]: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch)

2023-11-29 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/docker-playground/+/35159?usp=email ) Change subject: ttcn3-pcu-test/sns: fix PCUIF version number (follow up patch) .. Patch Set 1: (1 comment)

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread daniel
daniel has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references .. utils: Link with libosmoisdn to avoid

[M] Change in osmo-hnbgw[master]: mgw_fsm: Assume IuUP HNB IP addr = Iuh during MGCP CRCX on RAN side

2023-11-29 Thread pespin
pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/35153?usp=email ) Change subject: mgw_fsm: Assume IuUP HNB IP addr = Iuh during MGCP CRCX on RAN side .. Set Ready For Review -- To

[S] Change in libosmocore[master]: Add flag to enable RTS based polling

2023-11-29 Thread jolly
Attention is currently required from: fixeria, jolly, laforge, pespin. Hello Jenkins Builder, fixeria, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35160?usp=email to look at the new patch set (#2). The following approvals

[S] Change in libosmocore[master]: Add flag to enable RTS based polling

2023-11-29 Thread jolly
Attention is currently required from: fixeria, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35160?usp=email ) Change subject: Add flag to enable RTS based polling ..

[S] Change in pysim[master]: pySim-shell: Do not use self.lchan.scc when sending raw APDUs.

2023-11-29 Thread dexter
Attention is currently required from: fixeria, laforge. Hello Jenkins Builder, fixeria, laforge, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/pysim/+/35161?usp=email to look at the new patch set (#4). The following approvals got outdated and were removed:

[S] Change in osmo-ggsn[master]: libgtp: Remove defines for reserved causes in gtp.h

2023-11-29 Thread osmith
Attention is currently required from: daniel. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35162?usp=email ) Change subject: libgtp: Remove defines for reserved causes in gtp.h ..

[S] Change in osmo-ggsn[master]: libgtp: Remove defines for reserved causes in gtp.h

2023-11-29 Thread pespin
Attention is currently required from: daniel, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/35162?usp=email ) Change subject: libgtp: Remove defines for reserved causes in gtp.h

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread daniel
Attention is currently required from: fixeria, jolly, laforge. daniel has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references

[S] Change in libosmocore[master]: utils: Link with libosmoisdn to avoid undefined references

2023-11-29 Thread daniel
daniel has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35163?usp=email ) Change subject: utils: Link with libosmoisdn to avoid undefined references .. Abandoned -- To view, visit

[S] Change in libosmocore[master]: soft_uart: check Rx/Tx state once in osmo_soft_uart_{rx,tx}_ubits()

2023-11-29 Thread fixeria
Attention is currently required from: fixeria. Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/libosmocore/+/35171?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified-1 by Jenkins

[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling

2023-11-29 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: client: replace two assertions with graceful error handling .. client: replace two assertions with graceful error

[S] Change in osmo-mgw[master]: client: replace two assertions with graceful error handling

2023-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34997?usp=email ) Change subject: client: replace two assertions with graceful error handling .. Patch Set 2: Code-Review+2 -- To view,

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-11-29 Thread neels
neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email ) Change subject: add fmtp string to ptmap: allow all possible fmtp .. Patch Set 6: (1 comment) File tests/mgcp/mgcp_test.c:

[M] Change in osmo-ttcn3-hacks[master]: bsc: tests recovery from BORKEN after release failed

2023-11-29 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/35098?usp=email ) Change subject: bsc: tests recovery from BORKEN after release failed .. bsc: tests recovery from BORKEN after release failed

[L] Change in osmo-mgw[master]: add fmtp string to ptmap: allow all possible fmtp

2023-11-29 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/34900?usp=email to look at the new patch set (#6). The following approvals got outdated and were removed:

[M] Change in osmo-mgw[master]: mgcp-client: MGCP response: pass fmtp to caller

2023-11-29 Thread neels
Attention is currently required from: laforge, pespin. Hello Jenkins Builder, laforge, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-mgw/+/34905?usp=email to look at the new patch set (#3). The following approvals got outdated and were removed:

[S] Change in osmo-bsc[master]: systemd,manual: set LimitNOFILE=65536

2023-11-29 Thread neels
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-bsc/+/35173?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed: Verified+1 by Jenkins Builder Change subject: systemd,manual: set

[S] Change in osmo-msc[master]: call_leg: silence some false errors

2023-11-29 Thread neels
neels has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35100?usp=email ) Change subject: call_leg: silence some false errors .. call_leg: silence some false errors "[ESTABLISHED] transition to state

[S] Change in osmo-msc[master]: msc_vlr_test_call: drop misleading log

2023-11-29 Thread neels
Attention is currently required from: neels. Hello Jenkins Builder, fixeria, pespin, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/c/osmo-msc/+/35137?usp=email to look at the new patch set (#2). The following approvals got outdated and were removed:

[M] Change in osmo-mgw[master]: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically

2023-11-29 Thread neels
Attention is currently required from: dexter. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/34404?usp=email ) Change subject: mgcp_client_fsm: allocate struct mgcp_conn_peer dynamically ..

[L] Change in libosmocore[master]: soft_uart: implement modem status lines and flow control

2023-11-29 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/35172?usp=email ) Change subject: soft_uart: implement modem status lines and flow control .. soft_uart: implement modem status lines

  1   2   >