Patch Set 3: Code-Review-1
To recap discussion at the OsmoDevCon, the last remaining request before the
patch can be merged is to add an AVX target, which is a minor change.
Regarding clang support I also vote for moving this out of this ticket into a
new one.
--
To view, visit
Harald Welte has submitted this change and it was merged.
Change subject: deliver_to_mtp_user(): Fix null pointer dereference
..
deliver_to_mtp_user(): Fix null pointer dereference
We had used + derefernced the 'prim' pointer
Harald Welte has submitted this change and it was merged.
Change subject: scu_gen_encode_and_send(): Fix NULL pointer deref
..
scu_gen_encode_and_send(): Fix NULL pointer deref
We were using the 'xua' pointer before checkin if
Harald Welte has submitted this change and it was merged.
Change subject: osmo_sccp_addr_parse() Fix point code integer precision handling
..
osmo_sccp_addr_parse() Fix point code integer precision handling
"(cur[1] << 8) &
Harald Welte has submitted this change and it was merged.
Change subject: sccp_scoc: don't pass variable as argument if we know it's NULL
..
sccp_scoc: don't pass variable as argument if we know it's NULL
xua will always be
Harald Welte has submitted this change and it was merged.
Change subject: ss7_test: Fix '=' that should have been '=='
..
ss7_test: Fix '=' that should have been '=='
Change-Id: I1be4529c73992cb342a62aa19ba79be25e982620
Fixes:
Harald Welte has submitted this change and it was merged.
Change subject: sclc_rx_cldr(): Don't try to dereference user data_ie without
check
..
sclc_rx_cldr(): Don't try to dereference user data_ie without check
While the
Harald Welte has submitted this change and it was merged.
Change subject: m3ua_to_xfer_ind(): don't use data_ie without checking it exists
..
m3ua_to_xfer_ind(): don't use data_ie without checking it exists
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7_user_unregister(): Don't dereference NULL user
..
osmo_ss7_user_unregister(): Don't dereference NULL user
The 'user' argument to
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2439
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia34b181dcbcb179b2639e2f405364cc952069842
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2440
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie47e632f4bca490baf4282dc5d55ee55ca7f1ae8
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2438
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6dc56442441489aefc706bcebc49197ca3dae1e
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix 'make check'
..
fix 'make check'
Apply various fixes that arose from test case code rot. These tests will now be
used to verify patches submitted
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2444
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5277be0c434226d9d02e038f0bc72fd2557350c1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2444
to look at the new patch set (#2).
fix 'make check'
Apply various fixes that arose from test case code rot. These tests will now be
used to verify patches submitted to gerrit, so they
Review at https://gerrit.osmocom.org/2444
fix 'make check'
Apply various fixes that arose from test case code rot. These tests will now be
used to verify patches submitted to gerrit, so they need to be up to par.
Change-Id: I5277be0c434226d9d02e038f0bc72fd2557350c1
Related: OS#2215
---
M
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2443/1/contrib/jenkins-run.sh
File contrib/jenkins-run.sh:
Line 39: ssh "$osmo_gsm_tester_host" "ln -s $trial_dir
$osmo_gsm_tester_dir/trial-latest"
There's an issue of "polluting" the namespace of trials. This trial dir
Review at https://gerrit.osmocom.org/2443
jenkins-run: Provide a link to the latest trial archived
Change-Id: I26ddf55110738bd1944ccbfe72e8410ff9811392
---
M contrib/jenkins-run.sh
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-tester
Review at https://gerrit.osmocom.org/2442
OsmoGSMTester: fix typo in example
Change-Id: Iac0efc7fc561377c6a8a51ab7cd434e47bab458a
---
M OsmoGSMTester/chapters/intro.adoc
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
Review at https://gerrit.osmocom.org/2441
Fix wrongful GSM codecs SID frame detection in DTX.
Based on ETSI TS 101 318 section 5.1.2 the 95 bits SID code word
is not detected correctly due to a wrongful offset in the bits
location indexes.
Change-Id: I45d98c6edf267f313883503a65385190ffbc65ca
Review at https://gerrit.osmocom.org/2438
sccp_scoc: don't pass variable as argument if we know it's NULL
xua will always be NULL in one particular switch case of
scoc_fsm_conn_pend_out(), so let's use NULL directly rather than obscure
it though a variable that might be understood as this
Review at https://gerrit.osmocom.org/2440
osmo_sccp_addr_parse() Fix point code integer precision handling
"(cur[1] << 8) & 0x3f" is always 0 regardless of the values of its
operands.
Change-Id: Ie47e632f4bca490baf4282dc5d55ee55ca7f1ae8
Fixes: coverity CID#166932
---
M src/sccp2sua.c
1 file
Review at https://gerrit.osmocom.org/2439
osmo_ss7_user_unregister(): Don't dereference NULL user
The 'user' argument to osmo_ss7_user_unregister() can be NULL, so let's
make sure we don't dereference it.
Change-Id: Ia34b181dcbcb179b2639e2f405364cc952069842
Fixes: coverity CID#166933
---
M
Harald Welte has submitted this change and it was merged.
Change subject: sccp2sua: Avoid array overruns in sccp_is_{mandatory,optional}()
..
sccp2sua: Avoid array overruns in sccp_is_{mandatory,optional}()
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: deb: install openbsc.pc
..
deb: install openbsc.pc
Previously openbsc.pc was generated but not installed as part of
openbsc-dev.
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: osmo_sccp_user_sap_down(): Avoid uninitialized pointer deref
..
osmo_sccp_user_sap_down(): Avoid uninitialized pointer deref
When receiving an unknown
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2428
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9cfc94a115c19eedf0923caacd17d1521b4c8fe4
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2009
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5472a8fe74a81b98598fbdb688db778cb7d09e62
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: deb: add missing dependency on doxygen
..
deb: add missing dependency on doxygen
Attempt to fix OBS nightly by adding explicit dependency on doxygen,
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2399
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I132515cd4d89132bb59f9ee7804a5a50e8bd2775
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2436
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c1010b0ac82ee0b7bd5e2c7413899695eae0070
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 2:
Out of curiosity - how this was found? I mean in what way PACCH paging was
broken as a result of incorrect fix? Is there a way this can be formulated as a
unit test?
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2433
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1be4529c73992cb342a62aa19ba79be25e982620
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2434
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia102f6c4cd5c6c3f823cb219635c42b9a87765f8
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2432
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5cd3250afc0b787b78683cd8ab6b2512e0d5c69e
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2435
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5f7551e49c1b4ea417bee3516da1b2ece5ee0699
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2431
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0ca5026091e91926924b297f9342bda5f9fd38c9
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 4: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2103
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8d8534a343e27cde79ddc85be4998ebd0cb6e5c
Gerrit-PatchSet: 4
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2436
sclc_rx_cldr(): Don't try to dereference user data_ie without check
While the SUA / SCCP2SUA code is ensuring that mandatory information
elements such as the user data IE in a CLD$ message, we might still have
current or future callers of
Review at https://gerrit.osmocom.org/2435
m3ua_to_xfer_ind(): don't use data_ie without checking it exists
Change-Id: I5f7551e49c1b4ea417bee3516da1b2ece5ee0699
Fixes: coverity CID#166941
---
M src/osmo_ss7_hmrt.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/2433
ss7_test: Fix '=' that should have been '=='
Change-Id: I1be4529c73992cb342a62aa19ba79be25e982620
Fixes: coverity CID#166944
---
M tests/ss7/ss7_test.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull
Review at https://gerrit.osmocom.org/2434
sclc_rx_cldt(): Don't try to dereference user data_ie without check
While the SUA / SCCP2SUA code is ensuring that mandatory information
elements such as the user data IE in a CLDT message, we might still have
current or future callers of
Review at https://gerrit.osmocom.org/2437
m3ua_decode_notify(): Ensure status_ie is valid before using it
Change-Id: I3cdd0fbdffcbeeb68dbc979385de045220ea0b0c
Fixes: coverity CID#166939
---
M src/m3ua.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2426
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08a962d2f242cefb67fb2dc93818c1ed532e8990
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2430
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id1f5f293ea9bce8601d45164be670a7062d91802
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2429
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6618fa247b889d4162118278cd05dee85cf21899
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/2430
osmo_sccp_user_sap_down(): Avoid uninitialized pointer deref
When receiving an unknown primitive, we end up de-referencing an
unassigned/uninitialized pointer for 'conn'. Let's properly catch that
case and print an error message.
Change-Id:
Review at https://gerrit.osmocom.org/2429
sccp_user: Add missing 'break' statement
The missing break statement leads to an unintended fall-through which in
turn prints a wrong ERROR message.
Change-Id: I6618fa247b889d4162118278cd05dee85cf21899
Fixes: coverity CID#166948
---
M src/sccp_user.c
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2426
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08a962d2f242cefb67fb2dc93818c1ed532e8990
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2425
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If2a7b2c988d06e8bbd2a63f3a5ceeb403bfb34ed
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: xua_default_lm_fsm: Missing printf() argument
..
xua_default_lm_fsm: Missing printf() argument
Change-Id: I03c30a0d1e03ff56df80bdd1e8a7846142b6f79c
Harald Welte has submitted this change and it was merged.
Change subject: ss7_test: Avoid possible NULL pointer dereference in test case
..
ss7_test: Avoid possible NULL pointer dereference in test case
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Address some negative integer handling issues
..
Address some negative integer handling issues
If for some reason we cannot resolve the file descriptor
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2427
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied76c21e20332514c2ad364eea5fc17e24a3f4c6
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2400
to look at the new patch set (#2).
debian: remove obsolete dependency
This should fix package build for latest Ubuntu.
Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2399
to look at the new patch set (#2).
debian: remove obsolete dependency
This should fix package build for latest Ubuntu.
Change-Id:
Review at https://gerrit.osmocom.org/2425
ss7_test: Avoid possible NULL pointer dereference in test case
Change-Id: If2a7b2c988d06e8bbd2a63f3a5ceeb403bfb34ed
Fixes: coverity CID#166992
---
M tests/ss7/ss7_test.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/2427
sccp2sua: Avoid array overruns in sccp_is_{mandatory,optional}()
Change-Id: Ied76c21e20332514c2ad364eea5fc17e24a3f4c6
Fixes: coverity CID#166943, CID#166980
---
M src/sccp2sua.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull
Review at https://gerrit.osmocom.org/2426
xua_rkm: Fix handling of RK Registration with multiple Routing Keys
RKM permits multiple routing key IEs to be inside a single Routing Key
Registration message. We were trying to handle this, but the counter we
used as array index into the
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmux: Use osmo_gettimeofday for testing puroposes
..
osmux: Use osmo_gettimeofday for testing puroposes
This way we can use fake time and
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2418
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic39cab74400aca8262a00c0d06884230b1a15ca3
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmux: Add RTP marker bit support
..
osmux: Add RTP marker bit support
According to RFC4867 (RTP payload format for AMR):
"The RTP header marker bit
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: osmux: use uint8_t everywhere for batch_factor
..
osmux: use uint8_t everywhere for batch_factor
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2421
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4ee881715e874eaed3cca6ac42db21260123306a
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2422
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b1a676b653bcdad21cb7927d549f499950a2b73
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: stp: Install VTY commands for FSM introspection
..
stp: Install VTY commands for FSM introspection
Change-Id: I4ee881715e874eaed3cca6ac42db21260123306a
Harald Welte has submitted this change and it was merged.
Change subject: control_if: Add helper function for 'local execution' of
control command
..
control_if: Add helper function for 'local execution' of control command
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2423
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5761a47b8cba73ddcc02a88cfa5c87c1970c04e
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: control_if: Add control interface commands for FSMs
..
control_if: Add control interface commands for FSMs
This allows programmatic access to
Harald Welte has submitted this change and it was merged.
Change subject: control_if: Don't use magic number '5' when allocating vector
..
control_if: Don't use magic number '5' when allocating vector
We have a proper constant
Review at https://gerrit.osmocom.org/2422
Address some negative integer handling issues
If for some reason we cannot resolve the file descriptor for a given
FSM, we shouldn't attempt to send data through it.
Fixes: coverity CID#167155, CID#167154, CID#167153, CID#167152, CID#167151,
Review at https://gerrit.osmocom.org/2421
stp: Install VTY commands for FSM introspection
Change-Id: I4ee881715e874eaed3cca6ac42db21260123306a
---
M stp/stp_main.c
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/21/2421/1
Patch Set 2:
agreeing with Holger. Let's seed the regular libc rand() with some randomness
at program start, and then generate TMSI or other random identiifers from that.
The function for that should then verify that the initializtaion was actually
performed (so applications cannot forget
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2418
to look at the new patch set (#2).
osmux: Use osmo_gettimeofday for testing puroposes
This way we can use fake time and osmux_test take 700ms instead of
Max has submitted this change and it was merged.
Change subject: gbproxy: add example .service
..
gbproxy: add example .service
Change-Id: Ic8144777a77efce4bad44abf6c6abde12fc5149c
Related: SYS#3610
---
A
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2378
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f80340ee9c61c88962fdd6764a6098a844d0d1e
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2376
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaca748e0d942bb2a1ee7c2776b37485e1439eb0c
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2378
to look at the new patch set (#2).
control_if: Add control interface commands for FSMs
This allows programmatic access to introspection of FSM instances, which
is quite handy from e.g.
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2376
to look at the new patch set (#3).
control_if: Add helper function for 'local execution' of control command
Sometimes (particularly when testing), we may want to parse+execute an
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/2376/2/tests/fsm/fsm_test.c
File tests/fsm/fsm_test.c:
Line 12:
> that seems odd - only header is added but no functions from it are used?
thanks, it actually belonged into the next patch of the series, where control
interface test
Patch Set 1: Code-Review-1
(2 comments)
https://gerrit.osmocom.org/#/c/2389/1/src/common/measurement.c
File src/common/measurement.c:
Line 104: "MEAS PERIOD END status:%d for chan:%u, TS:%u,
SUBCHAN:%u, FN:%u, FN_MOD:%u\n",
typically we start the log line with some kind of
Harald Welte has abandoned this change.
Change subject: measurement: Fix reporting of ms timing offset
..
Abandoned
duplicate of gerrit 1700
--
To view, visit https://gerrit.osmocom.org/2415
To unsubscribe, visit
Patch Set 1: Code-Review-1
indeed, it's duplicate of gerrit 1700, and as that's now merged I'll abandon
this patch.
--
To view, visit https://gerrit.osmocom.org/2415
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: Add MS TO to RSL measurements
..
Add MS TO to RSL measurements
Add optional MS timing offset (3GPP TS 45.010 ยง 1.2) to RSL MEASUREMENT
RESULT (3GPP TS
Patch Set 1:
this should be merged into the previous patch, i.e. the one introducing
clearing the flag in the new/different place.
--
To view, visit https://gerrit.osmocom.org/2413
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/2412/1/src/common/measurement.c
File src/common/measurement.c:
Line 210: "Update TA TimingOffset_Mean:%d, UL RX TA:%d, DL
ordered TA:%d, flags:%d \n",
log statements here must include some kind of
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2410
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I23fba50f48415314da40cf5bf86fce2ed3e66af6
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 6: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/1700
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4dfe5c48834a083e757d5de3236a02e15a238b28
Gerrit-PatchSet: 6
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/2418/1/tests/osmux/osmux_test.c
File tests/osmux/osmux_test.c:
Line 233:
osmo_gettimeofday_override_add(0,PKT_TIME_USEC);
minor coding style: missing space
--
To view, visit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2403
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d643810949aeca4762f0cad05eed534d35087f7
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2419
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8144777a77efce4bad44abf6c6abde12fc5149c
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
93 matches
Mail list logo
