Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3056/3/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:
PS3, Line 992: 1sap->u.data.lqual_cb
this is where/how we report linqQuality to the common part in l1sap. I think
it would make a lot of sense to remove
Patch Set 1: Code-Review-1
(1 comment)
https://gerrit.osmocom.org/#/c/3078/1/src/osmo-bts-octphy/l1_tch.c
File src/osmo-bts-octphy/l1_tch.c:
Line 201: rmsg = msgb_alloc_headroom(256, 128, "L1C-to-RTP");
L1C is L1 Control (channel activation, ...). L1P is L1 [data] primitive. L1C
Patch Set 2:
might be useful to explain *why* it is being reverted.
--
To view, visit https://gerrit.osmocom.org/3051
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib50c813c470bf6ea740fe6667431eaa1a23fdd8d
Gerrit-PatchSet: 2
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ortp.c: Duration of a RTP frame affects timestamp of the
next one
..
osmo_ortp.c: Duration of a RTP frame affects timestamp of the next one
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3083
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib8f5fa5509059fe908c09a4381844c613d478548
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ortp: Add osmo_rtp_drop_frame API
..
osmo_ortp: Add osmo_rtp_drop_frame API
This API will be used by osmo-bts to maintain the sampling clock of the
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3070
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6099372b6231c0a4b6ea0716f46f5daee7049e1
Gerrit-PatchSet: 3
Gerrit-Project: libosmo-abis
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-litecell15: Fix missing frame number in MEAS IND
..
osmo-bts-litecell15: Fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c)
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: fix missing frame number in MEAS IND
..
osmo-bts-trx: fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c) for
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2813
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife3c791ff50e8a866a97b9783ac7ef3ef2402a70
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 5: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2861
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iee9c8f88b05cd5dba9920bb08e079a643e713237
Gerrit-PatchSet: 5
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
Please see https://osmocom.org/issues/2344 for my test results. With this
patch (and associated '-t 1') I can sustain a load of >= 100 on the system
running osmo-trx + osmo-bts. Without the patch, it fails within seconds.
Hence my argument to even make it default, and to use a
Patch Set 1:
> I would actually vote for making SCHED_RR a default, preferrably
> with an even higher priority (e.g. 10) than what we'd use as
> osmo-bts-trx, as osmo-trx is even more important to schedule than
> osmo-bts. What do you guys think?
These settings can be very tricky. osmo-trx
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3072
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied215ca9e9d9c346c2a654f96785d1b87b075129
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Tom Tsou has submitted this change and it was merged.
Change subject: LimeSDR: set approximate tx offset value to make GSM work
..
LimeSDR: set approximate tx offset value to make GSM work
may be fine-tuned in the future
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3088
to look at the new patch set (#2).
BSSGP: add function to reset all PTP BVC
Change-Id: I9bf8f4dd784ccddbb9926492a85fff3293a0e913
Related: OS#1638
---
M
Patch Set 1:
Have it been tested with DTX active?
--
To view, visit https://gerrit.osmocom.org/3084
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d112c6db142be138e71393e77129e6d069d9973
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Review at https://gerrit.osmocom.org/3089
BSSGP: Use libosmocore for BVC-RESET
Implement proper BVC RESET procedure by using libosmocore code to handle
BVCI reset and initiate PTP BVC reset if necessary.
Related: OS#1638
Change-Id: I718c949759688cb34ce6bcbb3da2092fcdfa6989
---
M
Review at https://gerrit.osmocom.org/3088
BSSGP: add function to reset all PTP BVC
Change-Id: I9bf8f4dd784ccddbb9926492a85fff3293a0e913
Related: OS#1638
---
M include/osmocom/gprs/gprs_bssgp_bss.h
M src/gb/gprs_bssgp.c
M src/gb/libosmogb.map
3 files changed, 27 insertions(+), 1 deletion(-)
Review at https://gerrit.osmocom.org/3086
sccp_helpers.h: remove duplicate declaration of osmo_sccp_make_addr_pc_ssn()
Change-Id: Ifbb03de3df3b9bac86fb97dfc8e81e99fc172292
---
M include/osmocom/sigtran/sccp_helpers.h
1 file changed, 0 insertions(+), 2 deletions(-)
git pull
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3030
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iab5529f6919fd22902a8b39e8a52079f08deb851
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix compiler warning: xua_test: hexdump pointer type
..
fix compiler warning: xua_test: hexdump pointer type
Was recently introduced by
Review at https://gerrit.osmocom.org/3085
jenkins: build msc using libosmo-sccp master
Since 81c0bcab068174036f6897e69311f413d94c74d4 was merged, it is not necessary
to build the neels/aoip branch anymore. Other patches on that branch are not
necessary either.
Change-Id:
Review at https://gerrit.osmocom.org/3084
l1sap.c: fn_ms_adj: Add err logging and always return GSM_RTP_DURATION
After latest changes, l2 expects to receive an event for every TCH
frame, that is, no TCH frame event should be lost on that layer. We
should now then be safe returning always
Review at https://gerrit.osmocom.org/3083
osmo_ortp.c: Duration of a RTP frame affects timestamp of the next one
Duration of an RTP frames dictates the timestamp used for the next
frame, not for the one being sent now. It was done like this before to
account for possible losses.
Implementation
Hello Max, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2861
to look at the new patch set (#5).
osmo-bts-litecell15: Fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c) for osmo-bts-litecell15 does not include
Hello Max, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2813
to look at the new patch set (#5).
osmo-bts-trx: fix missing frame number in MEAS IND
The layer 1 interface (l1_if.c) for osmo-bts-trx does not
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3081
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7ef40d9bdf74a99375bc6568ed9483499664bf6f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3071
to look at the new patch set (#4).
l1sap.c: Avoid sending RTP frame with empty payload
Depends on libosmo-abis Id6099372b6231c0a4b6ea0716f46f5daee7049e1
Change-Id:
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3070
to look at the new patch set (#3).
osmo_ortp: Add osmo_rtp_drop_frame API
This API will be used by osmo-bts to maintain the sampling clock of the
RTP socket whenever a frame
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3082
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6388de98e4a7e20843a1be88a58bba8d2c9aa0d5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3082
TRX: permit transmission of all-zero loopback frames
For some reason, osmo-bts-trx attempted to interpret/validate the
contents of the downlink TCH block that it was about to transmit. If
such checks are made, they should clearly be in the common part
dexter has restored this change.
Change subject: osmo-bts-litecell15: Fix missing frame number in MEAS IND
..
Restored
--
To view, visit https://gerrit.osmocom.org/2861
To unsubscribe, visit
Harald Welte has submitted this change and it was merged.
Change subject: Revert "SCOC: When sending a CORE/CR, SUA SRC_ADDR ==
CallingPartyAddress"
..
Revert "SCOC: When sending a CORE/CR, SUA SRC_ADDR == CallingPartyAddress"
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3046
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic76aacc81f87f8885fe04121aead5c79a761ef07
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Patch Set 1:
> why bother with the extra argument? A length of 0 bytes must mean
> a frame with invalid CRC. What other case for zero-length can you
> think of?
>From the FIXME in the code in l1_if.c, I understand that at some point we want
>to check for low quality link in a similar way
Patch Set 2:
(1 comment)
https://gerrit.osmocom.org/#/c/3070/2/src/trau/osmo_ortp.c
File src/trau/osmo_ortp.c:
Line 449: int osmo_rtp_drop_frame(struct osmo_rtp_socket *rs, unsigned int
duration)
drop_frame() sounds like an imperative, i.e. the function will be dropping a
frame. It's more a
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3071
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9053674aa4f43aac20dbd5c865d70317360abbc
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3056/3/src/osmo-bts-sysmo/l1_if.h
File src/osmo-bts-sysmo/l1_if.h:
Line 131: int l1if_tch_rx(struct gsm_bts_trx *trx, uint8_t chan_nr, struct msgb
*l1p_msg, bool low_quality);
why bother with the extra argument? A length of 0 bytes must
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3076
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9ee967c0f42098b3a0569e9d84f23832eb4f2d5
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1:
why bother with the extra argument? A length of 0 bytes must mean a frame with
invalid CRC. What other case for zero-length can you think of?
--
To view, visit https://gerrit.osmocom.org/3078
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Patch Set 1:
I would actually vote for making SCHED_RR a default, preferrably with an even
higher priority (e.g. 10) than what we'd use as osmo-bts-trx, as osmo-trx is
even more important to schedule than osmo-bts. What do you guys think?
--
To view, visit https://gerrit.osmocom.org/3080
To
Review at https://gerrit.osmocom.org/3080
Add '-t' command line option to enable SCHED_RR
SCHED_RR allows us to operate osmo-trx reliable even under exceptionally
high system load, as the realtime scheduler priority will have higher
priority than the other "regular" tasks on the system.
dexter has submitted this change and it was merged.
Change subject: Revert "sysmobts: normalize frame number in measurement
indication"
..
Revert "sysmobts: normalize frame number in measurement indication"
This reverts
dexter has abandoned this change.
Change subject: osmo-bts-litecell15: Fix missing frame number in MEAS IND
..
Abandoned
--
To view, visit https://gerrit.osmocom.org/2861
To unsubscribe, visit
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3079
deb: remove unused dependency
The libdbd dependency is not used because libsqlite3 is used directly -
adjust debian/control to match.
Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Related: OS#1929
---
M debian/control
1 file changed, 1
Hello Max, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3056
to look at the new patch set (#3).
sysmo: Allow passing low quality buffers to upper layers
We want to always call l1if_tch_rx in order to avoid losing triggering
Review at https://gerrit.osmocom.org/3078
octphy: Allow passing low quality buffers to upper layers
We want to always call l1if_tch_rx in order to avoid losing triggering
events on the upper layer.
With this change, the upper layer will increase correctly seq + ts for
RTP. It will then send
Review at https://gerrit.osmocom.org/3076
litecell15/tch.c: Clean up use of empty buffer
Make code easier to read and avoid reading first byte of the buffer if size is
0.
Change-Id: Ib9ee967c0f42098b3a0569e9d84f23832eb4f2d5
---
M src/osmo-bts-litecell15/tch.c
1 file changed, 4 insertions(+),
Review at https://gerrit.osmocom.org/3077
litecell15: Allow passing low quality buffers to upper layers
We want to always call l1if_tch_rx in order to avoid losing triggering
events on the upper layer.
With this change, the upper layer will increase correctly seq + ts for
RTP. It will then
Patch Set 2:
(1 comment)
> Is this really necessary on sysmoBTS only? What about other BTS
> models?
I'll check and provide separate patches for each of them.
https://gerrit.osmocom.org/#/c/3056/1/src/osmo-bts-sysmo/l1_if.c
File src/osmo-bts-sysmo/l1_if.c:
Line 969: }
> I think
Hello Max, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3070
to look at the new patch set (#2).
osmo_ortp: Add osmo_rtp_drop_frame API
This API will be used by osmo-bts to maintain the sampling clock of the
RTP socket whenever a frame
Patch Set 1:
> Why only implementation in .c but no .h file? How it's planned to
> be used? Please explain in commit message.
Indeed I forgot to add the .h file to the commit, thanks for pointing out.
--
To view, visit https://gerrit.osmocom.org/3070
To unsubscribe, visit
Patch Set 1: Code-Review-1
Why only implementation in .c but no .h file? How it's planned to be used?
Please explain in commit message.
--
To view, visit https://gerrit.osmocom.org/3070
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3071
to look at the new patch set (#2).
l1sap.c: Avoid sending RTP frame with empty payload
Depends on libosmo-abis Id6099372b6231c0a4b6ea0716f46f5daee7049e1
Change-Id:
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.10/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_8.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_8.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_17.04/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/i586
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/i586
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of build
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/Debian_9.0/x86_64
Package network:osmocom:nightly/libosmocore failed to build in Debian_9.0/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines of
Visit
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.04/x86_64
Package network:osmocom:nightly/libosmocore failed to build in
xUbuntu_16.04/x86_64
Check out the package for editing:
osc checkout network:osmocom:nightly libosmocore
Last lines
64 matches
Mail list logo
