Patch Set 3:
> (1 comment)
Abstract the fact away whether the dependency was provided by compilation from
source or by extraction of an artifact tar-ball.
One artifact tar-ball should contain the result of a make install run of a
single library to an empty directory.
>From a dependency
Patch Set 1:
(1 comment)
> (4 comments)
>
> Thnaks a lot for your contribution! It is very much appreciated,
> please forgitve me missing it in the patch review so far. It's
> not usual that it waits for three weeks. If you hsould see that
> again, feel free to send a "ping" either by
Patch Set 1:
> so should we go for this kind of patch, or should I push another
> version that does it unconditionally? My preference would be to go
> for the latter, to have a "sane default" configureation.
My only concern with default RR priority is that it requires proper permissions
or
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3073
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie43610de0b2196d84caf09717ec8c8ca75ab926d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3074
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8de5b165ccd72a62b0f16655618e24ca740d9637
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3079
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id2ab1facad703fa0c1d45084e70d41e73dbad6e7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/3075/1/Transceiver52M/UHDDevice.cpp
File Transceiver52M/UHDDevice.cpp:
PS1, Line 1188: 32767
Is there a reason to not use SHRT_MAX instead of 32767 here?
PS1, Line 1197: 32767
Line can be removed unless there is a good reason not to
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3120
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I91b81a4d7627cec39c1814a39ed4be306681b874
Gerrit-PatchSet: 3
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Tom Tsou has submitted this change and it was merged.
Change subject: cosmetic: transciever: Remove trailing whitespaces
..
cosmetic: transciever: Remove trailing whitespaces
Change-Id:
Tom Tsou has submitted this change and it was merged.
Change subject: transceiver: Avoid sending clock indications when trx is not
powered on
..
transceiver: Avoid sending clock indications when trx is not powered on
Stop
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3119
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib3fbe768048b2a34a75ace9688e306720e67019a
Gerrit-PatchSet: 2
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3133
configure.ac: Fix C(PP)FLAGS for BSD build
Issue first found in libosmocore. It seems the BSD build doesn't use
bash which means using += to append to a variable doesn't work
correctly.
Change-Id: I33f6b9de4990de0c4d3a6fc0bd7df632094e79ac
---
M
Review at https://gerrit.osmocom.org/3135
sccp_scoc: Fix compilation warning and leave a pragma message
Following warning was being printed:
warning: statement will never be executed [-Wswitch-unreachable]
The code in there seems not to be finished, so better leave the code and a
pragma
Review at https://gerrit.osmocom.org/3134
sccp_scoc: Fix trailing whitespace
Change-Id: Ia93bb7d59e4e2c31b693e2c3424d34386762d02e
---
M src/sccp_scoc.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/34/3134/1
diff --git
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3127/3/openbsc/src/libmsc/transaction.c
File openbsc/src/libmsc/transaction.c:
Line 74:if (subscr == NULL)
Is this normal? Should we log smth or caller takes care of it?
--
To view, visit https://gerrit.osmocom.org/3127
To
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3128/3/openbsc/src/libmsc/gsm_04_08.c
File openbsc/src/libmsc/gsm_04_08.c:
Line 868: /* #warning find a portable way to obtain the timezone
offset
I think you can safely remove the old warning.
--
To view, visit
Patch Set 3:
(1 comment)
https://gerrit.osmocom.org/#/c/3126/3/openbsc/src/libmsc/smpp_smsc.c
File openbsc/src/libmsc/smpp_smsc.c:
Line 326: return (acl) ? 38 /* network out of order */ : 1 /* number
unsassigned */;
Can we use define instead of numbers in here? This would also eliminate
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3130
to look at the new patch set (#4).
Add release target to Makefile
Add simple helper target to automate following release steps:
* cleanup TODO-RELEASE
* update debian/changelog
* git
Review at https://gerrit.osmocom.org/3132
Cleanup jenkins build scripts
* reorder builds to avoid rm -rf invocation
* avoid useless double autoreconf
* move common parts into shared helper
* move common build steps into separate function
Change-Id: I24e500e132f5c8e8133d35548cb7b4e4552331d0
Patch Set 2:
Don't review yet, I'll do further changes needed to implement store too.
--
To view, visit https://gerrit.osmocom.org/3129
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c0c325fee14143deca8310312fc530cd9ce92e
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3131
to look at the new patch set (#2).
Use release helper from libosmocore
Change-Id: Ifc88e5c942a8b430b2436d429c86560d82984a95
Related: OS#1861
---
M Makefile.am
M configure.ac
2 files
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3130
to look at the new patch set (#3).
Add release target to Makefile
Add simple helper target to automate following release steps:
* cleanup TODO-RELEASE
* update debian/changelog
* git
Review at https://gerrit.osmocom.org/3131
Use release helper from libosmocore
Change-Id: Ifc88e5c942a8b430b2436d429c86560d82984a95
Related: OS#1861
---
M Makefile.am
M configure.ac
2 files changed, 6 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmo-abis
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3126
to look at the new patch set (#3).
smpp: fix return cause
Return cause 38 when default SMPP route is unavailable. This
is better than cause 1.
Change-Id:
Review at https://gerrit.osmocom.org/3130
Add release target to Makefile
Add simple helper target to automate following release steps:
* cleanup TODO-RELEASE
* update debian/changelog
* git commit and tag
* git tag sign
Note: it requires bumpversion package to be installed.
N. B: you still
Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3104
to look at the new patch set (#4).
simple-client/server: be able to decide on which ss7 instance to bind
osmo_sccp_simple_client() and
Review at https://gerrit.osmocom.org/3129
esme: run_method_expect_failure: Check failure in server response
We can now enable the esme_ms_sms test part which asserts that sending
an SMS to an msisdn with unknown destination triggers an error.
Change-Id:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: default-suites: Add smpp
..
default-suites: Add smpp
No need to run it for several BTS as the focus here is testing the core
network and
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3122
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie6458801ec1ecce63e08617d1e449047dc496e16
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3126
to look at the new patch set (#2).
smpp: fix return cause
Return cause 38 when default SMPP route is unavailable. This
is better than cause 1.
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: smpp.adoc: describe VTY cmd 'local-tcp-ip' instead of
'local-tcp-port'
..
smpp.adoc: describe VTY cmd 'local-tcp-ip' instead of 'local-tcp-port'
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3124
to look at the new patch set (#2).
smpp.adoc: describe VTY cmd 'local-tcp-ip' instead of 'local-tcp-port'
Change-Id: I594b89094413758146bb25f5262902e263f8f3d1
---
M
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3124
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I594b89094413758146bb25f5262902e263f8f3d1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch:
Patch Set 1: Code-Review+2
argh! there's a patch I failed to test. Thanks!
--
To view, visit https://gerrit.osmocom.org/3121
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ida8941525db2d6a80539ffda29fb4fa74dbb1e16
Gerrit-PatchSet: 1
Patch Set 2: Code-Review+2
In the new patch set, only the jenkins.sh script is modified to build
libosmo-sccp master instead of a legacy branch. Hence re-adding Harald's +2.
--
To view, visit https://gerrit.osmocom.org/3109
To unsubscribe, visit https://gerrit.osmocom.org/settings
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3109
to look at the new patch set (#2).
migrate osmo-hnbgw to libosmo-sigtran's SCCP/M3UA
libosmo-sigtran now has a "proper" SCCP/M3UA stack, so we can make our hnb-gw
3GPP
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3113
to look at the new patch set (#2).
cn unitdata: verify correct remote addr
When receiving unitdata from the CN, verify that it is indeed coming from the
remote address
Review at https://gerrit.osmocom.org/3128
04.08: find a portable way to obtain the timezone offset
Portable GMT offset calculation to display correct
time on GSM.
Change-Id: I673f17af2550c9708c4771e4ea4eafbbfafbb824
---
M openbsc/src/libmsc/gsm_04_08.c
1 file changed, 11 insertions(+), 3
Review at https://gerrit.osmocom.org/3127
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no subscriber is supplied. This
will cause unidentified subscribers to be rejected.
Change-Id:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: jenkins: build from libosmo-netif master
..
jenkins: build from libosmo-netif master
After merge of the sysmocom/sctp branch to master, it was
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3125
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I473d1361b99ff0ff8adba9326b0e2dfbc48a3aef
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3125
jenkins: build from libosmo-netif master
After merge of the sysmocom/sctp branch to master, it was forgotten to change
this build script to move along to master.
Change-Id: I473d1361b99ff0ff8adba9326b0e2dfbc48a3aef
---
M contrib/jenkins.sh
1 file
Review at https://gerrit.osmocom.org/3124
smpp.adoc: Small improvements
Change-Id: I594b89094413758146bb25f5262902e263f8f3d1
---
M OsmoNITB/chapters/smpp.adoc
1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals
refs/changes/24/3124/1
Patch Set 3: Code-Review+1
This patch appears to be the solution to making osmo-bts-trx stable in the
osmo-gsm-tester. I would appreciate this being merged.
--
To view, visit https://gerrit.osmocom.org/3120
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3122
to look at the new patch set (#2).
default-suites: Add smpp
No need to run it for several BTS as the focus here is testing the core
network and interoperation with different BTS is
Review at https://gerrit.osmocom.org/3123
sysmo: Remove non longer valid -p option from help
The dsp-trace-flags command line argument was removed
in 9684099ae905e6e61cbc326035d0b37c480f6172
Change-Id: I8dbcdc7080ca3f7d7968aeef24422faa75d925fe
---
M src/osmo-bts-sysmo/main.c
1 file changed, 0
Review at https://gerrit.osmocom.org/3122
default-suites: Add smpp
No need to run it for several BTS as the focus here is testing the core
network and interoperation with different BTS is already tested with the
sms suite. This way we avoid lossing extra time running the default
suite set.
Review at https://gerrit.osmocom.org/3121
contrib: Fix removal of doc directories
The docs are actually not removed because the shell takes
{libosmocore,libosmo-sccp} as a string literal if found inside quote
marks, see [1] for more information.
[1]
Patch Set 3:
Yesterday evening I built osmo-trx used by osmo-gsm-tester with this patch
enabled, and since then (built 1146) the osmo-gsm-tester with osmo-bts-trx
seems a lot more stable:
http://jenkins.osmocom.org/jenkins/view/osmo-gsm-tester/job/osmo-gsm-tester_run/
--
To view, visit
49 matches
Mail list logo
