Patch Set 3:
Tom - do you think we can avoid RACH detection for non-SACCH and DCCH in
osmo-trx, following the same logic as here? Right now we're detecting RACH on
every burst IIRC.
--
To view, visit https://gerrit.osmocom.org/1960
To unsubscribe, visit https://gerrit.osmocom.org/settings
Review at https://gerrit.osmocom.org/3552
Fix static build of osmo-bts-trx and osmo-bts-virtual.
New libosmocore has some plugin system which requires dlopen(). So we need
to make sure we always link with libdl, even when building statically.
Note that this doesn't fix static build of tests -
Review at https://gerrit.osmocom.org/3550
gbproxy: log unhandled BSSGP PDU as text
Change-Id: Ibe3c8bd353b3a178e26b0936f25b2e1959f9990c
---
M openbsc/src/gprs/gb_proxy.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/50/3550/1
Hello Jenkins Builder, Pablo Neira Ayuso,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3540
to look at the new patch set (#3).
libmsc: Use actual delivery time in delivery reports.
Set the time on the status report to the time the message was delivered, as
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3549
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52968a10089d14e0e3b0f9be678c261e3f92939c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: esme: user_message_referece values should be smaller than 256
..
esme: user_message_referece values should be smaller than 256
SMPP specs say
Review at https://gerrit.osmocom.org/3549
esme: user_message_referece values should be smaller than 256
SMPP specs say message reference is 16 bits field.
However, message reference field in GSM03.40 spec is only 8 bits.
Change-Id: I52968a10089d14e0e3b0f9be678c261e3f92939c
---
M
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3540/1/openbsc/src/libmsc/gsm_04_11.c
File openbsc/src/libmsc/gsm_04_11.c:
Line 313: gsm340_gen_scts(smsp, sms->created);
> Not sure what your question is? :-)
It's not clear from the spec what the SCTS should be in this case? The
Hello Jenkins Builder, Pablo Neira Ayuso,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3540
to look at the new patch set (#2).
libmsc: Use actual delivery time in delivery reports.
Set the time on the status report to the time the message was delivered, as
Patch Set 1:
> (1 comment)
After reading the spec again, getting localtime from sqlite is wrong anyway. It
should be as it is: Use UTC and specific the timezone offset in libosmocore in
gsm340_gen_scts().
Only I'm getting tm->tm_gmtoff = 0 and tm->tm_zone = GMT. from gmtime() there,
even
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3548
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6e6ec5b9980958de82ade40e4cd898dc6f1b889f
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Pau Espin Pedrol has submitted this change and it was merged.
Change subject: esme: smpp pdu field is a string and needs conversion
..
esme: smpp pdu field is a string and needs conversion
I take the chance to also swap the
Review at https://gerrit.osmocom.org/3548
esme: smpp pdu field is a string and needs conversion
I take the chance to also swap the two log parameters, because they are
included into a dictionary and shown in swapped order in the log anyway,
which distracts me every time I look at the values.
Review at https://gerrit.osmocom.org/3547
MGW: Include MGCP endpoint naming scheme of old IPA/SCCPlite approach
Change-Id: Ib1fe96f0041534fa027b70ee67978cb7c6bc5207
---
M OsmoBSC/mgw/osmo-bsc-old-sccplite.msc
1 file changed, 8 insertions(+), 8 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3546
mgw: Fix endpoint names for new MGW
According to RFC3435, an RTP bridge forrwarding packets, transcoding
or otherwise, is a single endpoint with two connections. Let's treat
it as such. We introduce the "rtpbridge/" prefix to identify such
special
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/3538
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9272c337ad6399da4a47cc6e2736e25f24e099d8
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3540/1/openbsc/src/libmsc/db.c
File openbsc/src/libmsc/db.c:
Line 1708: "SELECT datetime(SMS.created,'localtime') as created,
SMS.* "
> Probably this is breaking openbsc/tests/db/db_test ?
Funny enough, not on my local box.
Patch Set 2:
> (2 comments)
Thanks Harald. I have modified the codes to make them look cleaner in patch set
#2.
--
To view, visit https://gerrit.osmocom.org/3538
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Hello Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/3538
to look at the new patch set (#2).
EDGE: Fix UL link adaptation.
We have seen that UL MCS5- MCS9 link adaptation has not been implemented in
current PCU implementation.
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/3540/1/openbsc/include/openbsc/gsm_data.h
File openbsc/include/openbsc/gsm_data.h:
Line 460: time_t created;
This creates a "hole" in the structure, I would place it before "bool
is_report;"
See "pahole" utility for what I mean,
Patch Set 1: Code-Review+1
(3 comments)
Apart from the obvious the existing issues, it's great you have tracked down
and fixed this little aspect, so this is my +1 :)
https://gerrit.osmocom.org/#/c/3540/1//COMMIT_MSG
Commit Message:
Line 7: SMS Delivery reports: Use actual delivery time, not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3545
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb9332c65ed7bd57baf1aeab5ab722f92fc23b24
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
22 matches
Mail list logo
