Patch Set 1:
I've received a ping about this patch, but I don't think I need to do anything
here. Please let me know if you need anything
--
To view, visit https://gerrit.osmocom.org/3614
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3603
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8563ab272d5256a1b8ceefd5fee37da61e1bd26
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: remove global variables from loops
..
osmo-bts-trx: remove global variables from loops
* move TA related globals into phy_link
* move
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3601
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I01d7c1abad67e51b886a4ecf2de072929d67da27
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: osmo-bts-trx: fix 'osmotrx legacy-setbsic'
..
osmo-bts-trx: fix 'osmotrx legacy-setbsic'
It was introduced in fe6c75d24a1751341bcee91cb45c7ac7f5d07da3:
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3090
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b5a5ab8bd07daf2500b66dec428b89b7f8cd852
Gerrit-PatchSet: 4
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Use value string check from osmo-ci
..
Use value string check from osmo-ci
Change-Id: Ib9c595ef80cb6b0d126d4da8244f6435e0526095
---
M contrib/jenkins.sh
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3600
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9c595ef80cb6b0d126d4da8244f6435e0526095
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3599
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0a7f5977550bd0a1ba8b03bdb7e2d619a398e4e
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3598/1/debian/changelog
File debian/changelog:
Line 4: * New upstream version
I think this should be more verbose, suhc as the addition of osmo-bts-virtual
or other major changes since April 2016?
--
To view, visit
Patch Set 3: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3575/3/openbsc/src/gprs/sgsn_libgtp.c
File openbsc/src/gprs/sgsn_libgtp.c:
Line 148: LOGP(DGPRS, LOGL_ERROR, "Create PDP Context for %s\n",
mmctx->imsi);
I think if you want to do this, it would make sense to also
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3597
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie89b79a45033bee422e4ff898069ea6ac2c2f524
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: Relax branch restriction while making release
..
Relax branch restriction while making release
Previously making release of non-library project from
Harald Welte has submitted this change and it was merged.
Change subject: Add gitreview config
..
Add gitreview config
Change-Id: I35b3aaa3f8af4127d8a1b00c77ab02ae6a182714
---
A .gitreview
1 file changed, 3 insertions(+), 0
Patch Set 1: Code-Review+2
I agree with max' comments but I think this is a simple "revert" of an existing
commit. So the issues should be resolved separately, and not in the same
commit as the revert, right?
--
To view, visit https://gerrit.osmocom.org/3570
To unsubscribe, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3576
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I35b3aaa3f8af4127d8a1b00c77ab02ae6a182714
Gerrit-PatchSet: 1
Gerrit-Project: osmo-pcap
Gerrit-Branch: master
Patch Set 1: Code-Review+2
I think a one-line comment in the code would make sense in addition to the
commit log message. Nobody will understand the code otherwise.
--
To view, visit https://gerrit.osmocom.org/3580
To unsubscribe, visit https://gerrit.osmocom.org/settings
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3573
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f8ad8687acb7f6f0eeeb962f007e87cca0c4c27
Gerrit-PatchSet: 3
Gerrit-Project: openggsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: libgtp: expand logging
..
libgtp: expand logging
* print destination address on sendto error
* print address length on conversion error
* log listening
Patch Set 1: Code-Review+2 Verified+1
setting "verified" as we simply have no process to verify such changes for now.
--
To view, visit https://gerrit.osmocom.org/3559
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/3558
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d80e7d260f9092f44d4d80471a4dd67b7acc839
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch:
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3596/1/TODO-RELEASE
File TODO-RELEASE:
Line 4
maybe simply squash the two commits? Why have one commit to introduce the
LIBVERSION change and another that removes the lines from todo-release?
--
To view, visit
Patch Set 1: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/3595/1//COMMIT_MSG
Commit Message:
Line 11: libosmotrau due to API changes
would be good to indicate roguhtly which API changes (commit[s]) and also
remove the related part from TODO-RELEASE ?
--
To view, visit
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3589
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6ff08a281c0c32148ca2c59f731d6550bf7b1c90
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: osmo_ss7_vty: fix 'as' / 'routing-key' command
..
osmo_ss7_vty: fix 'as' / 'routing-key' command
The VTY definition for this command is flawed and
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3585
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc68bfae5457960a9eae5d9648586d6ce719ad68
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: contrib: Change systemd requirements so the services connect
properly
..
contrib: Change systemd requirements so the services connect properly
Harald Welte has submitted this change and it was merged.
Change subject: contrib: Add osmo-msc service file
..
contrib: Add osmo-msc service file
Change-Id: Ifdaf4107167c84af8a616f4ee792d5a34495564b
---
A
Harald Welte has submitted this change and it was merged.
Change subject: examples/sgsn: Use osmo-hlr with auth-policy remote by default
..
examples/sgsn: Use osmo-hlr with auth-policy remote by default
For the vty tests, add
Harald Welte has submitted this change and it was merged.
Change subject: mgcp: hack RAB success from nano3G: patch first RTP payload
..
mgcp: hack RAB success from nano3G: patch first RTP payload
The ip.access nano3G needs
Harald Welte has submitted this change and it was merged.
Change subject: examples: Change IP address of config files
..
examples: Change IP address of config files
This helps in providing 3G software packages for the
Patch Set 4: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3421
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3b2013198d3e2b780a4e31c36b89b58129dcacd
Gerrit-PatchSet: 4
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 3: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3419
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie3a25f6771ed6e620cb2b315638c622a9a24e530
Gerrit-PatchSet: 3
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/3349
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5eff04dcb0936e21690e427ae5e49228cd459bd4
Gerrit-PatchSet: 7
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/3658
mgcp: Fix uplink activation of Osmux stream
Commit 575420637981828b64c1292ada015d7170b89390 introduced
OSMUX_STATE_NEGOTIATING to fix a race condition present in osmo-bsc_nat.
However, after this change osmo-bsc_mgcp cannot switch to
Review at https://gerrit.osmocom.org/3667
sgsn_test: Fix wrong definition of wrap func
Commit 058cd573d8 added 2 new pointer parameters to
gprs_subscr_request_auth_info, but forgot to update wraps of the
function in sgsn_test.
I catched this today because openbsc build test sgsn_test was
Review at https://gerrit.osmocom.org/3668
smpp: Fix compilation warning
I already stumbled into 2 compilation environments which had Werror
enabled for -Wmaybe-uninitialized and the build failed, so let's
workaround this warning.
| smpp_openbsc.c: In function 'handle_smpp_submit':
|
Review at https://gerrit.osmocom.org/3673
NITB: remove 'help' output about '-a' option that is removed for ages
This option was present in very early versions of the NITB, but
at least since 2011 it is no longer supported. It's still listed
in --help output, which is wrong.
Change-Id:
Review at https://gerrit.osmocom.org/3666
LIBMSC: Use sms->text, not sms->user_data to construct report body
gsm_04_11.c sms_report_alloc()
Use the sms->text, not the sms->user_data to construct the report body.
This also prevents the potential output of non printable characters to
the log
Review at https://gerrit.osmocom.org/3672
libmsc: Use actual delivery time in delivery reports.
Set the time on the status report to the time the message was delivered, as
this may not be the same as the time when we are delivering the report to the
originating MS.
Change-Id:
Review at https://gerrit.osmocom.org/3662
Migrate from gprs_apn_to_str() to libosmocore osmo_apn_to_str()
In 2015, Jacob moved/copied related functions to libosmocore, but
for some reason didn't remove the copies here. Let's follow-up on
that and remove duplicated code.
The libosmocore
Review at https://gerrit.osmocom.org/3669
libmsc: Fix wrong handling of user_message_reference parameter
libsmpp34 already converts received TLV integer values to native
endianess in libsmpp34_(un)pack.
Converting them again at receive time swaps the 2 bytes of
user_message_reference, then
Review at https://gerrit.osmocom.org/3643
utils: smpp_mirror: set registered_delivery field in SMPP SUBMIT_SM
To test delivery reports using this utility.
Change-Id: I0e477407531fdd4d906e53c9b5a48a79a239966f
---
M src/utils/smpp_mirror.c
1 file changed, 1 insertion(+), 0 deletions(-)
git
Review at https://gerrit.osmocom.org/3674
Treat SIGTERM just like SIGINT in our programs
When somebody kills the process, it's best to handle the signal
and to use the opportunity for some cleanup. We always did this
in the NITB on SIGINT, but never on SIGTERM. Let's change it.
Change-Id:
Review at https://gerrit.osmocom.org/3659
SGSN: Fix RAN information exposed on GTP during PDP CTX CREATE
In the PDP Context Create from SGSN to GGSN, we include information
about the RAN type (GERAN/UTRAN) and the Cell of the MS. This was
all hard-coded to GERAN, and wasn't updated when we
Review at https://gerrit.osmocom.org/3664
libmsc: use SMPP34_DELIVERY_RECEIPT_* in libsmpp34
Use new definitions in libsmpp34 to set the registered_delivery field
accordingly, as provided by I5b3afff1b3b77cccd949e0606914c7ac3ba6114c.
Moreover, do not set this header field to zero if status
Review at https://gerrit.osmocom.org/3670
gbproxy: log unhandled BSSGP PDU as text
Change-Id: Ibe3c8bd353b3a178e26b0936f25b2e1959f9990c
---
M src/gprs/gb_proxy.c
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/70/3670/1
diff
Review at https://gerrit.osmocom.org/3661
sgsn_vty: Don't assume pdp->lib is always valid
We can only print libgtp pdp information if a library context is
attached to this pdp context. This is not always the case,
particuarly during some teardown scenarios.
Change-Id:
Review at https://gerrit.osmocom.org/3671
gbproxy: log signal value as text
Change-Id: I6ed923f5c60a8d64305f4b8e90d1362d6510e1c5
---
M src/gprs/gb_proxy.c
1 file changed, 4 insertions(+), 6 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/71/3671/1
diff --git
Review at https://gerrit.osmocom.org/3663
increase libsmpp34 version requirement to 1.12
Only 1.12 contains some of the #defines that we're using with recent
commits.
Change-Id: I3743b10a1a5d2f1d42a61204273c1d00dc22b600
---
M configure.ac
1 file changed, 1 insertion(+), 1 deletion(-)
git
Review at https://gerrit.osmocom.org/3651
libmsc: gsm340_gen_oa_sub() may return negative value
gsm340_gen_oa() returns a negative value if the output buffer that the
caller passes is too small, so we have to check the return value of this
function.
Fixes: CID 174178
Fixes: CID 174179
Review at https://gerrit.osmocom.org/3656
mgcp_osmux: Remove unused parameter
Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3
---
M include/openbsc/osmux.h
M src/libmgcp/mgcp_osmux.c
2 files changed, 4 insertions(+), 8 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/3644
utils: smpp_mirror: temporarily munch SMPP delivery receipts
Just munch and log SMPP delivery receipts by now, don't mirror this, it
is going to break things in openbsc.
Follow up patch removes this and mirrors this SMPP message as a
SUBMIT_SM with
Review at https://gerrit.osmocom.org/3647
libmsc: update database to accomodate SMS status-report fields
SMPP DELIVER_SM messages with esm_class = Delivery Receipt need to send
this message reference (that the mobile phone allocates) to the ESME.
Thus, the ESME propagates it via SUBMIT_SM with
Review at https://gerrit.osmocom.org/3660
Fix gsm_pchan2chan_nr() to use RSL_CHAN_OSMO_PDCH
When converting from GSM_PCHAN_PDCH, we should generate
a RSL channel number IE with the osmocom extension
RSL_CHAN_OSMO_PDCH rather than claiming it is a regular
TCH/F channel.
This is important as
Review at https://gerrit.osmocom.org/3645
utils: smpp_mirror: reflect message reference TLV
Useful to test the delivery receipt support. This TLV contains the
GSM03.40 message reference.
Change-Id: I1b0abaa7e06ffe1bd2242c70813d8b70e9fa954f
---
M src/utils/smpp_mirror.c
1 file changed, 23
Review at https://gerrit.osmocom.org/3642
libmsc: missing bit shift in status report flag when stored in sms object
So we just store 0 or 1 depending on what the mobile phone requests.
Change-Id: Idb7d5594219c0e458ccb561383a59604bc1a4201
---
M src/libmsc/gsm_04_11.c
1 file changed, 1
Review at https://gerrit.osmocom.org/3665
LIBMSC: Place correct dst address in status report
gsm_04_11.c: gsm340_gen_sms_status_report_tpdu()
When we construct the status report PDU, use sms->src
instead of sms->dst as the destination address
This way we tell the MS that the message was
Review at https://gerrit.osmocom.org/3648
utils: smpp_mirror: bounce Delivery Receipts as Delivery Acknowledgments
Simple patch to test the new status-report support code, remove previous
code before Delivery Acknowledgement support was in place. Use
LOGL_DEBUG for logging messages here as
Review at https://gerrit.osmocom.org/3655
libcommon: Fix log output for bts>0.
Fixes regression probably introduced in c696cc28.
For bts>0 logging doesn't show bts number correctly when printing lchan
identification string - it will always show it as "bts=0". The reason for
this is that the
Review at https://gerrit.osmocom.org/3657
handover_logic: set correct link to bts for subscriber_connection in case of
moving this connection to another bts
In case of successful completion of handover gsm_subscriber_connection could be
moved from one bts to another,
so connection link to
Review at https://gerrit.osmocom.org/3654
libmsc: use new smpp34 esm_class definitions
Replace magic numbers by esm_class definitions, which
have been added to latest libsmpp34 in Change-Id
I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65
Change-Id: I6c458690da60c8f3637680efbd718f6e8c6feb4c
---
M
Review at https://gerrit.osmocom.org/3652
libmsc: Remove comment not applying anymore
The change-id I7276d356d805a83ebeec72b02c8563b7135ea0b6 added msg_ref to
the databse but forgot to remove the comment stating it's not being
stored.
Change-Id: I204f098c8f2a480405446113e2181b2c53700cf3
---
M
Review at https://gerrit.osmocom.org/3650
libmsc: support GSM 03.40 status report for nitb
This patch adds support for GSM 03.40 in nitb mode.
MS GSM 03.40 SMSC
||
| SMS-SUBMIT |
Review at https://gerrit.osmocom.org/3640
libmsc: set registered_delivery field in SMPP 3.4 DELIVER_SM messages
Propagate the status report request field to the SMPP message through
the registered_delivery field, so the ESME knows that the mobile phone
is asking for explicit delivery
Review at https://gerrit.osmocom.org/3649
libmsc: handle delivery ack via SMPP SUBMIT SM / send GSM 03.40 status report
This patch adds gsm340_sms_send_status_report_tpdu() to build a
status-report. Moreover, set sms->report field if we see a SMPP
SUBMIT_SM with Delivery Acknowledgment
Review at https://gerrit.osmocom.org/3646
libmsc: add support for SMPP delivery receipts
If the mobile phone requests a status report via SMS, send a DELIVER_SM
with esm_class = Delivery Receipt to ESME to indicate that the SMS has
been already delivered to its destination.
MSGSM
Review at https://gerrit.osmocom.org/3637
cosmetic: vty for timers: remove obsolete range check
The VTY parsing already ensures the parameter range being 1..65535, no need to
check the range again.
Change-Id: I1cffa5b01cd5c589f1e42998e32135f1da8c960b
---
M src/libbsc/bsc_vty.c
1 file changed,
Review at https://gerrit.osmocom.org/3641
libmsc: report status report request flag from SMPP SUBMIT_SM
Restore the sms status report request flag from SUBMIT_SM.
Change-Id: Iac05252253f8933a3875b4904599b7a225191a4b
---
M src/libmsc/smpp_openbsc.c
1 file changed, 1 insertion(+), 0
Review at https://gerrit.osmocom.org/3636
libmsc: move gsm340_rx_sms_submit() to sms_route_mt_sms()
Move the sms message-type-identifier (mti) handling away from the
routing logic. This patch allows us to reuse the sms_route_mt_sms()
function in a follow up patch for sms reports send through
Review at https://gerrit.osmocom.org/3639
timer vty: also print the default value in cmd doc
Rationale: allows seeing all timer defaults at once by doing
OsmoBSC(config-net)# timer ?
Before, defaults are visible only by doing on each timer:
OsmoBSC(config-net)# timer t1234
Change-Id:
Review at https://gerrit.osmocom.org/3638
vty: add 'default' keyword to timer config
Change-Id: I4e837e8bedfad7ac4fd50048ecb016ddb37c2397
---
M src/libbsc/bsc_vty.c
1 file changed, 14 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/38/3638/1
Review at https://gerrit.osmocom.org/3633
libmsc: remove dead code in sms_route_mt_sms()
The following branch:
if (!rc && !gsms->receiver)
rc = GSM411_RP_CAUSE_MO_NUM_UNASSIGNED;
at the end of sms_route_mt_sms() always evaluates false.
Just a bit before, in such
Review at https://gerrit.osmocom.org/3635
libmsc: remove 'deferred' parameter in sms_route_mt_sms()
No need to cache the sms object, just cache what we need into the
smpp_cmd structure. This simplifies what that I introduced in
93ffbd0029d1 ("libmsc: send RP-ACK to MS after ESME sends SMPP
Review at https://gerrit.osmocom.org/3634
libmsc: remove duplicate lines in deliver_to_esme()
This code is accidentally doing the same thing twice, remove it.
Change-Id: I68087a850399e22951d2407e4d8a09c671a775c9
---
M src/libmsc/smpp_openbsc.c
1 file changed, 0 insertions(+), 2 deletions(-)
Review at https://gerrit.osmocom.org/3632
libmsc: do not leak pending SMPP command object on error path
Make sure the SMPP command object is released on errors.
Change-Id: I474584425d23fb379a9d71b33e29ac0e24f01e61
---
M src/libmsc/smpp_openbsc.c
1 file changed, 6 insertions(+), 5 deletions(-)
Review at https://gerrit.osmocom.org/3625
gtphob: check for missing result of rate_ctr_group_alloc()
In case the counter group allocation fails, we must handle this
gracefully and fail the allocation of the parent object, too.
The recent change (Id I7dad4a4d52fe05f6b990359841b4408df5990e21)
Review at https://gerrit.osmocom.org/3628
bsc_vty: Don't allow timers of zero (0)
It typically doesn't make sense to configure any of the GSM RR timer
to 0 (Seconds). In fact, accidentially configuring any of the timers
to zero might have severe side effects, such as "stuck channels"
Review at https://gerrit.osmocom.org/3626
bsc_vty: Add VTY command to test CTRL TRAP feature
Using this new command (introduced in OsmoBSC + OsmoNITB), you can
simulate the generation of TRAP events for testin purposes.
start the control interface monitor as an example client program:
Review at https://gerrit.osmocom.org/3630
sgsn: Convert cch_pdp to host order for libgtp
libgtp is calling gtpie_tv2 which will convert this uint16_t from host
to network order. So far libosmogsm and the sgsn treated the charging
characteristics as opaque data. So when moving from byte array
Review at https://gerrit.osmocom.org/3629
remove code disabling T3109 if configured to 0
We no longer permit timers with a 0 value, so this case can never
happen. Also, if it should happen, I'd rather have a timter expiring
immediately (and breaking something) than not being started in the
Review at https://gerrit.osmocom.org/3617
Fix BTS attribute requests
* fix BTS numbers: use 0 to indicate given BTS and 0xFF to indicate all
BTS' as it's explained in 3GPP TS 52.021 §9.3.
* only request attributes from supported (OsmoBTS) types
Change-Id:
Review at https://gerrit.osmocom.org/3609
smpp_smsc.c: Log on sending deliver_sm message
Change-Id: Ie16294df6d5bc0065f8d2b49320ead61f535f271
---
M src/libmsc/smpp_smsc.c
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/09/3609/1
Review at https://gerrit.osmocom.org/3618
transaction: reject calls from unidentified subscribers
A valid subscriber is indespensible when allocating a new
transaction. Return NULL if no subscriber is supplied. This
will cause unidentified subscribers to be rejected.
Note: Under normal
Review at https://gerrit.osmocom.org/3620
libbsc: Add VTY command to re-send the SYSTEM INFORMATION to BTS
This is useful if you are updating some configuration parameters which
affect the content of the SYSTEM INFORMATION messages. Currently, we
only send them at the time the RSL connection
Review at https://gerrit.osmocom.org/3623
RSL: Allow disabling of BCCH/SACCH filling for given SI type
If we want to instruct the BTS to stop sending a given SI, we must be
able to send the respective BCCH INFO / SACCH FILLING with a header but
without any L3 data IE. This patch enables the
Review at https://gerrit.osmocom.org/3631
gsm_04_11: get rid of unused parameter in sms_route_mt_sms()
This parameter is unused, remove it.
Change-Id: I797abce3f91447e8f397c7cf726db7425479fe0e
---
M src/libmsc/gsm_04_11.c
1 file changed, 6 insertions(+), 5 deletions(-)
git pull
Review at https://gerrit.osmocom.org/3627
GSM timers: User reasonable defaults; don't save if equal default
A number of the GSM timers (including T3109) had no reasonable
default values if not specified in the VTY / config file. Together
with unconditional writing to the config file, this
Review at https://gerrit.osmocom.org/3624
gsm_bts_trx_set_system_infos(): Disable non-existing SI
If we previously had a given SI present/active, we must send a
zero-length BCCH FILLING for that SI type to the BTS to stop it from
further transmitting this SI.
Change-Id:
Review at https://gerrit.osmocom.org/3611
jenkins.sh: Proper error message if local environment isn't set up
Change-Id: I79c2302365824d9c8783dadfa378c8eaa07e2ee7
---
M contrib/jenkins.sh
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/3621
check for missing result of rate_ctr_group_alloc()
In case the counter group allocation fails, we must handle this
gracefully and fail the allocation of the parent object, too.
RelateD: OS#2361
Change-Id: I7dad4a4d52fe05f6b990359841b4408df5990e21
---
Review at https://gerrit.osmocom.org/3619
bsc_api: Fix copy+paste error in printing name of RR STATUS PDU
Change-Id: I0ef78ef046e4850346569f750693e12938b50ab5
---
M src/libbsc/bsc_api.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-msc
Review at https://gerrit.osmocom.org/3616
Add VTY commands for experimentation with TS 04.14 commands
TS 04.14 (TS 44.014) specifies a series of commands specific to
conformance testing. Let's add some VTY commands to play (at least
initially) with closing and opening voice loops in the MS.
Review at https://gerrit.osmocom.org/3614
libmsc: Fix VTY output for handover counters.
Handover countrs belong to BSC, but we mistakenly take values from MSC counters.
Change-Id: I9512330f2e91d2f526751c5228e6e8e0fe17d579
---
M src/libmsc/vty_interface_layer3.c
1 file changed, 5
Review at https://gerrit.osmocom.org/3615
Support for TS 04.14 conformance test commands
Change-Id: Ib27edbfc8ccdedf00589ec715ced7bed435fa94c
---
M include/openbsc/Makefile.am
A include/openbsc/gsm_04_14.h
M src/libmsc/Makefile.am
M src/libmsc/gsm_04_08.c
A src/libmsc/gsm_04_14.c
5 files
Review at https://gerrit.osmocom.org/3610
smpp: fix return cause
Return cause 38 when default SMPP route is unavailable. This
is better than cause 1.
Change-Id: If3241d50a78fa611981e55fef6ae4c72b0a2a167
---
M src/libmsc/gsm_04_11.c
M src/libmsc/smpp_openbsc.c
M src/libmsc/smpp_smsc.c
M
Review at https://gerrit.osmocom.org/3612
04.08: find a portable way to obtain the timezone offset
Portable GMT offset calculation to display correct
time on GSM.
Change-Id: I673f17af2550c9708c4771e4ea4eafbbfafbb824
---
M src/libmsc/gsm_04_08.c
1 file changed, 10 insertions(+), 3 deletions(-)
Patch Set 1: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/3608
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7cdf16232181d4b8093e61f2d8a3faed9010d4f
Gerrit-PatchSet: 1
Gerrit-Project: sandbox
Gerrit-Branch:
Neels Hofmeyr has submitted this change and it was merged.
Change subject: add .gitreview
..
add .gitreview
A .gitreview file is required to use git review.
More information about git review
Review at https://gerrit.osmocom.org/3608
add .gitreview
A .gitreview file is required to use git review.
More information about git review
https://www.mediawiki.org/wiki/Gerrit/git-review
Change-Id: Ie7cdf16232181d4b8093e61f2d8a3faed9010d4f
---
A .gitreview
1 file changed, 3 insertions(+), 0
1 - 100 of 139 matches
Mail list logo
