[PATCH] osmo-hlr[master]: fix default logging levels to NOTICE, not DEBUG

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4442

fix default logging levels to NOTICE, not DEBUG

Tweak unit test binaries to still used DEBUG loglevels, so that their expected
outputs remain unchanged (and nicely verbose).

Adjust test_nodes.vty, now expecting the 'notice' log levels upon
'show running-config'.

Change-Id: Ic061e61c9625b49cef8bc2a2c0b936e262c22268
---
M src/logging.c
M tests/auc/auc_test.c
M tests/auc/gen_ts_55_205_test_sets/main_template.c
M tests/db/db_test.c
M tests/test_nodes.vty
5 files changed, 9 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/42/4442/1

diff --git a/src/logging.c b/src/logging.c
index 9b8de45..f81781d 100644
--- a/src/logging.c
+++ b/src/logging.c
@@ -5,19 +5,19 @@
[DMAIN] = {
.name = "DMAIN",
.description = "Main Program",
-   .enabled = 1, .loglevel = LOGL_DEBUG,
+   .enabled = 1, .loglevel = LOGL_NOTICE,
},
[DDB] = {
.name = "DDB",
.description = "Database Layer",
.color = "\033[1;31m",
-   .enabled = 1, .loglevel = LOGL_DEBUG,
+   .enabled = 1, .loglevel = LOGL_NOTICE,
},
[DAUC] = {
.name = "DAUC",
.description = "Authentication Center",
.color = "\033[1;33m",
-   .enabled = 1, .loglevel = LOGL_DEBUG,
+   .enabled = 1, .loglevel = LOGL_NOTICE,
},
 };
 
diff --git a/tests/auc/auc_test.c b/tests/auc/auc_test.c
index f047a97..e9c114c 100644
--- a/tests/auc/auc_test.c
+++ b/tests/auc/auc_test.c
@@ -615,6 +615,7 @@
log_set_print_timestamp(osmo_stderr_target, 0);
log_set_use_color(osmo_stderr_target, 0);
log_set_print_category(osmo_stderr_target, 1);
+   log_parse_category_mask(osmo_stderr_target, "DMAIN,1:DDB,1:DAUC,1");
 
test_gen_vectors_2g_only();
test_gen_vectors_2g_plus_3g();
diff --git a/tests/auc/gen_ts_55_205_test_sets/main_template.c 
b/tests/auc/gen_ts_55_205_test_sets/main_template.c
index e917e71..37f47c3 100644
--- a/tests/auc/gen_ts_55_205_test_sets/main_template.c
+++ b/tests/auc/gen_ts_55_205_test_sets/main_template.c
@@ -107,6 +107,7 @@
log_set_print_timestamp(osmo_stderr_target, 0);
log_set_use_color(osmo_stderr_target, 0);
log_set_print_category(osmo_stderr_target, 1);
+   log_parse_category_mask(osmo_stderr_target, "DMAIN,1:DDB,1:DAUC,1");
 
 FUNCTION_CALLS
 
diff --git a/tests/db/db_test.c b/tests/db/db_test.c
index 0a53370..389ed00 100644
--- a/tests/db/db_test.c
+++ b/tests/db/db_test.c
@@ -816,6 +816,7 @@
log_set_print_timestamp(osmo_stderr_target, 0);
log_set_use_color(osmo_stderr_target, 0);
log_set_print_category(osmo_stderr_target, 1);
+   log_parse_category_mask(osmo_stderr_target, "DMAIN,1:DDB,1:DAUC,1");
 
/* omit the SQLite version and compilation flags from test output */
log_set_log_level(osmo_stderr_target, LOGL_ERROR);
diff --git a/tests/test_nodes.vty b/tests/test_nodes.vty
index 0de4ff4..6de673a 100644
--- a/tests/test_nodes.vty
+++ b/tests/test_nodes.vty
@@ -101,9 +101,9 @@
   logging print category 1
   logging print extended-timestamp 1
   logging level all debug
-  logging level main debug
-  logging level db debug
-  logging level auc debug
+  logging level main notice
+  logging level db notice
+  logging level auc notice
 ...
 !
 line vty

-- 
To view, visit https://gerrit.osmocom.org/4442
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic061e61c9625b49cef8bc2a2c0b936e262c22268
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-hlr[master]: tests/Makefile: use test db var instead of repeating the path

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4436

tests/Makefile: use test db var instead of repeating the path

Change-Id: I9859b522b5ffa7f2c9ed33ab849199d4b4e6696c
---
M tests/Makefile.am
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/36/4436/1

diff --git a/tests/Makefile.am b/tests/Makefile.am
index e71a250..2dba6a1 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -54,7 +54,7 @@
sqlite3 $(VTY_TEST_DB) < $(top_srcdir)/sql/hlr.sql
osmo_verify_transcript_vty.py -v \
-n OsmoHLR -p 4258 \
-   -r "$(top_builddir)/src/osmo-hlr -c 
$(top_srcdir)/doc/examples/osmo-hlr.cfg -l hlr_vty_test.db" \
+   -r "$(top_builddir)/src/osmo-hlr -c 
$(top_srcdir)/doc/examples/osmo-hlr.cfg -l $(VTY_TEST_DB)" \
$(U) $(srcdir)/*.vty
-rm -f $(VTY_TEST_DB)
 
@@ -69,7 +69,7 @@
sqlite3 $(CTRL_TEST_DB) < $(srcdir)/test_subscriber.sql
osmo_verify_transcript_ctrl.py -v \
-p 4259 \
-   -r "$(top_builddir)/src/osmo-hlr -c 
$(top_srcdir)/doc/examples/osmo-hlr.cfg -l hlr_ctrl_test.db" \
+   -r "$(top_builddir)/src/osmo-hlr -c 
$(top_srcdir)/doc/examples/osmo-hlr.cfg -l $(CTRL_TEST_DB)" \
$(U) $(srcdir)/*.ctrl
-rm -f $(CTRL_TEST_DB)
 

-- 
To view, visit https://gerrit.osmocom.org/4436
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9859b522b5ffa7f2c9ed33ab849199d4b4e6696c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-hlr[master]: add osmo-hlr-db-tool, program to migrate from osmo-nitb db

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4441

add osmo-hlr-db-tool, program to migrate from osmo-nitb db

Move macro copy_sqlite3_text_to_buf() to db.h, so it can be used in
hlr_db_tool.c.

Add _dbd_decode_binary() from libdbi to avoid depending on the entire libdbi
just for KI BLOB decoding. Add it in a separate file, copying its own license,
the lGPL.

Offer commandline option --import-nitb-db to read in an old osmo-nitb database
and copy subscriber IMSIs and 2G auth data to OsmoHLR db format.

Anticipate future command line options like --import-csv, so keep the code
generalized.

Change-Id: I0dfa6ec033dd93161c1adc2ce1637195fe5b7a63
---
M src/Makefile.am
M src/db.h
M src/db_hlr.c
A src/dbd_decode_binary.c
A src/hlr_db_tool.c
5 files changed, 473 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/41/4441/1

diff --git a/src/Makefile.am b/src/Makefile.am
index 3b09b7b..9fbb062 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -35,6 +35,7 @@
 
 bin_PROGRAMS = \
osmo-hlr \
+   osmo-hlr-db-tool \
$(NULL)
 
 noinst_PROGRAMS = \
@@ -66,6 +67,21 @@
$(SQLITE3_LIBS) \
$(NULL)
 
+osmo_hlr_db_tool_SOURCES = \
+   hlr_db_tool.c \
+   db.c \
+   db_hlr.c \
+   logging.c \
+   rand_urandom.c \
+   dbd_decode_binary.c \
+   $(NULL)
+
+osmo_hlr_db_tool_LDADD = \
+   $(LIBOSMOCORE_LIBS) \
+   $(LIBOSMOGSM_LIBS) \
+   $(SQLITE3_LIBS) \
+   $(NULL)
+
 db_test_SOURCES = \
auc.c \
db.c \
diff --git a/src/db.h b/src/db.h
index 35e4327..fc8e511 100644
--- a/src/db.h
+++ b/src/db.h
@@ -129,3 +129,14 @@
bool purge_val, bool is_ps);
 
 int hlr_subscr_nam(struct hlr *hlr, struct hlr_subscriber *subscr, bool 
nam_val, bool is_ps);
+
+/*! Call sqlite3_column_text() and copy result to a char[].
+ * \param[out] buf  A char[] used as sizeof() arg(!) and osmo_strlcpy() target.
+ * \param[in] stmt  An sqlite3_stmt*.
+ * \param[in] idx   Index in stmt's returned columns.
+ */
+#define copy_sqlite3_text_to_buf(buf, stmt, idx) \
+   do { \
+   const char *_txt = (const char *) sqlite3_column_text(stmt, 
idx); \
+   osmo_strlcpy(buf, _txt, sizeof(buf)); \
+   } while (0)
diff --git a/src/db_hlr.c b/src/db_hlr.c
index bae9a5a..c4d4974 100644
--- a/src/db_hlr.c
+++ b/src/db_hlr.c
@@ -35,17 +35,6 @@
 
 #define LOGHLR(imsi, level, fmt, args ...) LOGP(DAUC, level, "IMSI='%s': " 
fmt, imsi, ## args)
 
-/*! Call sqlite3_column_text() and copy result to a char[].
- * \param[out] buf  A char[] used as sizeof() arg(!) and osmo_strlcpy() target.
- * \param[in] stmt  An sqlite3_stmt*.
- * \param[in] idx   Index in stmt's returned columns.
- */
-#define copy_sqlite3_text_to_buf(buf, stmt, idx) \
-   do { \
-   const char *_txt = (const char *) sqlite3_column_text(stmt, 
idx); \
-   osmo_strlcpy(buf, _txt, sizeof(buf)); \
-   } while (0)
-
 /*! Add new subscriber record to the HLR database.
  * \param[in,out] dbc  database context.
  * \param[in] imsi  ASCII string of IMSI digits, is validated.
diff --git a/src/dbd_decode_binary.c b/src/dbd_decode_binary.c
new file mode 100644
index 000..e1a98ad
--- /dev/null
+++ b/src/dbd_decode_binary.c
@@ -0,0 +1,42 @@
+/* This function is blatantly copied from libdbi, from
+ * https://sourceforge.net/p/libdbi/libdbi/ci/master/tree/src/dbd_helper.c
+ * to save having to depend on the entire libdbi just for KI BLOB decoding.
+ */
+
+/*
+ * libdbi - database independent abstraction layer for C.
+ * Copyright (C) 2001-2003, David Parker and Mark Tobenkin.
+ * http://libdbi.sourceforge.net
+ * 
+ * This library is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
+ * version 2.1 of the License, or (at your option) any later version.
+ * 
+ * This library is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * Lesser General Public License for more details.
+ * 
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this library; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
+ * 
+ * $Id: dbd_helper.c,v 1.44 2011/08/09 11:14:14 mhoenicka Exp $
+ */
+
+#include 
+
+size_t _dbd_decode_binary(const unsigned char *in, unsigned char *out){
+  int i, e;
+  unsigned char c;
+  e = *(in++);
+  i = 0;
+  while( (c = *(in++))!=0 ){
+if( c==1 ){
+  c = *(in++) - 1;
+}
+out[i++] = c + e;
+  }
+  return (size_t)i;
+}
diff --git a/src/hlr_db_tool.c b/src/hlr_db_tool.c
new file mode 100644
index 000..95537b8
--- /dev/null
+++ b/src/hlr_db_tool.c
@@ -0,0 +1,404 @@
+/* (C) 2017 by sysmocom - s.f.m.c. GmbH 
+ *
+ 

[PATCH] osmo-hlr[master]: cosmetic: rename SL3_TXT macro, use osmo_strlcpy()

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4440

cosmetic: rename SL3_TXT macro, use osmo_strlcpy()

Rename SL3_TXT to more accurate copy_sqlite3_text_to_buf(), and use
osmo_strlcpy() instead of essentially dup'ing it.

The macro will also be used by hlr_db_tool.c in upcoming patch. This patch
prepares for a move to db.h.

Change-Id: I1dadecfe0109195c09c0e706201b0df009cc
---
M src/db_hlr.c
1 file changed, 14 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/40/4440/1

diff --git a/src/db_hlr.c b/src/db_hlr.c
index ef01428..bae9a5a 100644
--- a/src/db_hlr.c
+++ b/src/db_hlr.c
@@ -35,12 +35,15 @@
 
 #define LOGHLR(imsi, level, fmt, args ...) LOGP(DAUC, level, "IMSI='%s': " 
fmt, imsi, ## args)
 
-#define SL3_TXT(x, stmt, idx)  \
-   do {\
-   const char *_txt = (const char *) sqlite3_column_text(stmt, 
idx);\
-   if (_txt)   \
-   strncpy(x, _txt, sizeof(x));\
-   x[sizeof(x)-1] = '\0';  \
+/*! Call sqlite3_column_text() and copy result to a char[].
+ * \param[out] buf  A char[] used as sizeof() arg(!) and osmo_strlcpy() target.
+ * \param[in] stmt  An sqlite3_stmt*.
+ * \param[in] idx   Index in stmt's returned columns.
+ */
+#define copy_sqlite3_text_to_buf(buf, stmt, idx) \
+   do { \
+   const char *_txt = (const char *) sqlite3_column_text(stmt, 
idx); \
+   osmo_strlcpy(buf, _txt, sizeof(buf)); \
} while (0)
 
 /*! Add new subscriber record to the HLR database.
@@ -410,12 +413,12 @@
 
/* obtain the various columns */
subscr->id = sqlite3_column_int64(stmt, 0);
-   SL3_TXT(subscr->imsi, stmt, 1);
-   SL3_TXT(subscr->msisdn, stmt, 2);
+   copy_sqlite3_text_to_buf(subscr->imsi, stmt, 1);
+   copy_sqlite3_text_to_buf(subscr->msisdn, stmt, 2);
/* FIXME: These should all be BLOBs as they might contain NUL */
-   SL3_TXT(subscr->vlr_number, stmt, 3);
-   SL3_TXT(subscr->sgsn_number, stmt, 4);
-   SL3_TXT(subscr->sgsn_address, stmt, 5);
+   copy_sqlite3_text_to_buf(subscr->vlr_number, stmt, 3);
+   copy_sqlite3_text_to_buf(subscr->sgsn_number, stmt, 4);
+   copy_sqlite3_text_to_buf(subscr->sgsn_address, stmt, 5);
subscr->periodic_lu_timer = sqlite3_column_int(stmt, 6);
subscr->periodic_rau_tau_timer = sqlite3_column_int(stmt, 7);
subscr->nam_cs = sqlite3_column_int(stmt, 8);

-- 
To view, visit https://gerrit.osmocom.org/4440
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1dadecfe0109195c09c0e706201b0df009cc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-hlr[master]: automatically create db tables on osmo-hlr invocation

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4438

automatically create db tables on osmo-hlr invocation

If a database file is missing, osmo-hlr creates it, as is the default sqlite3
API behavior -- before this patch, that db file is created, but lacks useful
tables. Actually also create initial tables in it, as osmo-nitb did.

In effect, the 'vty-test' target in tests/Makefile.am no longer needs to create
a database manually. (The 'ctrl-test' still does, because it also wants to add
subscriber data on top of the bare tables.)

Note: it could be desirable to bail if the desired database file does not
exist. That is however a different semantic from this patch; this is not
changing the fact that a db file is created, this just creates a usable one.

Note: I am about to add osmo-hlr-db-tool to do database migration from
osmo-nitb. For that, it is desirable to bootstrap a usable database, which is
the core reason for this patch.

Don't plainly duplicate hlr.sql to .c, but create db_bootstrap.h as a
BUILT_SOURCE from reading in sql/hlr.sql and mangling via sed to a list of SQL
statement strings. On each db_open(), run this bootstrap sequence.

In sql/hlr.sql, these tweaks are necessary:
* Add 'IF NOT EXISTS' to 'CREATE TABLE', so that the bootstrap sequence can be
  run on an already bootstrapped db.
* Drop the final comment at the bottom, which ended up being an empty SQL
  statement and causing sqlite3 API errors, seemed to have no purpose anyway.

Note: by composing the statement strings as multiline and including the SQL
comments, sqlite3 actually retains the comments contained in table definitions
and prints them back during 'sqlite3 hlr.db .dump'.

Change-Id: If77dbbfe1af3e66aaec91cb6295b687f37678636
---
M sql/hlr.sql
M src/Makefile.am
M src/db.c
A src/db_bootstrap.sed
M tests/Makefile.am
M tests/db/Makefile.am
6 files changed, 81 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/38/4438/1

diff --git a/sql/hlr.sql b/sql/hlr.sql
index 5fbc712..696cf1c 100644
--- a/sql/hlr.sql
+++ b/sql/hlr.sql
@@ -1,6 +1,6 @@
 --modelled roughly after TS 23.008 version 13.3.0
 
-CREATE TABLE subscriber (
+CREATE TABLE IF NOT EXISTS subscriber (
id  INTEGER PRIMARY KEY,
-- Chapter 2.1.1.1
imsiVARCHAR(15) UNIQUE NOT NULL,
@@ -40,24 +40,24 @@
ms_purged_psBOOLEAN NOT NULL DEFAULT 0
 );
 
-CREATE TABLE subscriber_apn (
+CREATE TABLE IF NOT EXISTS subscriber_apn (
subscriber_id   INTEGER,-- subscriber.id
apn VARCHAR(256) NOT NULL
 );
 
 -- Chapter 2.1.3
-CREATE TABLE subscriber_multi_msisdn (
+CREATE TABLE IF NOT EXISTS subscriber_multi_msisdn (
subscriber_id   INTEGER,-- subscriber.id
msisdn  VARCHAR(15) NOT NULL
 );
 
-CREATE TABLE auc_2g (
+CREATE TABLE IF NOT EXISTS auc_2g (
subscriber_id   INTEGER PRIMARY KEY,-- subscriber.id
algo_id_2g  INTEGER NOT NULL,   -- enum osmo_auth_algo value
ki  VARCHAR(32) NOT NULL-- hex string: subscriber's 
secret key (128bit)
 );
 
-CREATE TABLE auc_3g (
+CREATE TABLE IF NOT EXISTS auc_3g (
subscriber_id   INTEGER PRIMARY KEY,-- subscriber.id
algo_id_3g  INTEGER NOT NULL,   -- enum osmo_auth_algo value
k   VARCHAR(32) NOT NULL,   -- hex string: subscriber's 
secret key (128bit)
@@ -68,4 +68,3 @@
 );
 
 CREATE UNIQUE INDEX IF NOT EXISTS idx_subscr_imsi ON subscriber (imsi);
--- SELECT algo_id_2g, ki, algo_id_3g, k, op, opc, sqn FROM subscriber LEFT 
JOIN auc_2g ON auc_2g.subscriber_id = subscriber.id LEFT JOIN auc_3g ON 
auc_3g.subscriber_id = subscriber.id WHERE imsi = ?
diff --git a/src/Makefile.am b/src/Makefile.am
index fc7c653..3b09b7b 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -10,7 +10,13 @@
 
 EXTRA_DIST = \
populate_hlr_db.pl \
+   db_bootstrap.sed \
$(NULL)
+
+BUILT_SOURCES = \
+   db_bootstrap.h \
+   $(NULL)
+CLEANFILES = $(BUILT_SOURCES)
 
 noinst_HEADERS = \
auc.h \
@@ -24,6 +30,7 @@
ctrl.h \
hlr_vty.h \
hlr_vty_subscr.h \
+   db_bootstrap.h \
$(NULL)
 
 bin_PROGRAMS = \
@@ -73,3 +80,14 @@
$(LIBOSMOGSM_LIBS) \
$(SQLITE3_LIBS) \
$(NULL)
+
+BOOTSTRAP_SQL = $(top_srcdir)/sql/hlr.sql
+
+db_bootstrap.h: $(BOOTSTRAP_SQL) $(srcdir)/db_bootstrap.sed
+   echo "/* DO NOT EDIT THIS FILE. It is generated from 
osmo-hlr.git/sql/hlr.sql */" > "$@"
+   echo "#pragma once" >> "$@"
+   echo "static const char *stmt_bootstrap_sql[] = {" >> "$@"
+   cat "$(BOOTSTRAP_SQL)" \
+   | sed -f "$(srcdir)/db_bootstrap.sed" \
+   >> "$@"
+   echo "};" >> "$@"
diff --git a/src/db.c b/src/db.c
index fbf5c76..8733cf5 100644
--- a/src/db.c
+++ b/src/db.c
@@ -25,6 +25,7 @@
 
 #include "logging.h"
 #include "db.h"
+#include "db_bootstrap.h"
 
 #define SEL_COLUMNS \
"id," \

[PATCH] osmo-hlr[master]: cosmetic: sql/hlr.sql: move comments

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4439

cosmetic: sql/hlr.sql: move comments

By moving the comments inside the table row definitions, they are dumped back
during 'sqlite3 hlr.db .dump'. When they are between SQL statements like before
this patch, the comments are lost.

Tweak wording.

Change-Id: I280c2e2d3e9b7f1dc632722724d9e1c54d041820
---
M sql/hlr.sql
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/39/4439/1

diff --git a/sql/hlr.sql b/sql/hlr.sql
index 696cf1c..80eb3e5 100644
--- a/sql/hlr.sql
+++ b/sql/hlr.sql
@@ -1,6 +1,5 @@
---modelled roughly after TS 23.008 version 13.3.0
-
 CREATE TABLE IF NOT EXISTS subscriber (
+-- OsmoHLR's DB scheme is modelled roughly after TS 23.008 version 13.3.0
id  INTEGER PRIMARY KEY,
-- Chapter 2.1.1.1
imsiVARCHAR(15) UNIQUE NOT NULL,
@@ -45,8 +44,8 @@
apn VARCHAR(256) NOT NULL
 );
 
--- Chapter 2.1.3
 CREATE TABLE IF NOT EXISTS subscriber_multi_msisdn (
+-- Chapter 2.1.3
subscriber_id   INTEGER,-- subscriber.id
msisdn  VARCHAR(15) NOT NULL
 );

-- 
To view, visit https://gerrit.osmocom.org/4439
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I280c2e2d3e9b7f1dc632722724d9e1c54d041820
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[PATCH] osmo-hlr[master]: db_test: fix *FLAGS

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4437

db_test: fix *FLAGS

The -I includes should be in CFLAGS, not CPPFLAGS.

I noticed problems with it when trying to add an -I$(builddir) in an upcoming
patch that adds a BUILT_SOURCE, If77dbbfe1af3e66aaec91cb6295b687f37678636.

Change-Id: Ie57a04b7efc7a1e16cf0e3625d8ad2f0ef0089b0
---
M tests/db/Makefile.am
1 file changed, 1 insertion(+), 7 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/37/4437/1

diff --git a/tests/db/Makefile.am b/tests/db/Makefile.am
index a1f35a7..b706bec 100644
--- a/tests/db/Makefile.am
+++ b/tests/db/Makefile.am
@@ -1,17 +1,11 @@
-AM_CPPFLAGS = \
+AM_CFLAGS = \
$(all_includes) \
-I$(top_srcdir)/src \
-   $(NULL)
-
-AM_CFLAGS = \
-Wall \
-ggdb3 \
$(LIBOSMOCORE_CFLAGS) \
$(LIBOSMOGSM_CFLAGS) \
$(SQLITE3_CFLAGS) \
-   $(NULL)
-
-AM_LDFLAGS = \
$(NULL)
 
 EXTRA_DIST = \

-- 
To view, visit https://gerrit.osmocom.org/4437
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie57a04b7efc7a1e16cf0e3625d8ad2f0ef0089b0
Gerrit-PatchSet: 1
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

osmo-bsc[master]: mgcp: use osmo-mgw to switch RTP streams

[Neels Hofmeyr]

Patch Set 6: Code-Review-1

please merge 4375 and 4376 into this patch, as agreed before? If the build 
failure is due to an unmerged patch in libosmocore or something, please add a 
'Depends:' tag.

-- 
To view, visit https://gerrit.osmocom.org/4334
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2882b7ca31a3219c676986e85045fa08a425d7a
Gerrit-PatchSet: 6
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-HasComments: No

[MERGED] osmo-hlr[master]: cosmetic: tweak params of hlr_controlif_setup()

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: cosmetic: tweak params of hlr_controlif_setup()
..


cosmetic: tweak params of hlr_controlif_setup()

Cosmetically prepare for adding new CTRL commands in hlr_controlif_setup():
- drop unused 'gs' param.
- use ctrl_interface_setup_dynip2(), so far with default CTRL nodes; custom
  nodes will be added soon.

Prepares: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
Change-Id: I63004a7953b04988449697dbc5d55d7ed0c6d82d
---
M src/ctrl.c
M src/ctrl.h
M src/hlr.c
3 files changed, 8 insertions(+), 9 deletions(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/ctrl.c b/src/ctrl.c
index 3bd4d8f..b49765d 100644
--- a/src/ctrl.c
+++ b/src/ctrl.c
@@ -94,14 +94,14 @@
return rc;
 }
 
-struct ctrl_handle *hlr_controlif_setup(struct hlr *ctx,
-   struct osmo_gsup_server *gs)
+struct ctrl_handle *hlr_controlif_setup(struct hlr *hlr)
 {
int rc;
-   struct ctrl_handle *hdl = ctrl_interface_setup_dynip(ctx,
-
ctx->ctrl_bind_addr,
-OSMO_CTRL_PORT_HLR,
-NULL);
+   struct ctrl_handle *hdl = ctrl_interface_setup_dynip2(hlr,
+ 
hlr->ctrl_bind_addr,
+ 
OSMO_CTRL_PORT_HLR,
+ NULL,
+ 0);
if (!hdl)
return NULL;
 
diff --git a/src/ctrl.h b/src/ctrl.h
index 663de30..239deea 100644
--- a/src/ctrl.h
+++ b/src/ctrl.h
@@ -27,5 +27,4 @@
 #include "gsup_server.h"
 
 int hlr_ctrl_cmds_install();
-struct ctrl_handle *hlr_controlif_setup(struct hlr *ctx,
-   struct osmo_gsup_server *gs);
+struct ctrl_handle *hlr_controlif_setup(struct hlr *hlr);
diff --git a/src/hlr.c b/src/hlr.c
index b32f709..6310526 100644
--- a/src/hlr.c
+++ b/src/hlr.c
@@ -474,7 +474,7 @@
}
 
g_hlr->ctrl_bind_addr = ctrl_vty_get_bind_addr();
-   g_hlr->ctrl = hlr_controlif_setup(g_hlr, g_hlr->gs);
+   g_hlr->ctrl = hlr_controlif_setup(g_hlr);
 
osmo_init_ignore_signals();
signal(SIGINT, _hdlr);

-- 
To view, visit https://gerrit.osmocom.org/4396
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I63004a7953b04988449697dbc5d55d7ed0c6d82d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 

libosmocore[master]: GPRS: check and report local address used for NSE

[Neels Hofmeyr]

Patch Set 2:

in english: a char[] _is_ a "char*". if you have

  char foo[]

then

  

is "just coincidentally" the same memory location as foo, syntactically it 
became a char**. So just passing 'foo' is the correct way in this instance.

-- 
To view, visit https://gerrit.osmocom.org/4395
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6932a29c7899d36bcc275f05dda9670b0e69bef0
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Holger Freyther 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-hlr[master]: ctrl: completely replace all CTRL commands

[Neels Hofmeyr]

Patch Set 7:

enough argued, here is your comment.

-- 
To view, visit https://gerrit.osmocom.org/4311
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
Gerrit-PatchSet: 7
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[PATCH] osmo-hlr[master]: ctrl: completely replace all CTRL commands

[Neels Hofmeyr]

Hello Max, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/4311

to look at the new patch set (#7).

ctrl: completely replace all CTRL commands

The previous commands are not conforming to how the CTRL interface is intended
to work:

  SET enable-ps 
  SET disable-ps 
  SET status-ps 

'status-ps' is a write-only command even though it returns the status.
'enable-ps' / 'disable-ps' indicate the value instead of a variable name of an
entity. The entity  takes the place of the variable value.

See also https://lists.osmocom.org/pipermail/openbsc/2017-September/011236.html

Instead, replace with

  SET subscriber.by-imsi-123456.ps-enabled {0,1}
  GET subscriber.by-imsi-123456.ps-enabled

and also provide further CTRL functions while at it:

  {SET,GET} subscriber.by-{imsi,msisdn,id}-123456.{cs,ps}-enabled {0,1}
  GET subscriber.by-{imsi,msisdn,id}-123456.{info,info-aud,info-all}

Provide CTRL tests in the form of transcripts.

Adjust tests/test_subscriber.sql to feature nonzero SQN, to see some values for
SQN in the CTRL transcript tests. (This does not affect the VTY tests, because
that creates its own subscribers, and there's no VTY command to set the SQN.)

This is the first time an application uses CTRL_NODE ids that are defined
outside of libosmocore, see 'Depends' below.

Implementation choice: the first idea was to have a '.' between the 'by-xxx'
and the value, like:

  subscriber.by-xxx.123456.function

but the difficulty with subscribers is that they are not in RAM, and I can't
just point node_data at a struct instance that is always there (like, say, a
global bts[0] struct in osmo-bsc). Instead, I want to store the selector and
later decide whether to read from the DB or whatever. With a '.' separating
things, the only way in a ctrl function to obtain both 'by-xxx' and '123456'
for picking a subscriber record would be to parse the entire variable path
string elements, including 'subscriber' and 'function', which would then also
clumsily fix at which node level we hook these commands; there could have been
separate CTRL_NODE_SUBSCR_BY_{IMSI,MSISDN,ID} parent nodes, but we cannot
introspect the current parent node dynamically within a ctrl function handler
(plus I'm not sure whether it's possible and a good idea to have the same
command under multiple parent nodes).

Rather than that, I store the 'by-foo-123' token in the node_data pointer to
have both bits of information pointed at by a single pointer; I use the
incoming command parsing to get this token pre-separated from surrounding node
names, and no need to re-allocate it, since the vector of tokens lives until
after command execution is complete. Each leaf command obtains this token from
cmd->node (aka node_data), and feeds this token to a common static function to
parse selector and value from it and to retrieve a subscriber record as needed.

(BTW, I have mentioned on the mailing list that this way might be necessary to
avoid numeric-only CTRL node names, but we don't need to, and that is not at
all related to this choice of structure.)

Depends: libosmocore I1bd62ae0d4eefde7e1517db15a2155640a1bab58
 libosmocore Ic9dba0e4a1eb5a7dc3cee2f181b9024ed4fc7005
Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
---
M src/ctrl.c
M src/ctrl.h
M tests/test_subscriber.ctrl
M tests/test_subscriber.sql
M tests/test_subscriber.vty
A tests/test_subscriber_errors.ctrl
6 files changed, 1,041 insertions(+), 73 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-hlr refs/changes/11/4311/7

diff --git a/src/ctrl.c b/src/ctrl.c
index b49765d..3e81661 100644
--- a/src/ctrl.c
+++ b/src/ctrl.c
@@ -21,77 +21,362 @@
  */
 
 #include 
+#include 
+#include 
+#include 
 
-#include 
-#include 
+#include 
 #include 
 
-#include "gsup_server.h"
-#include "logging.h"
-#include "db.h"
 #include "hlr.h"
-#include "luop.h"
 #include "ctrl.h"
+#include "db.h"
 
-static int handle_cmd_ps(struct hlr *ctx, struct ctrl_cmd *cmd, bool enable)
+#define SEL_BY "by-"
+#define SEL_BY_IMSI SEL_BY "imsi-"
+#define SEL_BY_MSISDN SEL_BY "msisdn-"
+#define SEL_BY_ID SEL_BY "id-"
+
+#define hexdump_buf(buf) osmo_hexdump_nospc((void*)buf, sizeof(buf))
+
+static bool startswith(const char *str, const char *start)
+{
+   return strncmp(str, start, strlen(start)) == 0;
+}
+
+static int _get_subscriber(struct db_context *dbc,
+  const char *by_selector,
+  struct hlr_subscriber *subscr)
+{
+   const char *val;
+   if (startswith(by_selector, SEL_BY_IMSI)) {
+   val = by_selector + strlen(SEL_BY_IMSI);
+   if (!osmo_imsi_str_valid(val))
+   return -EINVAL;
+   return db_subscr_get_by_imsi(dbc, val, subscr);
+   }
+   if (startswith(by_selector, SEL_BY_MSISDN)) {
+   val = by_selector + strlen(SEL_BY_MSISDN);
+   if (!osmo_msisdn_str_valid(val))
+   return -EINVAL;

osmo-hlr[master]: ctrl: completely replace all CTRL commands

[Neels Hofmeyr]

Patch Set 6:

(1 comment)

https://gerrit.osmocom.org/#/c/4311/6/src/ctrl.c
File src/ctrl.c:

Line 233:   aud3g.algo = OSMO_AUTH_ALG_NONE;
> I think it's worth putting this clarification right here next to the code r
ENOENT says it all: there is no such entry, and it's all over the db api docs 
(now it is). It goes on to print things, and each print exits if algo is none; 
but that's left up to the print function to decide. there is no mystery here at 
all.


-- 
To view, visit https://gerrit.osmocom.org/4311
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50
Gerrit-PatchSet: 6
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

[MERGED] libosmocore[master]: utils: avoid segfault when calling osmo_strlcpy(src=NULL)

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: utils: avoid segfault when calling osmo_strlcpy(src=NULL)
..


utils: avoid segfault when calling osmo_strlcpy(src=NULL)

Change-Id: Ieba7ba262ace2e370a4b9a550b3131fb13f07413
---
M src/utils.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified

Objections:
  Max: I would prefer this is not merged as is



diff --git a/src/utils.c b/src/utils.c
index ef8e916..f5894d8 100644
--- a/src/utils.c
+++ b/src/utils.c
@@ -372,7 +372,7 @@
  */
 size_t osmo_strlcpy(char *dst, const char *src, size_t siz)
 {
-   size_t ret = strlen(src);
+   size_t ret = src ? strlen(src) : 0;
 
if (siz) {
size_t len = (ret >= siz) ? siz - 1 : ret;

-- 
To view, visit https://gerrit.osmocom.org/4407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ieba7ba262ace2e370a4b9a550b3131fb13f07413
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 

[MERGED] osmo-gsm-manuals[master]: OsmoHLR: add make target to update the example ctrl and vty ...

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: OsmoHLR: add make target to update the example ctrl and vty 
files
..


OsmoHLR: add make target to update the example ctrl and vty files

Change-Id: I88027396ec15101697a79aa5e964387d47abdae2
---
M OsmoHLR/Makefile
1 file changed, 41 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoHLR/Makefile b/OsmoHLR/Makefile
index a9dc393..234a48c 100644
--- a/OsmoHLR/Makefile
+++ b/OsmoHLR/Makefile
@@ -8,3 +8,44 @@
 include $(TOPDIR)/build/Makefile.vty-reference.inc
 
 include $(TOPDIR)/build/Makefile.common.inc
+
+OSMO_HLR_PATH ?= ../../osmo-hlr
+TMP_DB = generated/hlr.db
+
+update-examples: update-examples-ctrl update-examples-vty
+
+.PHONY: found-update-deps
+found-update-deps:
+   @if [ ! -f "$(OSMO_HLR_PATH)/sql/hlr.sql" ]; then \
+   echo "You need to define OSMO_HLR_PATH to point at an 
osmo-hlr.git"; \
+   exit 1; \
+   fi
+   @if [ -z "$(shell which osmo-hlr)" ]; then \
+   echo "osmo-hlr needs to be installed / available in the PATH"; \
+   exit 1; \
+   fi
+   @if [ -z "$(shell which osmo_verify_transcript_ctrl.py)" ]; then \
+   echo "You need to install 
git.osmocom.org/python/osmo-python-tests.git"; \
+   exit 1; \
+   fi
+   @if [ -z "$(shell which osmo_verify_transcript_vty.py)" ]; then \
+   echo "You need to install 
git.osmocom.org/python/osmo-python-tests.git"; \
+   exit 1; \
+   fi
+
+update-examples-ctrl: found-update-deps
+   mkdir -p generated
+   rm -f "$(TMP_DB)"
+   sqlite3 "$(TMP_DB)" < "$(OSMO_HLR_PATH)/sql/hlr.sql"
+   sqlite3 "$(TMP_DB)" < "$(OSMO_HLR_PATH)/tests/test_subscriber.sql"
+   osmo_verify_transcript_ctrl.py \
+ -r "osmo-hlr -l $(TMP_DB) -c 
/n/s/osmo/src/osmo-hlr/doc/examples/osmo-hlr.cfg" \
+ -p 4259 --update *.ctrl
+
+update-examples-vty: found-update-deps
+   mkdir -p generated
+   rm -f "$(TMP_DB)"
+   sqlite3 "$(TMP_DB)" < "$(OSMO_HLR_PATH)/sql/hlr.sql"
+   osmo_verify_transcript_vty.py \
+ -r "osmo-hlr -l $(TMP_DB) -c 
/n/s/osmo/src/osmo-hlr/doc/examples/osmo-hlr.cfg" \
+ -p 4258 --update *.vty

-- 
To view, visit https://gerrit.osmocom.org/4392
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I88027396ec15101697a79aa5e964387d47abdae2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-gsm-manuals
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 

[MERGED] osmo-gsm-manuals[master]: OsmoHLR: update ctrl description and examples

[Neels Hofmeyr]

Neels Hofmeyr has submitted this change and it was merged.

Change subject: OsmoHLR: update ctrl description and examples
..


OsmoHLR: update ctrl description and examples

The patch to refactor ctrl commands to osmo-hlr, change
I98ee6a06b3aa6a67adb868e0b63b0e04eb42eb50, was tweaked. Adjust accordingly.

Change-Id: Ie4da6115bb2eb005a9f95bf4de1bfe36468fd607
---
M OsmoHLR/chapters/control.adoc
M OsmoHLR/example_subscriber_cs_ps_enabled.ctrl
M OsmoHLR/example_subscriber_info.ctrl
3 files changed, 50 insertions(+), 6 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/OsmoHLR/chapters/control.adoc b/OsmoHLR/chapters/control.adoc
index 89c9c08..50fd314 100644
--- a/OsmoHLR/chapters/control.adoc
+++ b/OsmoHLR/chapters/control.adoc
@@ -39,8 +39,8 @@
 namevalue
 
 
-To keep the reply as short as possible, most values are omitted if they are
-empty or reflect the default. These are the returned values and their presence
+To keep the reply as short as possible, some values are omitted if they are
+empty. These are the returned values and their presence
 modalities; for their meaning, see <>:
 
 .Returned values by OsmoHLR's 'info', 'info-all' and 'info-aud' commands
@@ -50,11 +50,16 @@
 |'info'|id|-9223372036854775808 .. 9223372036854775807 (usually not 
negative)|always
 |'info'|imsi|6 to 15 decimal digits|always
 |'info'|msisdn|1 to 15 decimal digits|when non-empty
-|'info'|nam_cs|'1' or '0'|when '0'
-|'info'|nam_ps|'1' or '0'|when '0'
+|'info'|nam_cs|'1' if CS is enabled, or '0'|always
+|'info'|nam_ps|'1' if PS is enabled, or '0'|always
 |'info'|vlr_number|up to 15 decimal digits|when non-empty
 |'info'|sgsn_number|up to 15 decimal digits|when non-empty
 |'info'|sgsn_address||when non-empty
+|'info'|ms_purged_cs|'1' if CS is purged, or '0'|always
+|'info'|ms_purged_ps|'1' if PS is purged, or '0'|always
+|'info'|periodic_lu_timer|0..4294967295|always
+|'info'|periodic_rau_tau_timer|0..4294967295|always
+|'info'|lmsi|8 hex digits|always
 |'info-aud'|aud2g.algo|one of 'comp128v1', 'comp128v2', 'comp128v3' or 
'xor'|when valid 2G auth data is set
 |'info-aud'|aud2g.ki|32 hexadecimal digits|when valid 2G auth data is set
 |'info-aud'|aud3g.algo|so far always 'milenage'|when valid 3G auth data is set
diff --git a/OsmoHLR/example_subscriber_cs_ps_enabled.ctrl 
b/OsmoHLR/example_subscriber_cs_ps_enabled.ctrl
index 1a98a80..a103fb8 100644
--- a/OsmoHLR/example_subscriber_cs_ps_enabled.ctrl
+++ b/OsmoHLR/example_subscriber_cs_ps_enabled.ctrl
@@ -3,6 +3,13 @@
 id 3
 imsi   9019903
 msisdn 103
+nam_cs 1
+nam_ps 1
+ms_purged_cs   0
+ms_purged_ps   0
+periodic_lu_timer  0
+periodic_rau_tau_timer 0
+lmsi   
 
 GET 2 subscriber.by-msisdn-103.ps-enabled
 GET_REPLY 2 subscriber.by-msisdn-103.ps-enabled 1
@@ -18,7 +25,13 @@
 id 3
 imsi   9019903
 msisdn 103
+nam_cs 1
 nam_ps 0
+ms_purged_cs   0
+ms_purged_ps   0
+periodic_lu_timer  0
+periodic_rau_tau_timer 0
+lmsi   
 
 SET 6 subscriber.by-msisdn-103.cs-enabled 0
 SET_REPLY 6 subscriber.by-msisdn-103.cs-enabled OK
@@ -33,6 +46,11 @@
 msisdn 103
 nam_cs 0
 nam_ps 0
+ms_purged_cs   0
+ms_purged_ps   0
+periodic_lu_timer  0
+periodic_rau_tau_timer 0
+lmsi   
 
 SET 9 subscriber.by-msisdn-103.cs-enabled 1
 SET_REPLY 9 subscriber.by-msisdn-103.cs-enabled OK
@@ -44,3 +62,10 @@
 id 3
 imsi   9019903
 msisdn 103
+nam_cs 1
+nam_ps 1
+ms_purged_cs   0
+ms_purged_ps   0
+periodic_lu_timer  0
+periodic_rau_tau_timer 0
+lmsi   
diff --git a/OsmoHLR/example_subscriber_info.ctrl 
b/OsmoHLR/example_subscriber_info.ctrl
index 2020508..1bdf00b 100644
--- a/OsmoHLR/example_subscriber_info.ctrl
+++ b/OsmoHLR/example_subscriber_info.ctrl
@@ -3,6 +3,13 @@
 id 3
 imsi   9019903
 msisdn 103
+nam_cs 1
+nam_ps 1
+ms_purged_cs   0
+ms_purged_ps   0
+periodic_lu_timer  0
+periodic_rau_tau_timer 0
+lmsi   
 
 GET 2 subscriber.by-msisdn-103.info-aud
 GET_REPLY 2 subscriber.by-msisdn-103.info-aud 
@@ -12,17 +19,24 @@
 aud3g.k000102030405060708090a0b0c0d0e0f
 aud3g.opc  101112131415161718191a1b1c1d1e1f
 aud3g.ind_bitlen   5
-aud3g.sqn  2342
+aud3g.sqn  0
 
 GET 3 subscriber.by-id-3.info-all
 GET_REPLY 3 subscriber.by-id-3.info-all 
 id 3
 imsi   9019903
 msisdn 103
+nam_cs 1
+nam_ps 1
+ms_purged_cs   0
+ms_purged_ps   0
+periodic_lu_timer  0
+periodic_rau_tau_timer 0
+lmsi   
 aud2g.algo COMP128v1
 aud2g.ki   000102030405060708090a0b0c0d0e0f
 aud3g.algo MILENAGE
 aud3g.k000102030405060708090a0b0c0d0e0f
 aud3g.opc  101112131415161718191a1b1c1d1e1f
 aud3g.ind_bitlen   5
-aud3g.sqn  2342
+aud3g.sqn  0

-- 
To view, visit https://gerrit.osmocom.org/4393
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4da6115bb2eb005a9f95bf4de1bfe36468fd607

libosmocore[master]: utils: avoid segfault when calling osmo_strlcpy(src=NULL)

[Neels Hofmeyr]

Patch Set 1:

(1 comment)

> Even in that case I still think that we have to update tests as
 > well.

scrap the "even in that case", otherwise I agree, could add some NULL tests.

https://gerrit.osmocom.org/#/c/4407/1/src/utils.c
File src/utils.c:

Line 375:   size_t ret = src ? strlen(src) : 0;
> I guess it's a good idea to still zero-terminate 'dst' even if 'src' is NUL
yes, NULL is semantically like "", and zero-termination is promised by the API, 
and it also is what we want.


-- 
To view, visit https://gerrit.osmocom.org/4407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba7ba262ace2e370a4b9a550b3131fb13f07413
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

libosmocore[master]: utils: avoid segfault when calling osmo_strlcpy(src=NULL)

[Neels Hofmeyr]

Patch Set 1:

> (1 comment)
 > 
 > > Even in that case I still think that we have to update tests as
 > > well.
 > 
 > scrap the "even in that case", otherwise I agree, could add some
 > NULL tests.

well, whaddaya know, there seems to be no osmo_strlcpy test around anywhere. 
I'll leave it to a separate patch then, am not too eager right now.

-- 
To view, visit https://gerrit.osmocom.org/4407
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieba7ba262ace2e370a4b9a550b3131fb13f07413
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

libosmocore[master]: [doc] Fix Doxygen 'param' direction: "in, out" rather than "i...

[Neels Hofmeyr]

Patch Set 1:

there seems to be no functional difference between [inout] and [in,out], so 
this is a rather questionable cosmetic...

-- 
To view, visit https://gerrit.osmocom.org/4390
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic2de1341b37453f339f0eefde3f14e14640fe3bb
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

libosmocore[master]: vty: Fix bad use of vector_slot()

[Neels Hofmeyr]

Patch Set 2:

IUUC it doesn't only fix the warning, but was also an actual error. 
vector_slot(V,I) should amount to a void*, right? In the surrounding code, it 
is used as char*, and the vline vector, IIUC, is a list of string tokens, each 
terminated by '\0'. So this should actually be a functional change, checking 
whether the current token is just "\0", in contrast to before, where it 
checked, in effect, whether the token is NULL. Can we pinpoint a functional 
change from this patch / could there be fallout?

-- 
To view, visit https://gerrit.osmocom.org/4389
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaba9e3450d68c51e16a7bda2fc0fc370992ca866
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

osmo-hlr[master]: vty: fix output of empty IMSI

[Neels Hofmeyr]

Patch Set 2:

for char[]s, I'm accustomed to 'if (*str)' and find it quite clear, personally 
... more accurate would be 'if (*str != '\0')', but there's no practical 
difference that I know of...

-- 
To view, visit https://gerrit.osmocom.org/4388
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I72e13efefbac0495b8dd1949a39fa44ebfd46b56
Gerrit-PatchSet: 2
Gerrit-Project: osmo-hlr
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: Pau Espin Pedrol 
Gerrit-HasComments: No

[PATCH] meta-telephony[laforge/nightly]: openbsc.git: Upstream binary now named osmo-bsc-sccplite

[Harald Welte]

Review at  https://gerrit.osmocom.org/4435

openbsc.git: Upstream binary now named osmo-bsc-sccplite

In Change-Id If10d1599b62d010726336134091a4e855c380d93, upstream
osmocom.git has renamed osmo-bsc (and related config files, etc)
to osmo-bsc-sccplite, so we don't have to rename it in the recipe
anymore.

Change-Id: I7e3bf1d6186fb32f4d671cbf84cad195d2776190
---
M recipes-osmocom/openbsc/openbsc.inc
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/meta-telephony refs/changes/35/4435/1

diff --git a/recipes-osmocom/openbsc/openbsc.inc 
b/recipes-osmocom/openbsc/openbsc.inc
index e04911d..3c1b98f 100644
--- a/recipes-osmocom/openbsc/openbsc.inc
+++ b/recipes-osmocom/openbsc/openbsc.inc
@@ -11,7 +11,7 @@
   file://osmo-bsc-sccplite.service \
   "
 
-INC_PR = "r23.${META_TELEPHONY_OSMO_INC}"
+INC_PR = "r24.${META_TELEPHONY_OSMO_INC}"
 
 
 EXTRA_OECONF += "--enable-osmo-bsc --enable-mgcp-transcoding --with-g729"
@@ -26,7 +26,7 @@
 do_install_append() {
install -d ${D}${sysconfdir}/osmocom
install -m 0660 ${S}/doc/examples/osmo-nitb/nanobts/openbsc.cfg 
${D}${sysconfdir}/osmocom/osmo-nitb.cfg
-   install -m 0660 ${S}/doc/examples/osmo-bsc/osmo-bsc.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
+   install -m 0660 
${S}/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg 
${D}${sysconfdir}/osmocom/osmo-bsc-sccplite.cfg
 
# Install sysv-init files
install -d ${D}${sysconfdir}/init.d
@@ -41,7 +41,6 @@
 
install -d ${D}/var/lib/osmocom
 
-   mv ${D}${bindir}/osmo-bsc ${D}${bindir}/osmo-bsc-sccplite
 }
 
 PACKAGES =+ "osmo-bsc-sccplite osmo-nitb"

-- 
To view, visit https://gerrit.osmocom.org/4435
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e3bf1d6186fb32f4d671cbf84cad195d2776190
Gerrit-PatchSet: 1
Gerrit-Project: meta-telephony
Gerrit-Branch: laforge/nightly
Gerrit-Owner: Harald Welte 

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  220s]To: 
[  220s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  220s] 
[  220s] You may investigate any problem if you feel able to do so, in which
[  220s] case the test suite provides a good starting point.  Its output may
[  220s] be found below `tests/testsuite.dir'.
[  220s] 
[  220s] Makefile:1221: recipe for target 'check-local' failed
[  220s] make[3]: *** [check-local] Error 1
[  220s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  220s] Makefile:1055: recipe for target 'check-am' failed
[  220s] make[2]: *** [check-am] Error 2
[  220s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  220s] Makefile:460: recipe for target 'check-recursive' failed
[  220s] make[1]: *** [check-recursive] Error 1
[  220s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  220s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  220s] debian/rules:12: recipe for target 'build' failed
[  220s] make: *** [build] Error 2
[  220s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  220s] 
[  220s] lamb25 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:09:49 UTC 2017.
[  220s] 
[  220s] ### VM INTERACTION START ###
[  223s] [  214.851964] reboot: Power down
[  223s] ### VM INTERACTION END ###
[  223s] 
[  223s] lamb25 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:09:52 UTC 2017.
[  223s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  149s]To: 
[  149s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  149s] 
[  149s] You may investigate any problem if you feel able to do so, in which
[  149s] case the test suite provides a good starting point.  Its output may
[  149s] be found below `tests/testsuite.dir'.
[  149s] 
[  149s] Makefile:1221: recipe for target 'check-local' failed
[  149s] make[3]: *** [check-local] Error 1
[  149s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  149s] Makefile:1055: recipe for target 'check-am' failed
[  149s] make[2]: *** [check-am] Error 2
[  149s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  149s] Makefile:460: recipe for target 'check-recursive' failed
[  149s] make[1]: *** [check-recursive] Error 1
[  149s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  149s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  149s] debian/rules:12: recipe for target 'build' failed
[  149s] make: *** [build] Error 2
[  149s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  149s] 
[  149s] lamb19 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:48 UTC 2017.
[  149s] 
[  149s] ### VM INTERACTION START ###
[  152s] [  145.284148] reboot: Power down
[  152s] ### VM INTERACTION END ###
[  152s] 
[  152s] lamb19 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:52 UTC 2017.
[  152s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  146s]To: 
[  146s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  146s] 
[  146s] You may investigate any problem if you feel able to do so, in which
[  146s] case the test suite provides a good starting point.  Its output may
[  146s] be found below `tests/testsuite.dir'.
[  146s] 
[  146s] Makefile:1221: recipe for target 'check-local' failed
[  146s] make[3]: *** [check-local] Error 1
[  146s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  146s] Makefile:1055: recipe for target 'check-am' failed
[  146s] make[2]: *** [check-am] Error 2
[  146s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  146s] Makefile:460: recipe for target 'check-recursive' failed
[  146s] make[1]: *** [check-recursive] Error 1
[  146s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  146s] dh_auto_test: make -j1 check returned exit code 2
[  146s] debian/rules:12: recipe for target 'build' failed
[  146s] make: *** [build] Error 2
[  146s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  146s] 
[  146s] lamb70 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:45 UTC 2017.
[  146s] 
[  146s] ### VM INTERACTION START ###
[  150s] [  142.875486] reboot: Power down
[  150s] ### VM INTERACTION END ###
[  150s] 
[  150s] lamb70 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:49 UTC 2017.
[  150s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  148s]To: 
[  148s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  148s] 
[  148s] You may investigate any problem if you feel able to do so, in which
[  148s] case the test suite provides a good starting point.  Its output may
[  148s] be found below `tests/testsuite.dir'.
[  148s] 
[  148s] Makefile:1221: recipe for target 'check-local' failed
[  148s] make[3]: *** [check-local] Error 1
[  148s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  148s] Makefile:1055: recipe for target 'check-am' failed
[  148s] make[2]: *** [check-am] Error 2
[  148s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  148s] Makefile:460: recipe for target 'check-recursive' failed
[  148s] make[1]: *** [check-recursive] Error 1
[  148s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  148s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  148s] debian/rules:12: recipe for target 'build' failed
[  148s] make: *** [build] Error 2
[  148s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  148s] 
[  148s] lamb54 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:34 UTC 2017.
[  148s] 
[  148s] ### VM INTERACTION START ###
[  152s] [  144.734962] reboot: Power down
[  152s] ### VM INTERACTION END ###
[  152s] 
[  152s] lamb54 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:38 UTC 2017.
[  152s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  133s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  133s] 
[  133s] You may investigate any problem if you feel able to do so, in which
[  133s] case the test suite provides a good starting point.  Its output may
[  133s] be found below `tests/testsuite.dir'.
[  133s] 
[  133s] Makefile:1208: recipe for target 'check-local' failed
[  133s] make[3]: *** [check-local] Error 1
[  133s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  133s] Makefile:1044: recipe for target 'check-am' failed
[  133s] make[2]: *** [check-am] Error 2
[  133s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  133s] Makefile:448: recipe for target 'check-recursive' failed
[  133s] make[1]: *** [check-recursive] Error 1
[  133s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  133s] dh_auto_test: make -j1 check returned exit code 2
[  133s] debian/rules:12: recipe for target 'build' failed
[  133s] make: *** [build] Error 2
[  133s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  133s] 
[  133s] lamb54 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:05 UTC 2017.
[  133s] 
[  133s] ### VM INTERACTION START ###
[  135s] Powering off.
[  135s] [  127.320222] reboot: Power down
[  135s] ### VM INTERACTION END ###
[  135s] 
[  135s] lamb54 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:08:07 UTC 2017.
[  135s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  224s]To: 
[  224s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  224s] 
[  224s] You may investigate any problem if you feel able to do so, in which
[  224s] case the test suite provides a good starting point.  Its output may
[  224s] be found below `tests/testsuite.dir'.
[  224s] 
[  224s] Makefile:1221: recipe for target 'check-local' failed
[  224s] make[3]: *** [check-local] Error 1
[  224s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  224s] Makefile:1055: recipe for target 'check-am' failed
[  224s] make[2]: *** [check-am] Error 2
[  224s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  224s] Makefile:460: recipe for target 'check-recursive' failed
[  224s] make[1]: *** [check-recursive] Error 1
[  224s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  224s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  224s] debian/rules:12: recipe for target 'build' failed
[  224s] make: *** [build] Error 2
[  224s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  224s] 
[  224s] lamb51 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:00:13 UTC 2017.
[  224s] 
[  224s] ### VM INTERACTION START ###
[  227s] [  219.590456] reboot: Power down
[  227s] ### VM INTERACTION END ###
[  227s] 
[  227s] lamb51 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
20:00:17 UTC 2017.
[  227s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  166s]To: 
[  166s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  166s] 
[  166s] You may investigate any problem if you feel able to do so, in which
[  166s] case the test suite provides a good starting point.  Its output may
[  166s] be found below `tests/testsuite.dir'.
[  166s] 
[  166s] Makefile:1221: recipe for target 'check-local' failed
[  166s] make[3]: *** [check-local] Error 1
[  166s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  166s] Makefile:1055: recipe for target 'check-am' failed
[  166s] make[2]: *** [check-am] Error 2
[  166s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  166s] Makefile:460: recipe for target 'check-recursive' failed
[  166s] make[1]: *** [check-recursive] Error 1
[  166s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  166s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  166s] debian/rules:12: recipe for target 'build' failed
[  166s] make: *** [build] Error 2
[  166s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  166s] 
[  166s] lamb55 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:59:40 UTC 2017.
[  166s] 
[  166s] ### VM INTERACTION START ###
[  169s] [  162.383931] reboot: Power down
[  169s] ### VM INTERACTION END ###
[  169s] 
[  169s] lamb55 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:59:44 UTC 2017.
[  169s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  201s]To: 
[  201s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  201s] 
[  201s] You may investigate any problem if you feel able to do so, in which
[  201s] case the test suite provides a good starting point.  Its output may
[  201s] be found below `tests/testsuite.dir'.
[  201s] 
[  201s] Makefile:1221: recipe for target 'check-local' failed
[  201s] make[3]: *** [check-local] Error 1
[  201s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  201s] Makefile:1055: recipe for target 'check-am' failed
[  201s] make[2]: *** [check-am] Error 2
[  201s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  201s] Makefile:460: recipe for target 'check-recursive' failed
[  201s] make[1]: *** [check-recursive] Error 1
[  201s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  201s] dh_auto_test: make -j1 check returned exit code 2
[  201s] debian/rules:12: recipe for target 'build' failed
[  201s] make: *** [build] Error 2
[  201s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  201s] 
[  201s] lamb22 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:58:55 UTC 2017.
[  201s] 
[  201s] ### VM INTERACTION START ###
[  204s] [  196.002906] reboot: Power down
[  204s] ### VM INTERACTION END ###
[  204s] 
[  204s] lamb22 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:58:59 UTC 2017.
[  204s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  153s]To: 
[  153s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  153s] 
[  153s] You may investigate any problem if you feel able to do so, in which
[  153s] case the test suite provides a good starting point.  Its output may
[  153s] be found below `tests/testsuite.dir'.
[  153s] 
[  153s] Makefile:1221: recipe for target 'check-local' failed
[  153s] make[3]: *** [check-local] Error 1
[  153s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  153s] Makefile:1055: recipe for target 'check-am' failed
[  153s] make[2]: *** [check-am] Error 2
[  153s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  153s] Makefile:460: recipe for target 'check-recursive' failed
[  153s] make[1]: *** [check-recursive] Error 1
[  153s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  153s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  153s] debian/rules:12: recipe for target 'build' failed
[  153s] make: *** [build] Error 2
[  153s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  153s] 
[  153s] build84 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:59:01 UTC 2017.
[  153s] 
[  153s] ### VM INTERACTION START ###
[  156s] [  148.837696] reboot: Power down
[  156s] ### VM INTERACTION END ###
[  156s] 
[  156s] build84 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:59:05 UTC 2017.
[  156s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  173s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  173s] 
[  173s] You may investigate any problem if you feel able to do so, in which
[  173s] case the test suite provides a good starting point.  Its output may
[  173s] be found below `tests/testsuite.dir'.
[  173s] 
[  173s] Makefile:1208: recipe for target 'check-local' failed
[  173s] make[3]: *** [check-local] Error 1
[  173s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  173s] Makefile:1044: recipe for target 'check-am' failed
[  173s] make[2]: *** [check-am] Error 2
[  173s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  173s] Makefile:448: recipe for target 'check-recursive' failed
[  173s] make[1]: *** [check-recursive] Error 1
[  173s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  173s] dh_auto_test: make -j1 check returned exit code 2
[  173s] debian/rules:12: recipe for target 'build' failed
[  173s] make: *** [build] Error 2
[  173s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  173s] 
[  173s] build34 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:57:46 UTC 2017.
[  173s] 
[  173s] ### VM INTERACTION START ###
[  175s] Powering off.
[  175s] [  166.667317] reboot: Power down
[  175s] ### VM INTERACTION END ###
[  175s] 
[  175s] build34 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
19:57:48 UTC 2017.
[  175s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

osmo-ci[master]: osmocom:nightly OBS: add osmo-bsc package / remove nitb-split

[Harald Welte]

Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit https://gerrit.osmocom.org/4434
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib99e0775e9db30ec3c5263bb3a364d8cab4633c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[MERGED] osmo-ci[master]: osmocom:nightly OBS: add osmo-bsc package / remove nitb-split

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmocom:nightly OBS: add osmo-bsc package / remove nitb-split
..


osmocom:nightly OBS: add osmo-bsc package / remove nitb-split

This was the last package that we only built in
osmocom:nitb-split:nightly, so we can remove the latter, too

Change-Id: Ib99e0775e9db30ec3c5263bb3a364d8cab4633c3
---
D scripts/osmocom-nightly-nitb-split.sh
M scripts/osmocom-nightly-packages.sh
2 files changed, 2 insertions(+), 119 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/scripts/osmocom-nightly-nitb-split.sh 
b/scripts/osmocom-nightly-nitb-split.sh
deleted file mode 100755
index 3b547bf..000
--- a/scripts/osmocom-nightly-nitb-split.sh
+++ /dev/null
@@ -1,119 +0,0 @@
-#!/bin/bash
-
-set -e
-set -x
-
-DT=$(date +%Y%m%d)
-PROJ=network:osmocom:nitb-split:nightly
-
-### common
-checkout() {
-  local name=$1
-  local branch=$2
-  local url="git://git.osmocom.org"
-
-  cd "$REPO"
-
-  if [ -n "$branch" ] ; then
-git clone "$url/$name" -b "$branch"
-  else
-git clone "$url/$name"
-  fi
-
-  cd -
-}
-
-### OBS build
-prepare() {
-  # clean up the whole space
-  mkdir -p "$REPO/osc/"
-  cd "$REPO/osc"
-  osc co "$PROJ"
-}
-
-build() {
-  local name=$1
-  local repodir=$REPO/$name
-  local oscdir=$REPO/osc/$PROJ/$name
-
-  if [ -d "$oscdir" ] ; then
-# remove earlier version
-cd "$oscdir"
-osc rm -- * || true
-  else
-# new package
-mkdir -p "$oscdir/"
-cd "$REPO/osc/$PROJ/"
-osc add "$name"
-  fi
-
-  cd "$repodir"
-
-  VER=$(head -1 debian/changelog | cut -d ' ' -f 2 | sed 's,(,,'  | sed 
's,),,')
-  dch -v "$VER.$DT" -m "Snapshot build"
-  git commit -m "$DT snapshot" debian/
-
-  mkdir -p "$DATA/$name"
-  # source code build without dependency checks and unsigned source and 
unsigned change log
-  gbp buildpackage -S -uc -us -d --git-ignore-branch 
"--git-export-dir=$DATA/$name"
-
-  mv "$DATA/$name/"*.tar* "$DATA/$name/"*.dsc "$oscdir/"
-
-  cd "$oscdir"
-  osc add -- *.tar* *.dsc
-  osc ci -m "Snapshot $name $DT"
-}
-
-post() {
-  cd "$REPO/osc/$PROJ/"
-  osc status
-}
-
-build_osmocom() {
-  BASE=$PWD
-  DATA=$BASE/data
-  REPO=$BASE/repo
-
-  # rather than including a dangerous 'rm -rf *' here, lets delegate to the 
user:
-  if [ -n "$(ls)" ]; then
-echo "ERROR: I need to run in an empty directory."
-exit 1
-  fi
-
-  prepare
-
-  checkout libosmocore
-  checkout libosmo-abis
-  checkout libosmo-netif
-  checkout libosmo-sccp
-  checkout libsmpp34
-  checkout libasn1c
-  checkout osmo-iuh
-  checkout osmo-hlr
-  checkout osmo-ggsn
-  checkout osmo-mgw
-  checkout osmo-bsc
-  checkout osmo-msc
-  checkout osmo-sgsn
-
-  build libosmocore
-  build libosmo-abis
-  build libosmo-netif
-  build libosmo-sccp
-  build libsmpp34
-  build libasn1c
-  build osmo-iuh
-  build osmo-hlr
-  build osmo-ggsn
-  build osmo-mgw
-  build osmo-bsc
-  build osmo-msc
-  build osmo-sgsn
-
-  post
-}
-
-TMPDIR=$(mktemp -d nightly-3g_XX)
-cd "$TMPDIR"
-build_osmocom
-rm -rf "./$TMPDIR/"
diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index 12aa587..6206576 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -26,6 +26,7 @@
 git clone git://git.osmocom.org/osmo-hlr
 git clone git://git.osmocom.org/osmo-mgw
 git clone git://git.osmocom.org/osmo-msc
+git clone git://git.osmocom.org/osmo-bsc
 
 
 PROJ=network:osmocom:nightly
@@ -67,6 +68,7 @@
 build osmo-hlr
 build osmo-mgw
 build osmo-msc
+build osmo-bsc
 
 cd $PROJ
 osc ci -m "Snapshot $DT"

-- 
To view, visit https://gerrit.osmocom.org/4434
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib99e0775e9db30ec3c5263bb3a364d8cab4633c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 

[PATCH] osmo-ci[master]: osmocom:nightly OBS: add osmo-bsc package / remove nitb-split

[Harald Welte]

Review at  https://gerrit.osmocom.org/4434

osmocom:nightly OBS: add osmo-bsc package / remove nitb-split

This was the last package that we only built in
osmocom:nitb-split:nightly, so we can remove the latter, too

Change-Id: Ib99e0775e9db30ec3c5263bb3a364d8cab4633c3
---
D scripts/osmocom-nightly-nitb-split.sh
M scripts/osmocom-nightly-packages.sh
2 files changed, 2 insertions(+), 119 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/34/4434/1

diff --git a/scripts/osmocom-nightly-nitb-split.sh 
b/scripts/osmocom-nightly-nitb-split.sh
deleted file mode 100755
index 3b547bf..000
--- a/scripts/osmocom-nightly-nitb-split.sh
+++ /dev/null
@@ -1,119 +0,0 @@
-#!/bin/bash
-
-set -e
-set -x
-
-DT=$(date +%Y%m%d)
-PROJ=network:osmocom:nitb-split:nightly
-
-### common
-checkout() {
-  local name=$1
-  local branch=$2
-  local url="git://git.osmocom.org"
-
-  cd "$REPO"
-
-  if [ -n "$branch" ] ; then
-git clone "$url/$name" -b "$branch"
-  else
-git clone "$url/$name"
-  fi
-
-  cd -
-}
-
-### OBS build
-prepare() {
-  # clean up the whole space
-  mkdir -p "$REPO/osc/"
-  cd "$REPO/osc"
-  osc co "$PROJ"
-}
-
-build() {
-  local name=$1
-  local repodir=$REPO/$name
-  local oscdir=$REPO/osc/$PROJ/$name
-
-  if [ -d "$oscdir" ] ; then
-# remove earlier version
-cd "$oscdir"
-osc rm -- * || true
-  else
-# new package
-mkdir -p "$oscdir/"
-cd "$REPO/osc/$PROJ/"
-osc add "$name"
-  fi
-
-  cd "$repodir"
-
-  VER=$(head -1 debian/changelog | cut -d ' ' -f 2 | sed 's,(,,'  | sed 
's,),,')
-  dch -v "$VER.$DT" -m "Snapshot build"
-  git commit -m "$DT snapshot" debian/
-
-  mkdir -p "$DATA/$name"
-  # source code build without dependency checks and unsigned source and 
unsigned change log
-  gbp buildpackage -S -uc -us -d --git-ignore-branch 
"--git-export-dir=$DATA/$name"
-
-  mv "$DATA/$name/"*.tar* "$DATA/$name/"*.dsc "$oscdir/"
-
-  cd "$oscdir"
-  osc add -- *.tar* *.dsc
-  osc ci -m "Snapshot $name $DT"
-}
-
-post() {
-  cd "$REPO/osc/$PROJ/"
-  osc status
-}
-
-build_osmocom() {
-  BASE=$PWD
-  DATA=$BASE/data
-  REPO=$BASE/repo
-
-  # rather than including a dangerous 'rm -rf *' here, lets delegate to the 
user:
-  if [ -n "$(ls)" ]; then
-echo "ERROR: I need to run in an empty directory."
-exit 1
-  fi
-
-  prepare
-
-  checkout libosmocore
-  checkout libosmo-abis
-  checkout libosmo-netif
-  checkout libosmo-sccp
-  checkout libsmpp34
-  checkout libasn1c
-  checkout osmo-iuh
-  checkout osmo-hlr
-  checkout osmo-ggsn
-  checkout osmo-mgw
-  checkout osmo-bsc
-  checkout osmo-msc
-  checkout osmo-sgsn
-
-  build libosmocore
-  build libosmo-abis
-  build libosmo-netif
-  build libosmo-sccp
-  build libsmpp34
-  build libasn1c
-  build osmo-iuh
-  build osmo-hlr
-  build osmo-ggsn
-  build osmo-mgw
-  build osmo-bsc
-  build osmo-msc
-  build osmo-sgsn
-
-  post
-}
-
-TMPDIR=$(mktemp -d nightly-3g_XX)
-cd "$TMPDIR"
-build_osmocom
-rm -rf "./$TMPDIR/"
diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index 12aa587..6206576 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -26,6 +26,7 @@
 git clone git://git.osmocom.org/osmo-hlr
 git clone git://git.osmocom.org/osmo-mgw
 git clone git://git.osmocom.org/osmo-msc
+git clone git://git.osmocom.org/osmo-bsc
 
 
 PROJ=network:osmocom:nightly
@@ -67,6 +68,7 @@
 build osmo-hlr
 build osmo-mgw
 build osmo-msc
+build osmo-bsc
 
 cd $PROJ
 osc ci -m "Snapshot $DT"

-- 
To view, visit https://gerrit.osmocom.org/4434
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib99e0775e9db30ec3c5263bb3a364d8cab4633c3
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  226s] 
[  226s] Please send `tests/testsuite.log' and all information you think might 
help:
[  226s] 
[  226s]To: 
[  226s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  226s] 
[  226s] You may investigate any problem if you feel able to do so, in which
[  226s] case the test suite provides a good starting point.  Its output may
[  226s] be found below `tests/testsuite.dir'.
[  226s] 
[  226s] Makefile:1221: recipe for target 'check-local' failed
[  226s] make[3]: *** [check-local] Error 1
[  226s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  226s] Makefile:1055: recipe for target 'check-am' failed
[  226s] make[2]: *** [check-am] Error 2
[  226s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  226s] Makefile:460: recipe for target 'check-recursive' failed
[  226s] make[1]: *** [check-recursive] Error 1
[  226s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  226s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  226s] debian/rules:12: recipe for target 'build' failed
[  226s] make: *** [build] Error 2
[  226s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  226s] 
[  226s] cloud113 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:54:23 UTC 2017.
[  226s] 
[  226s] ### VM INTERACTION START ###
[  229s] [  212.161909] reboot: Power down
[  230s] ### VM INTERACTION END ###

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  178s]To: 
[  178s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  178s] 
[  178s] You may investigate any problem if you feel able to do so, in which
[  178s] case the test suite provides a good starting point.  Its output may
[  178s] be found below `tests/testsuite.dir'.
[  178s] 
[  178s] Makefile:1221: recipe for target 'check-local' failed
[  178s] make[3]: *** [check-local] Error 1
[  178s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  178s] Makefile:1055: recipe for target 'check-am' failed
[  178s] make[2]: *** [check-am] Error 2
[  178s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  178s] Makefile:460: recipe for target 'check-recursive' failed
[  178s] make[1]: *** [check-recursive] Error 1
[  178s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  178s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  178s] debian/rules:12: recipe for target 'build' failed
[  178s] make: *** [build] Error 2
[  178s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  178s] 
[  178s] build34 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:53:24 UTC 2017.
[  178s] 
[  178s] ### VM INTERACTION START ###
[  181s] [  172.971915] reboot: Power down
[  182s] ### VM INTERACTION END ###
[  182s] 
[  182s] build34 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:53:28 UTC 2017.
[  182s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  167s]To: 
[  167s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  167s] 
[  167s] You may investigate any problem if you feel able to do so, in which
[  167s] case the test suite provides a good starting point.  Its output may
[  167s] be found below `tests/testsuite.dir'.
[  167s] 
[  167s] Makefile:1221: recipe for target 'check-local' failed
[  167s] make[3]: *** [check-local] Error 1
[  167s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  167s] Makefile:1055: recipe for target 'check-am' failed
[  167s] make[2]: *** [check-am] Error 2
[  167s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  167s] Makefile:460: recipe for target 'check-recursive' failed
[  167s] make[1]: *** [check-recursive] Error 1
[  167s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  167s] dh_auto_test: make -j1 check returned exit code 2
[  167s] debian/rules:12: recipe for target 'build' failed
[  167s] make: *** [build] Error 2
[  167s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  167s] 
[  167s] lamb26 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:44 UTC 2017.
[  167s] 
[  167s] ### VM INTERACTION START ###
[  171s] [  164.043366] reboot: Power down
[  171s] ### VM INTERACTION END ###
[  171s] 
[  171s] lamb26 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:48 UTC 2017.
[  171s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  152s]To: 
[  152s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  152s] 
[  152s] You may investigate any problem if you feel able to do so, in which
[  152s] case the test suite provides a good starting point.  Its output may
[  152s] be found below `tests/testsuite.dir'.
[  152s] 
[  152s] Makefile:1221: recipe for target 'check-local' failed
[  152s] make[3]: *** [check-local] Error 1
[  152s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  152s] Makefile:1055: recipe for target 'check-am' failed
[  152s] make[2]: *** [check-am] Error 2
[  152s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  152s] Makefile:460: recipe for target 'check-recursive' failed
[  152s] make[1]: *** [check-recursive] Error 1
[  152s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  152s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  152s] debian/rules:12: recipe for target 'build' failed
[  152s] make: *** [build] Error 2
[  152s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  152s] 
[  152s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:53:04 UTC 2017.
[  152s] 
[  152s] ### VM INTERACTION START ###
[  155s] [  148.420754] reboot: Power down
[  155s] ### VM INTERACTION END ###
[  155s] 
[  155s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:53:07 UTC 2017.
[  155s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  149s]To: 
[  149s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  149s] 
[  149s] You may investigate any problem if you feel able to do so, in which
[  149s] case the test suite provides a good starting point.  Its output may
[  149s] be found below `tests/testsuite.dir'.
[  149s] 
[  149s] Makefile:1221: recipe for target 'check-local' failed
[  149s] make[3]: *** [check-local] Error 1
[  149s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  149s] Makefile:1055: recipe for target 'check-am' failed
[  149s] make[2]: *** [check-am] Error 2
[  149s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  149s] Makefile:460: recipe for target 'check-recursive' failed
[  149s] make[1]: *** [check-recursive] Error 1
[  149s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  149s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  149s] debian/rules:12: recipe for target 'build' failed
[  149s] make: *** [build] Error 2
[  149s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  149s] 
[  149s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:59 UTC 2017.
[  149s] 
[  149s] ### VM INTERACTION START ###
[  152s] [  144.892517] reboot: Power down
[  152s] ### VM INTERACTION END ###
[  152s] 
[  152s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:53:03 UTC 2017.
[  152s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  126s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  126s] 
[  126s] You may investigate any problem if you feel able to do so, in which
[  126s] case the test suite provides a good starting point.  Its output may
[  126s] be found below `tests/testsuite.dir'.
[  126s] 
[  126s] Makefile:1208: recipe for target 'check-local' failed
[  126s] make[3]: *** [check-local] Error 1
[  126s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  126s] Makefile:1044: recipe for target 'check-am' failed
[  126s] make[2]: *** [check-am] Error 2
[  126s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  126s] Makefile:448: recipe for target 'check-recursive' failed
[  126s] make[1]: *** [check-recursive] Error 1
[  126s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  126s] dh_auto_test: make -j1 check returned exit code 2
[  126s] debian/rules:12: recipe for target 'build' failed
[  126s] make: *** [build] Error 2
[  126s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  126s] 
[  126s] lamb12 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:31 UTC 2017.
[  126s] 
[  126s] ### VM INTERACTION START ###
[  127s] Powering off.
[  127s] [  120.207903] reboot: Power down
[  127s] ### VM INTERACTION END ###
[  127s] 
[  127s] lamb12 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:32 UTC 2017.
[  127s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  150s]To: 
[  150s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  150s] 
[  150s] You may investigate any problem if you feel able to do so, in which
[  150s] case the test suite provides a good starting point.  Its output may
[  150s] be found below `tests/testsuite.dir'.
[  150s] 
[  150s] Makefile:1221: recipe for target 'check-local' failed
[  150s] make[3]: *** [check-local] Error 1
[  150s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  150s] Makefile:1055: recipe for target 'check-am' failed
[  150s] make[2]: *** [check-am] Error 2
[  150s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  150s] Makefile:460: recipe for target 'check-recursive' failed
[  150s] make[1]: *** [check-recursive] Error 1
[  150s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  150s] dh_auto_test: make -j1 check returned exit code 2
[  150s] debian/rules:12: recipe for target 'build' failed
[  150s] make: *** [build] Error 2
[  150s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  150s] 
[  150s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:12 UTC 2017.
[  150s] 
[  150s] ### VM INTERACTION START ###
[  153s] [  146.470540] reboot: Power down
[  153s] ### VM INTERACTION END ###
[  153s] 
[  153s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:52:15 UTC 2017.
[  153s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[   95s]To: 
[   95s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[   95s] 
[   95s] You may investigate any problem if you feel able to do so, in which
[   95s] case the test suite provides a good starting point.  Its output may
[   95s] be found below `tests/testsuite.dir'.
[   95s] 
[   95s] Makefile:1221: recipe for target 'check-local' failed
[   95s] make[3]: *** [check-local] Error 1
[   95s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[   95s] Makefile:1055: recipe for target 'check-am' failed
[   95s] make[2]: *** [check-am] Error 2
[   95s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[   95s] Makefile:460: recipe for target 'check-recursive' failed
[   95s] make[1]: *** [check-recursive] Error 1
[   95s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[   95s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[   95s] debian/rules:12: recipe for target 'build' failed
[   95s] make: *** [build] Error 2
[   95s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[   95s] 
[   95s] build79 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:51:50 UTC 2017.
[   95s] 
[   95s] ### VM INTERACTION START ###
[   99s] [   93.595060] reboot: Power down
[   99s] ### VM INTERACTION END ###
[   99s] 
[   99s] build79 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:51:53 UTC 2017.
[   99s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  103s] 
[  103s]To: 
[  103s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  103s] 
[  103s] You may investigate any problem if you feel able to do so, in which
[  103s] case the test suite provides a good starting point.  Its output may
[  103s] be found below `tests/testsuite.dir'.
[  103s] 
[  103s] Makefile:1221: recipe for target 'check-local' failed
[  103s] make[3]: *** [check-local] Error 1
[  103s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  103s] Makefile:1055: recipe for target 'check-am' failed
[  103s] make[2]: *** [check-am] Error 2
[  103s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  103s] Makefile:460: recipe for target 'check-recursive' failed
[  103s] make[1]: *** [check-recursive] Error 1
[  103s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  103s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  103s] debian/rules:12: recipe for target 'build' failed
[  103s] make: *** [build] Error 2
[  103s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  103s] 
[  103s] build85 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:51:45 UTC 2017.
[  103s] 
[  103s] ### VM INTERACTION START ###
[  106s] [  100.893922] reboot: Power down
[  107s] ### VM INTERACTION END ###
[  107s] 
[  107s] build85 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:51:50 UTC 2017.

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  147s]To: 
[  147s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  147s] 
[  147s] You may investigate any problem if you feel able to do so, in which
[  147s] case the test suite provides a good starting point.  Its output may
[  147s] be found below `tests/testsuite.dir'.
[  147s] 
[  147s] Makefile:1221: recipe for target 'check-local' failed
[  147s] make[3]: *** [check-local] Error 1
[  147s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  147s] Makefile:1055: recipe for target 'check-am' failed
[  147s] make[2]: *** [check-am] Error 2
[  147s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  147s] Makefile:460: recipe for target 'check-recursive' failed
[  147s] make[1]: *** [check-recursive] Error 1
[  147s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  147s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  147s] debian/rules:12: recipe for target 'build' failed
[  147s] make: *** [build] Error 2
[  147s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  147s] 
[  147s] lamb12 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:48:56 UTC 2017.
[  147s] 
[  147s] ### VM INTERACTION START ###
[  150s] [  142.685017] reboot: Power down
[  150s] ### VM INTERACTION END ###
[  150s] 
[  150s] lamb12 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:48:59 UTC 2017.
[  150s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  153s]To: 
[  153s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  153s] 
[  153s] You may investigate any problem if you feel able to do so, in which
[  153s] case the test suite provides a good starting point.  Its output may
[  153s] be found below `tests/testsuite.dir'.
[  153s] 
[  153s] Makefile:1221: recipe for target 'check-local' failed
[  153s] make[3]: *** [check-local] Error 1
[  153s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  153s] Makefile:1055: recipe for target 'check-am' failed
[  153s] make[2]: *** [check-am] Error 2
[  153s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  153s] Makefile:460: recipe for target 'check-recursive' failed
[  153s] make[1]: *** [check-recursive] Error 1
[  153s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  153s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  153s] debian/rules:12: recipe for target 'build' failed
[  153s] make: *** [build] Error 2
[  153s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  153s] 
[  153s] lamb01 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:03:48 UTC 2017.
[  153s] 
[  153s] ### VM INTERACTION START ###
[  156s] [  148.742487] reboot: Power down
[  156s] ### VM INTERACTION END ###
[  156s] 
[  156s] lamb01 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
17:03:51 UTC 2017.
[  156s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

osmo-gsm-tester[master]: default-suites: Add test cases with octphy BTS

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4427
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If8b5bda50c245ad693e7679ad44515b90a067fbb
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-gsm-tester[master]: Change example config to use only 1 TRX for osmo-bts-octphy ...

[Harald Welte]

Patch Set 1:

the OCTBTS conists of two DSPs, and each of them can be single-TRX or 
multi-TRX.  The multi-TRX license relates to running multiple soft TRXs on one 
DSP.

Result: you should be able to run two TRXs (one on each DSP) perfectly fine 
with current software.

-- 
To view, visit https://gerrit.osmocom.org/4426
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id2c415deb85187feb42fb6d24cc86273eb722936
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-gsm-tester[master]: Add support for osmo-bts-octphy

[Harald Welte]

Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.osmocom.org/#/c/4425/1/example/resources.conf
File example/resources.conf:

PS1, Line 34: Octphy
OCTPHY is the osmo-bts- backend name and the name of the PHY library.  "OCTBTS 
3500" is the product name, and we also have some "OCTBTS 3000".


-- 
To view, visit https://gerrit.osmocom.org/4425
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia350964fa539083bb68d439cad0caa8fdf85d297
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: Yes

osmo-gsm-tester[master]: util: Add change_elf_rpath API

[Harald Welte]

Patch Set 1: Code-Review+1

what a nightmare to have to jump through those hoops...

-- 
To view, visit https://gerrit.osmocom.org/4424
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc356957fb3dbcf9947bfe96b671ec8c7ede33ff
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-gsm-tester[master]: util: Add setcap_net_raw API

[Harald Welte]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/4423
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If3eb24461c02173dc80837a4cc83f9f2420c7816
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-gsm-tester[master]: config: Fix crash in overlay()

[Harald Welte]

Patch Set 1: Code-Review+1

-- 
To view, visit https://gerrit.osmocom.org/4422
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f8a191810e89a4081199edcb390fb3bb27ed42f
Gerrit-PatchSet: 1
Gerrit-Project: osmo-gsm-tester
Gerrit-Branch: master
Gerrit-Owner: Pau Espin Pedrol 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

[MERGED] osmo-bsc[master]: log: log the sccp message type of messages sent

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: log: log the sccp message type of messages sent
..


log: log the sccp message type of messages sent

We already log the message type of sccp messages we receive, but
for transmitting the log output is missing.

Also log the message type for tramsitted sccp messages.

Change-Id: I6736f15ddc03e5f70c3504abffbae6cbf766c9d7
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 16 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 48796c1..31a8cea 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -331,6 +331,22 @@
 
msc = conn->msc;
 
+   /* Log the type of the message we are sending. This is just
+* informative, do not stop if detecting the type fails */
+   if (msg->len >= 3) {
+   switch (msg->data[0]) {
+   case BSSAP_MSG_BSS_MANAGEMENT:
+   LOGP(DMSC, LOGL_INFO, "Tx MSC %s\n", 
gsm0808_bssmap_name(msg->data[2]));
+   break;
+   case BSSAP_MSG_DTAP:
+   LOGP(DMSC, LOGL_INFO, "Tx MSC DTAP\n");
+   break;
+   default:
+   LOGP(DMSC, LOGL_ERROR, "Tx MSC (unknwon message 
type)\n");
+   }
+   } else
+   LOGP(DMSC, LOGL_ERROR, "Tx MSC (message too short)\n");
+
if (a_reset_conn_ready(msc->a.reset) == false) {
LOGP(DMSC, LOGL_ERROR, "MSC is not connected. Dropping.\n");
return -EINVAL;

-- 
To view, visit https://gerrit.osmocom.org/4351
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6736f15ddc03e5f70c3504abffbae6cbf766c9d7
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[MERGED] osmo-bsc[master]: log: output hexdump of transmitted sccp messages

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: log: output hexdump of transmitted sccp messages
..


log: output hexdump of transmitted sccp messages

We output a hexdump for each sccp message we receive, but not when
sending.

Also log the hexdump of sccp messages when sending.

Change-Id: Ibfe52a0b7dbca4c569c603a008d73d0d99d1c345
---
M src/osmo-bsc/osmo_bsc_sigtran.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/osmo-bsc/osmo_bsc_sigtran.c b/src/osmo-bsc/osmo_bsc_sigtran.c
index 31a8cea..951061a 100644
--- a/src/osmo-bsc/osmo_bsc_sigtran.c
+++ b/src/osmo-bsc/osmo_bsc_sigtran.c
@@ -356,8 +356,8 @@
 
ss7 = osmo_ss7_instance_find(msc->a.cs7_instance);
OSMO_ASSERT(ss7);
-   LOGP(DMSC, LOGL_DEBUG, "Sending connection (id=%i) oriented data to 
MSC: %si\n",
-conn_id, osmo_sccp_addr_name(ss7, >a.msc_addr));
+   LOGP(DMSC, LOGL_DEBUG, "Sending connection (id=%i) oriented data to 
MSC: %s (%s)\n",
+conn_id, osmo_sccp_addr_name(ss7, >a.msc_addr), 
osmo_hexdump(msg->data, msg->len));
 
rc = osmo_sccp_tx_data_msg(msc->a.sccp_user, conn_id, msg);
 

-- 
To view, visit https://gerrit.osmocom.org/4350
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibfe52a0b7dbca4c569c603a008d73d0d99d1c345
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 

[MERGED] openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: rename osmo-bsc to osmo-bsc-sccplite
..


rename osmo-bsc to osmo-bsc-sccplite

This is to avoid naming conflicts with the new osmo-bsc, which resides
in its own git repository (osmo-bsc.git) and which uses libosmo-sigtran
and implements (primarily) 3GPP AoIP.

Change-Id: If10d1599b62d010726336134091a4e855c380d93
---
M debian/changelog
M debian/control
A debian/osmocom-bsc-sccplite.examples
A debian/osmocom-bsc-sccplite.install
D debian/osmocom-bsc.examples
D debian/osmocom-bsc.install
M debian/rules
M openbsc/.gitignore
M openbsc/contrib/bsc-test/msc.sh
R openbsc/contrib/systemd/osmo-bsc-sccplite.service
R openbsc/doc/examples/osmo-bsc-sccplite/osmo-bsc-sccplite.cfg
M openbsc/osmoappdesc.py
M openbsc/src/osmo-bsc/Makefile.am
M openbsc/src/osmo-bsc/osmo_bsc_main.c
M openbsc/tests/ctrl_test_runner.py
M openbsc/tests/vty_test_runner.py
16 files changed, 33 insertions(+), 28 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/debian/changelog b/debian/changelog
index e9a4212..dd850be 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -4,6 +4,10 @@
   * Prevent SGSN starting with 'auth-policy remote' when no 'gsup remote-*' 
are configured.
 Note: such configs are broken without extra workarounds anyway.
 
+  [ Harald Welte ]
+  * Rename osmo-bsc to osmo-bsc-sccplite to avoid clashes with new 3GPP AoIP
+osmo-bsc.git code
+
  -- Holger Hans Peter Freyther   Tue, 24 May 2016 
23:14:31 +0200
 
 openbsc (0.14.0) unstable; urgency=low
diff --git a/debian/control b/debian/control
index 58e8966..e31d0c4 100644
--- a/debian/control
+++ b/debian/control
@@ -21,7 +21,7 @@
 Vcs-Browser: http://openbsc.osmocom.org/trac/browser
 Homepage: https://projects.osmocom.org/projects/openbsc
 
-Package: osmocom-bsc
+Package: osmocom-bsc-sccplite
 Architecture: any
 Depends: ${shlibs:Depends},
  ${misc:Depends}
@@ -40,7 +40,7 @@
 Description: GSM Network-in-a-Box, implements BSC, MSC, SMSC, HLR, VLR
  This is the Network-in-a-Box version of OpenBSC. It has all the GSM network
  components bundled together. When using osmocom-nitb, there is no need for a
- Mobile Switching Center (MSC) which is needed when using osmocom-bsc.
+ Mobile Switching Center (MSC) which is needed when using osmocom-bsc-sccplite.
 
 Package: osmocom-ipaccess-utils
 Architecture: any
@@ -64,13 +64,13 @@
 Architecture: any
 Depends: ${shlibs:Depends},
  ${misc:Depends}
-Recommends: osmocom-bsc
+Recommends: osmocom-bsc-sccplite
 Description: Osmocom Base Station Controller Network Address Translation
  This NAT is useful for masquerading multiple BSCs behind one. It listens
  for incoming BSCs on port 5000 and connects to a specified Mobile Switching
  Center (MSC).
  .
- This package is part of OpenBSC and closely related to osmocom-bsc.
+ This package is part of OpenBSC and closely related to osmocom-bsc-sccplite.
 
 Package: openbsc-dev
 Architecture: all
@@ -83,11 +83,11 @@
  The directory structure is copied after the structure in the repository
  and the header and .c file are installed into /usr/src/osmocom/openbsc/.
 
-Package: osmocom-bsc-dbg
+Package: osmocom-bsc-sccplite-dbg
 Architecture: any
 Section: debug
 Priority: extra
-Depends: osmocom-bsc (= ${binary:Version}), ${misc:Depends}
+Depends: osmocom-bsc-sccplite (= ${binary:Version}), ${misc:Depends}
 Description: Debug symbols for the OpenBSC BSC
  Make debugging possible
 
diff --git a/debian/osmocom-bsc-sccplite.examples 
b/debian/osmocom-bsc-sccplite.examples
new file mode 100644
index 000..545709b
--- /dev/null
+++ b/debian/osmocom-bsc-sccplite.examples
@@ -0,0 +1,2 @@
+openbsc/doc/examples/osmo-bsc_mgcp
+openbsc/doc/examples/osmo-bsc-sccplite
diff --git a/debian/osmocom-bsc-sccplite.install 
b/debian/osmocom-bsc-sccplite.install
new file mode 100644
index 000..9ce795c
--- /dev/null
+++ b/debian/osmocom-bsc-sccplite.install
@@ -0,0 +1,2 @@
+/usr/bin/osmo-bsc_mgcp
+/usr/bin/osmo-bsc-sccplite
diff --git a/debian/osmocom-bsc.examples b/debian/osmocom-bsc.examples
deleted file mode 100644
index a95f12b..000
--- a/debian/osmocom-bsc.examples
+++ /dev/null
@@ -1 +0,0 @@
-openbsc/doc/examples/osmo-bsc_mgcp
diff --git a/debian/osmocom-bsc.install b/debian/osmocom-bsc.install
deleted file mode 100644
index ab9459e..000
--- a/debian/osmocom-bsc.install
+++ /dev/null
@@ -1,2 +0,0 @@
-/usr/bin/osmo-bsc_mgcp
-/usr/bin/osmo-bsc
diff --git a/debian/rules b/debian/rules
index d1d74a5..05bbbef 100755
--- a/debian/rules
+++ b/debian/rules
@@ -17,7 +17,7 @@
cd openbsc && autoreconf --install --force
 
 override_dh_strip:
-   dh_strip -posmocom-bsc --dbg-package=osmocom-bsc-dbg
+   dh_strip -posmocom-bsc-sccplite --dbg-package=osmocom-bsc-sccplite-dbg
dh_strip -posmocom-nitb --dbg-package=osmocom-nitb-dbg

[MERGED] osmo-ci[master]: osmocom:nightly OBS: Add osmo-msc + osmo-mgw

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmocom:nightly OBS: Add osmo-msc + osmo-mgw
..


osmocom:nightly OBS: Add osmo-msc + osmo-mgw

Change-Id: Ie417f912f11f3a45c6efb39595d6a4d89cf3a058
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index 05abe60..12aa587 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -24,6 +24,8 @@
 git clone git://git.osmocom.org/osmo-bts
 git clone git://git.osmocom.org/osmo-pcu
 git clone git://git.osmocom.org/osmo-hlr
+git clone git://git.osmocom.org/osmo-mgw
+git clone git://git.osmocom.org/osmo-msc
 
 
 PROJ=network:osmocom:nightly
@@ -63,6 +65,8 @@
 build osmo-bts
 build osmo-pcu
 build osmo-hlr
+build osmo-mgw
+build osmo-msc
 
 cd $PROJ
 osc ci -m "Snapshot $DT"

-- 
To view, visit https://gerrit.osmocom.org/4433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie417f912f11f3a45c6efb39595d6a4d89cf3a058
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 

openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4421
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If10d1599b62d010726336134091a4e855c380d93
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-ci[master]: osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package

[Harald Welte]

Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/4432
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f0726ed412e4a281dcf99047ca22b494216b4ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[MERGED] osmo-ci[master]: osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package
..


osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package

this package doesn't exist in the OBS anyway, yet we continue to attempt
to upload it there. Stop that :)

Change-Id: I0f0726ed412e4a281dcf99047ca22b494216b4ad
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 0 insertions(+), 2 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index dd84b4f..05abe60 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -20,7 +20,6 @@
 git clone git://git.osmocom.org/osmo-ggsn
 git clone git://git.osmocom.org/openbsc
 git clone git://git.osmocom.org/osmo-pcap
-git clone git://git.osmocom.org/cellmgr-ng osmo-stp
 git clone git://git.osmocom.org/osmo-trx
 git clone git://git.osmocom.org/osmo-bts
 git clone git://git.osmocom.org/osmo-pcu
@@ -59,7 +58,6 @@
 build osmo-sgsn
 build openbsc
 build osmo-pcap
-build osmo-stp
 build osmo-trx
 build osmo-sip-connector
 build osmo-bts

-- 
To view, visit https://gerrit.osmocom.org/4432
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f0726ed412e4a281dcf99047ca22b494216b4ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 

osmo-ci[master]: osmocom:nightly OBS: Add osmo-msc + osmo-mgw

[Harald Welte]

Patch Set 1: Verified+1

-- 
To view, visit https://gerrit.osmocom.org/4433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie417f912f11f3a45c6efb39595d6a4d89cf3a058
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

osmo-ci[master]: osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4432
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f0726ed412e4a281dcf99047ca22b494216b4ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

osmo-ci[master]: osmocom:nightly OBS: Add osmo-msc + osmo-mgw

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie417f912f11f3a45c6efb39595d6a4d89cf3a058
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-HasComments: No

[PATCH] osmo-ci[master]: osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package

[Harald Welte]

Review at  https://gerrit.osmocom.org/4432

osmocom:nightly OBS: remove old osmo-stp/cellmgr-ng package

this package doesn't exist in the OBS anyway, yet we continue to attempt
to upload it there. Stop that :)

Change-Id: I0f0726ed412e4a281dcf99047ca22b494216b4ad
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 0 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/32/4432/1

diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index dd84b4f..05abe60 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -20,7 +20,6 @@
 git clone git://git.osmocom.org/osmo-ggsn
 git clone git://git.osmocom.org/openbsc
 git clone git://git.osmocom.org/osmo-pcap
-git clone git://git.osmocom.org/cellmgr-ng osmo-stp
 git clone git://git.osmocom.org/osmo-trx
 git clone git://git.osmocom.org/osmo-bts
 git clone git://git.osmocom.org/osmo-pcu
@@ -59,7 +58,6 @@
 build osmo-sgsn
 build openbsc
 build osmo-pcap
-build osmo-stp
 build osmo-trx
 build osmo-sip-connector
 build osmo-bts

-- 
To view, visit https://gerrit.osmocom.org/4432
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f0726ed412e4a281dcf99047ca22b494216b4ad
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

[PATCH] osmo-ci[master]: osmocom:nightly OBS: Add osmo-msc + osmo-mgw

[Harald Welte]

Review at  https://gerrit.osmocom.org/4433

osmocom:nightly OBS: Add osmo-msc + osmo-mgw

Change-Id: Ie417f912f11f3a45c6efb39595d6a4d89cf3a058
---
M scripts/osmocom-nightly-packages.sh
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/33/4433/1

diff --git a/scripts/osmocom-nightly-packages.sh 
b/scripts/osmocom-nightly-packages.sh
index 05abe60..12aa587 100755
--- a/scripts/osmocom-nightly-packages.sh
+++ b/scripts/osmocom-nightly-packages.sh
@@ -24,6 +24,8 @@
 git clone git://git.osmocom.org/osmo-bts
 git clone git://git.osmocom.org/osmo-pcu
 git clone git://git.osmocom.org/osmo-hlr
+git clone git://git.osmocom.org/osmo-mgw
+git clone git://git.osmocom.org/osmo-msc
 
 
 PROJ=network:osmocom:nightly
@@ -63,6 +65,8 @@
 build osmo-bts
 build osmo-pcu
 build osmo-hlr
+build osmo-mgw
+build osmo-msc
 
 cd $PROJ
 osc ci -m "Snapshot $DT"

-- 
To view, visit https://gerrit.osmocom.org/4433
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie417f912f11f3a45c6efb39595d6a4d89cf3a058
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  170s]To: 
[  170s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  170s] 
[  170s] You may investigate any problem if you feel able to do so, in which
[  170s] case the test suite provides a good starting point.  Its output may
[  170s] be found below `tests/testsuite.dir'.
[  170s] 
[  170s] Makefile:1221: recipe for target 'check-local' failed
[  170s] make[3]: *** [check-local] Error 1
[  170s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  170s] Makefile:1055: recipe for target 'check-am' failed
[  170s] make[2]: *** [check-am] Error 2
[  170s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  170s] Makefile:460: recipe for target 'check-recursive' failed
[  170s] make[1]: *** [check-recursive] Error 1
[  170s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  170s] dh_auto_test: make -j1 check returned exit code 2
[  170s] debian/rules:12: recipe for target 'build' failed
[  170s] make: *** [build] Error 2
[  170s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  170s] 
[  170s] build33 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:01 UTC 2017.
[  170s] 
[  170s] ### VM INTERACTION START ###
[  174s] [  163.739423] reboot: Power down
[  174s] ### VM INTERACTION END ###
[  174s] 
[  174s] build33 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:05 UTC 2017.
[  174s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  177s]To: 
[  177s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  177s] 
[  177s] You may investigate any problem if you feel able to do so, in which
[  177s] case the test suite provides a good starting point.  Its output may
[  177s] be found below `tests/testsuite.dir'.
[  177s] 
[  177s] Makefile:1221: recipe for target 'check-local' failed
[  177s] make[3]: *** [check-local] Error 1
[  177s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  177s] Makefile:1055: recipe for target 'check-am' failed
[  177s] make[2]: *** [check-am] Error 2
[  177s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  177s] Makefile:460: recipe for target 'check-recursive' failed
[  177s] make[1]: *** [check-recursive] Error 1
[  177s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  177s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  177s] debian/rules:12: recipe for target 'build' failed
[  177s] make: *** [build] Error 2
[  177s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  177s] 
[  177s] cloud127 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:07 UTC 2017.
[  177s] 
[  177s] ### VM INTERACTION START ###
[  181s] [  166.305744] reboot: Power down
[  182s] ### VM INTERACTION END ###
[  182s] 
[  182s] cloud127 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:12 UTC 2017.
[  182s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  156s]To: 
[  156s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  156s] 
[  156s] You may investigate any problem if you feel able to do so, in which
[  156s] case the test suite provides a good starting point.  Its output may
[  156s] be found below `tests/testsuite.dir'.
[  156s] 
[  156s] Makefile:1221: recipe for target 'check-local' failed
[  156s] make[3]: *** [check-local] Error 1
[  156s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  156s] Makefile:1055: recipe for target 'check-am' failed
[  156s] make[2]: *** [check-am] Error 2
[  156s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  156s] Makefile:460: recipe for target 'check-recursive' failed
[  156s] make[1]: *** [check-recursive] Error 1
[  156s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  156s] dh_auto_test: make -j1 check returned exit code 2
[  156s] debian/rules:12: recipe for target 'build' failed
[  156s] make: *** [build] Error 2
[  156s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  156s] 
[  156s] lamb26 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:05 UTC 2017.
[  156s] 
[  156s] ### VM INTERACTION START ###
[  159s] [  152.633589] reboot: Power down
[  159s] ### VM INTERACTION END ###
[  159s] 
[  159s] lamb26 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:08 UTC 2017.
[  159s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  156s]To: 
[  156s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  156s] 
[  156s] You may investigate any problem if you feel able to do so, in which
[  156s] case the test suite provides a good starting point.  Its output may
[  156s] be found below `tests/testsuite.dir'.
[  156s] 
[  156s] Makefile:1221: recipe for target 'check-local' failed
[  156s] make[3]: *** [check-local] Error 1
[  156s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  156s] Makefile:1055: recipe for target 'check-am' failed
[  156s] make[2]: *** [check-am] Error 2
[  156s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  156s] Makefile:460: recipe for target 'check-recursive' failed
[  156s] make[1]: *** [check-recursive] Error 1
[  156s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  156s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  156s] debian/rules:12: recipe for target 'build' failed
[  156s] make: *** [build] Error 2
[  156s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  156s] 
[  156s] lamb26 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:08 UTC 2017.
[  156s] 
[  156s] ### VM INTERACTION START ###
[  159s] [  151.330929] reboot: Power down
[  159s] ### VM INTERACTION END ###
[  159s] 
[  159s] lamb26 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:12 UTC 2017.
[  159s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  128s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  128s] 
[  128s] You may investigate any problem if you feel able to do so, in which
[  128s] case the test suite provides a good starting point.  Its output may
[  128s] be found below `tests/testsuite.dir'.
[  128s] 
[  128s] Makefile:1208: recipe for target 'check-local' failed
[  128s] make[3]: *** [check-local] Error 1
[  128s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  128s] Makefile:1044: recipe for target 'check-am' failed
[  128s] make[2]: *** [check-am] Error 2
[  128s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  128s] Makefile:448: recipe for target 'check-recursive' failed
[  128s] make[1]: *** [check-recursive] Error 1
[  128s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  128s] dh_auto_test: make -j1 check returned exit code 2
[  128s] debian/rules:12: recipe for target 'build' failed
[  128s] make: *** [build] Error 2
[  128s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  128s] 
[  128s] lamb11 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:25 UTC 2017.
[  128s] 
[  128s] ### VM INTERACTION START ###
[  129s] Powering off.
[  129s] [  121.814332] reboot: Power down
[  129s] ### VM INTERACTION END ###
[  129s] 
[  129s] lamb11 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:27 UTC 2017.
[  129s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  161s]To: 
[  161s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  161s] 
[  161s] You may investigate any problem if you feel able to do so, in which
[  161s] case the test suite provides a good starting point.  Its output may
[  161s] be found below `tests/testsuite.dir'.
[  161s] 
[  161s] Makefile:1221: recipe for target 'check-local' failed
[  161s] make[3]: *** [check-local] Error 1
[  161s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  161s] Makefile:1055: recipe for target 'check-am' failed
[  161s] make[2]: *** [check-am] Error 2
[  161s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  161s] Makefile:460: recipe for target 'check-recursive' failed
[  161s] make[1]: *** [check-recursive] Error 1
[  161s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  161s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  161s] debian/rules:12: recipe for target 'build' failed
[  161s] make: *** [build] Error 2
[  161s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  161s] 
[  161s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:56 UTC 2017.
[  161s] 
[  161s] ### VM INTERACTION START ###
[  165s] [  157.099732] reboot: Power down
[  165s] ### VM INTERACTION END ###
[  165s] 
[  165s] lamb59 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:51:00 UTC 2017.
[  165s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  148s]To: 
[  148s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  148s] 
[  148s] You may investigate any problem if you feel able to do so, in which
[  148s] case the test suite provides a good starting point.  Its output may
[  148s] be found below `tests/testsuite.dir'.
[  148s] 
[  148s] Makefile:1221: recipe for target 'check-local' failed
[  148s] make[3]: *** [check-local] Error 1
[  148s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  148s] Makefile:1055: recipe for target 'check-am' failed
[  148s] make[2]: *** [check-am] Error 2
[  148s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  148s] Makefile:460: recipe for target 'check-recursive' failed
[  148s] make[1]: *** [check-recursive] Error 1
[  148s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  148s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  148s] debian/rules:12: recipe for target 'build' failed
[  148s] make: *** [build] Error 2
[  148s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  148s] 
[  148s] lamb10 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:32 UTC 2017.
[  148s] 
[  148s] ### VM INTERACTION START ###
[  152s] [  143.592483] reboot: Power down
[  152s] ### VM INTERACTION END ###
[  152s] 
[  152s] lamb10 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:36 UTC 2017.
[  152s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  170s]To: 
[  170s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  170s] 
[  170s] You may investigate any problem if you feel able to do so, in which
[  170s] case the test suite provides a good starting point.  Its output may
[  170s] be found below `tests/testsuite.dir'.
[  170s] 
[  170s] Makefile:1221: recipe for target 'check-local' failed
[  170s] make[3]: *** [check-local] Error 1
[  170s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  170s] Makefile:1055: recipe for target 'check-am' failed
[  170s] make[2]: *** [check-am] Error 2
[  170s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  170s] Makefile:460: recipe for target 'check-recursive' failed
[  170s] make[1]: *** [check-recursive] Error 1
[  170s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  170s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  170s] debian/rules:12: recipe for target 'build' failed
[  170s] make: *** [build] Error 2
[  170s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  170s] 
[  170s] lamb25 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:49:36 UTC 2017.
[  170s] 
[  170s] ### VM INTERACTION START ###
[  173s] [  166.479973] reboot: Power down
[  173s] ### VM INTERACTION END ###
[  173s] 
[  173s] lamb25 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:49:39 UTC 2017.
[  173s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  125s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  125s] 
[  125s] You may investigate any problem if you feel able to do so, in which
[  125s] case the test suite provides a good starting point.  Its output may
[  125s] be found below `tests/testsuite.dir'.
[  125s] 
[  126s] Makefile:1208: recipe for target 'check-local' failed
[  126s] make[3]: *** [check-local] Error 1
[  126s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  126s] Makefile:1044: recipe for target 'check-am' failed
[  126s] make[2]: *** [check-am] Error 2
[  126s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  126s] Makefile:448: recipe for target 'check-recursive' failed
[  126s] make[1]: *** [check-recursive] Error 1
[  126s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  126s] dh_auto_test: make -j1 check returned exit code 2
[  126s] debian/rules:12: recipe for target 'build' failed
[  126s] make: *** [build] Error 2
[  126s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  126s] 
[  126s] lamb01 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:03 UTC 2017.
[  126s] 
[  126s] ### VM INTERACTION START ###
[  127s] Powering off.
[  127s] [  118.946927] reboot: Power down
[  127s] ### VM INTERACTION END ###
[  127s] 
[  127s] lamb01 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:50:05 UTC 2017.
[  127s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  144s]To: 
[  144s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  144s] 
[  144s] You may investigate any problem if you feel able to do so, in which
[  144s] case the test suite provides a good starting point.  Its output may
[  144s] be found below `tests/testsuite.dir'.
[  144s] 
[  144s] Makefile:1221: recipe for target 'check-local' failed
[  144s] make[3]: *** [check-local] Error 1
[  144s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  144s] Makefile:1055: recipe for target 'check-am' failed
[  144s] make[2]: *** [check-am] Error 2
[  144s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  144s] Makefile:460: recipe for target 'check-recursive' failed
[  144s] make[1]: *** [check-recursive] Error 1
[  144s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  144s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  144s] debian/rules:12: recipe for target 'build' failed
[  144s] make: *** [build] Error 2
[  144s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  144s] 
[  144s] lamb58 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:48:36 UTC 2017.
[  144s] 
[  144s] ### VM INTERACTION START ###
[  147s] [  139.629576] reboot: Power down
[  147s] ### VM INTERACTION END ###
[  147s] 
[  147s] lamb58 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
15:48:39 UTC 2017.
[  147s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_17.04/i586

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  252s] | 
[  252s] | This file was extended by libosmocore config.status 0.9.6.20171026, 
which was
[  252s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  252s] | 
[  252s] |   CONFIG_FILES= 
[  252s] |   CONFIG_HEADERS  = 
[  252s] |   CONFIG_LINKS= 
[  252s] |   CONFIG_COMMANDS = 
[  252s] |   $ ./config.status Doxyfile.core
[  252s] | 
[  252s] | on build31
[  252s] | 
[  252s] | config.status:1174: creating Doxyfile.core
[  252s] 
[  252s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  252s] make[1]: *** [override_dh_auto_test] Error 1
[  252s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  252s] debian/rules:15: recipe for target 'build' failed
[  252s] make: *** [build] Error 2
[  252s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  252s] 
[  252s] build31 failed "build libosmocore_0.9.6.20171026.dsc" at Thu Oct 26 
15:48:09 UTC 2017.
[  252s] 
[  252s] ### VM INTERACTION START ###
[  256s] [  245.833424] reboot: Power down
[  256s] ### VM INTERACTION END ###
[  256s] 
[  256s] build31 failed "build libosmocore_0.9.6.20171026.dsc" at Thu Oct 26 
15:48:14 UTC 2017.
[  256s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

libosmo-sccp[master]: sccp_scrc: fix Network Indicator in SIO composition

[Harald Welte]

Patch Set 1: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7bb4eb6518a1e0d74313bda776d2a6acd0b02e1b
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

[MERGED] libosmo-sccp[master]: sccp_scrc: fix Network Indicator in SIO composition

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: sccp_scrc: fix Network Indicator in SIO composition
..


sccp_scrc: fix Network Indicator in SIO composition

Since the NI is in bits DC, not BA, it needs to be shifted by 6, not 4, to end
up in the two most significant bits. Also, NI is two bits wide, hence & 0x3.
(The m3ua.c side of this is already correct.)

See ITU-T Recommendation Q.704 (07/96), 14.2 "Service information octet".

Before this patch, NI was always sent as 00 == International regardless of the
VTY configuration.

This patch was verified to work by a wireshark trace of osmo-bsc connecting to
osmo-msc, showing the NI decoded as configured by an osmo-bsc.cfg file in the
BSSMAP Reset message MTP 3 / Protocol data.

Change-Id: I7bb4eb6518a1e0d74313bda776d2a6acd0b02e1b
---
M include/osmocom/sigtran/mtp_sap.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/sigtran/mtp_sap.h 
b/include/osmocom/sigtran/mtp_sap.h
index 120ae91..0ae8592 100644
--- a/include/osmocom/sigtran/mtp_sap.h
+++ b/include/osmocom/sigtran/mtp_sap.h
@@ -31,7 +31,7 @@
OSMO_MTP_PRIM_STATUS,
 };
 
-#define MTP_SIO(service, net_ind)  (((net_ind & 0xF) << 4) | (service & 
0xF))
+#define MTP_SIO(service, net_ind)  (((net_ind & 0x3) << 6) | (service & 
0xF))
 
 struct osmo_mtp_transfer_param {
uint32_t opc;

-- 
To view, visit https://gerrit.osmocom.org/4431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7bb4eb6518a1e0d74313bda776d2a6acd0b02e1b
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder

[PATCH] libosmo-sccp[master]: sccp_scrc: fix Network Indicator in SIO composition

[Neels Hofmeyr]

Review at  https://gerrit.osmocom.org/4431

sccp_scrc: fix Network Indicator in SIO composition

Since the NI is in bits DC, not BA, it needs to be shifted by 6, not 4, to end
up in the two most significant bits. Also, NI is two bits wide, hence & 0x3.
(The m3ua.c side of this is already correct.)

See ITU-T Recommendation Q.704 (07/96), 14.2 "Service information octet".

Before this patch, NI was always sent as 00 == International regardless of the
VTY configuration.

This patch was verified to work by a wireshark trace of osmo-bsc connecting to
osmo-msc, showing the NI decoded as configured by an osmo-bsc.cfg file in the
BSSMAP Reset message MTP 3 / Protocol data.

Change-Id: I7bb4eb6518a1e0d74313bda776d2a6acd0b02e1b
---
M include/osmocom/sigtran/mtp_sap.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-sccp refs/changes/31/4431/1

diff --git a/include/osmocom/sigtran/mtp_sap.h 
b/include/osmocom/sigtran/mtp_sap.h
index 120ae91..0ae8592 100644
--- a/include/osmocom/sigtran/mtp_sap.h
+++ b/include/osmocom/sigtran/mtp_sap.h
@@ -31,7 +31,7 @@
OSMO_MTP_PRIM_STATUS,
 };
 
-#define MTP_SIO(service, net_ind)  (((net_ind & 0xF) << 4) | (service & 
0xF))
+#define MTP_SIO(service, net_ind)  (((net_ind & 0x3) << 6) | (service & 
0xF))
 
 struct osmo_mtp_transfer_param {
uint32_t opc;

-- 
To view, visit https://gerrit.osmocom.org/4431
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7bb4eb6518a1e0d74313bda776d2a6acd0b02e1b
Gerrit-PatchSet: 1
Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr 

[MERGED] osmo-sgsn[master]: Fix libosmo-sigtran dependency

[Max]

Max has submitted this change and it was merged.

Change subject: Fix libosmo-sigtran dependency
..


Fix libosmo-sigtran dependency

That's follow-up fix for I72819462db0b4656fabaa80731342d06ae91fcdf to
make sure IU builds are properly conditioned.

Change-Id: Idb034bf2ae749204836ab7e02018d769bb242a9f
---
M src/gprs/gtphub_main.c
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  dexter: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/gtphub_main.c b/src/gprs/gtphub_main.c
index c3e25d5..3f7de50 100644
--- a/src/gprs/gtphub_main.c
+++ b/src/gprs/gtphub_main.c
@@ -39,14 +39,16 @@
 #include 
 #include 
 
-#include 
-
 #include 
 #include 
 #include 
 
 #include "../../bscconfig.h"
 
+#if BUILD_IU
+#include 
+#endif
+
 extern void *osmo_gtphub_ctx;
 void *tall_bsc_ctx;
 

-- 
To view, visit https://gerrit.osmocom.org/4430
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb034bf2ae749204836ab7e02018d769bb242a9f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 

[MERGED] osmo-sgsn[master]: jenkins: check for IU properly

[Max]

Max has submitted this change and it was merged.

Change subject: jenkins: check for IU properly
..


jenkins: check for IU properly

The bug fixed by Idb034bf2ae749204836ab7e02018d769bb242a9f was not
detected by jenkins because it installs libosmo-sccp unconditionally.

Let's be more strict and install it only when necessary for IU builds to
make sure we can catch such bugs in future.

Change-Id: I573c7fec687edb71d79815b38a3bcf96273c03b3
---
M contrib/jenkins.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/contrib/jenkins.sh b/contrib/jenkins.sh
index dc1a1a5..140fc63 100755
--- a/contrib/jenkins.sh
+++ b/contrib/jenkins.sh
@@ -26,10 +26,10 @@
 
 osmo-build-dep.sh libosmo-abis
 osmo-build-dep.sh libosmo-netif
-osmo-build-dep.sh libosmo-sccp
 osmo-build-dep.sh osmo-ggsn
 
 if [ "x$IU" = "x--enable-iu" ]; then
+   osmo-build-dep.sh libosmo-sccp
osmo-build-dep.sh libasn1c
#osmo-build-dep.sh asn1c aper-prefix # only needed for make regen in 
osmo-iuh
osmo-build-dep.sh osmo-iuh

-- 
To view, visit https://gerrit.osmocom.org/4429
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I573c7fec687edb71d79815b38a3bcf96273c03b3
Gerrit-PatchSet: 4
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 

[MERGED] osmo-sgsn[master]: gbproxy: don't link unnecessary

[Max]

Max has submitted this change and it was merged.

Change subject: gbproxy: don't link unnecessary
..


gbproxy: don't link unnecessary

* remove sigtran include from common_vty.c because nothing uses it
* remove LIBOSMOSIGTRAN_LIBS from generic OSMO_LIBS
* remove LIBOSMOABIS_LIBS from generic OSMO_LIBS

Both LIBOSMOSIGTRAN and LIBOSMOABIS are linked explicitly when necessary
already anyway.

Change-Id: I015a9d858bc2a95f8c9a4aedd3e0a84eadcf84e1
---
M src/gprs/Makefile.am
M src/libcommon/common_vty.c
2 files changed, 0 insertions(+), 3 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/src/gprs/Makefile.am b/src/gprs/Makefile.am
index 654604b..764acba 100644
--- a/src/gprs/Makefile.am
+++ b/src/gprs/Makefile.am
@@ -28,13 +28,11 @@
 
 OSMO_LIBS = \
$(LIBOSMOCORE_LIBS) \
-   $(LIBOSMOABIS_LIBS) \
$(LIBOSMOGSM_LIBS) \
$(LIBOSMOVTY_LIBS) \
$(LIBOSMOCTRL_LIBS) \
$(LIBOSMOGB_LIBS) \
$(LIBGTP_LIBS) \
-   $(LIBOSMOSIGTRAN_LIBS) \
$(NULL)
 
 bin_PROGRAMS = \
diff --git a/src/libcommon/common_vty.c b/src/libcommon/common_vty.c
index ac3c7fc..e960550 100644
--- a/src/libcommon/common_vty.c
+++ b/src/libcommon/common_vty.c
@@ -33,7 +33,6 @@
 #include 
 #include 
 #include 
-#include 
 
 
 int bsc_vty_go_parent(struct vty *vty)

-- 
To view, visit https://gerrit.osmocom.org/4428
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I015a9d858bc2a95f8c9a4aedd3e0a84eadcf84e1
Gerrit-PatchSet: 2
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  170s]To: 
[  170s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  170s] 
[  170s] You may investigate any problem if you feel able to do so, in which
[  170s] case the test suite provides a good starting point.  Its output may
[  170s] be found below `tests/testsuite.dir'.
[  170s] 
[  170s] Makefile:1221: recipe for target 'check-local' failed
[  170s] make[3]: *** [check-local] Error 1
[  170s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  170s] Makefile:1055: recipe for target 'check-am' failed
[  170s] make[2]: *** [check-am] Error 2
[  170s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  170s] Makefile:460: recipe for target 'check-recursive' failed
[  170s] make[1]: *** [check-recursive] Error 1
[  170s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  170s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  170s] debian/rules:12: recipe for target 'build' failed
[  170s] make: *** [build] Error 2
[  170s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  170s] 
[  170s] lamb63 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:53 UTC 2017.
[  170s] 
[  170s] ### VM INTERACTION START ###
[  173s] [  166.084622] reboot: Power down
[  173s] ### VM INTERACTION END ###
[  173s] 
[  173s] lamb63 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:57 UTC 2017.
[  173s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_17.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_17.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_17.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  215s]To: 
[  215s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  215s] 
[  215s] You may investigate any problem if you feel able to do so, in which
[  215s] case the test suite provides a good starting point.  Its output may
[  215s] be found below `tests/testsuite.dir'.
[  215s] 
[  215s] Makefile:1221: recipe for target 'check-local' failed
[  215s] make[3]: *** [check-local] Error 1
[  215s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  215s] Makefile:1055: recipe for target 'check-am' failed
[  215s] make[2]: *** [check-am] Error 2
[  215s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  215s] Makefile:460: recipe for target 'check-recursive' failed
[  215s] make[1]: *** [check-recursive] Error 1
[  215s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  215s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  215s] debian/rules:12: recipe for target 'build' failed
[  215s] make: *** [build] Error 2
[  215s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  215s] 
[  215s] cloud128 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:52 UTC 2017.
[  215s] 
[  215s] ### VM INTERACTION START ###
[  218s] [  183.149936] reboot: Power down
[  219s] ### VM INTERACTION END ###
[  220s] 
[  220s] cloud128 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:58 UTC 2017.
[  220s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  187s]To: 
[  187s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  187s] 
[  187s] You may investigate any problem if you feel able to do so, in which
[  187s] case the test suite provides a good starting point.  Its output may
[  187s] be found below `tests/testsuite.dir'.
[  187s] 
[  187s] Makefile:1221: recipe for target 'check-local' failed
[  187s] make[3]: *** [check-local] Error 1
[  187s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  187s] Makefile:1055: recipe for target 'check-am' failed
[  187s] make[2]: *** [check-am] Error 2
[  187s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  187s] Makefile:460: recipe for target 'check-recursive' failed
[  187s] make[1]: *** [check-recursive] Error 1
[  187s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  187s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  187s] debian/rules:12: recipe for target 'build' failed
[  187s] make: *** [build] Error 2
[  187s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  187s] 
[  187s] lamb14 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:23 UTC 2017.
[  187s] 
[  187s] ### VM INTERACTION START ###
[  190s] [  173.975356] reboot: Power down
[  190s] ### VM INTERACTION END ###
[  190s] 
[  190s] lamb14 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:27 UTC 2017.
[  190s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  159s]To: 
[  159s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  159s] 
[  159s] You may investigate any problem if you feel able to do so, in which
[  159s] case the test suite provides a good starting point.  Its output may
[  159s] be found below `tests/testsuite.dir'.
[  159s] 
[  159s] Makefile:1221: recipe for target 'check-local' failed
[  159s] make[3]: *** [check-local] Error 1
[  159s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  159s] Makefile:1055: recipe for target 'check-am' failed
[  159s] make[2]: *** [check-am] Error 2
[  159s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  159s] Makefile:460: recipe for target 'check-recursive' failed
[  159s] make[1]: *** [check-recursive] Error 1
[  159s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  159s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  159s] debian/rules:12: recipe for target 'build' failed
[  159s] make: *** [build] Error 2
[  159s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  159s] 
[  159s] lamb23 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:08 UTC 2017.
[  159s] 
[  159s] ### VM INTERACTION START ###
[  162s] [  155.512276] reboot: Power down
[  162s] ### VM INTERACTION END ###
[  162s] 
[  162s] lamb23 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:12 UTC 2017.
[  162s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/i586

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  172s]To: 
[  172s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  172s] 
[  172s] You may investigate any problem if you feel able to do so, in which
[  172s] case the test suite provides a good starting point.  Its output may
[  172s] be found below `tests/testsuite.dir'.
[  172s] 
[  172s] Makefile:1221: recipe for target 'check-local' failed
[  172s] make[3]: *** [check-local] Error 1
[  172s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  172s] Makefile:1055: recipe for target 'check-am' failed
[  172s] make[2]: *** [check-am] Error 2
[  172s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  172s] Makefile:460: recipe for target 'check-recursive' failed
[  172s] make[1]: *** [check-recursive] Error 1
[  172s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  172s] dh_auto_test: make -j1 check returned exit code 2
[  172s] debian/rules:12: recipe for target 'build' failed
[  172s] make: *** [build] Error 2
[  172s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  172s] 
[  172s] cloud107 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:50:19 UTC 2017.
[  172s] 
[  172s] ### VM INTERACTION START ###
[  175s] [  159.335234] reboot: Power down
[  176s] ### VM INTERACTION END ###
[  176s] 
[  176s] cloud107 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:50:23 UTC 2017.
[  176s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_9.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_9.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_9.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  194s]To: 
[  194s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  194s] 
[  194s] You may investigate any problem if you feel able to do so, in which
[  194s] case the test suite provides a good starting point.  Its output may
[  194s] be found below `tests/testsuite.dir'.
[  194s] 
[  194s] Makefile:1221: recipe for target 'check-local' failed
[  194s] make[3]: *** [check-local] Error 1
[  194s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  194s] Makefile:1055: recipe for target 'check-am' failed
[  194s] make[2]: *** [check-am] Error 2
[  194s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  194s] Makefile:460: recipe for target 'check-recursive' failed
[  194s] make[1]: *** [check-recursive] Error 1
[  194s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  194s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  194s] debian/rules:12: recipe for target 'build' failed
[  194s] make: *** [build] Error 2
[  194s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  194s] 
[  194s] lamb53 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:57 UTC 2017.
[  194s] 
[  194s] ### VM INTERACTION START ###
[  197s] [  189.414565] reboot: Power down
[  197s] ### VM INTERACTION END ###
[  197s] 
[  197s] lamb53 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:49:01 UTC 2017.
[  197s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.04/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.04/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.04/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  145s]To: 
[  145s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  145s] 
[  145s] You may investigate any problem if you feel able to do so, in which
[  145s] case the test suite provides a good starting point.  Its output may
[  145s] be found below `tests/testsuite.dir'.
[  145s] 
[  145s] Makefile:1221: recipe for target 'check-local' failed
[  145s] make[3]: *** [check-local] Error 1
[  145s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  145s] Makefile:1055: recipe for target 'check-am' failed
[  145s] make[2]: *** [check-am] Error 2
[  145s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  145s] Makefile:460: recipe for target 'check-recursive' failed
[  145s] make[1]: *** [check-recursive] Error 1
[  145s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  145s] dh_auto_test: make -j1 check returned exit code 2
[  145s] debian/rules:12: recipe for target 'build' failed
[  145s] make: *** [build] Error 2
[  145s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  145s] 
[  145s] lamb19 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:22 UTC 2017.
[  145s] 
[  145s] ### VM INTERACTION START ###
[  148s] [  141.178013] reboot: Power down
[  148s] ### VM INTERACTION END ###
[  148s] 
[  148s] lamb19 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:26 UTC 2017.
[  148s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/i586

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/i586

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/i586

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  127s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  127s] 
[  127s] You may investigate any problem if you feel able to do so, in which
[  127s] case the test suite provides a good starting point.  Its output may
[  127s] be found below `tests/testsuite.dir'.
[  127s] 
[  127s] Makefile:1208: recipe for target 'check-local' failed
[  127s] make[3]: *** [check-local] Error 1
[  127s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  127s] Makefile:1044: recipe for target 'check-am' failed
[  127s] make[2]: *** [check-am] Error 2
[  127s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  127s] Makefile:448: recipe for target 'check-recursive' failed
[  127s] make[1]: *** [check-recursive] Error 1
[  127s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  127s] dh_auto_test: make -j1 check returned exit code 2
[  127s] debian/rules:12: recipe for target 'build' failed
[  127s] make: *** [build] Error 2
[  127s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  127s] 
[  127s] lamb06 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:12 UTC 2017.
[  127s] 
[  127s] ### VM INTERACTION START ###
[  129s] Powering off.
[  129s] [  121.528518] reboot: Power down
[  129s] ### VM INTERACTION END ###
[  129s] 
[  129s] lamb06 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:14 UTC 2017.
[  129s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  143s]To: 
[  143s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  143s] 
[  143s] You may investigate any problem if you feel able to do so, in which
[  143s] case the test suite provides a good starting point.  Its output may
[  143s] be found below `tests/testsuite.dir'.
[  143s] 
[  143s] Makefile:1221: recipe for target 'check-local' failed
[  143s] make[3]: *** [check-local] Error 1
[  143s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  143s] Makefile:1055: recipe for target 'check-am' failed
[  143s] make[2]: *** [check-am] Error 2
[  143s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  143s] Makefile:460: recipe for target 'check-recursive' failed
[  143s] make[1]: *** [check-recursive] Error 1
[  143s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  143s] dh_auto_test: make -j1 check VERBOSE=1 returned exit code 2
[  143s] debian/rules:12: recipe for target 'build' failed
[  143s] make: *** [build] Error 2
[  143s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  143s] 
[  143s] wildcard2 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:20 UTC 2017.
[  143s] 
[  143s] ### VM INTERACTION START ###
[  146s] [  133.121233] reboot: Power down
[  147s] ### VM INTERACTION END ###
[  147s] 
[  147s] wildcard2 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:48:25 UTC 2017.
[  147s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/osmo-pcu in Debian_8.0/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/osmo-pcu/Debian_8.0/x86_64

Package network:osmocom:nightly/osmo-pcu failed to build in Debian_8.0/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly osmo-pcu

Last lines of build log:
[  122s]Subject: [osmo-pcu 0.3.0.20171026] testsuite: 2 3 5 6 7 8 11 failed
[  122s] 
[  122s] You may investigate any problem if you feel able to do so, in which
[  122s] case the test suite provides a good starting point.  Its output may
[  122s] be found below `tests/testsuite.dir'.
[  122s] 
[  122s] Makefile:1208: recipe for target 'check-local' failed
[  122s] make[3]: *** [check-local] Error 1
[  122s] make[3]: Leaving directory '/usr/src/packages/BUILD/tests'
[  122s] Makefile:1044: recipe for target 'check-am' failed
[  122s] make[2]: *** [check-am] Error 2
[  122s] make[2]: Leaving directory '/usr/src/packages/BUILD/tests'
[  122s] Makefile:448: recipe for target 'check-recursive' failed
[  122s] make[1]: *** [check-recursive] Error 1
[  122s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  122s] dh_auto_test: make -j1 check returned exit code 2
[  122s] debian/rules:12: recipe for target 'build' failed
[  122s] make: *** [build] Error 2
[  122s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  122s] 
[  122s] lamb03 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:47:10 UTC 2017.
[  122s] 
[  122s] ### VM INTERACTION START ###
[  123s] Powering off.
[  123s] [  116.894944] reboot: Power down
[  123s] ### VM INTERACTION END ###
[  123s] 
[  123s] lamb03 failed "build osmo-pcu_0.3.0.20171026.dsc" at Thu Oct 26 
14:47:11 UTC 2017.
[  123s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

Build failure of network:osmocom:nightly/libosmocore in xUbuntu_16.10/x86_64

[OBS Notification]

Visit 
https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/libosmocore/xUbuntu_16.10/x86_64

Package network:osmocom:nightly/libosmocore failed to build in 
xUbuntu_16.10/x86_64

Check out the package for editing:
  osc checkout network:osmocom:nightly libosmocore

Last lines of build log:
[  226s] | 
[  226s] | This file was extended by libosmocore config.status 0.9.6.20171026, 
which was
[  226s] | generated by GNU Autoconf 2.69.  Invocation command line was
[  226s] | 
[  226s] |   CONFIG_FILES= 
[  226s] |   CONFIG_HEADERS  = 
[  226s] |   CONFIG_LINKS= 
[  226s] |   CONFIG_COMMANDS = 
[  226s] |   $ ./config.status Doxyfile.core
[  226s] | 
[  226s] | on build36
[  226s] | 
[  226s] | config.status:1174: creating Doxyfile.core
[  226s] 
[  226s] debian/rules:26: recipe for target 'override_dh_auto_test' failed
[  226s] make[1]: *** [override_dh_auto_test] Error 1
[  226s] make[1]: Leaving directory '/usr/src/packages/BUILD'
[  226s] debian/rules:15: recipe for target 'build' failed
[  226s] make: *** [build] Error 2
[  226s] dpkg-buildpackage: error: debian/rules build gave error exit status 2
[  226s] 
[  226s] build36 failed "build libosmocore_0.9.6.20171026.dsc" at Thu Oct 26 
14:45:25 UTC 2017.
[  226s] 
[  226s] ### VM INTERACTION START ###
[  229s] [  218.870133] reboot: Power down
[  229s] ### VM INTERACTION END ###
[  229s] 
[  229s] build36 failed "build libosmocore_0.9.6.20171026.dsc" at Thu Oct 26 
14:45:29 UTC 2017.
[  229s] 

-- 
Configure notifications at https://build.opensuse.org/user/notifications
openSUSE Build Service (https://build.opensuse.org/)

[MERGED] openbsc[master]: remove sgsn, gbproxy and gtphub from openbsc.git

[Harald Welte]

Harald Welte has submitted this change and it was merged.

Change subject: remove sgsn, gbproxy and gtphub from openbsc.git
..


remove sgsn, gbproxy and gtphub from openbsc.git

The GPRS related programs osmo-sgsn, osmo-gtphub and osmo-gbproxy
have been split off into the separate osmo-sgsn repository, which
can be found at
git://git.osmocom.org/osmo-sgsn.git
http://git.osmocom.org/osmo-sgsn/

This is technically unrelated but conceptually part of the larger
NITB-split activities.

I did a brief log of all changes in src/gprs and couldn't find any
commits that we might have applied here but which are missing from
osmo-sgsn.git.

Change-Id: If60e28b23f5cfb2c4eb354951363a2bb63f3e0de
---
M debian/control
D debian/osmo-gtphub.default
D debian/osmo-gtphub.examples
D debian/osmo-gtphub.init
D debian/osmo-gtphub.install
D debian/osmocom-gbproxy.init
D debian/osmocom-gbproxy.install
D debian/osmocom-sgsn.default
D debian/osmocom-sgsn.examples
D debian/osmocom-sgsn.init
D debian/osmocom-sgsn.install
M debian/rules
M openbsc/.gitignore
M openbsc/configure.ac
D openbsc/contrib/gprs/gb-proxy-unblock-bug.py
D openbsc/contrib/gprs/gprs-bssgp-histogram.lua
D openbsc/contrib/gprs/gprs-buffer-count.lua
D openbsc/contrib/gprs/gprs-split-trace-by-tlli.lua
D openbsc/contrib/gprs/gprs-verify-nu.lua
D openbsc/contrib/systemd/osmo-gbproxy.service
D openbsc/contrib/systemd/osmo-sgsn.service
D openbsc/doc/examples/osmo-gbproxy/osmo-gbproxy-legacy.cfg
D openbsc/doc/examples/osmo-gbproxy/osmo-gbproxy.cfg
D openbsc/doc/examples/osmo-gtphub/gtphub-example.txt
D openbsc/doc/examples/osmo-gtphub/osmo-gtphub-1iface.cfg
D openbsc/doc/examples/osmo-gtphub/osmo-gtphub.cfg
D openbsc/doc/examples/osmo-sgsn/osmo-sgsn.cfg
M openbsc/include/openbsc/Makefile.am
D openbsc/include/openbsc/crc24.h
D openbsc/include/openbsc/gb_proxy.h
D openbsc/include/openbsc/gprs_gb_parse.h
D openbsc/include/openbsc/gprs_gmm.h
D openbsc/include/openbsc/gprs_llc.h
D openbsc/include/openbsc/gprs_llc_xid.h
D openbsc/include/openbsc/gprs_sgsn.h
D openbsc/include/openbsc/gprs_sndcp.h
D openbsc/include/openbsc/gprs_sndcp_comp.h
D openbsc/include/openbsc/gprs_sndcp_dcomp.h
D openbsc/include/openbsc/gprs_sndcp_pcomp.h
D openbsc/include/openbsc/gprs_sndcp_xid.h
D openbsc/include/openbsc/gprs_subscriber.h
D openbsc/include/openbsc/gprs_utils.h
M openbsc/include/openbsc/gsm_subscriber.h
D openbsc/include/openbsc/gtphub.h
D openbsc/include/openbsc/sgsn.h
M openbsc/include/openbsc/signal.h
D openbsc/include/openbsc/slhc.h
D openbsc/include/openbsc/v42bis.h
D openbsc/include/openbsc/v42bis_private.h
M openbsc/osmoappdesc.py
M openbsc/src/Makefile.am
D openbsc/src/gprs/.gitignore
D openbsc/src/gprs/Makefile.am
D openbsc/src/gprs/crc24.c
D openbsc/src/gprs/gb_proxy.c
D openbsc/src/gprs/gb_proxy_main.c
D openbsc/src/gprs/gb_proxy_patch.c
D openbsc/src/gprs/gb_proxy_peer.c
D openbsc/src/gprs/gb_proxy_tlli.c
D openbsc/src/gprs/gb_proxy_vty.c
D openbsc/src/gprs/gprs_gb_parse.c
D openbsc/src/gprs/gprs_gmm.c
D openbsc/src/gprs/gprs_llc.c
D openbsc/src/gprs/gprs_llc_parse.c
D openbsc/src/gprs/gprs_llc_vty.c
D openbsc/src/gprs/gprs_llc_xid.c
D openbsc/src/gprs/gprs_sgsn.c
D openbsc/src/gprs/gprs_sndcp.c
D openbsc/src/gprs/gprs_sndcp_comp.c
D openbsc/src/gprs/gprs_sndcp_dcomp.c
D openbsc/src/gprs/gprs_sndcp_pcomp.c
D openbsc/src/gprs/gprs_sndcp_vty.c
D openbsc/src/gprs/gprs_sndcp_xid.c
D openbsc/src/gprs/gprs_subscriber.c
D openbsc/src/gprs/gprs_utils.c
D openbsc/src/gprs/gtphub.c
D openbsc/src/gprs/gtphub_ares.c
D openbsc/src/gprs/gtphub_main.c
D openbsc/src/gprs/gtphub_sock.c
D openbsc/src/gprs/gtphub_vty.c
D openbsc/src/gprs/osmo_sgsn.cfg
D openbsc/src/gprs/sgsn_ares.c
D openbsc/src/gprs/sgsn_auth.c
D openbsc/src/gprs/sgsn_cdr.c
D openbsc/src/gprs/sgsn_ctrl.c
D openbsc/src/gprs/sgsn_libgtp.c
D openbsc/src/gprs/sgsn_main.c
D openbsc/src/gprs/sgsn_vty.c
D openbsc/src/gprs/slhc.c
D openbsc/src/gprs/v42bis.c
M openbsc/tests/Makefile.am
M openbsc/tests/atlocal.in
M openbsc/tests/ctrl_test_runner.py
D openbsc/tests/gbproxy/Makefile.am
D openbsc/tests/gbproxy/gbproxy_test.c
D openbsc/tests/gbproxy/gbproxy_test.ok
D openbsc/tests/gprs/Makefile.am
D openbsc/tests/gprs/gprs_test.c
D openbsc/tests/gprs/gprs_test.ok
D openbsc/tests/gtphub/Makefile.am
D openbsc/tests/gtphub/gtphub_test.c
D openbsc/tests/gtphub/gtphub_test.ok
M openbsc/tests/nanobts_omlattr/nanobts_omlattr_test.c
D openbsc/tests/oap/Makefile.am
D openbsc/tests/oap/oap_client_test.c
D openbsc/tests/oap/oap_client_test.err
D openbsc/tests/oap/oap_client_test.ok
D openbsc/tests/sgsn/Makefile.am
D openbsc/tests/sgsn/sgsn_test.c
D openbsc/tests/sgsn/sgsn_test.ok
D openbsc/tests/slhc/Makefile.am
D openbsc/tests/slhc/slhc_test.c
D openbsc/tests/slhc/slhc_test.ok
D openbsc/tests/sndcp_xid/Makefile.am
D openbsc/tests/sndcp_xid/sndcp_xid_test.c
D openbsc/tests/sndcp_xid/sndcp_xid_test.ok
M openbsc/tests/testsuite.at
D openbsc/tests/v42bis/Makefile.am
D 

osmo-bsc[master]: log: output hexdump of transmitted sccp messages

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4350
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibfe52a0b7dbca4c569c603a008d73d0d99d1c345
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max 
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

openbsc[master]: rename osmo-bsc to osmo-bsc-sccplite

[Harald Welte]

Patch Set 3:

> in the issue OS#2526, you suggested to include 'legacy' in the name

That was just an idea. I think it's specific enough as-is.

-- 
To view, visit https://gerrit.osmocom.org/4421
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If10d1599b62d010726336134091a4e855c380d93
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-HasComments: No

osmo-bsc[master]: log: log the sccp message type of messages sent

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4351
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6736f15ddc03e5f70c3504abffbae6cbf766c9d7
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: dexter 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: No

openbsc[master]: remove sgsn, gbproxy and gtphub from openbsc.git

[dexter]

Patch Set 3: Code-Review+1

> Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4417
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If60e28b23f5cfb2c4eb354951363a2bb63f3e0de
Gerrit-PatchSet: 3
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter 
Gerrit-HasComments: No

[PATCH] osmo-bsc[master]: mgcp: use osmo-mgw to switch RTP streams

[dexter]

Hello Neels Hofmeyr, Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

https://gerrit.osmocom.org/4334

to look at the new patch set (#6).

mgcp: use osmo-mgw to switch RTP streams

osmo-bsc currently negotiates the RTP stream directly with the
BTS and reports back the RTP IP/Port on the BTS. This works fine
for a single BTS, but for Handover the port/ip pointing to the
MSC side must not change, so an entity in between the BTSs and
the MSC is required.

Integrate the mgcp-client and use osmo-mgw to switch the RTP
streams.

TODO: Handover will not work yet, because there is no
functionality to update the connection with the port/ip of
the new BTS.

Change-Id: Ia2882b7ca31a3219c676986e85045fa08a425d7a
---
M configure.ac
M include/osmocom/bsc/Makefile.am
M include/osmocom/bsc/gsm_data.h
M include/osmocom/bsc/osmo_bsc.h
A include/osmocom/bsc/osmo_bsc_mgcp.h
M src/Makefile.am
M src/osmo-bsc/Makefile.am
M src/osmo-bsc/osmo_bsc_audio.c
M src/osmo-bsc/osmo_bsc_bssap.c
M src/osmo-bsc/osmo_bsc_main.c
A src/osmo-bsc/osmo_bsc_mgcp.c
M src/osmo-bsc/osmo_bsc_sigtran.c
M src/osmo-bsc/osmo_bsc_vty.c
13 files changed, 1,030 insertions(+), 65 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/34/4334/6

diff --git a/configure.ac b/configure.ac
index 4edbb83..f73f33c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -47,8 +47,9 @@
 PKG_CHECK_MODULES(LIBOSMONETIF, libosmo-netif >= 0.0.1)
 PKG_CHECK_MODULES(LIBOSMOSIGTRAN, libosmo-sigtran) # TODO version?
 PKG_CHECK_MODULES(LIBCRYPTO, libcrypto >= 0.9.5)
-PKG_CHECK_MODULES(LIBOSMOLEGACYMGCP, libosmo-legacy-mgcp >= 0.0.1)
 PKG_CHECK_MODULES(LIBOSMOSCCP, libosmo-sccp >= 0.0.2)
+PKG_CHECK_MODULES(LIBOSMOMGCPCLIENT, libosmo-mgcp-client >= 1.0.0)
+PKG_CHECK_MODULES(LIBOSMOLEGACYMGCP, libosmo-legacy-mgcp >= 1.0.0)
 
 dnl checks for header files
 AC_HEADER_STDC
@@ -135,7 +136,6 @@
 src/libfilter/Makefile
 src/libcommon-cs/Makefile
 src/osmo-bsc/Makefile
-src/osmo-bsc_nat/Makefile
 src/ipaccess/Makefile
 src/utils/Makefile
 tests/Makefile
diff --git a/include/osmocom/bsc/Makefile.am b/include/osmocom/bsc/Makefile.am
index 8ad2b5d..1f7cd39 100644
--- a/include/osmocom/bsc/Makefile.am
+++ b/include/osmocom/bsc/Makefile.am
@@ -41,6 +41,7 @@
openbscdefines.h \
osmo_bsc.h \
osmo_bsc_grace.h \
+   osmo_bsc_mgcp.h \
osmo_bsc_rf.h \
osmo_bsc_sigtran.h \
bsc_msc_data.h \
diff --git a/include/osmocom/bsc/gsm_data.h b/include/osmocom/bsc/gsm_data.h
index 51b2c98..5cb7efd 100644
--- a/include/osmocom/bsc/gsm_data.h
+++ b/include/osmocom/bsc/gsm_data.h
@@ -479,6 +479,11 @@
uint8_t t3212;
 
struct {
+   struct mgcp_client_conf *conf;
+   struct mgcp_client *client;
+   } mgw;
+
+   struct {
/* CS7 instance id number (set via VTY) */
uint32_t cs7_instance;
/* A list with the context information about
diff --git a/include/osmocom/bsc/osmo_bsc.h b/include/osmocom/bsc/osmo_bsc.h
index 5ebea50..8a5cd30 100644
--- a/include/osmocom/bsc/osmo_bsc.h
+++ b/include/osmocom/bsc/osmo_bsc.h
@@ -29,6 +29,20 @@
uint32_t rtp_ip;
int rtp_port;
 
+   /* RTP address of the remote end (assigned by MSC through assignment
+* request) */
+   struct sockaddr_storage aoip_rtp_addr_remote;
+
+   /* Local RTP address (reported back to the MSC by us with the
+* assignment complete message) */
+   struct sockaddr_storage aoip_rtp_addr_local;
+
+   /* storage to keep states of the MGCP connection handler, the
+* handler is created when an assignment request is received
+* and is terminated when the assignment complete message is
+* sent */
+   struct mgcp_ctx *mgcp_ctx;
+
/* for advanced ping/pong */
int send_ping;
 
@@ -72,4 +86,6 @@
 
 struct llist_head *bsc_access_lists(void);
 
+int bssmap_send_aoip_ass_compl(struct gsm_lchan *lchan);
+
 #endif
diff --git a/include/osmocom/bsc/osmo_bsc_mgcp.h 
b/include/osmocom/bsc/osmo_bsc_mgcp.h
new file mode 100644
index 000..7246dda
--- /dev/null
+++ b/include/osmocom/bsc/osmo_bsc_mgcp.h
@@ -0,0 +1,45 @@
+/* (C) 2017 by Sysmocom s.f.m.c. GmbH
+ * All Rights Reserved
+ *
+ * Author: Philipp Maier
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as published by
+ * the Free Software Foundation; either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program.  If not, see 

osmo-sgsn[master]: jenkins: check for IU properly

[Harald Welte]

Patch Set 4: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4429
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I573c7fec687edb71d79815b38a3bcf96273c03b3
Gerrit-PatchSet: 4
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-HasComments: No

osmo-sgsn[master]: Fix libosmo-sigtran dependency

[Harald Welte]

Patch Set 3: Code-Review+2

-- 
To view, visit https://gerrit.osmocom.org/4430
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb034bf2ae749204836ab7e02018d769bb242a9f
Gerrit-PatchSet: 3
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Gerrit-Owner: Max 
Gerrit-Reviewer: Harald Welte 
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr 
Gerrit-Reviewer: dexter 
Gerrit-HasComments: No