[PATCH] osmo-ci[master]: jobs: rename normal-builds.yml to master-builds.yml

2017-12-02 Thread Neels Hofmeyr
jobs: rename normal-builds.yml to master-builds.yml Also apply the rename in the job names Change-Id: If623e573e49d4f1a409139c112afbc34e4cc450e --- R jobs/master-builds.yml 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci refs/changes/40/5140/2

[PATCH] osmo-ci[master]: jobs: master-builds: libosmo-sigtran should trigger bsc and iuh

2017-12-02 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5144 jobs: master-builds: libosmo-sigtran should trigger bsc and iuh osmo-iuh in turn triggers osmo-msc and osmo-sgsn, no explicit triggers needed here. Change-Id: Ifd950660cdc3417e82b0a8f4ce2b1efde880cb7a --- M jobs/master-builds.yml 1 file changed, 2

[PATCH] osmo-ci[master]: jobs: master-branches: trigger sgsn from iuh

2017-12-02 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5143 jobs: master-branches: trigger sgsn from iuh osmo-sgsn uses libosmo-ranap and hence should be triggered from osmo-iuh. This naturally "includes" a trigger for libosmo-sigtran. Change-Id: Ia356dc2a8d5120f9d6262bf8eb25c32fe71e76c9 --- M

[PATCH] osmo-ci[master]: jobs: master-builds: osmo-bsc is now also a downstream of os...

2017-12-02 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5142 jobs: master-builds: osmo-bsc is now also a downstream of osmo-mgw Change-Id: I03c63108bd845ee723d565c34e930bb68bef --- M jobs/master-builds.yml 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

osmo-ci[master]: jobs: rename normal-builds.yml to master-builds.yml

2017-12-02 Thread Neels Hofmeyr
Patch Set 1: Verified+1 not verified yet, but it doesn't matter either -- To view, visit https://gerrit.osmocom.org/5140 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If623e573e49d4f1a409139c112afbc34e4cc450e Gerrit-PatchSet: 1

osmo-ci[master]: jobs: master-builds: apply various initial fixes

2017-12-02 Thread Neels Hofmeyr
Patch Set 1: Verified+1 not verified yet, but it doesn't matter either -- To view, visit https://gerrit.osmocom.org/5141 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2ad9c90a0986d1304cd53383d3df5b375f23ac8 Gerrit-PatchSet: 1

osmo-ci[master]: Describe our normal (non-gerrit) build jobs in jenkins-job-b...

2017-12-02 Thread Neels Hofmeyr
Patch Set 3: Verified+1 not verified yet, but it doesn't matter either -- To view, visit https://gerrit.osmocom.org/4827 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib04707393264a845876659d7bee0cdc9f8b897b6 Gerrit-PatchSet: 3

[PATCH] osmo-ci[master]: jobs: rename normal-builds.yml to master-builds.yml

2017-12-02 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5140 jobs: rename normal-builds.yml to master-builds.yml Change-Id: If623e573e49d4f1a409139c112afbc34e4cc450e --- R jobs/master-builds.yml 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-ci

[PATCH] osmo-ci[master]: jobs: master-builds: apply various initial fixes

2017-12-02 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5141 jobs: master-builds: apply various initial fixes libosmo-sccp, osmo-ggsn: The osmo-gsm-tester builds are downstream builds, yes, but we configured that with the osmo-gsm-tester builds: instead of telling libosmo-sccp to build

osmo-msc[master]: Remove utils imported from openbsc, fix building remaining u...

2017-12-02 Thread Pau Espin Pedrol
Patch Set 1: Related task: https://osmocom.org/issues/2522 -- To view, visit https://gerrit.osmocom.org/5139 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359 Gerrit-PatchSet: 1 Gerrit-Project:

osmo-ci[master]: Describe our normal (non-gerrit) build jobs in jenkins-job-b...

2017-12-02 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 (6 comments) Looks good except for these ideas, but don't bother to edit, I have the tweaks ready in an additional patch. Let's then just merge and fix the jobs in subsequent commits? https://gerrit.osmocom.org/#/c/4827/2/jobs/normal-builds.yml File

osmo-ci[master]: Use stow for dependency management

2017-12-02 Thread Alexander Huemer
Patch Set 3: > stow is now installed on all build slaves, wiki also lists stow > now. Is there anything I can do to move forward with change? -- To view, visit https://gerrit.osmocom.org/2691 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

[PATCH] osmo-msc[master]: Add missing CFLAGS

2017-12-02 Thread Alexander Huemer
Review at https://gerrit.osmocom.org/5138 Add missing CFLAGS Change-Id: I67b5d797a80b55e01dcdbb8c782748b049cf9199 --- M src/libcommon-cs/Makefile.am M src/libcommon/Makefile.am M src/libmsc/Makefile.am M src/libvlr/Makefile.am M src/utils/Makefile.am 5 files changed, 18 insertions(+), 2

[PATCH] osmo-msc[master]: Remove utils imported from openbsc, fix building remaining u...

2017-12-02 Thread Alexander Huemer
Review at https://gerrit.osmocom.org/5139 Remove utils imported from openbsc, fix building remaining util smpp_mirror Change-Id: If7e1af11cdac8587bb4d66fb4eacee4b79945359 --- M configure.ac M src/utils/Makefile.am D src/utils/meas_db.c D src/utils/meas_db.h D src/utils/meas_json.c D

osmo-pcu[master]: TBF: fix compiler warning in test

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+1 I'm surprised the old code actually worked if it needs bit-or instead of logical-or. -- To view, visit https://gerrit.osmocom.org/5119 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-pcu[master]: Fix compiler warning

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5118 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic34c72c8bff6d7c775f56bb6026fec5425f7dcb4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master

osmo-pcu[master]: TBF: log timer override

2017-12-02 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5109 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I462464a1e6df937b72cad65d19cd48e95dc4db45 Gerrit-PatchSet: 2 Gerrit-Project: osmo-pcu Gerrit-Branch: master

libosmocore[master]: embedded: fix tests

2017-12-02 Thread Harald Welte
Patch Set 1: what I'm wondering is: Why are we not catching this on jenkinks? Aren't we building an embedded libosmocore as part of build testing? -- To view, visit https://gerrit.osmocom.org/5123 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment

libosmocore[master]: Fix embedded build

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5122 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie92d2eea21e19e499b3f3bb4d5a82e31fbbea3f0 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libosmocore[master]: embedded: fix tests

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5123 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icedad5ba3ed311ccdb97fa3ccd3002f5fda8be68 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

osmo-mgw[master]: MGCP endpoints: parse as decimal, not hex

2017-12-02 Thread Harald Welte
Patch Set 2: endpoints are *strings*. We should not treat them as numbers. So whatever this patch (or related patches do), it is only a very small incremental (and insignificant) step towards endpoints as names, which is what the MGCP spec has always stated. Sure, the endpoints within one

[MERGED] osmo-bts[master]: measurement.c: Fix various typos in comments

2017-12-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: measurement.c: Fix various typos in comments .. measurement.c: Fix various typos in comments Change-Id: Ief208045664769406cd60a92a12c4b44988a98b4 --- M

[PATCH] osmo-bts[master]: measurment.c: Introduce INFO category for DMEAS logging

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5137 measurment.c: Introduce INFO category for DMEAS logging There's no point in either having full verbosity in DEBUG level and not logging any measurement related information in INFO. Let's at least print the results at the end of each measurement period

osmo-bts[master]: measurment.c: Introduce INFO category for DMEAS logging

2017-12-02 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5137 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2c870531478c05ce31cc1015597a068a4a76cf99 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

[MERGED] osmo-bts[master]: Comments on individual members of struct gsm_abis_mo

2017-12-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Comments on individual members of struct gsm_abis_mo .. Comments on individual members of struct gsm_abis_mo Change-Id:

[MERGED] osmo-bts[master]: l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C...

2017-12-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C for MPH .. l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C for MPH Change-Id:

[MERGED] osmo-bts[master]: scheduler_trx: L1P is for PH (data), L1M for MPH (control)

2017-12-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: scheduler_trx: L1P is for PH (data), L1M for MPH (control) .. scheduler_trx: L1P is for PH (data), L1M for MPH (control) Almost all log statements in

[MERGED] osmo-bts[master]: scheduler: Harmonize log line format; Always print TS name +...

2017-12-02 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: scheduler: Harmonize log line format; Always print TS name + decoded FN .. scheduler: Harmonize log line format; Always print TS name + decoded FN

[PATCH] osmo-bts[master]: osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5136 osmo-bts-trx: Fix reported frame number during PRIM_INFO_MEAS The upper layers (L1SAP, the common part of L1) *always* require frame numbers in the uplink direction to be reported as the frame number of the *first* burst, not the last burst of a given

osmo-bts[master]: Comments on individual members of struct gsm_abis_mo

2017-12-02 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5124 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e005410080201746906b8a60e9f7957031d2e58 Gerrit-PatchSet: 3 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: measurement.c: Fix various typos in comments

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5133 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ief208045664769406cd60a92a12c4b44988a98b4 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: measurement.c: Fix various typos in comments

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5133 measurement.c: Fix various typos in comments Change-Id: Ief208045664769406cd60a92a12c4b44988a98b4 --- M src/common/measurement.c 1 file changed, 8 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/33/5133/1

osmo-bts[master]: scheduler: Harmonize log line format; Always print TS name +...

2017-12-02 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5125 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5703b46c8a59fe00a3cdc063bcf72872980ec5e5 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C...

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5135 l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C for MPH Change-Id: Icc0325f41a1d80535d33e123083e220ee47df129 --- M src/common/l1sap.c 1 file changed, 11 insertions(+), 11 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts

osmo-bts[master]: scheduler_trx: L1P is for PH (data), L1M for MPH (control)

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5134 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4312f8ab0414eb38db0d62f05c95ab961f500c14 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: scheduler: Harmonize log line format; Always print TS name +...

2017-12-02 Thread Harald Welte
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5125 to look at the new patch set (#2). scheduler: Harmonize log line format; Always print TS name + decoded FN Change-Id: I5703b46c8a59fe00a3cdc063bcf72872980ec5e5 --- M

osmo-bts[master]: l1sap: Fix log subsystem: Use DRTP for RTP related bits, L1C...

2017-12-02 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5135 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icc0325f41a1d80535d33e123083e220ee47df129 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master

[PATCH] osmo-bts[master]: scheduler_trx: L1P is for PH (data), L1M for MPH (control)

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5134 scheduler_trx: L1P is for PH (data), L1M for MPH (control) Almost all log statements in scheduler_trx.c were using the wrong logging subsystem. Let's fix this. Also, make it more obvious from the log subsystem help text Change-Id:

osmo-bts[master]: scheduler: Harmonize log line format; Always print TS name +...

2017-12-02 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (8 comments) just -1ing to indicate that there are comments... nothing critical. https://gerrit.osmocom.org/#/c/5125/1/src/common/scheduler.c File src/common/scheduler.c: Line 308:"Prim %u for is out of range (100), or channel %s with "

osmo-bts[master]: Comments on individual members of struct gsm_abis_mo

2017-12-02 Thread Neels Hofmeyr
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5124 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e005410080201746906b8a60e9f7957031d2e58 Gerrit-PatchSet: 2 Gerrit-Project: osmo-bts Gerrit-Branch: master

osmo-bts[master]: Comments on individual members of struct gsm_abis_mo

2017-12-02 Thread Neels Hofmeyr
Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/5124/1/include/osmo-bts/gsm_data_shared.h File include/osmo-bts/gsm_data_shared.h: Line 114: /* A-bist OML Object Instance */ 'bis' -- To view, visit https://gerrit.osmocom.org/5124 To unsubscribe, visit

[PATCH] osmo-bts[master]: Comments on individual members of struct gsm_abis_mo

2017-12-02 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/5124 to look at the new patch set (#2). Comments on individual members of struct gsm_abis_mo Change-Id: I8e005410080201746906b8a60e9f7957031d2e58 --- M include/osmo-bts/gsm_data_shared.h 1

osmo-mgw[master]: MGCP endpoints: parse as decimal, not hex

2017-12-02 Thread Neels Hofmeyr
Patch Set 2: elsewhere it seems we are confirming the hex nature of endpoint IDs (or was that a connection identifier?) ... Possibly this needs to be fixed the other way, by libosmo-mgcp-client translating the number-of-endpoints to a hex representation? -- To view, visit

[MERGED] osmo-mgw[master]: Revert "mgcp_client: don't configure "bts base"" until osmo-...

2017-12-02 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: Revert "mgcp_client: don't configure "bts base"" until osmo-msc is ready .. Revert "mgcp_client: don't configure "bts base"" until osmo-msc is ready

osmo-mgw[master]: Revert "mgcp_client: don't configure "bts base"" until osmo-...

2017-12-02 Thread Neels Hofmeyr
Neels Hofmeyr has reverted this change. Change subject: Revert "mgcp_client: don't configure "bts base"" until osmo-msc is ready .. Uploaded patch set 1. -- To view, visit https://gerrit.osmocom.org/5126 To unsubscribe,

osmo-mgw[master]: Revert "mgcp_client: don't configure "bts base"" until osmo-...

2017-12-02 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/5126 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibce214c2bfc35623097abbb647619426ef3dcc94 Gerrit-PatchSet: 1 Gerrit-Project: osmo-mgw Gerrit-Branch: master

[PATCH] osmo-mgw[master]: Revert "mgcp_client: don't configure "bts base"" until osmo-...

2017-12-02 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/5126 Revert "mgcp_client: don't configure "bts base"" until osmo-msc is ready OsmoMSC is in the odd situation that it is already using the new libosmo-mgcp-client, which is targeted at osmo-mgw, to configure talking to the old osmo-bsc_mgcp. By removing

[PATCH] osmo-bts[master]: scheduler: Harmonize log line format; Always print TS name +...

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5125 scheduler: Harmonize log line format; Always print TS name + decoded FN Change-Id: I5703b46c8a59fe00a3cdc063bcf72872980ec5e5 --- M include/osmo-bts/scheduler_backend.h M src/common/scheduler.c M src/osmo-bts-trx/scheduler_trx.c 3 files changed, 93

[PATCH] osmo-bts[master]: Comments on individual members of struct gsm_abis_mo

2017-12-02 Thread Harald Welte
Review at https://gerrit.osmocom.org/5124 Comments on individual members of struct gsm_abis_mo Change-Id: I8e005410080201746906b8a60e9f7957031d2e58 --- M include/osmo-bts/gsm_data_shared.h 1 file changed, 7 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts