Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6631
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba6d0c9c729367e00a9ab7fff7c89007d336e59d
Gerrit-PatchSet: 1
Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: compiler warning: ignore deprecated in mgcp_client_test.c
..
compiler warning: ignore deprecated in mgcp_client_test.c
mgcp_msg_crcx() causes
Harald Welte has submitted this change and it was merged.
Change subject: gsm_data_shared: extend bts feature list with speech codecs
..
gsm_data_shared: extend bts feature list with speech codecs
The feature list does not
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I977dc729ba856631245aedf76afd48eac92166f7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: octphy: ensure all BTS models set features
..
octphy: ensure all BTS models set features
Most of the BTS models do not or do register not all of thier
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6641
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6d50c6f4e2348b23f31c3415b0f5577a3f5be50
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: mgcp_client: show failure by MGCP SDP section parsing test
..
mgcp_client: show failure by MGCP SDP section parsing test
To show how the current code
Harald Welte has submitted this change and it was merged.
Change subject: mgcp_client: cosmetic: clean up SDP params parsing
..
mgcp_client: cosmetic: clean up SDP params parsing
The mgcp_response_parse_params() is in a
Harald Welte has submitted this change and it was merged.
Change subject: mgcp_client: detect SDP section-start parsing errors
..
mgcp_client: detect SDP section-start parsing errors
After call to mgcp_find_section_end(),
Patch Set 2: Code-Review+2 Verified+1
--
To view, visit https://gerrit.osmocom.org/6638
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c6d3566b8f6dbf04c0cd8b127423f5295c19f8d
Gerrit-PatchSet: 2
Gerrit-Project: osmo-mgw
Gerrit-Branch:
Patch Set 1:
Back rto all of heels' comments
--
To view, visit https://gerrit.osmocom.org/6602
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iffd441eb2b6b75dfbe001b49b01bea015ca6e11c
Gerrit-PatchSet: 1
Gerrit-Project: osmo-iuh
Harald Welte has submitted this change and it was merged.
Change subject: sgsn_test: guard against struct gprs_ra_id changing
..
sgsn_test: guard against struct gprs_ra_id changing
sgsn_test initializes various struct
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6645
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I517ed9edf77fac37d9de7a39df24c419a8a65d96
Gerrit-PatchSet: 1
Gerrit-Project: osmo-sgsn
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: RSL: Ensure we don't accept DCHAN messages for CCHAN
..
RSL: Ensure we don't accept DCHAN messages for CCHAN
If the Channel Number IE points to a common
Harald Welte has submitted this change and it was merged.
Change subject: RSL: Properly reject RSL CHAN_NR IE for incompatible PCHAN
..
RSL: Properly reject RSL CHAN_NR IE for incompatible PCHAN
If we receive a message for a
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: also test gsm48_generate_lai() and
gsm48_decode_lai()
..
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai()
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: cosmetically re-order MCC to come before MNC
..
gsm0408_test: cosmetically re-order MCC to come before MNC
For consistency in human
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: include BCD and leading zeros in test output
..
gsm0408_test: include BCD and leading zeros in test output
(Preparation for adding 3-digit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6662
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6661
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Harald Welte has submitted this change and it was merged.
Change subject: cosmetic: gsm0408_test: RA test cases as array-of-struct
..
cosmetic: gsm0408_test: RA test cases as array-of-struct
(Preparation for adding 3-digit
Harald Welte has submitted this change and it was merged.
Change subject: gsm0408_test: RA test: include min/max value cases
..
gsm0408_test: RA test: include min/max value cases
(Preparation for adding 3-digit MNC)
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6660
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6657
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6658
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6656
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6655
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6654
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6c645ebf82d5f8d9d51c4c4cc804a0172008156
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6653
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic75041e84c15c77805ecafb823bf7108920675ca
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: L1CTL: Add optional link_id argument to t_L1CTL_DATA_IND()
..
L1CTL: Add optional link_id argument to t_L1CTL_DATA_IND()
Change-Id:
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6652
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4cf42825da1034966086d9232273c2328a94947
Gerrit-PatchSet: 1
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch:
Harald Welte has submitted this change and it was merged.
Change subject: GSM_RR_Types: Add ts_IMM_ASS and ts_MEAS_REP
..
GSM_RR_Types: Add ts_IMM_ASS and ts_MEAS_REP
which allows us to send RR IMMEDIATE ASSIGNMENT (DL/AGCH)
Patch Set 1: Code-Review+1
Would be also great to have a minimalistic commit description,
i.e. where do we use gsm48_ra_id and why?
--
To view, visit https://gerrit.osmocom.org/6667
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id:
introduce GSM_MCC_MNC_INVALID
In some cases, we want to mark an unset MCC-MNC. Define uint16-max for this
purpose.
osmo-bsc code is already doing so with a -1 and using int data types, which
will become inconvenient with the new API that handles MCC and MNC as uint16_t.
Change-Id:
gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing.
gsm48_mnc_cmp() will be used by osmo-sgsn.git
Change-Id: Ib7176b1d65a03b76f41f94bc9d3293a8a07d24c6
---
M
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
gsm0408_test: add test cases for MNC with leading zeros
Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 149 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore
gsm0408_test: check for new mnc_3_digits flag
Note that on the input side, the 3-digits flag may be left false when the MNC
is >99 anyway. On the decoded side, the flag is set accurately.
Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
---
M tests/gsm0408/gsm0408_test.c
M
Review at https://gerrit.osmocom.org/6672
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Note that in gbproxy_test.ok, 0-0
Review at https://gerrit.osmocom.org/6671
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Depends:
Review at https://gerrit.osmocom.org/6667
use gsm48_ra_id instead of buf
Change-Id: I0d3908fb8ca1e2e669d257b5d59b40675fa85d06
---
M include/osmocom/bsc/abis_nm.h
M include/osmocom/bsc/gsm_data.h
M src/libbsc/abis_nm.c
M src/libbsc/bts_ipaccess_nanobts_omlattr.c
M src/libbsc/gsm_data.c
5 files
Review at https://gerrit.osmocom.org/6670
hnb-test: log accurate three-digit MNC with leading zeros
Depends: Id2240f7f518494c9df6c8bda52c0d5092f90f221 (libosmocore)
Change-Id: Ie3dd206bca2f38a0ef7ee7f9d3b6bf2eacc899a4
---
M src/tests/hnb-test.c
1 file changed, 4 insertions(+), 3 deletions(-)
Review at https://gerrit.osmocom.org/6668
implement support for 3-digit MNC with leading zeros
Add 3-digit flags and use the new RAI and LAI API from libosmocore throughout
the code base to be able to handle an MNC < 100 that has three digits (leading
zeros).
Depends:
Review at https://gerrit.osmocom.org/6669
pcu_if: implement support for 3-digit MNC -- TODO
I am actually unsure how this one relates to the pcuif of osmo-bts and
osmo-pcu, if at all. Pushing this for review to probe the community for the
proper counterpart of this.
Change-Id:
Review at https://gerrit.osmocom.org/6665
implement support for 3-digit MNC with leading zeros
Record the mnc_3_digits flag from SI and pass on via the PCU interface.
Bump the PCU interface version from 7 to 9, since osmo-bsc.git had a pcuif of
version 8 already, and its addition of the
Review at https://gerrit.osmocom.org/
implement support for 3-digit MNC with leading zeros
Receive the mnc_3_digits flag from the PCU interface. Bump the PCU interface
version from 7 to 9 to match osmo-bts (see
I49cd762c3c9d7ee6a82451bdf3ffa2a060767947 there).
Add 3-digit flags and use
Review at https://gerrit.osmocom.org/6664
GSM_MNC_INVALID
Change-Id: Ieee7add0bd6d94cf84743a49794bbcd38561b72f
---
M include/osmocom/gsm/gsm48.h
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/64/6664/1
diff --git
Review at https://gerrit.osmocom.org/6660
gsm0408_test: check for new mnc_3_digits flag
Note that on the input side, the 3-digits flag may be left false when the MNC
is >99 anyway. On the decoded side, the flag is set accurately.
Change-Id: I89765613d8c5bd939a6957f7443ac88475f1b93c
---
M
Review at https://gerrit.osmocom.org/6657
gsm0408_test: RA test: include min/max value cases
(Preparation for adding 3-digit MNC)
Change-Id: Ifbc167de0cc039858112677b8d0cd14a2c8af086
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 22 insertions(+), 0
Review at https://gerrit.osmocom.org/6662
gsm0408_test: add test cases for MNC with leading zeros
Change-Id: I9b387e09293a6bbef84b9620ccf21ee2f9ec751c
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 149 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6663
gsm: add gsm48_mnc_from_str() and gsm48_mnc_cmp(), for 3-digit MNC
gsm48_mnc_from_str() preserves leading zeros in the string and is useful for
VTY config parsing.
gsm48_mnc_cmp() will be used by osmo-sgsn.git
Change-Id:
Review at https://gerrit.osmocom.org/6661
gsm0408_test: test new gsm48_{decode,generate}_lai2() functions
Change-Id: I4c8492b8055803d2857f1ef30aede088778b085b
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 45 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6658
gsm0408_test: also test gsm48_generate_lai() and gsm48_decode_lai()
Change-Id: Idd6cee090464bc92b654332904a9a08edf16e5c9
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 53 insertions(+), 0 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6659
implement support for 3-digit MNC with leading zeros
Enable representing three-digit MNC with leading zeros. The MNCs 23 and 023 are
actually different; so far we treated both as 23. Re-encode an incoming BCD or
string of 023 as it were, i.e. not
Review at https://gerrit.osmocom.org/6656
gsm0408_test: include BCD and leading zeros in test output
(Preparation for adding 3-digit MNC)
Change-Id: I7f8ae05fa3e4a6fc004212757b05ca8a14c9ef45
---
M tests/gsm0408/gsm0408_test.c
M tests/gsm0408/gsm0408_test.ok
2 files changed, 8 insertions(+), 5
Review at https://gerrit.osmocom.org/6654
cosmetic: gsm0408_test: RA test cases as array-of-struct
(Preparation for adding 3-digit MNC)
Change-Id: Ic6c645ebf82d5f8d9d51c4c4cc804a0172008156
---
M tests/gsm0408/gsm0408_test.c
1 file changed, 12 insertions(+), 8 deletions(-)
git pull
Review at https://gerrit.osmocom.org/6655
gsm0408_test: cosmetically re-order MCC to come before MNC
For consistency in human readability, MCC simply should come first, always.
Change-Id: Idb86a7088fac4d8a8c41190ab46f9801635f4eee
---
M tests/gsm0408/gsm0408_test.c
M
Review at https://gerrit.osmocom.org/6653
GSM_RR_Types: Add ts_IMM_ASS and ts_MEAS_REP
which allows us to send RR IMMEDIATE ASSIGNMENT (DL/AGCH) and
RR MEASUREMENT REPORT (UL/SACCH) messages from tests.
Change-Id: Ic75041e84c15c77805ecafb823bf7108920675ca
---
M library/GSM_RR_Types.ttcn
1
Review at https://gerrit.osmocom.org/6652
L1CTL: Add optional link_id argument to t_L1CTL_DATA_IND()
Change-Id: Ib4cf42825da1034966086d9232273c2328a94947
---
M library/L1CTL_Types.ttcn
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-ttcn3-hacks
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Types: Add templates for "BSC side"
..
RSL_Types: Add templates for "BSC side"
So far, the RSL templates have been used for BSC testing, i.e.
TTCN3
Harald Welte has submitted this change and it was merged.
Change subject: IPA_Emulation: Make dependencies to RSL/MGCP/SCCP/GSUP
conditional
..
IPA_Emulation: Make dependencies to RSL/MGCP/SCCP/GSUP conditional
Let's use the
Harald Welte has submitted this change and it was merged.
Change subject: IPA_Emulation: Don't log IPAC_MSGT_ID_RESP as
"Unknown/unsupported"
..
IPA_Emulation: Don't log IPAC_MSGT_ID_RESP as "Unknown/unsupported"
Change-Id:
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Introduce notion of 'bts_role'
..
RSL_Emulation: Introduce notion of 'bts_role'
So far we assumed we emulate the BTS side and talk to a
Harald Welte has submitted this change and it was merged.
Change subject: RSL_Emulation: Pass ASP_IPA_EVENT_UP to RSL_CCHAN port
..
RSL_Emulation: Pass ASP_IPA_EVENT_UP to RSL_CCHAN port
When emulating the BSC side of RSL,
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:
Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
Why not to use a macros here?
#define CHAN_NR_IS_DCHAN(chan) \
(chan & 0x80)
--
To view, visit https://gerrit.osmocom.org/6635
Patch Set 1: Code-Review+2
(1 comment)
https://gerrit.osmocom.org/#/c/6635/1/src/common/rsl.c
File src/common/rsl.c:
Line 139: static bool chan_nr_is_dchan(uint8_t chan_nr)
> Why not to use a macros here?
what's wrong with a function? it gets inlined by the compiler anyway...
--
To view,
Patch Set 4:
(2 comments)
Re: testing again here:
It still makes sense to check logging here as it uses this Log class on top,
which adds locking mechanism.
https://gerrit.osmocom.org/#/c/6620/4/CommonLibs/Makefile.am
File CommonLibs/Makefile.am:
Line 26: AM_CFLAGS = $(LIBOSMOCORE_CFLAGS)
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6647
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67f1980fc615ab74371cbe1c4f83e987381299bc
Gerrit-PatchSet: 1
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 1: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6634
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iebd2571726d1284a7431b3f9b23ad3185e832ed1
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6649
Move enums required by VTY to a separate header
This patch is a preparation for next patches, which add full VTY cfg
support.
Change-Id: I3d5b0576aa96869756f1629a40306c0043b6304b
---
M CommonLibs/Makefile.am
A CommonLibs/config_defs.h
M
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/6619/5/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 345: config->config_file = (char *)DEFAULT_CONFIG_FILE;
Why do we need this cast?
It should already be (char *), am I wrong?
--
To view,
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6644
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I977dc729ba856631245aedf76afd48eac92166f7
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 4:
(2 comments)
And do we really need to test logging here?
It's already being tested in libosmocore,
so testing here for me seems useless...
https://gerrit.osmocom.org/#/c/6620/4/CommonLibs/Makefile.am
File CommonLibs/Makefile.am:
Line 26: AM_CFLAGS = $(LIBOSMOCORE_CFLAGS)
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/6619/5/CommonLibs/trx_vty.h
File CommonLibs/trx_vty.h:
Line 7: struct trx_ctx {
Please add a comment with brief description of this
structure and further plans, i.e. what is it going
to be used for?
--
To view, visit
Review at https://gerrit.osmocom.org/6646
osmo-trx: set up signals using libosmocore helpers
Change-Id: I86e78cd6054d0deff1b1aa061299d9f307e2a352
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 20 insertions(+), 12 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/4/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 79: #define DEFAULT_CONFIG_FILE"/etc/osmocom/osmo-trx.cfg"
I am not sure, is this common for Osmocom projects to
keep the configuration files in
Review at https://gerrit.osmocom.org/6647
osmo-trx: Set up talloc ctx
Change-Id: I67f1980fc615ab74371cbe1c4f83e987381299bc
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx refs/changes/47/6647/1
diff --git
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6649/1//COMMIT_MSG
Commit Message:
Line 9: This patch is a preparation for next patches, which add full VTY cfg
Moreover, the commit message doesn't explain why
this is necessary :?
--
To view, visit https://gerrit.osmocom.org/6649
To
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6618
to look at the new patch set (#5).
Depend on libosmocore
Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
---
M Transceiver52M/Makefile.am
M configure.ac
M contrib/jenkins.sh
3
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#5).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Patch Set 1: Code-Review-1
I support the idea of using a proper enum X instead of int.
But do we really have to move these enums away from classes?
I believe there should be a way to avoid this...
--
To view, visit https://gerrit.osmocom.org/6649
To unsubscribe, visit
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/6646/1/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 248: fprintf(stdout, "SIGINT received, shutting down\n");
We already printed, which signal was received.
Let's either drop the 'SIGINT received'
Patch Set 5: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6618
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
Gerrit-PatchSet: 5
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6650
vty: Implement VTY cfg parsing for current parameters
At this stage, osmo-trx still uses the cmdline parameters top run the
device, but it is already able to parse all the same parameters from a
cfg file through the VTY and filling a trx_ctx structure
Review at https://gerrit.osmocom.org/6651
osmo-trx: Drop cmd lines and use VTY cfg
Change-Id: Ib8de1a5da4b3c0b6a49e00033f616e1d66656adf
---
M Transceiver52M/osmo-trx.cpp
1 file changed, 99 insertions(+), 319 deletions(-)
git pull ssh://gerrit.osmocom.org:29418/osmo-trx
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6620
to look at the new patch set (#5).
Logger: Use libosmocore logging system
We still need an intermediate class Logger due to osmo-trx being
multi-threaded and requiring to have a lock
Review at https://gerrit.osmocom.org/6648
osmo-trx.cpp: Move trx start and stop to helper functions
Make main() smaller, and make it easier to replace cmdline parameters in
following commits.
Change-Id: I10eaaafe38ace2b7bb095a0ad1db70d6c06ee03b
---
M Transceiver52M/osmo-trx.cpp
1 file
Patch Set 4:
I would prefer to integrate both talloc and signal handlers separately...
--
To view, visit https://gerrit.osmocom.org/6618
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If345c89293fcd7d1ad4f17214eea339951f25a5d
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6643
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I509f2a7bbfa96c70bdfea4ff2488ee371e914620
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6641
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If6d50c6f4e2348b23f31c3415b0f5577a3f5be50
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Patch Set 1: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/6642
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I26765a64153368016921c2ac115b1c4aec9bc5e4
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Review at https://gerrit.osmocom.org/6645
sgsn_test: guard against struct gprs_ra_id changing
sgsn_test initializes various struct gprs_ra_id without naming the actual
members, which is vulnerable to struct member re-ordering. Name the members
explicitly.
An upcoming ABI change in libosmocore
Review at https://gerrit.osmocom.org/6643
vty: display bts features in vty command show bts
The VTY command show bts does not display the bts specific
features yet.
- Also display the feature list in snow-bts
Change-Id: I509f2a7bbfa96c70bdfea4ff2488ee371e914620
---
M src/common/vty.c
1 file
Review at https://gerrit.osmocom.org/6644
bts: use feature list instead of speech codec table
osmo-bts has a table of pchan/channel mode combinations for every
bts. This table models the codec capabilitys of the BTS hardware.
However, having the speech codec apabilities modeled inside the
BTS
Review at https://gerrit.osmocom.org/6642
octphy: ensure all BTS models set features
Most of the BTS models do not or do register not all of thier
features to the the feature list.
- Update/extend the feature lists for all BTS-Models
Change-Id: I26765a64153368016921c2ac115b1c4aec9bc5e4
---
M
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c
File CommonLibs/debug.c:
Line 9: .description = "Transciever",
> _ei_ not _ie_ because its receiver, not reciever and "Transceiver" is from
Typo indeed :-)
mgcp_client: cosmetic: clean up SDP params parsing
The mgcp_response_parse_params() is in a jumble. Straighten out these cosmetic
issues:
- Move assertion of r->body close to its first use.
- Instead of a talloc_zero and osmo_strlcpy dance, simply use talloc_strdup().
- Drop the first unused
mgcp_client: show failure by MGCP SDP section parsing test
To show how the current code fails, add test_sdp_section_start() to
mgcp_client_test.c, and temporarily accept failing output. This will be fixed
in change I62a2453cd9e2e7d5408423161fa65ec9c9989f98.
Change-Id:
Review at https://gerrit.osmocom.org/6639
mgcp_client: cosmetic: clean up SDP params parsing
The mgcp_response_parse_params() is in a jumble. Straighten out these cosmetic
issues:
- Move assertion of r->body close to its first use.
- Instead of a talloc_zero and osmo_strlcpy dance, simply use
Review at https://gerrit.osmocom.org/6638
mgcp_client: show failure by MGCP SDP section parsing test
To show how the current code fails, add test_sdp_section_start() to
mgcp_client_test.c, and temporarily accept failing output. This will be fixed
in change
1 - 100 of 143 matches
Mail list logo
