libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Neels Hofmeyr
Patch Set 16: (3 comments) https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 711: remain -= sizeof(struct gsm48_loc_area_id) + sizeof(*ci_be); and might be nice to define a local var for sizeof(struct gsm48_loc_area_id) +

libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Neels Hofmeyr
Patch Set 16: Code-Review-1 (1 comment) found an error https://gerrit.osmocom.org/#/c/6509/16/src/gsm/gsm0808_utils.c File src/gsm/gsm0808_utils.c: Line 705: if (decode_lai([lai_offset], >lai.plmn.mcc, >lai.plmn.mnc, >lai.lac) != 0) error here: lai_offset is unset in the first

[PATCH] osmo-msc[master]: vlr_ciph_result: fix use after free of imeisv

2018-03-12 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/7264 vlr_ciph_result: fix use after free of imeisv Define the struct vlr_ciph_result member .imeisv not as a char* but a char[] of appropriate length, to avoid the need to point to external memory. Thus fix a use-after-free in msc_cipher_mode_compl(),

osmo-bsc[master]: abis_rsl: properly handle RSL Release Ind from MS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: > At first sight I'm not entirely convinced. > > An RLL REL IND indicates release of one SAPI (on either DCCH or > SACCH), not release of the radio channel. The MS could release > SAPI3 as no SMS transmissions are pending but still keep SAPI 0 for > other signaling? > >

osmo-sgsn[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7119 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-mgw[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

osmo-mgw[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7116 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-sgsn[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

[MERGED] osmo-pcu[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

osmo-msc[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7117 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-msc[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

osmo-pcu[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7118 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-ggsn[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

[MERGED] osmo-hlr[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

[MERGED] osmo-iuh[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

osmo-iuh[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7115 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-hlr[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

osmo-ggsn[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7111 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-hlr[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7114 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-ggsn[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7112 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-hlr[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7113 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-ggsn[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

osmo-bts[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7110 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] osmo-bsc[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

[MERGED] osmo-bts[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

libsmpp34[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7107 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libsmpp34[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

libosmocore[master]: jenkins_amd64.sh: use --enable-werror configure flag, not CF...

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libosmo-sccp[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

libosmocore[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7104 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

osmo-bsc[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7108 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libsmpp34[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

[MERGED] libosmocore[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

[MERGED] libosmo-sccp[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

libosmocore[master]: jenkins_amd64.sh: use --enable-werror configure flag, not CF...

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7105 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I81b50c39cd6e908c4c95651829b679425de87a28 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master

libsmpp34[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7106 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libosmocore[master]: jenkins_amd64.sh: use --enable-werror configure flag, not CF...

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins_amd64.sh: use --enable-werror configure flag, not CFLAGS .. jenkins_amd64.sh: use --enable-werror configure flag, not CFLAGS Note that the

libosmo-sccp[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7103 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmo-sccp[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7103 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5c3f11586d48a076479eb19ed80a11caad4251d8 Gerrit-PatchSet: 1 Gerrit-Project: libosmo-sccp Gerrit-Branch: master

[MERGED] libosmo-netif[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

libosmo-netif[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7101 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmo-sccp[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7102 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libasn1c[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: configure: add --enable-werror .. configure: add --enable-werror Provide a sane means of adding the -Werror compiler flag. Currently, some of our

[MERGED] libosmo-netif[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

libosmo-abis[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7098 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libasn1c[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7097 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmo-abis[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7099 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

libosmo-netif[master]: configure: add --enable-werror

2018-03-12 Thread Neels Hofmeyr
Patch Set 1: Code-Review+2 marking +2 because I'm (barely) allowed to by the comment at https://gerrit.osmocom.org/7096 (03-09 13:04 CET) -- To view, visit https://gerrit.osmocom.org/7100 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id:

[MERGED] libosmo-abis[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

[MERGED] libasn1c[master]: jenkins.sh: use --enable-werror configure flag, not CFLAGS

2018-03-12 Thread Neels Hofmeyr
Neels Hofmeyr has submitted this change and it was merged. Change subject: jenkins.sh: use --enable-werror configure flag, not CFLAGS .. jenkins.sh: use --enable-werror configure flag, not CFLAGS Change-Id:

libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Neels Hofmeyr
Patch Set 16: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb Gerrit-PatchSet: 16 Gerrit-Project: libosmocore Gerrit-Branch: master

[PATCH] osmocom-bb[master]: Merge branch 'fixeria/trx' into master

2018-03-12 Thread Vadim Yanitskiy
Review at https://gerrit.osmocom.org/7263 Merge branch 'fixeria/trx' into master This change introduces the following: - trxcon - a similar to the osmocon application, which implements both L1CTL and TRX interfaces, and intended to connect the L2&3 applications with a transciever,

[PATCH] osmo-bsc[master]: ipaccess-config: Enable logging all categories to print errors

2018-03-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7260 ipaccess-config: Enable logging all categories to print errors log_parse_category_mask is preventing errors from being printed, which makes debugging issues with the application harder. Change-Id: I69ee2de921979f8bfaa8b501c6b05db1717b0c36 --- M

[PATCH] osmo-bsc[master]: ipaccess-config: Improve handling of last parameter

2018-03-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7262 ipaccess-config: Improve handling of last parameter Check exact number of parameters to avoid explicit void params ("") to be used as BTS IP by an incorrect caller. Exit successfully if firmware analysis is requested and there's no BTS IP provided

[PATCH] osmo-bsc[master]: ipaccess-config: Add missing path with log error

2018-03-12 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/7261 ipaccess-config: Add missing path with log error Change-Id: Id903e3e20e12a143cedab72dc14669c07f4d11ac --- M src/ipaccess/ipaccess-config.c 1 file changed, 1 insertion(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bsc

osmo-bts[master]: LC15: Fix missing fill frame and GSM 05.08 mandatory frame

2018-03-12 Thread Stefan Sperling
Patch Set 5: (8 comments) I'm not familiar with these parts of the spec. So my comments are only cosmetic in nature. https://gerrit.osmocom.org/#/c/5753/5/src/common/msg_utils.c File src/common/msg_utils.c: Line 388: else Add curly braces to this else block? It spans more than

[MERGED] osmo-bsc[master]: abisip-find: Force stdout buffer flush

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: abisip-find: Force stdout buffer flush .. abisip-find: Force stdout buffer flush If list-view is not enabled, then a line with the new BTS is printed to

osmo-bsc[master]: abisip-find: Add --format-json option

2018-03-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7259 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib2d461c79fbc242141dc342578467c3e9c6ed5fc Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

[MERGED] osmo-bsc[master]: abisip-find: Add option to bind to a specific source address

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: abisip-find: Add option to bind to a specific source address .. abisip-find: Add option to bind to a specific source address When the BTS answers, it

[MERGED] osmo-bsc[master]: abisip-find: Add --format-json option

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: abisip-find: Add --format-json option .. abisip-find: Add --format-json option This format outputs json format which can be more easily parsed if

osmo-bsc[master]: abisip-find: Add option to bind to a specific source address

2018-03-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7257 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b805f22d261003239d7002d9e568ea4797a2b0b Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-bsc[master]: abisip-find: Force stdout buffer flush

2018-03-12 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7258 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I19f8c7f747fa7a130a436e5e07a8648932404bf0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bsc Gerrit-Branch: master

osmo-msc[master]: Track libosmocore API change in osmo-msc.

2018-03-12 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/6518 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I67377270cf3b081ac5dc9cd7b4dc28f74143753a Gerrit-PatchSet: 2 Gerrit-Project: osmo-msc Gerrit-Branch: master

libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Harald Welte
Patch Set 16: Code-Review+1 leaving it to Neels to see if his comments are all addressed. -- To view, visit https://gerrit.osmocom.org/6509 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib7e754f538df0c83298a3c958b4e15a32fcb8abb

libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Stefan Sperling
Patch Set 14: (2 comments) https://gerrit.osmocom.org/#/c/6509/14/include/osmocom/gsm/gsm0808.h File include/osmocom/gsm/gsm0808.h: Line 33: struct gsm0808_cell_id_list; > this structs is defined in above protocol/gsm_08_08.h so no real point in a Yep, will do in next patch set.

[PATCH] libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#16). support for more cell ID list types in libosmocore Introduce gsm0808_dec_cell_id_list2() with supports additional types of cell

[PATCH] osmo-msc[master]: Track libosmocore API change in osmo-msc.

2018-03-12 Thread Stefan Sperling
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6518 to look at the new patch set (#2). Track libosmocore API change in osmo-msc. struct gsm0808_cell_id_list in libosmocore is deprecated by

[PATCH] libosmocore[master]: support for more cell ID list types in libosmocore

2018-03-12 Thread Stefan Sperling
Hello Neels Hofmeyr, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/6509 to look at the new patch set (#15). support for more cell ID list types in libosmocore Introduce gsm0808_dec_cell_id_list2() with supports additional types of cell

[MERGED] osmo-ttcn3-hacks[master]: bts: Make f_TC_meas_res_periodic work with real BTS

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Make f_TC_meas_res_periodic work with real BTS .. bts: Make f_TC_meas_res_periodic work with real BTS In a real BTS + OsmocomBB-L1, we cannot

[MERGED] osmo-ttcn3-hacks[master]: L1CTL/bts: Fix tons of compiler warnings by splitting rx+tx ...

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: L1CTL/bts: Fix tons of compiler warnings by splitting rx+tx templates .. L1CTL/bts: Fix tons of compiler warnings by splitting rx+tx templates

[MERGED] osmo-ttcn3-hacks[master]: bts: Align default SI contents with what we see from OsmoBSC

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Align default SI contents with what we see from OsmoBSC .. bts: Align default SI contents with what we see from OsmoBSC Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: bts: Add TC_sacch_info_mod and TC_sacch_filling

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add TC_sacch_info_mod and TC_sacch_filling .. bts: Add TC_sacch_info_mod and TC_sacch_filling Change-Id: I38b3e302eddb699b2dbdae06fc929dd59de7b2dc

[MERGED] osmo-ttcn3-hacks[master]: WIP: Work towards a more real DL TBF receiver implementation

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: WIP: Work towards a more real DL TBF receiver implementation .. WIP: Work towards a more real DL TBF receiver implementation Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: bts: Add f_rsl_transceive() flag to ignore all unrelated mes...

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add f_rsl_transceive() flag to ignore all unrelated messages .. bts: Add f_rsl_transceive() flag to ignore all unrelated messages

[MERGED] osmo-ttcn3-hacks[master]: bts: Send DM_REL_REQ to L1 when closing logical channel

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Send DM_REL_REQ to L1 when closing logical channel .. bts: Send DM_REL_REQ to L1 when closing logical channel Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: pcu: First DL TBF hack

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: pcu: First DL TBF hack .. pcu: First DL TBF hack Change-Id: Ib3f09e125a7a4492d9072f8e9f5896eaac7ed03b --- M library/GSM_RR_Types.ttcn M

[MERGED] osmo-ttcn3-hacks[master]: L1CTL: Have proper timeout during reset

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: L1CTL: Have proper timeout during reset .. L1CTL: Have proper timeout during reset Change-Id: Ib6b33f522eddb1377e9857cc5d88363852732b46 --- M

[MERGED] osmo-ttcn3-hacks[master]: bts: Add TC_deact_sacch()

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add TC_deact_sacch() .. bts: Add TC_deact_sacch() This test case checks on each logical channel if the DEACT SACCH RSL message actually deactivates

[MERGED] osmo-ttcn3-hacks[master]: L1CTL: make sure to self.stop in all setverdict(fail) cases

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: L1CTL: make sure to self.stop in all setverdict(fail) cases .. L1CTL: make sure to self.stop in all setverdict(fail) cases Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: BTS_Tests: Access Control Classes are inverted

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: BTS_Tests: Access Control Classes are inverted .. BTS_Tests: Access Control Classes are inverted No normal phone would ever send us a RACH request due

[MERGED] osmo-ttcn3-hacks[master]: bts: Ignore first MEAS REP as it often contains bogus values

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Ignore first MEAS REP as it often contains bogus values .. bts: Ignore first MEAS REP as it often contains bogus values The first measurement

[MERGED] osmo-ttcn3-hacks[master]: bts: f_rsl_transceive: Add altsteps for sacch/facch/meas_rep

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: f_rsl_transceive: Add altsteps for sacch/facch/meas_rep .. bts: f_rsl_transceive: Add altsteps for sacch/facch/meas_rep It may be that during CHAN

[MERGED] osmo-ttcn3-hacks[master]: bts: Add f_shutdown() for clean shutdown; use it from tests

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Add f_shutdown() for clean shutdown; use it from tests .. bts: Add f_shutdown() for clean shutdown; use it from tests Change-Id:

[MERGED] osmo-ttcn3-hacks[master]: bts: Make PCU and TRXC sockets optional

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Make PCU and TRXC sockets optional .. bts: Make PCU and TRXC sockets optional If we want to test with a real (remote) BTS, we can neither access

[MERGED] osmo-ttcn3-hacks[master]: bts: Introduce RxLev/RxQual tolerance values

2018-03-12 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: bts: Introduce RxLev/RxQual tolerance values .. bts: Introduce RxLev/RxQual tolerance values In real-world measurements there's always some tolerance.

osmo-ttcn3-hacks[master]: bts: Add f_rsl_transceive() flag to ignore all unrelated mes...

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7250 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I34d8e9350dbe2b032a7454d7f003262e27c802ad Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Add TC_sacch_multi to test for scheduling of multiple S...

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7252 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b9a68a0dc004c2ebc8a39f0c7b7aad690675a2d Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Add TC_deact_sacch()

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7249 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id8219ffce0635071cb50669b89368de51fe82843 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Add TC_sacch_info_mod and TC_sacch_filling

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7251 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I38b3e302eddb699b2dbdae06fc929dd59de7b2dc Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Align default SI contents with what we see from OsmoBSC

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7241 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8d0fa73e1a9b859e1833b0d2ce8cb6bbf07938cc Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Make f_TC_meas_res_periodic work with real BTS

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7245 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55a79f9e23118d2bb28f27cbcc7ab28712570ef1 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Send DM_REL_REQ to L1 when closing logical channel

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7247 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0c0bb52b4de20dfd2d4ea8d0045ea63d84686ac5 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Add f_shutdown() for clean shutdown; use it from tests

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7248 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I225d2363c77dce969bda95ff27506bece586a34a Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: f_rsl_transceive: Add altsteps for sacch/facch/meas_rep

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7246 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic27b28ead3fc4bff82655d0e8d88fda01b71eca7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Introduce RxLev/RxQual tolerance values

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7243 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41396ad081706a0dbd6cc992b81d9bba266b6d6d Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Ignore first MEAS REP as it often contains bogus values

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7244 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5edfdca0c2b5c63073dca7f12f9c0d447e37995c Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: bts: Make PCU and TRXC sockets optional

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7242 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibb02cf289b0d2e77170f146463822c164efc21cd Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: L1CTL: make sure to self.stop in all setverdict(fail) cases

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7238 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2013a8ec0641d8ef935e6615c1bde599f42db260 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: BTS_Tests: Access Control Classes are inverted

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7240 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I149dca67971bde3072ec2081d9ad7e8f43434ebf Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

osmo-ttcn3-hacks[master]: WIP: Work towards a more real DL TBF receiver implementation

2018-03-12 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/7230 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I300312734d99f2b8a406f39e04b4f738940f7579 Gerrit-PatchSet: 3 Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch:

  1   2   >