Change in ...libosmocore[master]: lapdm: Allow user to specify T200 values; Use correct N200 values

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14339 ) Change subject: lapdm: Allow user to specify T200 values; Use correct N200 values .. Patch Set 3: (5 comments) https

Change in ...osmo-bsc[master]: vty: adjust config name for unit-id

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14365 ) Change subject: vty: adjust config name for unit-id .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-hlr[master]: db_hlr: zero-initialize "struct tm"

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14364 ) Change subject: db_hlr: zero-initialize "struct tm" .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osm

Change in ...osmo-msc[master]: db_sms_test: Do not print exact memcmp result

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14357 ) Change subject: db_sms_test: Do not print exact memcmp result .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: common/scheduler.c: refactor description of TRXC_* lchans

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14322 ) Change subject: common/scheduler.c: refactor description of TRXC_* lchans .. Set Ready For Review -- To view, visit https

Change in ...osmo-bsc[master]: vty: adjust config name for unit-id

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/14365 ) Change subject: vty: adjust config name for unit-id .. Patch Set 1: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-bts[master]: trx: Update documentation for fn-advance and rts-advance

2019-06-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14334 ) Change subject: trx: Update documentation for fn-advance and rts-advance .. Patch Set 1: Code-Review+1 Oh, I am sorry. Nevermind. I

Change in ...osmo-bts[master]: trx: Update documentation for fn-advance and rts-advance

2019-06-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14334 ) Change subject: trx: Update documentation for fn-advance and rts-advance .. Patch Set 1: Code-Review-1 (3 comments) https

Change in ...osmo-msc[master]: tests: share stubs.h from msc_vlr_test as stubs.c

2019-06-03 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14352 Change subject: tests: share stubs.h from msc_vlr_test as stubs.c .. tests: share stubs.h from msc_vlr_test as stubs.c Change-Id

Change in ...osmo-msc[master]: Introduce initial unit test for db_sms_* API

2019-06-03 Thread fixeria
Gerrit-Branch: master Gerrit-Change-Id: Id94ad35b6f78f839137db2e17010fbf9b40111a3 Gerrit-Change-Number: 13629 Gerrit-PatchSet: 4 Gerrit-Owner: fixeria Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit

Change in ...libosmocore[master]: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx()

2019-06-03 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/libosmocore/+/13973 ) Change subject: libosmovty: deprecate vty_init(), add vty_init[_app]_ctx() .. Abandoned Thanks Harald! Your explanation makes a lot

Change in ...osmo-msc[master]: Introduce initial unit test for db_sms_* API

2019-06-03 Thread fixeria
Gerrit-Branch: master Gerrit-Change-Id: Id94ad35b6f78f839137db2e17010fbf9b40111a3 Gerrit-Change-Number: 13629 Gerrit-PatchSet: 5 Gerrit-Owner: fixeria Gerrit-Reviewer: Harald Welte Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria Gerrit-Reviewer: pespin Gerrit-CC: Max Gerrit

Change in ...osmo-msc[master]: tests: share stubs.h from msc_vlr_test as stubs.c

2019-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14352 ) Change subject: tests: share stubs.h from msc_vlr_test as stubs.c .. Set Ready For Review -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages

2019-06-04 Thread fixeria
Gerrit-Change-Number: 14372 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: do not override LD_LIBRARY_PATH

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14374 Change subject: start-testsuite.sh: do not override LD_LIBRARY_PATH .. start-testsuite.sh: do not override LD_LIBRARY_PATH

Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages

2019-06-04 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 ) Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages .. Abandoned -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr

2019-06-04 Thread fixeria
To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie7d311bf8f03bf9b1d29b5bb28ffad793f215fd1 Gerrit-Change-Number: 14370 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14375 Change subject: BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX .. BTS_Tests.ttcn: indicate default RSSI=-60 to FakeTRX

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix name of f_trx_fake_toffs256()

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14371 Change subject: BTS_Tests.ttcn: fix name of f_trx_fake_toffs256() .. BTS_Tests.ttcn: fix name of f_trx_fake_toffs256

Change in ...osmo-ttcn3-hacks[master]: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14372 Change subject: library/TRXC_CodecPort.ttcn: add debug print on Rx / Tx of messages .. library/TRXC_CodecPort.ttcn: add

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: correct error messages about TRXC connection

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14369 Change subject: BTS_Tests.ttcn: correct error messages about TRXC connection .. BTS_Tests.ttcn: correct error messages about

Change in ...osmo-ttcn3-hacks[master]: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14370 Change subject: BTS_Tests.ttcn: fix TRXC port mapping between test_CT and ConnHdlr .. BTS_Tests.ttcn: fix TRXC port mapping

Change in ...osmo-msc[master]: libmsc/db.c: fix potential integer overflow

2019-06-04 Thread fixeria
m.org/c/osmo-msc/+/13470 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ibbd588545e1a4817504c806a3d02cf59d5938ee2 Gerrit-Change-Number: 13470 Gerrit-PatchSet: 9 Gerrit-Owner: fixeria

Change in ...osmo-msc[master]: libmsc/db.c: introduce and use parse_sm_ud_from_result()

2019-06-04 Thread fixeria
: If67dfb9f7d2a55fa3d45dc4689a2acff9909faf6 Gerrit-Change-Number: 13488 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-sgsn[master]: osmo-sgsn: add VTY parameter to toggle authentication

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14194 ) Change subject: osmo-sgsn: add VTY parameter to toggle authentication .. Set Ready For Review -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: start-testsuite.sh: do not override LD_LIBRARY_PATH

2019-06-04 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14374 ) Change subject: start-testsuite.sh: do not override LD_LIBRARY_PATH .. start-testsuite.sh: do not override

Change in ...osmo-sgsn[master]: doc/manuals/vty: regenerate sgsn_vty_reference.xml

2019-06-04 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14377 Change subject: doc/manuals/vty: regenerate sgsn_vty_reference.xml .. doc/manuals/vty: regenerate sgsn_vty_reference.xml Change-Id

Change in ...osmo-msc[master]: libmsc/db.c: get rid of hard-coded SMS expiry threshold

2019-06-04 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13631 ) Change subject: libmsc/db.c: get rid of hard-coded SMS expiry threshold .. Set Ready For Review -- To view, visit https

Change in ...osmo-msc[master]: libmsc/db.c: properly get / set TP-UD length (octets vs septets)

2019-06-04 Thread fixeria
fixeria has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/13490 ) Change subject: libmsc/db.c: properly get / set TP-UD length (octets vs septets) .. Abandoned -- To view, visit https://gerrit.osmocom.org/c

Change in ...osmo-sgsn[master]: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler

2019-06-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14195 ) Change subject: osmo-sgsn: get rid of OSMO_ASSERT() in 'auth-policy' handler .. Patch Set 2: > I created https://osmocom.

Change in ...osmo-msc[master]: debian/control: add missing libdbd-sqlite3 to Build-Depends

2019-06-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14380 Change subject: debian/control: add missing libdbd-sqlite3 to Build-Depends .. debian/control: add missing libdbd-sqlite3 to Build

Change in ...osmo-ttcn3-hacks[master]: BTS: pcu_rr_suspend clean up and release the channel

2019-06-06 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14396 ) Change subject: BTS: pcu_rr_suspend clean up and release the channel .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in ...osmo-msc[master]: libmsc/db.c: get rid of hard-coded SMS expiry threshold

2019-06-06 Thread fixeria
Gerrit-Change-Id: I0ce6b1ab50986dc69a2be4ea62b6a24c7f3f8f0a Gerrit-Change-Number: 13631 Gerrit-PatchSet: 7 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Stefan Sperling Gerrit-Reviewer: fixeria Gerrit-Reviewer: laforge Gerrit-CC: pespin Gerrit-MessageType: newpatchset

Change in ...libosmocore[master]: gsm48_decode_bcd_number2: fix ENOSPC edge case

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14397 ) Change subject: gsm48_decode_bcd_number2: fix ENOSPC edge case .. Patch Set 2: Code-Review-1 (3 comments) https

Change in ...osmo-pcu[master]: gprs_bssgp_pcu: explicit allocate & initialize bssgp_nsi instance

2019-06-06 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/14171 ) Change subject: gprs_bssgp_pcu: explicit allocate & initialize bssgp_nsi instance .. Patch Set 2: Code-Review+1 -- To view, v

Change in ...libosmocore[master]: gsm48_decode_bcd_number2: fix ENOSPC edge case

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14397 ) Change subject: gsm48_decode_bcd_number2: fix ENOSPC edge case .. Patch Set 2: I recommend to extend the unit test first, so you

Change in ...osmo-ttcn3-hacks[master]: hlr: add Check IMEI tests

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14402 ) Change subject: hlr: add Check IMEI tests .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14402/1

Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14399 ) Change subject: rx_check_imei_req(): fix IMEI bounds checking .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14399/1

Change in ...libosmocore[master]: gsm48_decode_bcd_number2: fix ENOSPC edge case

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14397 ) Change subject: gsm48_decode_bcd_number2: fix ENOSPC edge case .. Patch Set 4: Code-Review+1 -- To view, visit https

Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14399 ) Change subject: rx_check_imei_req(): fix IMEI bounds checking .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14399/1

Change in ...osmo-ttcn3-hacks[master]: hlr: f_vty_subscr_show(): add invert arg

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14401 ) Change subject: hlr: f_vty_subscr_show(): add invert arg .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-trx[master]: lms: Drop unusued variable masterClockRate

2019-06-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14367 ) Change subject: lms: Drop unusued variable masterClockRate .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-trx[master]: lms: Fix stream_stats checks with overrun/underrun

2019-06-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14368 ) Change subject: lms: Fix stream_stats checks with overrun/underrun .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in ...osmo-trx[master]: Add rate_ctr support to store/retrieve SDR errors through VTY

2019-06-05 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-trx/+/14167 ) Change subject: Add rate_ctr support to store/retrieve SDR errors through VTY .. Patch Set 2: Code-Review+1 -- To view, visit

Change in ...osmo-ttcn3-hacks[master]: CTRL_Types: Fix SET value not encoded in message

2019-06-07 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14405 ) Change subject: CTRL_Types: Fix SET value not encoded in message .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-msc[master]: db: Fix call to mempcy with NULL src ptr

2019-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14355 ) Change subject: db: Fix call to mempcy with NULL src ptr .. Patch Set 1: Code-Review+2 -- To view, visit https

Change in ...osmo-bts[master]: vty: adjust config name for unit-id

2019-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/14359 ) Change subject: vty: adjust config name for unit-id .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14359/1/src/common

Change in ...osmo-msc[master]: db_sms_test: Do not print exact memcmp result

2019-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14357 ) Change subject: db_sms_test: Do not print exact memcmp result .. Patch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/14357/1

Change in ...osmo-msc[master]: db_sms_test: Remove libdbi expected driver load errors

2019-06-03 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14356 ) Change subject: db_sms_test: Remove libdbi expected driver load errors .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c

Change in ...osmo-bts[master]: common/bts.c: bts_supports_cm(): take care about GSM48_CMODE_SIGN

2019-06-02 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14335 Change subject: common/bts.c: bts_supports_cm(): take care about GSM48_CMODE_SIGN .. common/bts.c: bts_supports_cm(): take care

Change in ...osmo-bts[master]: Use #define RSL_CHAN_RACH for RSL Channel Number of RACH

2019-06-05 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bts/+/14381 Change subject: Use #define RSL_CHAN_RACH for RSL Channel Number of RACH .. Use #define RSL_CHAN_RACH for RSL Channel Number of RACH

Change in ...osmo-ttcn3-hacks[master]: lapdm: Rename 'dummy_CT' to more reasonable 'lapdm_test_CT'

2019-06-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14326 ) Change subject: lapdm: Rename 'dummy_CT' to more reasonable 'lapdm_test_CT' .. Patch Set 1: Code-Review+1 -- To view

Change in ...osmocom-bb[master]: trxcon/l1ctl.c: properly handle handover RACH request

2019-06-02 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14274 ) Change subject: trxcon/l1ctl.c: properly handle handover RACH request .. Patch Set 3: Code-Review+2 -- To view, visit https

Change in ...osmocom-bb[master]: trxcon/l1ctl.c: properly handle handover RACH request

2019-06-02 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/osmocom-bb/+/14274 ) Change subject: trxcon/l1ctl.c: properly handle handover RACH request .. trxcon/l1ctl.c: properly handle handover RACH

Change in ...libosmocore[master]: vty: command.c: Fix: multi-choice args are no longer passed incomplet...

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14436 ) Change subject: vty: command.c: Fix: multi-choice args are no longer passed incomplete to vty func .. Patch Set 2: Code-Review+1

Change in ...libosmocore[master]: fsm.c: Print error message for FSM with allstate_action but no events

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14361 ) Change subject: fsm.c: Print error message for FSM with allstate_action but no events .. Patch Set 2: Code-Review+1 (2 comments

Change in ...osmo-msc[master]: libvlr: fix sgsn tmsi creation

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14448 ) Change subject: libvlr: fix sgsn tmsi creation .. Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/14448/1

Change in ...libosmocore[master]: vty: command.c: Fix: single-choice optional args are no longer passed...

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14437 ) Change subject: vty: command.c: Fix: single-choice optional args are no longer passed incomplete to vty func .. Patch Set 2

Change in ...osmo-msc[master]: libmsc/mncc_builtin.c: drop dummy switch in int_mncc_recv()

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14449 Change subject: libmsc/mncc_builtin.c: drop dummy switch in int_mncc_recv() .. libmsc/mncc_builtin.c: drop dummy switch

Change in ...osmo-sgsn[master]: sgsn: Have authentication required on by default

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/14445 ) Change subject: sgsn: Have authentication required on by default .. Patch Set 2: Code-Review+1 Sorry, I have been reading "de

Change in ...libosmocore[master]: protocol/gsm_04_08.h: do not check if unsigned is positive

2019-06-12 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14426 Change subject: protocol/gsm_04_08.h: do not check if unsigned is positive .. protocol/gsm_04_08.h: do not check if unsigned

Change in ...osmo-ttcn3-hacks[master]: hlr: add create-subscriber-on-demand tests

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14424 ) Change subject: hlr: add create-subscriber-on-demand tests .. Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c

Change in ...osmo-hlr[master]: hlr.c: abort LU without MSISDN

2019-06-12 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14423 ) Change subject: hlr.c: abort LU without MSISDN .. Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in ...osmo-ttcn3-hacks[master]: library/GSUP_Types.ttcn: refactor PROC_SS IEs generation

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14455 Change subject: library/GSUP_Types.ttcn: refactor PROC_SS IEs generation .. library/GSUP_Types.ttcn: refactor PROC_SS IEs

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit session IEs

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14453 Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit session IEs .. gsup_client_mux_tx_error_reply(): fix: do not omit

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit session IEs

2019-06-14 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/14453 ) Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit session IEs .. Set Ready For Review -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_mt_ussd_for_unknown_subscr

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14450 Change subject: MSC_Tests.ttcn: introduce TC_mt_ussd_for_unknown_subscr .. MSC_Tests.ttcn: introduce

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit SM-RP-MR IE

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14456 Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit SM-RP-MR IE .. gsup_client_mux_tx_error_reply(): fix: do not omit

Change in ...osmo-msc[master]: libmsc/gsm_0(4|9)_11_gsup.c: print error message if subscr is not known

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14451 Change subject: libmsc/gsm_0(4|9)_11_gsup.c: print error message if subscr is not known .. libmsc/gsm_0(4|9)_11_gsup.c: print error

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not override IMSI

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14452 Change subject: gsup_client_mux_tx_error_reply(): fix: do not override IMSI .. gsup_client_mux_tx_error_reply(): fix: do not override

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14454 Change subject: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE .. gsup_client_mux_tx_error_reply(): fix: do

Change in ...libosmocore[master]: core/utils: drop meaningless const from return value of osmo_luhn()

2019-06-12 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14425 ) Change subject: core/utils: drop meaningless const from return value of osmo_luhn() .. core/utils: drop meaningless

Change in ...libosmocore[master]: protocol/gsm_04_08.h: do not check if unsigned is positive

2019-06-12 Thread fixeria
fixeria has submitted this change and it was merged. ( https://gerrit.osmocom.org/c/libosmocore/+/14426 ) Change subject: protocol/gsm_04_08.h: do not check if unsigned is positive .. protocol/gsm_04_08.h: do not check

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: add timeouts to SS/USSD test cases

2019-06-14 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14457 Change subject: MSC_Tests.ttcn: add timeouts to SS/USSD test cases .. MSC_Tests.ttcn: add timeouts to SS/USSD test cases

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: add timers to SS/USSD test cases

2019-06-14 Thread fixeria
Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14463 Change subject: libmsc/gsm_09_11.c: do not abuse LOG_TRANS() and early trans allocation .. libmsc/gsm_09_11.c: do not abuse

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop rudimantary vsub->cgi.lai.lac check

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14465 Change subject: libmsc/gsm_09_11.c: drop rudimantary vsub->cgi.lai.lac check .. libmsc/gsm_09_11.c: drop rudimantary v

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14466 Change subject: libmsc/gsm_09_11.c: drop meaningless check for concurrent paging .. libmsc/gsm_09_11.c: drop meaningless check

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: log network-originated session establishment error

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14464 Change subject: libmsc/gsm_09_11.c: log network-originated session establishment error .. libmsc/gsm_09_11.c: log network-originated

Change in ...osmo-msc[master]: libmsc/msc_net_init.c: pass pointer to gsm_network directly

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14467 Change subject: libmsc/msc_net_init.c: pass pointer to gsm_network directly .. libmsc/msc_net_init.c: pass pointer to gsm_network

Change in ...osmo-msc[master]: libmsc/gsm_04_08.c: clean up unused leftover includes

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14462 Change subject: libmsc/gsm_04_08.c: clean up unused leftover includes .. libmsc/gsm_04_08.c: clean up unused leftover includes

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR message where needed

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14458 Change subject: libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR message where needed .. libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR message when needed

2019-06-15 Thread fixeria
fixeria has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/14458 ) Change subject: libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR message when needed .. libmsc/gsm_09_11.c: send GSUP PROS_SS ERROR message

Change in ...libosmocore[master]: fsm.c: Print error message for FSM with allstate_action but no events

2019-06-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14361 ) Change subject: fsm.c: Print error message for FSM with allstate_action but no events .. Patch Set 3: Code-Review+2 -- To view

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: drop rudimentary vsub->cgi.lai.lac check

2019-06-15 Thread fixeria
Gerrit-Change-Id: I7bd48860e923cb1f1a5bccc4b0f497ec1a7bcf84 Gerrit-Change-Number: 14465 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit message class IE

2019-06-15 Thread fixeria
Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id00a99b713a6b97c455b8e6ae49abea163e8281f Gerrit-Change-Number: 14454 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit session IEs

2019-06-15 Thread fixeria
mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I57317a7b8036d1ffd36e2021efc146db4633da84 Gerrit-Change-Number: 14453 Gerrit-PatchSet: 3 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: gsup_client_mux_tx_error_reply(): fix: do not omit SM-RP-MR IE

2019-06-15 Thread fixeria
-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ifb6e749928548e6febfe7768aefe9a2a3ecf4de0 Gerrit-Change-Number: 14456 Gerrit-PatchSet: 2 Gerrit-Owner: fixeria Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: fix: return trans from establish_nc_ss_trans()

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14461 Change subject: libmsc/gsm_09_11.c: fix: return trans from establish_nc_ss_trans() .. libmsc/gsm_09_11.c: fix: return trans from

Change in ...osmo-msc[master]: libmsc/paging.c: cosmetic: remove leading space in log line

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14470 Change subject: libmsc/paging.c: cosmetic: remove leading space in log line .. libmsc/paging.c: cosmetic: remove leading space in log

Change in ...libosmocore[master]: Revert "fsm.c: Print error message for FSM with allstate_action but n...

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/libosmocore/+/14473 Change subject: Revert "fsm.c: Print error message for FSM with allstate_action but no events" .. Revert "fsm

Change in ...libosmocore[master]: Revert "fsm.c: Print error message for FSM with allstate_action but n...

2019-06-15 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/14473 ) Change subject: Revert "fsm.c: Print error message for FSM with allstate_action but no events" .. Patch Set 1: Cod

Change in ...osmo-ttcn3-hacks[master]: MSC_Tests.ttcn: introduce TC_proc_ss_paging_fail

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14474 Change subject: MSC_Tests.ttcn: introduce TC_proc_ss_paging_fail .. MSC_Tests.ttcn: introduce TC_proc_ss_paging_fail

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14475 Change subject: libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed .. libmsc/gsm_09_11.c: inform HLR/EUSE if Paging has failed

Change in ...osmo-msc[master]: libmsc/paging.c: cosmetic: actually use default branch of switch

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14469 Change subject: libmsc/paging.c: cosmetic: actually use default branch of switch .. libmsc/paging.c: cosmetic: actually use default

Change in ...osmo-msc[master]: libmsc/msc_a.c: fix: remove dummy allstate_action of msc_a_fsm

2019-06-15 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14472 Change subject: libmsc/msc_a.c: fix: remove dummy allstate_action of msc_a_fsm .. libmsc/msc_a.c: fix: remove dummy allstate_action

Change in ...osmo-hlr[master]: rx_check_imei_req(): fix IMEI bounds checking

2019-06-11 Thread fixeria
fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/14399 ) Change subject: rx_check_imei_req(): fix IMEI bounds checking .. Patch Set 3: Code-Review+1 -- To view, visit https

Change in ...osmo-ttcn3-hacks[master]: library/L1CTL_PortType.ttcn: clarify and unify timeout messages

2019-06-11 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/14420 Change subject: library/L1CTL_PortType.ttcn: clarify and unify timeout messages .. library/L1CTL_PortType.ttcn: clarify

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: avoid double zero-initialization of gsup_msg

2019-06-17 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14499 Change subject: libmsc/gsm_09_11.c: avoid double zero-initialization of gsup_msg .. libmsc/gsm_09_11.c: avoid double zero

Change in ...osmo-msc[master]: libmsc/gsm_09_11.c: fix broken reference counting for vsub

2019-06-17 Thread fixeria
fixeria has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/14500 Change subject: libmsc/gsm_09_11.c: fix broken reference counting for vsub .. libmsc/gsm_09_11.c: fix broken reference counting

  1   2   3   4   5   6   7   8   9   10   >