Change in osmo-sgsn[master]: Fix Radio Priority in MM Attach and PDP Context Activation

2020-09-20 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/20217 ) Change subject: Fix Radio Priority in MM Attach and PDP Context Activation .. Fix Radio Priority in MM Attach and PDP Context

Change in osmo-sip-connector[master]: mncc: Support IPv6 addresses (new version mncc 7)

2020-09-10 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/20052 ) Change subject: mncc: Support IPv6 addresses (new version mncc 7) .. Patch Set 3: Code-Review+1 Manually Tested.. Looks

Change in osmo-sip-connector[master]: Revert "sip: Specify invite contact tag"

2020-09-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/19992 ) Change subject: Revert "sip: Specify invite contact tag" .. Patch Set 1: Code-Review+1 > It may be wort

Change in osmo-msc[master]: Don't Store an SMS in the database when the ESME is not Bound

2020-09-01 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19935 ) Change subject: Don't Store an SMS in the database when the ESME is not Bound .. Patch Set 1: (1 comment) https://gerrit.osmoco

Change in osmo-msc[master]: Don't Store an SMS in the database when the ESME is not Bound

2020-09-01 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/19935 ) Change subject: Don't Store an SMS in the database when the ESME is not Bound .. Don't Store an SMS in the database when t

Change in libosmo-sccp[master]: Fix (2) change in ss7 server default listen addr, keeps backward-comp...

2020-09-01 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-sccp/+/19931 ) Change subject: Fix (2) change in ss7 server default listen addr, keeps backward-compatibility behavior .. Patch Set 1: Code

Change in osmo-hlr[master]: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy"

2020-08-31 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/19914 ) Change subject: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy" .. Patch Set 1: (1 comment) https://gerrit.osm

Change in osmo-hlr[master]: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy"

2020-08-31 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/19914 ) Change subject: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy" .. Patch Set 1: (1 comment) https://gerrit.osm

Change in osmo-hlr[master]: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy"

2020-08-31 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-hlr/+/19914 ) Change subject: osmo-hlr-db-tool: Make import from osmo-nitb less "lossy" .. osmo-hlr-db-tool: Make import from osmo-nitb l

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-29 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. Patch Set 4: > (2 comments) So, both of these issues you point

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
keith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. vty: allow configuring db path from cfg file So far, the cmdline argument was

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. Patch Set 4: Code-Review+2 -- To view, visit https

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
visit https://gerrit.osmocom.org/c/osmo-msc/+/19875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I18d954c30fcceb0b36a620b927fd3a93dcc79f49 Gerrit-Change-Number: 19875 Gerrit-PatchSet: 4 G

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
visit https://gerrit.osmocom.org/c/osmo-msc/+/19875 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: I18d954c30fcceb0b36a620b927fd3a93dcc79f49 Gerrit-Change-Number: 19875 Gerrit-PatchSet: 3 G

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. Set Ready For Review -- To view, visit https://gerrit.osmocom.org/c

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. Patch Set 1: > Build Failed > I'm not sure how to re g

Change in osmo-msc[master]: vty: allow configuring db path from cfg file

2020-08-28 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/19875 ) Change subject: vty: allow configuring db path from cfg file .. vty: allow configuring db path from cfg file So far, the cmdline

Change in osmo-pcu[master]: bts: Rename mslot_class_from_ra

2020-05-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18129 ) Change subject: bts: Rename mslot_class_from_ra .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/c/osmo

Change in osmo-pcu[master]: bts: Fix Decoding EGPRS MultislotClass from 11-bit EGPRS PACKET CHANN...

2020-05-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18130 ) Change subject: bts: Fix Decoding EGPRS MultislotClass from 11-bit EGPRS PACKET CHANNEL REQUEST .. Patch Set 2: Code-Review+1 -- To

Change in osmo-pcu[master]: bts: Return uint8_t in egprs_mslot_class_from_ra()

2020-05-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18131 ) Change subject: bts: Return uint8_t in egprs_mslot_class_from_ra() .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-pcu[master]: tbf: Avoid crash: don't set TBF window size if setup failed

2020-05-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/18115 ) Change subject: tbf: Avoid crash: don't set TBF window size if setup failed .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-27 Thread keith
keith has abandoned this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Abandoned This functionality is not currently needed. -- To view, visit https

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-27 Thread keith
41 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 8 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Bu

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-27 Thread keith
41 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 7 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Bu

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-27 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Patch Set 6: (1 comment) https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/6/ggsn

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Patch Set 6: (1 comment) > I agree with you the only real use for the feat

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-26 Thread keith
41 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 6 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Bu

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-25 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Patch Set 5: Maybe it does have a use case; if one really wanted to have a

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-25 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Patch Set 5: Thanks for the code review! I have implemented as suggested, but

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-25 Thread keith
41 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Bu

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-24 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Patch Set 4: (3 comments) https://gerrit.osmocom.org/c/osmo-ggsn/+/17941/4

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-24 Thread keith
cribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder G

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-24 Thread keith
cribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder G

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-24 Thread keith
cribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ggsn Gerrit-Branch: master Gerrit-Change-Id: I03fcf8a1532bd9988ea99a6afd3dc325174ce9d6 Gerrit-Change-Number: 17941 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder G

Change in osmo-ggsn[master]: Add default APN for each EUA Type

2020-04-24 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-ggsn/+/17941 ) Change subject: Add default APN for each EUA Type .. Add default APN for each EUA Type MS may request an unknown APN. In this case

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-24 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 6: Code-Review+1 -- To view, visit https

Change in osmo-bts[master]: lc15: Fix returning values on void function

2020-04-24 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17936 ) Change subject: lc15: Fix returning values on void function .. Patch Set 1: Code-Review+1 -- To view, visit https

Change in osmo-bts[master]: lc15: Fix mismatching signature in callback provided

2020-04-24 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17937 ) Change subject: lc15: Fix mismatching signature in callback provided .. Patch Set 2: Code-Review+1 Exactly what I asked for in https

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (2 comments) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-20 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-19 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17855 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 2: > > Patch Set 2: Code-Review-1 > >

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17808 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 2: (1 comment) > > Description set to "I

Change in osmo-bts[master]: osmo-bts-litecell15: Implement missing features.

2020-04-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17808 ) Change subject: osmo-bts-litecell15: Implement missing features. .. Patch Set 2: > Description set to "I'm not sure w

Change in osmo-bts[master]: osmo-bts-litecell15: Increase max_cell_size.

2020-04-13 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/17807 ) Change subject: osmo-bts-litecell15: Increase max_cell_size. .. Patch Set 2: (3 comments) https://gerrit.osmocom.org/c/osmo-bts

Change in osmo-bsc[master]: Meas Tools: Avoid unusable terminal in case of error on osmo_sock_init

2020-03-28 Thread keith
: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.

2020-03-28 Thread keith
m.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib3b3558723682defcee22e7ea2d8bf5c2cff1278 Gerrit-Change-Number: 17647 Gerrit-PatchSet: 5 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Meas Tools, Avoid compiler format warnings

2020-03-28 Thread keith
org/c/osmo-bsc/+/17649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8d807ffc4571f2954e3d1083da673dc1235e7687 Gerrit-Change-Number: 17649 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Rev

Change in osmo-bsc[master]: Meas Tools, Avoid compiler format warnings

2020-03-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17649 ) Change subject: Meas Tools, Avoid compiler format warnings .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/17649

Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.

2020-03-28 Thread keith
m.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib3b3558723682defcee22e7ea2d8bf5c2cff1278 Gerrit-Change-Number: 17647 Gerrit-PatchSet: 4 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith Gerrit-Reviewer: pespin Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.

2020-03-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17647 ) Change subject: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging. .. Patch Set 3: (3 comments) https://gerrit.osmocom.org

Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.

2020-03-28 Thread keith
tings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ib3b3558723682defcee22e7ea2d8bf5c2cff1278 Gerrit-Change-Number: 17647 Gerrit-PatchSet: 3 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Meas Tools, Avoid compiler format warnings

2020-03-28 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17649 ) Change subject: Meas Tools, Avoid compiler format warnings .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo-bsc/+/17649

Change in osmo-bsc[master]: Meas Tools: Avoid messing up the terminal with error on osmo_sock_init

2020-03-28 Thread keith
ettings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: Ia5148d9ef386df314bc2837b3cb672150250bd2a Gerrit-Change-Number: 17648 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Reviewer: Jenkins Builder Gerrit-MessageType: newpatchset

Change in osmo-bsc[master]: Meas Tools, Avoid compiler format warnings

2020-03-28 Thread keith
org/c/osmo-bsc/+/17649 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I8d807ffc4571f2954e3d1083da673dc1235e7687 Gerrit-Change-Number: 17649 Gerrit-PatchSet: 2 Gerrit-Owner: keith Gerrit-Rev

Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging.

2020-03-27 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-bsc/+/17647 ) Change subject: Meas Tools: Avoid OSMO_ASSERT due to uninitialised logging. .. Meas Tools: Avoid OSMO_ASSERT due to uninitialised

Change in osmo-bsc[master]: Meas Tools: Avoid messing up the terminal with error on osmo_sock_init

2020-03-27 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17648 ) Change subject: Meas Tools: Avoid messing up the terminal with error on osmo_sock_init .. Meas Tools: Avoid messing up the terminal

Change in osmo-bsc[master]: Meas Tools: Avoid OSMO_ASSERT to due uninitialised logging.

2020-03-27 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17647 ) Change subject: Meas Tools: Avoid OSMO_ASSERT to due uninitialised logging. .. Meas Tools: Avoid OSMO_ASSERT to due uninitialised

Change in osmo-bsc[master]: Meas Tools, Avoid compiler format warnings

2020-03-27 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-bsc/+/17649 ) Change subject: Meas Tools, Avoid compiler format warnings .. Meas Tools, Avoid compiler format warnings Change-Id

Change in openbsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2020-03-27 Thread keith
keith has submitted this change. ( https://gerrit.osmocom.org/c/openbsc/+/17635 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. rsl: Send IE MS Power Param during CHAN ACT and MS PWR

Change in openbsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2020-03-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/17635 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. Patch Set 1: Code-Review+2 -- To view, visit

Change in openbsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2020-03-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/openbsc/+/17635 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. Patch Set 1: Code-Review+1 Unless there'

Change in osmo-pcu[master]: BSSGP: fix: properly encode P-TMSI in RR Paging Request

2020-03-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17617 ) Change subject: BSSGP: fix: properly encode P-TMSI in RR Paging Request .. Patch Set 2: Code-Review+2 -- To view, visit https

Change in osmo-pcu[master]: BSSGP: fix: properly encode P-TMSI in RR Paging Request

2020-03-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17617 ) Change subject: BSSGP: fix: properly encode P-TMSI in RR Paging Request .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-pcu[master]: BSSGP: fix: properly encode P-TMSI in RR Paging Request

2020-03-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17617 ) Change subject: BSSGP: fix: properly encode P-TMSI in RR Paging Request .. Patch Set 1: This patch solves the issue for me, as

Change in osmo-pcu[master]: BSSGP: fix: properly encode P-TMSI in RR Paging Request

2020-03-26 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17617 ) Change subject: BSSGP: fix: properly encode P-TMSI in RR Paging Request .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c

Change in openbsc[master]: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages

2020-03-26 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/openbsc/+/17635 ) Change subject: rsl: Send IE MS Power Param during CHAN ACT and MS PWR CTRL messages .. rsl: Send IE MS Power Param during CHAN ACT

Change in osmo-pcu[master]: Don't check ul_control_block before decoding into it.

2020-03-26 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17634 ) Change subject: Don't check ul_control_block before decoding into it. .. Don't check ul_control_block before decoding into

Change in osmo-pcu[master]: Send UL-CTRL Packet to GSMTAP even if we fail to decode.

2020-03-05 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17393 ) Change subject: Send UL-CTRL Packet to GSMTAP even if we fail to decode. .. Send UL-CTRL Packet to GSMTAP even if we fail to decode

Change in osmo-pcu[master]: csn1: fix csnStreamDecoder(): skip bits unhandled by serialize()

2020-03-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17391 ) Change subject: csn1: fix csnStreamDecoder(): skip bits unhandled by serialize() .. Patch Set 1: Code-Review+1 I can't claim t

Change in osmo-pcu[master]: tests/rlcmac: add a new test vector for Packet Resource Request

2020-03-05 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17390 ) Change subject: tests/rlcmac: add a new test vector for Packet Resource Request .. Patch Set 1: Code-Review+1 -- To view, visit

Change in osmo-pcu[master]: gprs_bssgp_pcu: fixup: fix length check in gprs_bssgp_pcu_rx_dl_ud()

2020-02-03 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/17082 ) Change subject: gprs_bssgp_pcu: fixup: fix length check in gprs_bssgp_pcu_rx_dl_ud() .. Patch Set 1: Code-Review+2 (1 comment

Change in osmo-ttcn3-hacks[master]: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/16882 ) Change subject: MSC/SMPP: introduce TC_smpp_mo_sms_rp_error for OS#4351 .. Patch Set 3: (1 comment) https

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 4: Code-Review+2 -- To view, visit https://gerrit.osmocom.org

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
6873/4 -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/16873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic34d398e0a850856e20380ae35e5c2ae5e3c539b Gerrit-Change-Number: 16873 Gerrit-P

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 4: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/16873

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. Patch Set 2: (1 comment) https://gerrit.osmocom.org/c/osmo-msc/+/16873

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-15 Thread keith
ps://gerrit.osmocom.org/c/osmo-msc/+/16873 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Ic34d398e0a850856e20380ae35e5c2ae5e3c539b Gerrit-Change-Number: 16873 Gerrit-PatchSet: 3 Gerrit

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-14 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. libmsc: SMS, Avoid premature RP-ACK to MS There was one libmsc commit to

Change in osmo-msc[master]: libmsc: SMS, Avoid premature RP-ACK to MS

2020-01-14 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/16873 ) Change subject: libmsc: SMS, Avoid premature RP-ACK to MS .. libmsc: SMS, Avoid premature RP-ACK to MS The was one libmsc commit to

Change in osmo-bts[master]: L1SAP: use LOGL_DEBUG for logging from rach_pass_filter()

2020-01-14 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16800 ) Change subject: L1SAP: use LOGL_DEBUG for logging from rach_pass_filter() .. Patch Set 2: Code-Review+1 -- To view, visit https

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread keith
keith has uploaded a new patch set (#3). ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what it

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread keith
keith has uploaded a new patch set (#2). ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what it

Change in osmo-msc[master]: Trivial: code simplification, return early

2020-01-13 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/16839 ) Change subject: Trivial: code simplification, return early .. Trivial: code simplification, return early This commit also, (for what

Change in osmo-msc[master]: Use GSM411_RP_* and not GSM48_CC_*

2020-01-11 Thread keith
keith has submitted this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16806 ) Change subject: Use GSM411_RP_* and not GSM48_CC_* .. Use GSM411_RP_* and not GSM48_CC_* d34ed5768cccab57e879bd32f38872d290c9ae89 introduced

Change in osmo-msc[master]: Use GSM411_RP_* and not GSM48_CC_*

2020-01-11 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/16806 ) Change subject: Use GSM411_RP_* and not GSM48_CC_* .. Patch Set 1: Code-Review+2 Based on "Exceptions for Trivial" guidl

Change in osmo-bts[master]: L1SAP: remove verbose logging from rach_pass_filter()

2020-01-11 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16800 ) Change subject: L1SAP: remove verbose logging from rach_pass_filter() .. Patch Set 1: > (1 comment) Given I triggered this on

Change in osmo-bts[master]: L1SAP: remove verbose logging from rach_pass_filter()

2020-01-11 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/16800 ) Change subject: L1SAP: remove verbose logging from rach_pass_filter() .. Patch Set 1: (1 comment) https://gerrit.osmocom.org/c/osmo

Change in osmo-msc[master]: Use GSM411_RP_* and not GSM48_CC_*

2020-01-11 Thread keith
keith has uploaded this change for review. ( https://gerrit.osmocom.org/c/osmo-msc/+/16806 ) Change subject: Use GSM411_RP_* and not GSM48_CC_* .. Use GSM411_RP_* and not GSM48_CC_* d34ed5768cccab57e879bd32f38872d290c9ae89

Change in osmo-hlr[master]: contrib/dgsm/ add example esme and dialplan

2020-01-11 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16204 ) Change subject: contrib/dgsm/ add example esme and dialplan .. Patch Set 23: Code-Review+1 (1 comment) https://gerrit.osmocom.org/c

Change in osmo-hlr[master]: contrib/dgsm/ add example esme and dialplan

2020-01-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16204 ) Change subject: contrib/dgsm/ add example esme and dialplan .. Patch Set 18: (4 comments) https://gerrit.osmocom.org/c/osmo-hlr

Change in osmo-hlr[master]: add mDNS lookup method to libosmo-mslookup

2020-01-08 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16256 ) Change subject: add mDNS lookup method to libosmo-mslookup .. Patch Set 11: (1 comment) https://gerrit.osmocom.org/c/osmo-hlr

Change in osmo-hlr[master]: D-GSM 2/n: implement mDNS method of mslookup server

2020-01-07 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16257 ) Change subject: D-GSM 2/n: implement mDNS method of mslookup server .. Patch Set 14: Code-Review-1 (1 comment) https

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

2019-09-16 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 ) Change subject: exit if the sip agent failed to start .. Patch Set 1: > Assume osmo-sip-connector is only managed thro

Change in ...osmo-sip-connector[master]: exit if the sip agent failed to start

2019-09-16 Thread keith
keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/15532 ) Change subject: exit if the sip agent failed to start .. Patch Set 1: > Assume osmo-sip-connector is only managed thro

<    1   2   3   4   5   6   7   8   9   10   >