Stefan Sperling has submitted this change and it was merged. (
https://gerrit.osmocom.org/7992 )
Change subject: move creation of insert subscriber data messages to a common
function
..
move creation of insert subscriber data m
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/7992 )
Change subject: move creation of insert subscriber data messages to a common
function
..
Patch Set 6: Code-Review+2
--
To view, visit http
Hello neels, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7992
to look at the new patch set (#6).
Change subject: move creation of insert subscriber data messages to a common
function
.
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/7992 )
Change subject: move creation of insert subscriber data messages to a common
function
..
Patch Set 5: Code-Review-1
(1 comment)
https://ge
Hello neels, Neels Hofmeyr, Harald Welte, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7992
to look at the new patch set (#5).
Change subject: move creation of insert subscriber data messages to a common
function
.
Neels Hofmeyr has posted comments on this change. (
https://gerrit.osmocom.org/7992 )
Change subject: move creation of insert subscriber data messages to a common
function
..
Patch Set 4: Code-Review+1
(3 comments)
https://g
Patch Set 4:
(1 comment)
https://gerrit.osmocom.org/#/c/7992/4/src/gsup_server.h
File src/gsup_server.h:
Line 62: int osmo_gsup_create_insert_subscriber_data_msg(struct
osmo_gsup_message *gsup, char *imsi, char *msisdn,
Are those (imsi, msisdn, ...)input parameters? If yes, then we typically m
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7992
to look at the new patch set (#4).
move creation of insert subscriber data messages to a common function
Move code to create an Insert Subscriber Data message into a comm
Patch Set 4:
> Uploaded patch set 4.
This patch set should address your comments. Does it?
--
To view, visit https://gerrit.osmocom.org/7992
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a92ca34cdaadca9eacc774bb1ca386c325ba865
Gerrit
Hello Neels Hofmeyr, Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7992
to look at the new patch set (#3).
move creation of insert subscriber data messages to a common function
Move code to create an Insert Subscriber Data message into a comm
Patch Set 2: Code-Review-1
(2 comments)
One thing that's worse after this patch: we add a couple of short-lived small
dynamic allocations (gsup message, msisdn, apn). The root cause being that we
failed to use actual arrays in the original definition of the gsup message
struct.
Instead of ta
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/7992/1/src/luop.c
File src/luop.c:
Line 53:if (msg_out == NULL) {
> same here. OSMO_ASSERT(msg_out) is sufficient.
Changed accordingly in next patch set.
--
To view, visit https://gerrit.osmocom.org/7992
To unsubscribe, visit ht
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/7992
to look at the new patch set (#2).
move creation of insert subscriber data messages to a common function
Move code to create an Insert Subscriber Data message into a common
function whi
Patch Set 1:
(2 comments)
https://gerrit.osmocom.org/#/c/7992/1/src/gsup_server.c
File src/gsup_server.c:
Line 372: msisdn_enc = talloc_size(gsup,
OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN);
simply OSMO_ASSERT on the talloc result, in all calls (both the one for gsup
above, as well as the othe
Review at https://gerrit.osmocom.org/7992
move creation of insert subscriber data messages to a common function
Move code to create an Insert Subscriber Data message into a common
function which can be shared by hlr.c and luop.c.
Change-Id: I6a92ca34cdaadca9eacc774bb1ca386c325ba865
Requested-b
15 matches
Mail list logo