Patch Set 3: Code-Review+2
No comments happening, I think we need to resolve it and fix the PCU. I was
going to revert, but lynxis' "looks good to me" encourages me to merge this.
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerri
Neels Hofmeyr has submitted this change and it was merged.
Change subject: fix PACCH paging: don't return early in case of NULL TBF
..
fix PACCH paging: don't return early in case of NULL TBF
Commit b78a4a6dfef217c538d45949a6ae
Patch Set 3: Code-Review+1
LGTM
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Patch Set 3:
https://osmocom.org/issues/2241
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Br
Hello Harald Welte, Jenkins Builder, Holger Freyther,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2420
to look at the new patch set (#3).
fix PACCH paging: don't return early in case of NULL TBF
Commit b78a4a6dfef217c538d45949a6ae725e22a36b05 tried to fix a
Patch Set 2:
So, da7250ad2c1cd5ddc7d3c6e10435a00b357ef8f7 introduced a segfault, and
b78a4a6dfef217c538d45949a6ae725e22a36b05 as well as this patch fix the
segfault, while still having problems. To cut this short, we could also revert
all of the patches. Opinions/better patches welcome.
--
T
Patch Set 2:
(2 comments)
Thanks for the review; the thing is, I don't really know what this code is
doing and why, this issue jumped at my knees and now I'm trying to throw stones
at it to not be broken. I would very much welcome a more qualified person to
take this patch over from me; might
Patch Set 2: Code-Review+1
(2 comments)
How long did the fix take?
https://gerrit.osmocom.org/#/c/2420/2/src/gprs_rlcmac_sched.cpp
File src/gprs_rlcmac_sched.cpp:
Line 186: return NULL;
msg is leaked now?
Line 202: return msg;
okay but we might still have
Patch Set 2:
Out of curiosity - how this was found? I mean in what way PACCH paging was
broken as a result of incorrect fix? Is there a way this can be formulated as a
unit test?
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerri
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Patch Set 2: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/2420
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib79f4a945e211a13ac7d1e511cc37b0940ac6202
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/2420
to look at the new patch set (#2).
fix PACCH paging: don't return early in case of NULL TBF
Commit b78a4a6dfef217c538d45949a6ae725e22a36b05 tried to fix a NULL dereference
error, but ap
Review at https://gerrit.osmocom.org/2420
fix PACCH paging: don't return early in case of NULL TBF
Commit b78a4a6dfef217c538d45949a6ae725e22a36b05 tried to fix a NULL dereference
error, but apparently was overly eager to return, because it looked like all
code paths would dereference the tbf.
13 matches
Mail list logo
