Harald Welte has submitted this change and it was merged.
Change subject: Add initial support for logging, vty, ctrl
..
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are
Patch Set 9: Code-Review+2
--
To view, visit https://gerrit.osmocom.org/6619
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad
Gerrit-PatchSet: 9
Gerrit-Project: osmo-trx
Gerrit-Branch: master
Patch Set 5:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/5/CommonLibs/trx_vty.h
File CommonLibs/trx_vty.h:
Line 7: struct trx_ctx {
> Please add a comment with brief description of this
Initially I thought it would make sesne to move the Trasnciever, RadioDevice
and RadioInterface
Patch Set 5: Code-Review+1
(1 comment)
https://gerrit.osmocom.org/#/c/6619/5/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 345: config->config_file = (char *)DEFAULT_CONFIG_FILE;
Why do we need this cast?
It should already be (char *), am I wrong?
--
To view,
Patch Set 5:
(1 comment)
https://gerrit.osmocom.org/#/c/6619/5/CommonLibs/trx_vty.h
File CommonLibs/trx_vty.h:
Line 7: struct trx_ctx {
Please add a comment with brief description of this
structure and further plans, i.e. what is it going
to be used for?
--
To view, visit
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/4/Transceiver52M/osmo-trx.cpp
File Transceiver52M/osmo-trx.cpp:
Line 79: #define DEFAULT_CONFIG_FILE"/etc/osmocom/osmo-trx.cfg"
I am not sure, is this common for Osmocom projects to
keep the configuration files in
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#5).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Patch Set 4:
(2 comments)
https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c
File CommonLibs/debug.c:
Line 9: .description = "Transciever",
> _ei_ not _ie_ because its receiver, not reciever and "Transceiver" is from
Typo indeed :-)
Patch Set 4:
(4 comments)
https://gerrit.osmocom.org/#/c/6619/4//COMMIT_MSG
Commit Message:
Line 12: Depends on libosmocore Change-Id
Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9
Related: OS#2184
https://gerrit.osmocom.org/#/c/6619/4/CommonLibs/debug.c
File CommonLibs/debug.c:
Line 9:
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#4).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Hello Jenkins Builder,
I'd like you to reexamine a change. Please visit
https://gerrit.osmocom.org/6619
to look at the new patch set (#3).
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't
Patch Set 2:
Depends on libosmocore Ib79cdb62d45d8c78445c7b064e58eb7e9faeccf9 (6623)
--
To view, visit https://gerrit.osmocom.org/6619
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad
Patch Set 1: Code-Review-1
Don't merge yet starting from this commit, since VTY parameter reading is still
not done. It will come in next commits together with dropping parameters other
than -C (which will be reconverted to -c).
--
To view, visit https://gerrit.osmocom.org/6619
To
Review at https://gerrit.osmocom.org/6619
Add initial support for logging, vty, ctrl
Up to this point, the logging system, vty and ctrl are initialized and
can be used fine, though they don't have a lot of use yet.
Change-Id: I08982c37b4f873966304b3cfb38a10ee86eb3dad
---
M
14 matches
Mail list logo
