[PATCH] libsmpp34[master]: add smpp34_tlv_for_each() helper

2017-08-11 Thread Pablo Neira Ayuso
Review at https://gerrit.osmocom.org/3469 add smpp34_tlv_for_each() helper So we don't need to remember this is an opencoded list of TLVs. Change-Id: I446929feed049d0411e1629ca263e2bc41f714cc --- M src/smpp34_structs.h 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.o

openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 4: When would it be good time to remove code for backward compatibility? Holger added v3 by 2014-03-07, it's a bit more than 3 years now. -- To view, visit https://gerrit.osmocom.org/3435 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Ch

[PATCH] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Review at https://gerrit.osmocom.org/3470 libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling submit_to_sms() now handles two TLVs, so find_tlv() is suboptiomal and it can be removed, since it would result in two passes on the TLV list. Use new smpp34_tlv_for_each() helper to ite

[PATCH] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling submit_to_sms() now handles two TLVs, so find_tlv() is suboptiomal and it can be removed, since it would result in two passes on the TLV list. Use new smpp34_tlv_for_each() helper to iterate over the list of TLVs. Change-Id: I53a

openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-11 Thread Holger Freyther
Patch Set 4: > When would it be good time to remove code for backward > compatibility? > > Holger added v3 by 2014-03-07, it's a bit more than 3 years now. I don't know... let me try to build an opinion :) * The nitb in the current form is deprecated anyway. So spending time to remove comp

[PATCH] openggsn[master]: IPv6: Implement IPv6 prefix assignment via ICMPv6 router adv...

2017-08-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3458 to look at the new patch set (#3). IPv6: Implement IPv6 prefix assignment via ICMPv6 router advertisement The 3GPP specs are quite strange when it comes to how an IPv6 address or rather

[PATCH] openggsn[master]: replace hand-coded tun_gifindex() with standard POSIX if_nam...

2017-08-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/3471 replace hand-coded tun_gifindex() with standard POSIX if_nametoindex() Change-Id: I738472765ab09f530dcf071455e1bb4e6fb3f6e5 --- M lib/tun.c 1 file changed, 3 insertions(+), 25 deletions(-) git pull ssh://gerrit.osmocom.org:29418/openggsn refs/change

[PATCH] openggsn[master]: Support setting TUN device IPv6 address + prefix

2017-08-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3408 to look at the new patch set (#8). Support setting TUN device IPv6 address + prefix As we can now have PDP contexts with IPv6 user IP payload, it is useful to extend the TUN related cod

[PATCH] openggsn[master]: tun_new(): Fix array overflow in FreeBSD related code

2017-08-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/3472 tun_new(): Fix array overflow in FreeBSD related code Change-Id: I096e3b614e82e402886163274cfcf9355bd57580 --- M lib/tun.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/openggsn refs/changes/72/3472/1 diff --

openbsc[master]: libmsc: update database to accomodate SMS status-report fields

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 4: Agreed. So let it sink by when the NITB code becomes officially dead. Thanks! -- To view, visit https://gerrit.osmocom.org/3435 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7276d356d805a83ebeec72b02c8563b7135ea0b6 Gerri

openggsn[master]: IPv6: Implement IPv6 prefix assignment via ICMPv6 router adv...

2017-08-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3458 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icddf7d30e01d76a4784bcef5787b36f52f703a9f Gerrit-PatchSet: 3 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

openggsn[master]: IPv6: in46_addr: OSMO_ASSERT() in case of unsupported calls

2017-08-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3460 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I444c190bdcd18780344e1f0dad4faf3bcf9da5a5 Gerrit-PatchSet: 3 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

openggsn[master]: IPv6: Support PCO for IPv6 DNS addresses

2017-08-11 Thread Harald Welte
Patch Set 3: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3459 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21499afd61def8c925f7838bde76f34d28214b56 Gerrit-PatchSet: 3 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

[PATCH] openggsn[master]: Support setting TUN device IPv6 address + prefix

2017-08-11 Thread Harald Welte
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3408 to look at the new patch set (#9). Support setting TUN device IPv6 address + prefix As we can now have PDP contexts with IPv6 user IP payload, it is useful to extend the TUN related cod

[PATCH] libsmpp34[master]: add esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
Review at https://gerrit.osmocom.org/3473 add esm_class definitions Add special message attributes definitions that are associated with the short message. Thus, we can get rid of magic numbers in our codebase. Change-Id: I91afd8b462b8fd3b2c4c5b54f4eeb7ec5b730b65 --- M src/smpp34.h 1 file chang

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 2: Build breaks because this patch depends on a patch in libsmpp34. -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53a65164a6cc4abc6bf57d9a8dc275cf21c90222 Gerrit-PatchSet: 2 G

[MERGED] openggsn[master]: Support setting TUN device IPv6 address + prefix

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Support setting TUN device IPv6 address + prefix .. Support setting TUN device IPv6 address + prefix As we can now have PDP contexts with IPv6 user IP pa

openggsn[master]: Support setting TUN device IPv6 address + prefix

2017-08-11 Thread Harald Welte
Patch Set 9: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3408 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I899d21e52d02e0b8384af29ddd489ff19c8f2cf6 Gerrit-PatchSet: 9 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

[MERGED] openggsn[master]: IPv6: in46_addr: OSMO_ASSERT() in case of unsupported calls

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: IPv6: in46_addr: OSMO_ASSERT() in case of unsupported calls .. IPv6: in46_addr: OSMO_ASSERT() in case of unsupported calls There's a bit of trickery with

[PATCH] openbsc[master]: libmsc: use new smpp34 esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
Review at https://gerrit.osmocom.org/3474 libmsc: use new smpp34 esm_class definitions Replace magic numbers by esm_class definitions. Change-Id: I6c458690da60c8f3637680efbd718f6e8c6feb4c --- M openbsc/src/libmsc/smpp_openbsc.c 1 file changed, 8 insertions(+), 10 deletions(-) git pull ssh:

[MERGED] openggsn[master]: IPv6: Implement IPv6 prefix assignment via ICMPv6 router adv...

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: IPv6: Implement IPv6 prefix assignment via ICMPv6 router advertisement .. IPv6: Implement IPv6 prefix assignment via ICMPv6 router advertisement The 3GP

[MERGED] openggsn[master]: IPv6: Support PCO for IPv6 DNS addresses

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: IPv6: Support PCO for IPv6 DNS addresses .. IPv6: Support PCO for IPv6 DNS addresses In IPv6, DNS server information is not passed along as IPCP6 like in

openbsc[master]: libmsc: use new smpp34 esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 1: This jenkins build will fail too, because it depends on a patch in libsmpp34 that I have just submitted. -- To view, visit https://gerrit.osmocom.org/3474 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c458690da60c8f36376

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pau Espin Pedrol
Patch Set 2: You could provide info about the dependency in the form "Requires libsmpp34 Change-Id XYZ" in the commit message, or at least here as a comment. This way is easier to track what needs to be merged, or which version of the library is used. -- To view, visit https://gerrit.osmocom

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 2: OK, will include this info once patches for libsmpp34 get in. So this also helps re-kick Jenkins building. -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53a65164a6cc4abc6b

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 2: Oh, I forgot. You can probably speed up the process if you give me +X to my libsmpp34 patches (if you're familiar with that code). Thanks! -- To view, visit https://gerrit.osmocom.org/3470 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Ger

[MERGED] openggsn[master]: tun_new(): Fix array overflow in FreeBSD related code

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: tun_new(): Fix array overflow in FreeBSD related code .. tun_new(): Fix array overflow in FreeBSD related code Change-Id: I096e3b614e82e402886163274cfcf9

openggsn[master]: replace hand-coded tun_gifindex() with standard POSIX if_nam...

2017-08-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3471 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I738472765ab09f530dcf071455e1bb4e6fb3f6e5 Gerrit-PatchSet: 2 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

openggsn[master]: tun_new(): Fix array overflow in FreeBSD related code

2017-08-11 Thread Harald Welte
Patch Set 2: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3472 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I096e3b614e82e402886163274cfcf9355bd57580 Gerrit-PatchSet: 2 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

[MERGED] openggsn[master]: replace hand-coded tun_gifindex() with standard POSIX if_nam...

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: replace hand-coded tun_gifindex() with standard POSIX if_nametoindex() .. replace hand-coded tun_gifindex() with standard POSIX if_nametoindex() Change-

libsmpp34[master]: add smpp34_tlv_for_each() helper

2017-08-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3469 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I446929feed049d0411e1629ca263e2bc41f714cc Gerrit-PatchSet: 1 Gerrit-Project: libsmpp34 Gerrit-Branch: master Gerri

libsmpp34[master]: add esm_class definitions

2017-08-11 Thread Harald Welte
Patch Set 1: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/3473/1/src/smpp34.h File src/smpp34.h: Line 213: SMPP34_REPLY_PATH = 0x80, I think an enum only makes sense for fields that are not a bit/flag mask. The biggest benefit of using enum's is that you will g

libsmpp34[master]: add esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 1: Frankly, I would have used a define in first place. But I kind of understood enum is the policy for osmocom projects, so I followed this path. -- To view, visit https://gerrit.osmocom.org/3473 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment G

[MERGED] libsmpp34[master]: add smpp34_tlv_for_each() helper

2017-08-11 Thread Pablo Neira Ayuso
Pablo Neira Ayuso has submitted this change and it was merged. Change subject: add smpp34_tlv_for_each() helper .. add smpp34_tlv_for_each() helper So we don't need to remember this is an opencoded list of TLVs. Change-Id: I44

[PATCH] openggsn[master]: Use osmocom-style git-version-gen / .version magic

2017-08-11 Thread Harald Welte
Review at https://gerrit.osmocom.org/3475 Use osmocom-style git-version-gen / .version magic This generates the version number from the latest tag + git history Change-Id: I71e1c3f8f534d9e9690c94068eccdee29a6fee12 --- M Makefile.am M configure.ac M debian/rules A git-version-gen 4 files change

[PATCH] libsmpp34[master]: add esm_class definitions

2017-08-11 Thread Pablo Neira Ayuso
Hello Harald Welte, Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3473 to look at the new patch set (#2). add esm_class definitions Add special message attributes definitions that are associated with the short message. Thus, we can get rid of

openggsn[master]: Use osmocom-style git-version-gen / .version magic

2017-08-11 Thread Harald Welte
Patch Set 1: Code-Review+2 -- To view, visit https://gerrit.osmocom.org/3475 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I71e1c3f8f534d9e9690c94068eccdee29a6fee12 Gerrit-PatchSet: 1 Gerrit-Project: openggsn Gerrit-Branch: master Gerrit

[MERGED] openggsn[master]: Use osmocom-style git-version-gen / .version magic

2017-08-11 Thread Harald Welte
Harald Welte has submitted this change and it was merged. Change subject: Use osmocom-style git-version-gen / .version magic .. Use osmocom-style git-version-gen / .version magic This generates the version number from the lates

openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pau Espin Pedrol
Patch Set 2: I never looked at that library so far, and I cannot give +2 on it anyway, sorry for that. Regarding your "retrigger by pushing again", I give you a tip for that: You can re-trigger the jenkins job which was launched by Gerrit and it if succeeds, it will automatically give Verify+

[PATCH] openbsc[master]: libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV ha...

2017-08-11 Thread Pablo Neira Ayuso
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3470 to look at the new patch set (#3). libmsc: use smpp34_tlv_for_each() to avoid suboptimal TLV handling submit_to_sms() now handles two TLVs, so find_tlv() is suboptiomal and it can be re

[PATCH] osmo-gsm-manuals[master]: osmux: Fix description for Dummy frames FT field

2017-08-11 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/3478 osmux: Fix description for Dummy frames FT field Change-Id: Ia421655bd1be45101da3db2a0af44fbb3cc111c1 --- M OsmoBSC/osmux-reference.adoc 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-gsm-manuals refs/c

[PATCH] libosmo-sccp[master]: sccp: add doxgen comments for osmo_sccp_simple_client()

2017-08-11 Thread dexter
Review at https://gerrit.osmocom.org/3481 sccp: add doxgen comments for osmo_sccp_simple_client() Some of the functons in sccp_user.c have already doygen comments on them. Add doxygen comments for the simple client functions as well Change-Id: I9143bdc54d729f9f50e69fe38cd1798e065f2497 --- M s

[PATCH] libosmo-sccp[master]: sccp: fix handling of default IP addresses in osmo_sccp_simp...

2017-08-11 Thread dexter
Review at https://gerrit.osmocom.org/3479 sccp: fix handling of default IP addresses in osmo_sccp_simple_client() When the default IP addresses (remote or local) the respective struct value should be set to NULL. Fix wrong ?:-notation. Change-Id: I312caf9d54cedb02034e4ef88fdd2e6ad9ca1c34 ---

[PATCH] libosmo-sccp[master]: sccp: make osmo_sccp_addr_name() available

2017-08-11 Thread dexter
Review at https://gerrit.osmocom.org/3482 sccp: make osmo_sccp_addr_name() available osmo_sccp_addr_name() is not listed in any header file. Add osmo_sccp_addr_name() to sccp_helpers.h in order to make it available. Change-Id: I092dd55948faeeff78f28f7d50c5b84b9e69ef24 --- M include/osmocom/si

[PATCH] libosmo-sccp[master]: sccp: check for valid point code in osmo_sccp_simple_client()

2017-08-11 Thread dexter
Review at https://gerrit.osmocom.org/3480 sccp: check for valid point code in osmo_sccp_simple_client() The point-code is not checked in the beginning, only the ASP checks the point code at a very late stage and fails in case an invalid point-code is detected. Remove the check in the ASP creat

[PATCH] openbsc[master]: mgcp_osmux: Remove unused parameter

2017-08-11 Thread Pau Espin Pedrol
Review at https://gerrit.osmocom.org/3483 mgcp_osmux: Remove unused parameter Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3 --- M openbsc/include/openbsc/osmux.h M openbsc/src/libmgcp/mgcp_osmux.c 2 files changed, 4 insertions(+), 8 deletions(-) git pull ssh://gerrit.osmocom.org:2941

openbsc[master]: mgcp_osmux: Remove unused parameter

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3483 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb1e7cb15fe04642578f5292124ebc1eac9c9aa3 Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-

osmo-gsm-manuals[master]: osmux: Fix description for Dummy frames FT field

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3478 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia421655bd1be45101da3db2a0af44fbb3cc111c1 Gerrit-PatchSet: 1 Gerrit-Project: osmo-gsm-manuals Gerrit-Branch: maste

osmo-msc[master]: 04.08: log protocol discriminators and message types by name

2017-08-11 Thread Pablo Neira Ayuso
Patch Set 6: Code-Review+1 -- To view, visit https://gerrit.osmocom.org/3350 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida205d217e304337d816b14fd15e2ee435e7397d Gerrit-PatchSet: 6 Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit

[PATCH] libosmo-sccp[master]: sccp: function to get sccp instance from sccp user

2017-08-11 Thread dexter
Review at https://gerrit.osmocom.org/3484 sccp: function to get sccp instance from sccp user It is currently impossible to find out which SCCP instance handles a particular user. Introduce function to lookup the SCCP instance from a given SCCP user. Change-Id: I9562c4f1d00e2ebb3252c5dea598b64

[PATCH] libosmo-sccp[master]: sccp: fixup for osmo_sccp_get_ss7()

2017-08-11 Thread dexter
Review at https://gerrit.osmocom.org/3485 sccp: fixup for osmo_sccp_get_ss7() osmo_sccp_get_ss7() has the risk of a nullpointer dereference, when sccp is NULL. Return NULL when the sccp instance is NULL. Add doxygen comment Change-Id: I84d484e4441fd37443fff8c67e17df8fb15d5b2e --- M include/o

[PATCH] osmo-msc[master]: Implement AoIP, port to M3UA SIGTRAN (large addition and ref...

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3486 Implement AoIP, port to M3UA SIGTRAN (large addition and refactoring) This was originally a long series of commits converging to the final result seen in this patch. It does not make much sense to review the smaller steps' trial and error, we need to re

[PATCH] osmo-msc[master]: Implement IuCS (large refactoring and addition)

2017-08-11 Thread Neels Hofmeyr
Hello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3347 to look at the new patch set (#6). Implement IuCS (large refactoring and addition) osmo-nitb becomes osmo-msc add DIUCS debug log constant add iucs.[hc] add msc vty, remove nitb vty add

[PATCH] osmo-msc[master]: MSC, SGSN: use OSMO_GSUP_PORT == 4222 instead of 2222

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3488 MSC,SGSN: use OSMO_GSUP_PORT == 4222 instead of In SGSN, actually place the port in the SGSN config by default, so that the gsup port may now be omitted in the VTY config (the IP address suffices). Adjust the osmo-sgsn.cfg example. Depends: I4222

[PATCH] osmo-msc[master]: .gitignore: cosmetic: use globs to ignore test binaries

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3491 .gitignore: cosmetic: use globs to ignore test binaries Change-Id: I840e4333a4cad646d751ebafe7e0ef23e7a9c708 --- M .gitignore 1 file changed, 7 insertions(+), 39 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/91/3491/1 d

[PATCH] osmo-msc[master]: move libiu to osmo-iuh/libosmo-ranap

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3489 move libiu to osmo-iuh/libosmo-ranap Remove libiu here, use the functions from libosmo-ranap instead, by applying the ranap_ / RANAP_ prefix. Corresponding change-id in osmo-iuh.git is I6a3f7ad15be03fb94689b4af6ccfa828c25f45c0 To be able to run the m

[PATCH] osmo-msc[master]: gsup client: move not-connected to error loglevel

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3493 gsup client: move not-connected to error loglevel Change-Id: I8290963aedb7237da89c9ff98adf4cd33beb5031 --- M src/libcommon/gsup_client.c 1 file changed, 2 insertions(+), 10 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/9

[PATCH] osmo-msc[master]: mgcp: add VTY Option to force-realloc endpoints

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3487 mgcp: add VTY Option to force-realloc endpoints Currently the force_realloc feature is turnd on and of in a hardcoded way. This patch makes the option available via VTY. Change-Id: Ic8740512c5ea0766ff6ceb1c28b9c2b3fe46e75f --- M src/libmgcp/mgcp_vty.c

[PATCH] osmo-msc[master]: msc_vlr tests: add IMEISV tests

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3494 msc_vlr tests: add IMEISV tests Change-Id: I752afef2ae3ce04e813c7e9fea0e883e607c0e14 --- M tests/msc_vlr/msc_vlr_test_gsm_authen.c M tests/msc_vlr/msc_vlr_test_gsm_authen.err M tests/msc_vlr/msc_vlr_test_gsm_ciph.c M tests/msc_vlr/msc_vlr_test_gsm_ciph.

[PATCH] osmo-msc[master]: libmsc: make pitfall in gsm0408_dispatch() more obvious

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3498 libmsc: make pitfall in gsm0408_dispatch() more obvious The function gsm0408_dispatch() accepts a message buffer pointer and accesses the l3h pointer. Even in a properly allocated message buffer, this may lead into a segfault if the user forgets to set

[PATCH] osmo-msc[master]: cosmetic: msc_vlr_tests: drop unused var

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3490 cosmetic: msc_vlr_tests: drop unused var Change-Id: I584c0dfffe005597563dbd72fad8a087c554ba3d --- M tests/msc_vlr/msc_vlr_tests.c 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/90/3490/1

[PATCH] osmo-msc[master]: add msg type to SMS rx logging

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3496 add msg type to SMS rx logging Change-Id: I73ea4eebe57b2d1008045a27f174072178b9f077 --- M src/libmsc/gsm_04_11.c 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/96/3496/1 diff --git a/src/

[PATCH] osmo-msc[master]: replace internal libmgcp with libosmo-legacy-mgcp

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3492 replace internal libmgcp with libosmo-legacy-mgcp Change-Id: Ic99d681759edce11564da62500c2aac5cf5fffe2 --- M configure.ac M include/openbsc/Makefile.am M include/openbsc/bsc_nat.h M include/openbsc/gsm_data.h D include/openbsc/mgcp.h D include/openbsc/m

[PATCH] osmo-msc[master]: vlr: set require IMEI by default

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3495 vlr: set require IMEI by default Change-Id: I91d8f3e79cdaa206f8cd32b42bd7c23933f9631a --- M src/libvlr/vlr.c 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-msc refs/changes/95/3495/1 diff --git a/src/li

[PATCH] osmo-msc[master]: split off osmo-msc: remove files, apply build, rename

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3497 split off osmo-msc: remove files, apply build, rename Change-Id: Icf025e5ea8d180613b3114282951c9afa67af9a7 --- M configure.ac D debian/osmo-gtphub.default D debian/osmo-gtphub.examples D debian/osmo-gtphub.init D debian/osmo-gtphub.install D debian/osmo

[PATCH] osmo-msc[master]: rework debian packages support

2017-08-11 Thread Neels Hofmeyr
Review at https://gerrit.osmocom.org/3499 rework debian packages support Remove old leftover from split of osmo-mgw out of openbsc. Change-Id: I77544cb38c31777c3fab52979d19488a63e52de3 --- D debian/autoreconf M debian/changelog M debian/control M debian/copyright D debian/docs D debian/openbsc

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in xUbuntu_17.04/i586

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_17.04/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_17.04/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 17

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/x86_64 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 17

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.04/x86_64

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.04/x86_64 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.04/x86_64 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log:

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 179s]

Build failure of network:osmocom:nightly/openbsc in Debian_9.0/i586

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/Debian_9.0/i586 Package network:osmocom:nightly/openbsc failed to build in Debian_9.0/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [ 179s]

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

Build failure of network:osmocom:nightly/openbsc in xUbuntu_16.10/i586

2017-08-11 Thread OBS Notification
Visit https://build.opensuse.org/package/live_build_log/network:osmocom:nightly/openbsc/xUbuntu_16.10/i586 Package network:osmocom:nightly/openbsc failed to build in xUbuntu_16.10/i586 Check out the package for editing: osc checkout network:osmocom:nightly openbsc Last lines of build log: [

osmo-msc[master]: examples: Change IP address of config files

2017-08-11 Thread Neels Hofmeyr
Patch Set 2: Hmm. In the example config file, we set a local IP address that is useful for OE packaging, because it matches a sysmocom device's actual IP address configuration. It's a good idea to actually use the example and thus be sure that we have a usable example config in doc/. But this

osmo-msc[master]: Implement AoIP, port to M3UA SIGTRAN (large addition and ref...

2017-08-11 Thread Neels Hofmeyr
Patch Set 1: Code-Review-1 (1 comment) https://gerrit.osmocom.org/#/c/3486/1/src/osmo-bsc/osmo_bsc_vty.c File src/osmo-bsc/osmo_bsc_vty.c: Line 192:* store the string names instead. */ This has to be fixed before the vty tests can go through. Currently it prints '(null)' as address nam

[PATCH] libasn1c[master]: add /debian to build a package

2017-08-11 Thread lynxis lazus
Hello Neels Hofmeyr, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/3440 to look at the new patch set (#2). add /debian to build a package debian files need a release so start with release 0.1.0 Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289 --- A debia

libasn1c[master]: add /debian to build a package

2017-08-11 Thread lynxis lazus
Patch Set 2: done -- To view, visit https://gerrit.osmocom.org/3440 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I135d975b84027d51cb1dc534e04dd314bbd20289 Gerrit-PatchSet: 2 Gerrit-Project: libasn1c Gerrit-Branch: master Gerrit-Owner:

libasn1c[master]: add /debian to build a package

2017-08-11 Thread Neels Hofmeyr
Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/3440/2/debian/copyright File debian/copyright: Line 65 @hwelte, are the licenses making sense now? -- To view, visit https://gerrit.osmocom.org/3440 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-Message